From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EF6C91284 for ; Thu, 29 Jan 2015 17:14:19 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 29 Jan 2015 08:09:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,486,1418112000"; d="scan'208";a="644550527" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2015 08:13:55 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.28]) by irsmsx105.ger.corp.intel.com ([169.254.7.81]) with mapi id 14.03.0195.001; Thu, 29 Jan 2015 16:13:49 +0000 From: "Wodkowski, PawelX" To: "Ouyang, Changchun" , Thomas Monjalon , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss Thread-Index: AQHQNSvegZBK61bmM0KneVRinNefH5zT6r6AgADgLACAAoeaUA== Date: Thu, 29 Jan 2015 16:13:49 +0000 Message-ID: References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> <1561845.4QtzaTeLCI@xps13> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 16:14:20 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang, Changchun > Sent: Wednesday, January 28, 2015 2:35 AM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, January 27, 2015 8:13 PM > > To: Ouyang, Changchun > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf r= ss > > > > > To follow up the comments from Wodkowski, PawelX, remove this > > > unnecessary check, as check_mq_mode has already check the queue > > number > > > in device configure stage, if the queue number of vf is not correct, > > > it will return error code and exit, so it doesn't need check again > > > here in device start stage(note: pf_host_configure is called in devic= e start > > stage). > > > > > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > > > > > Signed-off-by: Changchun Ouyang > > > > Suggested-by: Pawel Wodkowski > > Fixes: 42d2f78abcb77 ("configure VF RSS") > > > > Applied > > >=20 > Thanks very much for the applying! >=20 > > Changchun, as you are working on ixgbe, maybe you would like to review > > some ixgbe patches from others? > > >=20 > No problem, I will try to do it when my bandwidth allows me to do it, :-) > Thanks > Changchun Actually I was suggesting exactly opposite direction. Main issue is that th= e sriov field in rte_eth_dev_data is only used by igb and ixgbe drivers. In a= ddition rte_eth_dev_check_mq_mode() is specialized for ixgbe driver. I am thinking about moving sriov from rte_eth_dev_data to driver's private structure or at least move rte_eth_dev_check_mq_mode() to struct eth_dev_op= s as optional driver configuration step. What do you think about both steps? Pawel