From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4CBAC234
 for <dev@dpdk.org>; Fri, 30 Jan 2015 13:11:49 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 30 Jan 2015 04:11:35 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,491,1418112000"; d="scan'208";a="670254463"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga002.fm.intel.com with ESMTP; 30 Jan 2015 04:11:34 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.28]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.229]) with mapi id 14.03.0195.001;
 Fri, 30 Jan 2015 12:11:32 +0000
From: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4
 header files
Thread-Index: AQHQPHaDnguQ7BoyTUu8MBOjSh+095zYfUiwgAANaoCAAAcRwA==
Date: Fri, 30 Jan 2015 12:11:31 +0000
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D12B903DC@IRSMSX102.ger.corp.intel.com>
References: <1422362703-18868-1-git-send-email-pawelx.wodkowski@intel.com>
 <3047657.sxLCa6eQXg@xps13>
 <F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com>
 <54CB6E1F.6040907@intel.com>
In-Reply-To: <54CB6E1F.6040907@intel.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4
 header files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jan 2015 12:11:49 -0000

> -----Original Message-----
> From: Doherty, Declan
> Sent: Friday, January 30, 2015 12:42 PM
> To: Wodkowski, PawelX; Thomas Monjalon
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 h=
eader
> files
>=20
> On 30/01/15 10:56, Wodkowski, PawelX wrote:
> >> -----Original Message-----
> >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >> Sent: Friday, January 30, 2015 11:21 AM
> >> To: Wodkowski, PawelX
> >> Cc: dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode=
4
> header
> >> files
> >>
> >> Hi Pawel,
> >>
> >>> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> >>> ---
> >>>   lib/librte_pmd_bond/rte_eth_bond_8023ad.h         |    8 ++++++++
> >>>   lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h |    8 ++++++++
> >>
> >> Why adding extern C in a private header file?
> >>
> >> --
> >> Thomas
> >
> > To be consistent with rte_eth_bond_private.h where it is included.
> >
> >
>=20
> We only need the decls on the public headers exported by the
> librte_pmd_bond makefile, so there is no need to modify
> rte_eth_bond_private.h as it should never be linked to directly by
> external code.

I modified rte_eth_bond_8023ad_private.h not rte_eth_bond_private.h.
In rte_eth_bond_private.h those declarations are present already.
If so those declarations should be removed from rte_eth_bond_private.h.

I can do this in v2 if you accept this.