From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9FEB3B481 for ; Wed, 18 Feb 2015 14:05:15 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 18 Feb 2015 05:05:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,512,1418112000"; d="scan'208";a="679741356" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 18 Feb 2015 05:05:12 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.69]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001; Wed, 18 Feb 2015 13:05:10 +0000 From: "Wodkowski, PawelX" To: "Richardson, Bruce" , Tetsuya Mukawa Thread-Topic: [dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier Thread-Index: AQHQS2q5DHlZ6LLH6k+Sd5cKjrp6Rpz2VmyAgAAAhYCAAAc/oA== Date: Wed, 18 Feb 2015 13:05:10 +0000 Message-ID: References: <1424257369-19130-1-git-send-email-mukawa@igel.co.jp> <20150218123006.GB5960@bricha3-MOBL3> <20150218123159.GC5960@bricha3-MOBL3> In-Reply-To: <20150218123159.GC5960@bricha3-MOBL3> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 13:05:16 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, February 18, 2015 1:32 PM > To: Tetsuya Mukawa > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identi= fier >=20 > On Wed, Feb 18, 2015 at 12:30:07PM +0000, Bruce Richardson wrote: > > On Wed, Feb 18, 2015 at 08:02:49PM +0900, Tetsuya Mukawa wrote: > > > Currently uint8_t is used for port identifier. This patch changes it, > > > and use uint16_t as port identifier. > > > This patch only changes ethdev library. ABI of the library will be > > > kept even after applying it. > > > > > > Also, this patch involves following fixes. > > > - Use "port_id" as variable name instead of "port". > > > > > > > > > Signed-off-by: Tetsuya Mukawa > > > --- > > > lib/librte_ether/rte_ethdev.c | 212 +- > > > lib/librte_ether/rte_ethdev_internal.h | 3672 > ++++++++++++++++++++++++++++++++ > > > 2 files changed, 3778 insertions(+), 106 deletions(-) > > > create mode 100644 lib/librte_ether/rte_ethdev_internal.h > > > > > I'm not sure I follow why we need a new header file for this. > > Also, thinking about this change, a more fundamental problem is going t= o be > > the mbuf structure, which stores a port id inside it in an 8-bit value. > > Upgrading that to a 16-bit value requires some thought, and verificatio= n to > > ensure any adjustment of fields does not lead to serious performance is= sues. > > > > Therefore, I suggest we leave the port id values as 8-bits until such t= ime > > as we need greater than 255 port values in a real-world use case. > > Out of interest - anyone have a DPDK app where they use >16 port id val= ues? If > > so, how high does the port id value get? Not real application but simple example of setup: 4 Niantic x 2 ports x 64 VF =3D 512 port id I don't know what would be the real need/advantage of such setup (bonding?)= but=20 you see, in theory it is already insufficient. > > > > Regards, > > /Bruce > > >=20 > Resending with correct email addr for Neil. >=20 > /Bruce