DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>,
	Alexander Guy <alexander@andern.org>,
	Julien Cretin <julien.cretin@trust-in-soft.com>,
	"Buriez, Patrice" <patrice.buriez@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version
Date: Thu, 28 May 2015 10:05:49 +0000	[thread overview]
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D1358F48E@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86CAC4@SHSMSX104.ccr.corp.intel.com>

> >
> > -ifeq ($(shell test -f /proc/version_signature && lsb_release -si
> > 2>/dev/null),Ubuntu)
> > +ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu)
> >  MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | tr -
> d .)
> > -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
> > -                        cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comma))
> > +UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE
> > $(RTE_KERNELDIR)/include/generated/utsrelease.h \
> > +	 | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1)
> >  MODULE_CFLAGS +=
> > -
> D"UBUNTU_KERNEL_CODE=UBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_
> C
> > ODE))"
> >  endif
> >
> > --
> > 1.9.1
Hi,

It is fine for me if it do the job and does not break build on other OS (also other 
Ubuntu versions especially 12.04 if we still support it).
Please only check if UTS_RELEASE is available on all Ubuntu versions DPDK support.

Pawel

  reply	other threads:[~2015-05-28 10:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 11:45 Simon Kagstrom
2015-05-28  3:30 ` Zhang, Helin
2015-05-28 10:05   ` Wodkowski, PawelX [this message]
2015-05-28 10:37     ` Simon Kågström
2015-05-28 10:48       ` Wodkowski, PawelX
2015-05-28 11:06         ` Buriez, Patrice
2015-05-28 11:35           ` Wodkowski, PawelX
2015-05-28 12:12         ` Simon Kågström
2015-05-28  4:00 ` Stephen Hemminger
2015-06-16 21:09 ` Thomas Monjalon
2015-07-10 14:43   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F6F2A6264E145F47A18AB6DF8E87425D1358F48E@IRSMSX102.ger.corp.intel.com \
    --to=pawelx.wodkowski@intel.com \
    --cc=alexander@andern.org \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=julien.cretin@trust-in-soft.com \
    --cc=patrice.buriez@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).