From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 532B59E7
 for <dev@dpdk.org>; Thu, 28 May 2015 12:05:52 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP; 28 May 2015 03:05:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,512,1427785200"; d="scan'208";a="578116631"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by orsmga003.jf.intel.com with ESMTP; 28 May 2015 03:05:50 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.36]) by
 IRSMSX107.ger.corp.intel.com ([169.254.10.94]) with mapi id 14.03.0224.002;
 Thu, 28 May 2015 11:05:49 +0100
From: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, Alexander Guy
 <alexander@andern.org>, Julien Cretin <julien.cretin@trust-in-soft.com>,
 "Buriez, Patrice" <patrice.buriez@intel.com>
Thread-Topic: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version
Thread-Index: AQHQmPaY/1ItCZM1VUyV9JxqmUR20J2RKGfg
Date: Thu, 28 May 2015 10:05:49 +0000
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D1358F48E@IRSMSX102.ger.corp.intel.com>
References: <20150527134524.5f107cac@miho>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86CAC4@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86CAC4@SHSMSX104.ccr.corp.intel.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu
	kernel version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 10:05:52 -0000

> >
> > -ifeq ($(shell test -f /proc/version_signature && lsb_release -si
> > 2>/dev/null),Ubuntu)
> > +ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu)
> >  MODULE_CFLAGS +=3D -DUBUNTU_RELEASE_CODE=3D$(shell lsb_release -sr | t=
r -
> d .)
> > -UBUNTU_KERNEL_CODE :=3D $(shell cut -d' ' -f2 /proc/version_signature =
| \
> > -                        cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comma)=
)
> > +UBUNTU_KERNEL_CODE :=3D $(shell echo `grep UTS_RELEASE
> > $(RTE_KERNELDIR)/include/generated/utsrelease.h \
> > +	 | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1)
> >  MODULE_CFLAGS +=3D
> > -
> D"UBUNTU_KERNEL_CODE=3DUBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_
> C
> > ODE))"
> >  endif
> >
> > --
> > 1.9.1
Hi,

It is fine for me if it do the job and does not break build on other OS (al=
so other=20
Ubuntu versions especially 12.04 if we still support it).
Please only check if UTS_RELEASE is available on all Ubuntu versions DPDK s=
upport.

Pawel