From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 18E8911C5
 for <dev@dpdk.org>; Thu, 28 May 2015 12:48:14 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP; 28 May 2015 03:48:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,512,1427785200"; d="scan'208";a="716887643"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga001.fm.intel.com with ESMTP; 28 May 2015 03:48:12 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.36]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.51]) with mapi id 14.03.0224.002;
 Thu, 28 May 2015 11:48:11 +0100
From: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= <simon.kagstrom@netinsight.net>,
 "Zhang, Helin" <helin.zhang@intel.com>, Alexander Guy <alexander@andern.org>, 
 Julien Cretin <julien.cretin@trust-in-soft.com>, "Buriez, Patrice"
 <patrice.buriez@intel.com>
Thread-Topic: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version
Thread-Index: AQHQmPaY/1ItCZM1VUyV9JxqmUR20J2RKGfg///5cYCAABMxMA==
Date: Thu, 28 May 2015 10:48:11 +0000
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D1358F4CC@IRSMSX102.ger.corp.intel.com>
References: <20150527134524.5f107cac@miho>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86CAC4@SHSMSX104.ccr.corp.intel.com>
 <F6F2A6264E145F47A18AB6DF8E87425D1358F48E@IRSMSX102.ger.corp.intel.com>
 <5566EFDD.5040209@netinsight.net>
In-Reply-To: <5566EFDD.5040209@netinsight.net>
Accept-Language: pl-PL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu
	kernel version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 10:48:15 -0000


> -----Original Message-----
> From: Simon K=E5gstr=F6m [mailto:simon.kagstrom@netinsight.net]
> Sent: Thursday, May 28, 2015 12:37 PM
> To: Wodkowski, PawelX; Zhang, Helin; Alexander Guy; Julien Cretin; Buriez=
,
> Patrice
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel ver=
sion
>=20
> On 2015-05-28 12:05, Wodkowski, PawelX wrote:
> >>>
> >>> -UBUNTU_KERNEL_CODE :=3D $(shell cut -d' ' -f2 /proc/version_signatur=
e | \
> >>> -                        cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comm=
a))
> >>> +UBUNTU_KERNEL_CODE :=3D $(shell echo `grep UTS_RELEASE
> >>> $(RTE_KERNELDIR)/include/generated/utsrelease.h \
> >>> +	 | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1)
> >
> > It is fine for me if it do the job and does not break build on other OS=
 (also other
> > Ubuntu versions especially 12.04 if we still support it).
> > Please only check if UTS_RELEASE is available on all Ubuntu versions DP=
DK
> support.
>=20
> From some digging, it appears it entered the kernel tree in 2006 and
> moved to include/generated/ in 2009 so I guess that should be fine for
> DPDK builds?
>=20
> // Simon

I also think that it is OK but I also think should check by building you (o=
 ask
someone to do it for you)  on those systems not by theory :)

--=20
Pawel