From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 416BE5B26; Wed, 13 Feb 2019 19:43:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 10:43:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,366,1544515200"; d="scan'208";a="115957155" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 13 Feb 2019 10:43:46 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Feb 2019 10:43:46 -0800 Received: from fmsmsx120.amr.corp.intel.com ([169.254.15.225]) by FMSMSX114.amr.corp.intel.com ([10.18.116.8]) with mapi id 14.03.0415.000; Wed, 13 Feb 2019 10:43:46 -0800 From: "Stillwell Jr, Paul M" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support Thread-Index: AQHUw1LwlSAGm3f+Q0mYfYdfYbuZPqXeERuw Date: Wed, 13 Feb 2019 18:43:44 +0000 Message-ID: References: <1548662003-7339-1-git-send-email-wei.zhao1@intel.com> <1550029788-45809-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1550029788-45809-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzgzYjkwOWEtMWYwOS00OTkzLWEzNGUtYmZjYTM4MjJjODJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidGN5SUdtWUR6dFV2Z1F2K3pwd2xNU296Nm9lUThsWGwzVVwvUHdXcHRTYlRGS0NHXC9MdjY3YkN2bHg1ajVVdnJRIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 18:43:49 -0000 Your patch description says we should be checking dev_conf.rxmode.offloads = should be checked to enable VLAN, but I don't see the patch checking for th= at. What am I missing? Paul -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao Sent: Tuesday, February 12, 2019 7:50 PM To: dev@dpdk.org Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei Subject: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support There is need to check whether dev_conf.rxmode.offloads is set when start i= ce device, if one of the vlan related bits is set, for example DEV_RX_OFFLO= AD_VLAN_FILTER and so on, sevice start process to enable this offloads requ= est. Signed-off-by: Wei Zhao --- v2: -rework patch for compile error. --- drivers/net/ice/ice_ethdev.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c in= dex 6b0113b..a23c63a 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1714,7 +1714,7 @@ ice_dev_start(struct rte_eth_dev *dev) struct ice_vsi *vsi =3D pf->main_vsi; uint16_t nb_rxq =3D 0; uint16_t nb_txq, i; - int ret; + int mask, ret; =20 /* program Tx queues' context in hardware */ for (nb_txq =3D 0; nb_txq < data->nb_tx_queues; nb_txq++) { @@ -1742,6 +1= 742,14 @@ ice_dev_start(struct rte_eth_dev *dev) =20 ice_set_rx_function(dev); =20 + mask =3D ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK | + ETH_VLAN_EXTEND_MASK; + ret =3D ice_vlan_offload_set(dev, mask); + if (ret) { + PMD_INIT_LOG(ERR, "Unable to set VLAN offload"); + goto rx_err; + } + /* enable Rx interrput and mapping Rx queue to interrupt vector */ if (ice_rxq_intr_setup(dev)) return -EIO; -- 2.7.5