From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADAF6A0548; Fri, 23 Sep 2022 23:56:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A53142BC3; Fri, 23 Sep 2022 23:56:06 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id CF651400D4 for ; Fri, 23 Sep 2022 23:56:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663970165; x=1695506165; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=H/VWoHD5D6TOQhh2G4KiGnNaYUjrnwh2830PMvfzwtI=; b=PG3ouacr2e92HodW4ZYRo/V8EjchEo1LFgXb7qRijH4lIQDvXy0gq30F b1n1asphAsVR+DwH6MDt43o70ZcMp+DNXIOqsl/0pUWbtd54mdHHFVTO1 68osX6o3UzMXBpycxCnkgsyojRWnGDqZO8pglkBrbEXyC5hrqRQk7m4jZ LEnZHS5SleXd2Ux+IX6zWlf7eg1JtOAFxCpsyCCVdL/twnaddlW305RS5 NEBXzQ95q6sDg8iiJyuV8hd2iBUuNPXLNXphHRiZg26OM4O/ANndophBc aIn5JHFn4AT+SX7VW8BF1xuhrcpsagfNBXykamun0wRidZktxMNjxYoVP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10479"; a="362523118" X-IronPort-AV: E=Sophos;i="5.93,340,1654585200"; d="scan'208";a="362523118" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 14:56:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,340,1654585200"; d="scan'208";a="795660846" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 23 Sep 2022 14:56:04 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 14:56:03 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 23 Sep 2022 14:56:03 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 23 Sep 2022 14:56:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQVwrd8TgRotrKvTJ21QAV1gM3PG9+3/502ZkRuwlw8bBoc7FaFO+eWvkJVCwq+BtD33WHoZZbMrbfyilYBrzHmagcaXwBgX01EcOnmXms3mWpgP1XrLNFPFRkPhPnTtU/GF8FtdbtT9ur9RyN/pbeHvtF8AQdiB/0FFuGbsK/fC/9odWv9X3LckPKVIKKMxx9265d6VPXMCRBfOVYEiJe0bGwiSFFajGVYR1oWXICTSVVBlnxq45Vq8Z1Wr/Ym1ufyTztscqQUvGRH5owWtsbth+EHu06wIER3ZNNGGDDjqJgljpEnwh1/WJzBs+ozGbB+PXIObztk1BZbIf+IN3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e42m+FHRWA78vdRshKfHt8UIElZ/Er6KITSTZGszfkQ=; b=Td0Ti9aKSCnekIlxvGX90qdoKRQRT2Xyl/l+QKQcxan6B4bcbfCNy5nc/r+RevupXdj3sgQ/JjsWwUZhmFhVHg6LnisYfErR3pTcThHlKSr/OP2ex/7m+zSAmDOfF4werBzcC9fxJK5us4OJYF7wk0SzcP9gOIR8oH+NcV7//sFxkYGH+/eOkBHImARRJl17Gj3MO75BIclL7zm12HyqJ4hDr57U7lJuwIn3jALoQy2gqPacRoV8pgHXvH4T2hj2pxCJqxACokbr/ORZevxj3bKWnIQS3j1zeC2jYxm7qMu0Ypuur5x62a6lhmBzn/dhAVlRdHN5DSt1rQZlUN1R2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3303.namprd11.prod.outlook.com (2603:10b6:a03:18::15) by PH7PR11MB6355.namprd11.prod.outlook.com (2603:10b6:510:1fd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Fri, 23 Sep 2022 21:56:02 +0000 Received: from BYAPR11MB3303.namprd11.prod.outlook.com ([fe80::10cc:4369:95db:87b3]) by BYAPR11MB3303.namprd11.prod.outlook.com ([fe80::10cc:4369:95db:87b3%5]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 21:56:02 +0000 From: "Harris, James R" To: David Marchand CC: "Walker, Benjamin" , "dev@dpdk.org" , "Liu, Changpeng" , Alexey Marchuk , Shuhei Matsumoto , "Thomas Monjalon" , "Richardson, Bruce" , Stephen Hemminger Subject: Re: [RFC v3 00/26] Bus and device cleanup for 22.11 Thread-Topic: [RFC v3 00/26] Bus and device cleanup for 22.11 Thread-Index: AQHYopaL6RLeWOtkQkyDXy8araWHk62fbCUAgCAZkYCABsoagIABcCMAgCMOBoCAAiTdAIAA9oUA Date: Fri, 23 Sep 2022 21:56:01 +0000 Message-ID: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <8AC9271A-AC63-4C5E-BF9C-E4E8027A1132@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3303:EE_|PH7PR11MB6355:EE_ x-ms-office365-filtering-correlation-id: 5c4f946c-4921-4a2a-44e9-08da9dae67f7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eVexpfqzE3M0tC3s13lqNc+k/UYwGzyU6V3X8oTUCiWK4P/cDgLBYa24rQRnVEsEIhI3XV/+hZO9bJkJTAxNd6/89XaTbXnJjdArfnRQgYlavM1APc/hsqmGzSTIitaJbKDAXOCVUHe53KqitJyMAR+wavzrEo/tBfyZgHRzooFH015i1iIEZ4sunSqD4i69+DLrZg0XsIJg+K1hKNOu3+J7xWCgAmN21S+AMcqG1jz0TysPqua7IstXCzMm7QahA0DzD2T5So09QF7XXIV8y5vNt4+ZtgLD4uCsc90bNLV4/jjBvKHxobMRgpdZXcbPqt0gi6hRkYKAYyLCnn67x9RWjq95PMnM/CsTlQi/P3FdYHCfqOaKQTJ9s2G/jWO5wu1OyAex8w9Cllak/dw/24Z75QVkgTxkzyVYOWHtFE2z07KJlynisz/uNiP0YXq43F3kn/GZ4RWNvFxWjfas1xLoQOUZyLqhellb8y2ptfmXFAQrkf0aN08Uvh8oH5VoZKsM++iyrjF3lEGVBsa2Pz7Pb+8xzn51yuqPOz85wlHY1wY1BL+IgeRx2E0fmRpJtFfopKRzOSZxs2aAisK/wDa+FnN7cjhp0/W58dvuCT1EpQ3Y0FpSaxhEL63iuNuuiXCUAOO1rHZqzo6HjePHPYUv/JTtwRvnTbuPMJNZL3IE0MSYtJcMqyWnLjpLYYLHKafI6PotVBeBsIs1YipjJlYGvNuY5xbPyE4kKOujA5ACJVntxHJZrGbW7J5aW2hAAnWJe9IG30meP8/tH+fXdmozj7UqFpyJLEz4wD51iyE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3303.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199015)(6486002)(71200400001)(6916009)(478600001)(54906003)(36756003)(6506007)(5660300002)(76116006)(53546011)(316002)(6512007)(26005)(64756008)(8676002)(38100700002)(66476007)(66446008)(4326008)(2906002)(41300700001)(186003)(8936002)(2616005)(66556008)(66946007)(122000001)(33656002)(83380400001)(86362001)(38070700005)(82960400001)(45980500001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BCxMAd/HmA9YCQDEEq/yNzYoDgm8xUu22LrlJzX55pPfBPdgerJ8A+kCDHvL?= =?us-ascii?Q?B+qM8IyJFfgQXIls48c/5Ax8xe2eOP3MQPH8XSw4Sy49AEI4En4iE2Pro/Ik?= =?us-ascii?Q?s1lfdz3gxd/GIMoSnDJKU1ExJEc/6HEyrlg5Yoc1CMnMx41MfUazVmqaFA3O?= =?us-ascii?Q?vKLcAHQRHrIlBDNmxk4vu+sNWXxHixGjS/nqaG0TiQyeN+2AYLAyfcYIWZph?= =?us-ascii?Q?0hn20wFBMuWhXlENPM4YWJwz/mL+clUDh5FXOAgpddZxOv6hRTEdKyYsYO9Y?= =?us-ascii?Q?0wCiPXN8fZkjbNLTPShrzSxP8hUDyX6n9bqnvS1uRiujbMu9lOADdkmVXgGv?= =?us-ascii?Q?2ndyOdQrG3oLvkyu33A9pWxHPECL2qeqjEz8dVnh+Fa8yFaDzAB0LQojmSv3?= =?us-ascii?Q?hTecemQ7Ga3FWeikO9bqK9NwMeJoxDwFomHb01VmjGNUoMfyQweg5raXyTd3?= =?us-ascii?Q?fEzZHMHlwQqq9vgv+cynhVooZ31M7vaDfWPDrLoj5kiRGVK+LwM2rOQswxqE?= =?us-ascii?Q?Ibgx0cyBlGRyTYZN64EYpddcMNaPBwu6sQ1a73HMPorsbjyI42r5DdeOM78k?= =?us-ascii?Q?sy4Uh26Yr9cr5CKtoAsTKYJOSlaFuSczuFCln/tKpMiThJm0lWgrcBUlJIqr?= =?us-ascii?Q?xZb7bsLRkuEnpJZVrW+14+23oNQaJ0B4r579taZOJ+8BxQdAV7iSFGIEqxPs?= =?us-ascii?Q?aOlyIo9lpMjr0zeyy6OFg3/yzLwtE3OZE2r5U+zctIRMl9pjaHeR0nBTR+Wf?= =?us-ascii?Q?t7T1zpkMX6dOYzX4nboefOVakJPOHrgWgHaIKDdHrHmm9A22I/ENPOHwSn1h?= =?us-ascii?Q?cEQOkTW2Biu0GmELO+uoi7fs/p3Xdp4UMTK7m3gzpVsZulQk9OEVgnl43cMB?= =?us-ascii?Q?LtscSVWenSZtwCI9nXIoEnj+4uMb2nxwABGPpss946VVzTX4WCxwxg1ecvzd?= =?us-ascii?Q?FB4fLeO0yM1bL8kmm4f5jkJWXT/0VxbVK3bYpxfJ5C7Ef+NPRIYXftyPo+WM?= =?us-ascii?Q?1GPvIDyGN09juWCtXpig6g4B/U7ZzOdgN9FZUGWGmNfcjuTDkXnSykXMI9V1?= =?us-ascii?Q?5N4MLgYlAMXYhpc/MMY/Sg8PVCSK9Tz2qlq2Aa2dpi6KgzfsdSyb64ZZ+oCO?= =?us-ascii?Q?YAAzZyZ5I7bVsFJVjOCMddbwQ51SXCg97J+zaOYlBRACW1hS4ZSxpkzRGekR?= =?us-ascii?Q?wLy6w15L7sOiA3OYkBeri0wC7iVkay7Ywp7AIUX2o46LvSbKI2FUJrgBxf9t?= =?us-ascii?Q?v8PBH1ATsRfGZi0Cdxln9mkrTAVSAT+jGjkcB+IslS/ptuPzzO9kI8RpOVl4?= =?us-ascii?Q?8pVZcaT1gNpScnCDLvd8zm7CD/rXVh6fOyuaixR1C3xJlwMOWuEOEf7P48Oh?= =?us-ascii?Q?7+FnTnWtirwfZdD8DuXJTkPvZwxFJu28Tnk0GzgWHM4EHDpUQRBBo3jWQZJM?= =?us-ascii?Q?p+TREv/4fURbg6icm3kNY1RIxCD1dmc6Jw1fuld+jJrzKnmE3PMCWfN+Er+J?= =?us-ascii?Q?aRVCcuItNxaaOVI9PvmtlyOB9pzvvxu01HjxZpQSKwUqDIptGpBhnP532uWM?= =?us-ascii?Q?VJG6Br5DTBmWJSRXAIMCRpHPJuTWxq+dCfSUyJsZ7nRMLrh8rEiaoe8HemSw?= =?us-ascii?Q?8w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <1D0827F3B24C9A4F835B47F72808F7FC@namprd11.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4f946c-4921-4a2a-44e9-08da9dae67f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 21:56:02.0006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uXzameQGyQpTFhS3etRJlsuqYV2EZmtFJLY7AmbG4d4Gdl0KEZRYfYkEuY6c4tO7eUneaYckT+0BY1ItjyKv/zdobjtXZHtSW3hYueP+4X0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6355 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Sep 23, 2022, at 12:13 AM, David Marchand = wrote: >=20 > On Thu, Sep 22, 2022 at 12:29 AM Harris, James R > wrote: >>=20 >>=20 >> So sticking with the internal header copies for now, this works fine >> for LTS and non-LTS releases. What about stable releases (i.e. 22.11.1)= ? >> IIUC, these header files could change in a stable release since they are >> no longer part of the ABI? >=20 > In theory, yes they can change. > But this is a price to pay, as no one seems willing to invest and > maintain a stable API for PCI drivers. Understood. SPDK is preparing for this possibility, just wanted to confirm it was necessary. > I just noticed that some parts of the cleanups I had proposed have > been merged in SPDK. > Next time, I prefer getting some feedback from SPDK community before > my SoB is applied (or stripped) on modified patches. My apologies David. The RTE_DEV_FOREACH cleanup was a nice one and an obvi= ous improvement. I believe it was applied without any modifications (except fo= r fuzz offsets) but still should have given you a heads-up. -Jim