From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 093121B435 for ; Mon, 7 Jan 2019 08:41:50 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B957A4042; Mon, 7 Jan 2019 07:41:49 +0000 (UTC) Received: from [10.36.116.34] (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1F68608C1; Mon, 7 Jan 2019 07:41:48 +0000 (UTC) From: "Eelco Chaudron" To: "Stephen Hemminger" , cristian.dumitrescu@intel.com Cc: dev@dpdk.org Date: Mon, 07 Jan 2019 08:41:46 +0100 Message-ID: In-Reply-To: <20190104114235.228a31f9@hermes.lan> References: <154661036216.75321.4852909033090962683.stgit@dbuild> <154661038141.75321.10886021990395716851.stgit@dbuild> <20190104114235.228a31f9@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 07 Jan 2019 07:41:49 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 07:41:50 -0000 On 4 Jan 2019, at 20:42, Stephen Hemminger wrote: > On Fri, 4 Jan 2019 13:59:42 +0000 > Eelco Chaudron wrote: > >> This patch adds support for RFC4115 trTCM meters. >> >> Signed-off-by: Eelco Chaudron > > > > Fix comment formatting. Hi Stephen, I left these warnings in on purpose, to match the existing comment style in the file. These specific warnings are from a structure copied from one right above which also has the same style and line lengths. As they are warning I though I should leave it as is, Christian what are your thoughts on this? > > ### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM > meter support > > WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines > #172: FILE: lib/librte_meter/rte_meter.h:59: > +/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and > EBS > +parameters only count bytes of IP packets and do not include link > specific > > WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a > separate line > #174: FILE: lib/librte_meter/rte_meter.h:61: > +none-zero respectively.*/ > > WARNING:LONG_LINE_COMMENT: line over 80 characters > #176: FILE: lib/librte_meter/rte_meter.h:63: > + uint64_t cir; /**< Committed Information Rate (CIR). Measured in > bytes per second. */ > > WARNING:LONG_LINE_COMMENT: line over 80 characters > #177: FILE: lib/librte_meter/rte_meter.h:64: > + uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes > per second. */ > > WARNING:LONG_LINE_COMMENT: line over 80 characters > #355: FILE: lib/librte_meter/rte_meter.h:406: > + /**< Number of bytes currently available in the excess(E) token > bucket */ > > total: 0 errors, 5 warnings, 356 lines checked