From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DF8A41B1CD for ; Fri, 5 Oct 2018 17:05:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 08:05:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,344,1534834800"; d="scan'208";a="96395354" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 05 Oct 2018 08:04:58 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 5 Oct 2018 08:04:58 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by fmsmsx116.amr.corp.intel.com ([169.254.2.92]) with mapi id 14.03.0319.002; Fri, 5 Oct 2018 08:04:58 -0700 From: "Wiles, Keith" To: Ilya Maximets CC: "dev@dpdk.org" , "Wu, Jingjing" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Xing, Beilei" , "Zhang, Qi Z" , "Wang, Xiao W" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay Thread-Index: AQHUQ5SjvH4y+epZ7EKWcma5u068v6URWCgAgAAJzgCAAAXIgA== Date: Fri, 5 Oct 2018 15:04:57 +0000 Message-ID: References: <20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com> <20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com> <20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com> In-Reply-To: <20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.18.77] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 15:05:03 -0000 > On Oct 5, 2018, at 9:44 AM, Ilya Maximets wrote: >=20 > On 05.10.2018 17:09, Wiles, Keith wrote: >>=20 >>=20 >>> On Sep 3, 2018, at 9:44 AM, Ilya Maximets wrot= e: >>>=20 >>> For meson build without deprecation warnings following >>> patch should be applied first: >>> http://patches.dpdk.org/patch/44129/ >>=20 >> Not to be super picky (OK I am super picky sometimes) can we change the = name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is d= elay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which i= s a form of delay, but delay in DPDK assume busy wait. >=20 > I'm not sure about this, because this function intended to be used > as 'rte_delay_us_callback', i.e. as implementation of 'rte_delay_us()'. > IMO, it should state that it is the part of this API and that it > sleeps internally at the same time. So I tried to combine both "delay" > and "sleep" in one function name. >=20 > If we'll change the name to 'rte_sleep_us' it will look like alternative > to 'rte_delay_us', but it's one of its implementations. > 'rte_delay_us_sleep' should be alternative to 'rte_delay_us_block()'. >=20 > I'd like to call it 'rte_delay_us_nonblock()', but it may be way more > confusing. >=20 > What do you think? I personally do not see the big tie to delay and callback as the rte_delay_= us() is not rte_delay_us_with_callback() :-) Yes the code maybe doing a cal= lback, but that has nothing to do with the API name IMO. Anyone else care about the name? >=20 >>>=20 >>> Ilya Maximets (2): >>> eal: add nanosleep based delay function >>> drivers/net: use sleep delay by default for intel NICs >>>=20 >>> drivers/net/avf/Makefile | 1 + >>> drivers/net/avf/base/avf_osdep.h | 4 +- >>> drivers/net/e1000/Makefile | 1 + >>> drivers/net/e1000/base/e1000_osdep.h | 2 +- >>> drivers/net/e1000/meson.build | 2 + >>> drivers/net/i40e/base/i40e_osdep.h | 6 +-- >>> drivers/net/ifc/base/ifcvf_osdep.h | 2 +- >>> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- >>> drivers/net/ixgbe/meson.build | 3 +- >>> lib/librte_eal/common/eal_common_timer.c | 19 +++++++ >>> .../common/include/generic/rte_cycles.h | 11 ++++ >>> lib/librte_eal/rte_eal_version.map | 1 + >>> test/test/autotest_data.py | 6 +++ >>> test/test/meson.build | 1 + >>> test/test/test_cycles.c | 51 ++++++++++++++----- >>> 15 files changed, 89 insertions(+), 23 deletions(-) >>>=20 >>> --=20 >>> 2.17.1 >>>=20 >>=20 >> Regards, >> Keith >>=20 >>=20 >>=20 Regards, Keith