From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7723E12A8 for ; Tue, 9 Jun 2015 10:58:47 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 09 Jun 2015 01:58:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,579,1427785200"; d="scan'208";a="584589561" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga003.jf.intel.com with ESMTP; 09 Jun 2015 01:58:29 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 9 Jun 2015 16:55:28 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX101.ccr.corp.intel.com ([10.239.4.153]) with mapi id 14.03.0224.002; Tue, 9 Jun 2015 16:55:16 +0800 From: "He, Shaopeng" To: "Chen, Jing D" , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] fm10k: update VLAN offload features Thread-Index: AQHQnOAlm5wX4m2UyESob9zYYP874Z2jCHwAgADbulA= Date: Tue, 9 Jun 2015 08:55:15 +0000 Message-ID: References: <1433213937-21690-1-git-send-email-shaopeng.he@intel.com> <1433213937-21690-4-git-send-email-shaopeng.he@intel.com> <4341B239C0EFF9468EE453F9E9F4604D016FA28F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D016FA28F@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] fm10k: update VLAN offload features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 08:58:48 -0000 > -----Original Message----- > From: Chen, Jing D > Sent: Tuesday, June 09, 2015 11:27 AM > To: He, Shaopeng; dev@dpdk.org > Cc: Qiu, Michael > Subject: RE: [PATCH 3/3] fm10k: update VLAN offload features >=20 > Hi, >=20 >=20 > > -----Original Message----- > > From: He, Shaopeng > > Sent: Tuesday, June 02, 2015 10:59 AM > > To: dev@dpdk.org > > Cc: Chen, Jing D; Qiu, Michael; He, Shaopeng > > Subject: [PATCH 3/3] fm10k: update VLAN offload features > > > > Fm10k PF/VF does not support QinQ; VLAN strip and filter are always on > > for PF/VF ports. > > > > Signed-off-by: Shaopeng He > > --- > > drivers/net/fm10k/fm10k_ethdev.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > > b/drivers/net/fm10k/fm10k_ethdev.c > > index 4f23bf1..9b198a7 100644 > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > @@ -884,6 +884,27 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, > > uint16_t vlan_id, int on) > > return (-EIO); > > } > > > > +static void > > +fm10k_vlan_offload_set(__rte_unused struct rte_eth_dev *dev, int > > +mask) { > > + if (mask & ETH_VLAN_STRIP_MASK) { > > + if (!dev->data->dev_conf.rxmode.hw_vlan_strip) > > + PMD_INIT_LOG(ERR, "VLAN stripping is " > > + "always on in fm10k"); > > + } > > + > > + if (mask & ETH_VLAN_EXTEND_MASK) { > > + if (dev->data->dev_conf.rxmode.hw_vlan_extend) > > + PMD_INIT_LOG(ERR, "VLAN QinQ is not " > > + "supported in fm10k"); > > + } > > + > > + if (mask & ETH_VLAN_FILTER_MASK) { > > + if (!dev->data->dev_conf.rxmode.hw_vlan_filter) > > + PMD_INIT_LOG(ERR, "VLAN filter is always on in > > fm10k"); > > + } > > +} > > + >=20 > Update fm10k_dev_infos_get() to configure above options to expected > values? Thank you for the reminder, I will update the value of rx_offload_capa=20 and tx_offload_capa in fm10k_dev_infos_get() in the next version