* [dpdk-dev] [PATCH] fm10k: fix vlan flag bug in scattered RX
@ 2015-12-18 3:09 Wang Xiao W
2015-12-18 5:35 ` He, Shaopeng
0 siblings, 1 reply; 3+ messages in thread
From: Wang Xiao W @ 2015-12-18 3:09 UTC (permalink / raw)
To: jing.d.chen; +Cc: dev
In fm10k_recv_scattered_pkts function, a packet is stored in a linked list,
offload flags such as PKT_RX_VLAN_PKT should be set in the first segment.
Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
---
drivers/net/fm10k/fm10k_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c
index e958865..de31cad 100644
--- a/drivers/net/fm10k/fm10k_rxtx.c
+++ b/drivers/net/fm10k/fm10k_rxtx.c
@@ -305,7 +305,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
* So, always PKT_RX_VLAN_PKT flag is set and vlan_tci
* is valid for each RX packet's mbuf.
*/
- mbuf->ol_flags |= PKT_RX_VLAN_PKT;
+ first_seg->ol_flags |= PKT_RX_VLAN_PKT;
first_seg->vlan_tci = desc.w.vlan;
/* Prefetch data of first segment, if configured to do so. */
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: fix vlan flag bug in scattered RX
2015-12-18 3:09 [dpdk-dev] [PATCH] fm10k: fix vlan flag bug in scattered RX Wang Xiao W
@ 2015-12-18 5:35 ` He, Shaopeng
2016-02-02 17:41 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: He, Shaopeng @ 2015-12-18 5:35 UTC (permalink / raw)
To: Wang, Xiao W, Chen, Jing D; +Cc: dev
> -----Original Message-----
> From: Wang, Xiao W
> Sent: Friday, December 18, 2015 11:09 AM
> To: Chen, Jing D
> Cc: He, Shaopeng; dev@dpdk.org; Wang, Xiao W
> Subject: [PATCH] fm10k: fix vlan flag bug in scattered RX
>
> In fm10k_recv_scattered_pkts function, a packet is stored in a linked list,
> offload flags such as PKT_RX_VLAN_PKT should be set in the first segment.
>
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
Thanks for the catch.
Acked-by: Shaopeng He <shaopeng.he@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: fix vlan flag bug in scattered RX
2015-12-18 5:35 ` He, Shaopeng
@ 2016-02-02 17:41 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-02-02 17:41 UTC (permalink / raw)
To: He, Shaopeng; +Cc: dev
On Fri, Dec 18, 2015 at 05:35:35AM +0000, He, Shaopeng wrote:
>
> > -----Original Message-----
> > From: Wang, Xiao W
> > Sent: Friday, December 18, 2015 11:09 AM
> > To: Chen, Jing D
> > Cc: He, Shaopeng; dev@dpdk.org; Wang, Xiao W
> > Subject: [PATCH] fm10k: fix vlan flag bug in scattered RX
> >
> > In fm10k_recv_scattered_pkts function, a packet is stored in a linked list,
> > offload flags such as PKT_RX_VLAN_PKT should be set in the first segment.
> >
> > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
>
> Thanks for the catch.
>
> Acked-by: Shaopeng He <shaopeng.he@intel.com>
First commit applied to dpdk-next-net tree.
Applied to dpdk-next-net/rel_16_04 with added fixes line:
Fixes: 6b59a3bc82b1 ("fm10k: fix VLAN in Rx mbuf")
I hope to apply more patches that are ready in the coming days.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-02 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 3:09 [dpdk-dev] [PATCH] fm10k: fix vlan flag bug in scattered RX Wang Xiao W
2015-12-18 5:35 ` He, Shaopeng
2016-02-02 17:41 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).