From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 669DC95D6 for ; Thu, 4 Feb 2016 01:38:51 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 03 Feb 2016 16:38:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,392,1449561600"; d="scan'208";a="876490372" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 03 Feb 2016 16:38:50 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 3 Feb 2016 16:38:49 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 3 Feb 2016 16:38:49 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Thu, 4 Feb 2016 08:38:41 +0800 From: "He, Shaopeng" To: "Chen, Jing D" , "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: fix switch manager high CPU usage Thread-Index: AQHRWY9jRtP6TaSaVESQg+BW53R9HJ8ZbhsAgAGnV4A= Date: Thu, 4 Feb 2016 00:38:40 +0000 Message-ID: References: <1453960023-31402-1-git-send-email-shaopeng.he@intel.com> <4341B239C0EFF9468EE453F9E9F4604D0443C0B8@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D0443C0B8@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: fix switch manager high CPU usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 00:38:51 -0000 Hi Mark, > -----Original Message----- > From: Chen, Jing D > Sent: Wednesday, February 03, 2016 3:23 PM > To: He, Shaopeng; dev@dpdk.org > Cc: Wang, Xiao W > Subject: RE: [PATCH] fm10k: fix switch manager high CPU usage >=20 > Hi, >=20 >=20 > Best Regards, > Mark >=20 >=20 > > -----Original Message----- > > From: He, Shaopeng > > Sent: Thursday, January 28, 2016 1:47 PM > > To: dev@dpdk.org > > Cc: Chen, Jing D; Wang, Xiao W; He, Shaopeng > > Subject: [PATCH] fm10k: fix switch manager high CPU usage > > > > fm10k switch core uses source MAC + VID + SGLORT to do look up in MAC > > table. If no match, an exception interrupt will be sent to the switch > > manager, and cause high CPU usage. >=20 > Above paragraph didn't describe the bug clearly. Can you add more Words o= n > it? Thanks for the comments, I will send a v2. >=20 > > This patch fixes this issue. A default SGLORT is assigned to each TX > > queue. This default value works for non-VMDq mode and current VMDq > > example. For advanced VMDq usage, e.g. > > different source MAC address for different TX queue, FTAG forwarding > > function could be used to change this default SGLORT value. > > > > Signed-off-by: Shaopeng He > > --- > > drivers/net/fm10k/fm10k_ethdev.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > > b/drivers/net/fm10k/fm10k_ethdev.c > > index e4aed94..f6eb05d 100644 > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > @@ -675,6 +675,9 @@ fm10k_dev_tx_init(struct rte_eth_dev *dev) > > FM10K_WRITE_REG(hw, FM10K_TDBAH(i), > > base_addr >> (CHAR_BIT * sizeof(uint32_t))); > > FM10K_WRITE_REG(hw, FM10K_TDLEN(i), size); > > + > > + /* assign default SGLORT for each TX queue */ > > + FM10K_WRITE_REG(hw, FM10K_TX_SGLORT(i), hw- > > >mac.dglort_map); > > } > > > > /* set up vector or scalar TX function as appropriate */ > > -- > > 1.9.3