From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2F03995D5 for ; Thu, 4 Feb 2016 01:40:39 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 03 Feb 2016 16:40:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,392,1449561600"; d="scan'208";a="908037928" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2016 16:40:38 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 3 Feb 2016 16:40:38 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 3 Feb 2016 16:40:37 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.210]) with mapi id 14.03.0248.002; Thu, 4 Feb 2016 08:40:36 +0800 From: "He, Shaopeng" To: "Chen, Jing D" , "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: enable PCIe port level Loopback Suppression Thread-Index: AQHRWY+WyJJ7EWxcM0a2xEQzaMmnIp8ZbOwAgAGowbA= Date: Thu, 4 Feb 2016 00:40:34 +0000 Message-ID: References: <1453960119-31558-1-git-send-email-shaopeng.he@intel.com> <4341B239C0EFF9468EE453F9E9F4604D0443C0A1@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D0443C0A1@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: enable PCIe port level Loopback Suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 00:40:39 -0000 Hi Mark, > -----Original Message----- > From: Chen, Jing D > Sent: Wednesday, February 03, 2016 3:18 PM > To: He, Shaopeng; dev@dpdk.org > Cc: Wang, Xiao W > Subject: RE: [PATCH] fm10k: enable PCIe port level Loopback Suppression >=20 > Hi, >=20 > Best Regards, > Mark >=20 >=20 > > -----Original Message----- > > From: He, Shaopeng > > Sent: Thursday, January 28, 2016 1:49 PM > > To: dev@dpdk.org > > Cc: Chen, Jing D; Wang, Xiao W; He, Shaopeng > > Subject: [PATCH] fm10k: enable PCIe port level Loopback Suppression > > > > A PCIe port may represent within it multiple logical ports > > (for example when SR-IOV is enabled, or when a VMDQ type logical > > port scheme is employed assigning ports to sets of queues). > > For this reason each RX queue in each PCIe port is given a source > > GLORT that is used for loopback suppression. > > This patch assigns a SGLORT for each RX queue, and enables PCIe > > port level Loopback Suppression. > > >=20 > The log message is a little obscure for me. Maybe you can wrote: > In FM10K, a single PF device can derive out a few logical ports, like SRI= OV > VF device, VMDQ object. To better manage them, FM10K silicon assigned a > Unique GLORT ID to each logical ports. > When a logical port sends a broadcast packet, the silicon will flood it t= o all > Logical ports, including the one sent the broadcast packet. To prevent th= is, > silicon has a rxq register to fill the glort id of the logical port that = queue binds > to.... Thanks for the suggestion, I will reword and send another version. Thanks, --Shaopeng >=20 > > Signed-off-by: Shaopeng He > > --- > > drivers/net/fm10k/fm10k_ethdev.c | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > > b/drivers/net/fm10k/fm10k_ethdev.c > > index f6eb05d..60f821a 100644 > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > @@ -690,12 +690,15 @@ static int > > fm10k_dev_rx_init(struct rte_eth_dev *dev)