From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 40878F72 for ; Tue, 24 Jul 2018 15:17:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 06:17:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,398,1526367600"; d="scan'208";a="67121189" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jul 2018 06:17:51 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Jul 2018 06:17:51 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.3]) by fmsmsx118.amr.corp.intel.com ([169.254.1.60]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 06:17:51 -0700 From: "Wiles, Keith" To: "Kurakin, Ilia" CC: DPDK , "Richardson, Bruce" , "Khatko, Roman P" Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach Thread-Index: AQHUH1suvEIdyCqRYU+fqAvFIz/MoKSe2BMA Date: Tue, 24 Jul 2018 13:17:50 +0000 Message-ID: References: <1530623488-69056-1-git-send-email-ilia.kurakin@intel.com> <1532002902-25187-1-git-send-email-ilia.kurakin@intel.com> In-Reply-To: <1532002902-25187-1-git-send-email-ilia.kurakin@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.3.8] Content-Type: text/plain; charset="us-ascii" Content-ID: <92F93CD6BF67454AB33B97F28A3E7000@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 13:17:53 -0000 > On Jul 19, 2018, at 7:21 AM, ilia.kurakin@intel.com wrote: >=20 > From: Ilia Kurakin >=20 > The patch changes rx_burst profiling approach: > 1. VTune's instrumentation is removed > 2. empty hook callback for profiling is added > This way all VTune-specific logic moves to the VTune side. > Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option > is turned on. VTune uses this hook to attach to the polling cycle. It > is not possible to attach to the rx_burst directly, as it is inline. >=20 > Signed-off-by: Ilia Kurakin >=20 > --- >=20 > -v2 change: > fix coding style issue, re-merge >=20 > config/common_base | 2 +- > doc/guides/prog_guide/profile_app.rst | 34 ++--------- > lib/librte_ethdev/ethdev_profile.c | 103 +++++------------------------= ----- > lib/librte_ethdev/ethdev_profile.h | 6 +- > lib/librte_ethdev/rte_ethdev.c | 4 +- > 5 files changed, 25 insertions(+), 124 deletions(-) >=20 Looks good and a cleaner method. Acked-by: Keith Wiles Regards, Keith