DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option
Date: Fri, 21 Sep 2018 08:31:09 +0000	[thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8461EA4DF@HASMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com>

I'd like to point out that the comments inside eal_memory.c are outdated (e.g. the one from line #249). It makes it difficult to review this patch.

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pawel Wodkowski
> Sent: Friday, September 21, 2018 1:57 PM
> To: dev@dpdk.org
> Cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
> Subject: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option
> 
> The final_va field is set during remap_segment() but this information is not
> propagated to temporal copy of huge page memory configuration so the
> unlink_hugepage_files() function wrongly assume that there is nothing to
> unlink. Fix this issue by checking orig_va instead of final_va.
> 
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> To: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>

  reply	other threads:[~2018-09-21  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 11:56 Pawel Wodkowski
2018-09-21  8:31 ` Stojaczyk, Dariusz [this message]
2018-09-26 18:12 ` Wodkowski, PawelX
2018-10-05  8:13 ` Burakov, Anatoly
2018-10-11  9:40   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8461EA4DF@HASMSX105.ger.corp.intel.com \
    --to=dariusz.stojaczyk@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=pawelx.wodkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).