From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5DF061DB8 for ; Fri, 29 Mar 2019 06:22:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 22:22:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,283,1549958400"; d="scan'208";a="144839681" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2019 22:22:57 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 22:22:57 -0700 Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 22:22:56 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.16]) by hasmsx108.ger.corp.intel.com ([169.254.9.237]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 08:22:54 +0300 From: "Stojaczyk, Dariusz" To: Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas Thread-Index: AQHUzfah5qMJ9/bDl0OWlLn4rA+FaqYhkKMAgACyImA= Date: Fri, 29 Mar 2019 05:22:54 +0000 Message-ID: References: <1848003.AzJ49HI9Wz@xps> In-Reply-To: <1848003.AzJ49HI9Wz@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.249.45.155] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 05:22:59 -0000 This patch caused a regression. Any secondary process fails to initialize. Please see the quick fix here: http://patchwork.dpdk.org/patch/51882/ D. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, March 28, 2019 9:45 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped ar= eas >=20 > 26/02/2019 18:13, Anatoly Burakov: > > Currently, there are numerous reliability issues with fbarray, > > such as: > > - There is no way to prevent attaching to overlapping memory > > areas > > - There is no way to prevent double-detach > > - Failed destroy leaves fbarray in an invalid state (fbarray > > itself is valid, but its backing memory area is already > > detached) > > > > In addition, on FreeBSD, doing mmap() on a file descriptor > > does not keep the lock, so we also need to store the fd > > in order to keep the lock. > > > > This patch improves upon fbarray to address both of these > > issues by adding an internal tailq to track allocated areas > > and their respective file descriptors. > > > > Signed-off-by: Anatoly Burakov >=20 > Applied, thanks >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C7757A0679 for ; Fri, 29 Mar 2019 06:23:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA5442965; Fri, 29 Mar 2019 06:23:00 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5DF061DB8 for ; Fri, 29 Mar 2019 06:22:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 22:22:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,283,1549958400"; d="scan'208";a="144839681" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2019 22:22:57 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 22:22:57 -0700 Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 22:22:56 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.16]) by hasmsx108.ger.corp.intel.com ([169.254.9.237]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 08:22:54 +0300 From: "Stojaczyk, Dariusz" To: Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas Thread-Index: AQHUzfah5qMJ9/bDl0OWlLn4rA+FaqYhkKMAgACyImA= Date: Fri, 29 Mar 2019 05:22:54 +0000 Message-ID: References: <1848003.AzJ49HI9Wz@xps> In-Reply-To: <1848003.AzJ49HI9Wz@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.249.45.155] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329052254.miEhVxKF_iaEsrTFr7defSmPV49UXqZQw52QzUGaKAI@z> This patch caused a regression. Any secondary process fails to initialize. Please see the quick fix here: http://patchwork.dpdk.org/patch/51882/ D. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, March 28, 2019 9:45 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped ar= eas >=20 > 26/02/2019 18:13, Anatoly Burakov: > > Currently, there are numerous reliability issues with fbarray, > > such as: > > - There is no way to prevent attaching to overlapping memory > > areas > > - There is no way to prevent double-detach > > - Failed destroy leaves fbarray in an invalid state (fbarray > > itself is valid, but its backing memory area is already > > detached) > > > > In addition, on FreeBSD, doing mmap() on a file descriptor > > does not keep the lock, so we also need to store the fd > > in order to keep the lock. > > > > This patch improves upon fbarray to address both of these > > issues by adding an internal tailq to track allocated areas > > and their respective file descriptors. > > > > Signed-off-by: Anatoly Burakov >=20 > Applied, thanks >=20 >=20