From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 145DC7CAB for ; Tue, 22 Aug 2017 11:55:24 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2017 02:55:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,411,1498546800"; d="scan'208";a="143138184" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 22 Aug 2017 02:55:23 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 Aug 2017 02:55:23 -0700 Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 Aug 2017 02:55:23 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.165]) by LCSMSX154.ger.corp.intel.com ([169.254.7.22]) with mapi id 14.03.0319.002; Tue, 22 Aug 2017 12:55:20 +0300 From: "Stojaczyk, DariuszX" To: Jens Freimann CC: "dev@dpdk.org" , "Wodkowski, PawelX" , "Maxime Coquelin (mcoqueli)" , "yliu@fridaylinux.org" Thread-Topic: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close Thread-Index: AQHTGkKZNekXt2DT80qswFet9ekRsaKOtaoAgAFQZaA= Date: Tue, 22 Aug 2017 09:55:19 +0000 Message-ID: References: <1503308082-17926-1-git-send-email-dariuszx.stojaczyk@intel.com> <20170821150034.sevaefe57m3pnlpd@localhost.localdomain> In-Reply-To: <20170821150034.sevaefe57m3pnlpd@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.103.102.79] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 09:55:25 -0000 Hi Jens, > I'm a little uncertain but my gut feeling is that in this context a conne= ction is > something between two sockets, not between devices. What do you mean? This is a unix domain socket connection. DPDK can create the socket, then t= he client may connect to it via connect(2). > I would probably add > these callbacks to struct vhost_user_socket. This is also where we keep t= he > list of connections. I get your point. However, it's vhost_device_ops struct that's being set by= the user via rte_vhost_driver_callback_register(). The new_connection call= back is there just to mark the device as *in use, can't be deleted*. It doe= sn't transport any connection data. Regards, D.