From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C888A100F for ; Tue, 29 Aug 2017 08:08:51 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 28 Aug 2017 23:08:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,444,1498546800"; d="scan'208";a="145671108" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 28 Aug 2017 23:08:49 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 28 Aug 2017 23:08:49 -0700 Received: from HASMSX110.ger.corp.intel.com (10.184.198.28) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 28 Aug 2017 23:08:49 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.195]) by HASMSX110.ger.corp.intel.com ([169.254.6.210]) with mapi id 14.03.0319.002; Tue, 29 Aug 2017 09:08:46 +0300 From: "Stojaczyk, DariuszX" To: 'Jens Freimann' CC: "dev@dpdk.org" , "Wodkowski, PawelX" , "maxime.coquelin@redhat.com" , "yliu@fridaylinux.org" Thread-Topic: [dpdk-dev] [PATCH v2] vhost: added user callbacks for socket open/close Thread-Index: AQHTG0U/s7iGrCv390WWJCzYFCiNjqKUnnCAgAB8ZgA= Date: Tue, 29 Aug 2017 06:08:45 +0000 Message-ID: References: <1503308082-17926-1-git-send-email-dariuszx.stojaczyk@intel.com> <1503419092-63814-1-git-send-email-dariuszx.stojaczyk@intel.com> <20170825092213.ce66eb2w56ui3iy2@localhost.localdomain> In-Reply-To: <20170825092213.ce66eb2w56ui3iy2@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.103.102.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] vhost: added user callbacks for socket open/close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 06:08:52 -0000 Hi Jens, > I'm still not sure I understand the use case. So just for my > understanding: users need to distinct between "the device is going away > temporarily, keep the connection" and "we're shutting down for good", is > that it? Yes, exactly. > Maybe it's just me or maybe it means you could explain your example in th= e > commit message a bit more. Ok. How about the following commit message instead: ``` rte_vhost: added user callbacks for socket open/close Added new callbacks to notify about socket connection status. As destroy_device is used for virtqueue processing *pause* as well as connection close, the user has no distinction between those. Consider the following scenario: rte_vhost: received SET_VRING_BASE message, calling destroy_device() as usual user: end-user asks to remove the device (together with socket file), OK, device is not *in use* - that's NOT the behavior we want calling rte_vhost_driver_unregister() etc. Instead of changing new_device/destroy_device callbacks and breaking the ABI, a set of new functions new_connection/destroy_connection has been added. ``` > Oh, and you should put the maintainers on Cc to get a faster review. Thanks, I will! Regards, D.=20