* [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal
@ 2018-07-02 5:13 Matan Azrad
2018-07-02 18:58 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2018-07-02 5:13 UTC (permalink / raw)
To: Nelio Laranjeiro; +Cc: dev, Shahaf Shuler
Starting from rdma-core v19, Mellanox OFED 4.4, the Verbs resources
cleanup is properly activated in plug-out process while setting the
MLX5_DEVICE_FATAL_CLEANUP environment variable to 1.
Set the aforementioned variable to 1.
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index f0e6ed7..d081bdd 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1409,6 +1409,11 @@
/* Match the size of Rx completion entry to the size of a cacheline. */
if (RTE_CACHE_LINE_SIZE == 128)
setenv("MLX5_CQE_SIZE", "128", 0);
+ /*
+ * MLX5_DEVICE_FATAL_CLEANUP tells ibv_destroy functions to
+ * cleanup all the Verbs resources even when the device was removed.
+ */
+ setenv("MLX5_DEVICE_FATAL_CLEANUP", "1", 1);
#ifdef RTE_LIBRTE_MLX5_DLOPEN_DEPS
if (mlx5_glue_init())
return;
--
1.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal
2018-07-02 5:13 [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal Matan Azrad
@ 2018-07-02 18:58 ` Yongseok Koh
2018-07-03 12:36 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-07-02 18:58 UTC (permalink / raw)
To: Matan Azrad; +Cc: Nélio Laranjeiro, dev, Shahaf Shuler
> On Jul 1, 2018, at 10:13 PM, Matan Azrad <matan@mellanox.com> wrote:
>
> Starting from rdma-core v19, Mellanox OFED 4.4, the Verbs resources
> cleanup is properly activated in plug-out process while setting the
> MLX5_DEVICE_FATAL_CLEANUP environment variable to 1.
>
> Set the aforementioned variable to 1.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal
2018-07-02 18:58 ` Yongseok Koh
@ 2018-07-03 12:36 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-07-03 12:36 UTC (permalink / raw)
To: Yongseok Koh, Matan Azrad; +Cc: Nélio Laranjeiro, dev
Monday, July 2, 2018 9:58 PM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on
> removal
>
>
> > On Jul 1, 2018, at 10:13 PM, Matan Azrad <matan@mellanox.com> wrote:
> >
> > Starting from rdma-core v19, Mellanox OFED 4.4, the Verbs resources
> > cleanup is properly activated in plug-out process while setting the
> > MLX5_DEVICE_FATAL_CLEANUP environment variable to 1.
> >
> > Set the aforementioned variable to 1.
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-03 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-02 5:13 [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal Matan Azrad
2018-07-02 18:58 ` Yongseok Koh
2018-07-03 12:36 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).