DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] 18.11.3 (LTS) patches review and test
@ 2019-09-13 16:31 Kevin Traynor
  2019-09-19 10:22 ` Yu, PingX
                   ` (4 more replies)
  0 siblings, 5 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-09-13 16:31 UTC (permalink / raw)
  To: stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
	Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
	Thomas Monjalon, yuan.peng, zhaoyan.chen

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 9th October.

Please help with testing and validation of your use cases and report
any issues/results in reply to this mail. For the final release the
fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1

These patches are located at branch 18.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (5):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (26):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-13 16:31 [dpdk-dev] 18.11.3 (LTS) patches review and test Kevin Traynor
@ 2019-09-19 10:22 ` Yu, PingX
  2019-09-19 21:33   ` Ju-Hyoung Lee
  2019-09-25 16:06   ` Kevin Traynor
  2019-10-03 13:20 ` Kevin Traynor
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 30+ messages in thread
From: Yu, PingX @ 2019-09-19 10:22 UTC (permalink / raw)
  To: Kevin Traynor, stable, dev
  Cc: dev, Akhil Goyal, Ali Alnubani, Walker, Benjamin,
	David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
	Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu,
	Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen,
	Zhaoyan

Hi all,
Update Intel test result here.

# Basic Intel(R) NIC testing
* PF(i40e): Pass
* PF(ixgbe): Pass
* VF: Pass 
* Build or compile: 3 bugs are found.
  1. [dpdk-stable 18.11.3] compile error on freebsd12
  2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
  3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
* Intel NIC single core/NIC performance: Pass 

#Basic cryptodev and virtio testing
* vhost/virtio basic loopback, PVP and performance test: Pass.
* cryptodev: Pass

Regards,
Yu Ping

-----Original Message-----
From: Kevin Traynor [mailto:ktraynor@redhat.com] 
Sent: Saturday, September 14, 2019 12:31 AM
To: stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: 18.11.3 (LTS) patches review and test

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 9th October.

Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1

These patches are located at branch 18.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (5):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (26):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-19 10:22 ` Yu, PingX
@ 2019-09-19 21:33   ` Ju-Hyoung Lee
  2019-09-19 22:44     ` Abhishek Marathe
  2019-09-25 16:06   ` Kevin Traynor
  1 sibling, 1 reply; 30+ messages in thread
From: Ju-Hyoung Lee @ 2019-09-19 21:33 UTC (permalink / raw)
  To: Yu, PingX, Kevin Traynor, stable, dev, Abhishek Marathe
  Cc: dev, Akhil Goyal, Ali Alnubani, Walker, Benjamin,
	David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
	Mcnamara, John, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan,
	Ju-Hyoung Lee

+ @Abhishek Marathe

-----Original Message-----
From: Yu, PingX <pingx.yu@intel.com> 
Sent: Thursday, September 19, 2019 3:22 AM
To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org; dev@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: RE: 18.11.3 (LTS) patches review and test

Hi all,
Update Intel test result here.

# Basic Intel(R) NIC testing
* PF(i40e): Pass
* PF(ixgbe): Pass
* VF: Pass 
* Build or compile: 3 bugs are found.
  1. [dpdk-stable 18.11.3] compile error on freebsd12
  2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
  3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
* Intel NIC single core/NIC performance: Pass 

#Basic cryptodev and virtio testing
* vhost/virtio basic loopback, PVP and performance test: Pass.
* cryptodev: Pass

Regards,
Yu Ping

-----Original Message-----
From: Kevin Traynor [mailto:ktraynor@redhat.com] 
Sent: Saturday, September 14, 2019 12:31 AM
To: stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: 18.11.3 (LTS) patches review and test

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 9th October.

Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc1&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C2251f86c3a534bd30e6008d73ceb4a82%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637044853583839323&amp;sdata=tN3TEjZOfh3rtGlux6wmTLi7C1JNYQ6np%2BId727mkDM%3D&amp;reserved=0

These patches are located at branch 18.11 of dpdk-stable repo:
    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C2251f86c3a534bd30e6008d73ceb4a82%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637044853583839323&amp;sdata=NIBwU2flw6i5Em8f%2BAx0RavZae18YJL4vxNIZvvVOWs%3D&amp;reserved=0

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (5):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (26):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-19 21:33   ` Ju-Hyoung Lee
@ 2019-09-19 22:44     ` Abhishek Marathe
  2019-09-23 16:18       ` Kevin Traynor
  0 siblings, 1 reply; 30+ messages in thread
From: Abhishek Marathe @ 2019-09-19 22:44 UTC (permalink / raw)
  To: Ju-Hyoung Lee, Yu, PingX, Kevin Traynor, stable, dev
  Cc: dev, Akhil Goyal, Ali Alnubani, Walker, Benjamin,
	David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
	Mcnamara, John, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

Hi All,

While testing 18.11.3-rc1 on Azure we faced following problems:

1.  VERIFY-DPDK-OVS - This test case builds OVS (OpenVSwitch) with DPDK support on Ubuntu distro (16.04 and 18.04) and tests if the OVS DPDK ports can be created. This testcase aborted, after diagnosis we found out that installation is failing because of "netdev-dpdk: Prefix network structures with rte_" commit. After reverting this commit on OVS, we are able to install OVS with DPDK 18.11.3.
2. Performance test cases failed due to lower performance than the defined threshold. We are investigating it further.


Test Result:

DPDK v18.11.3-rc1 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
Tested with Mellanox and netvsc poll-mode drivers.
The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C91a2f95c8337446a4f2a08d739007bc2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637040546547039086&amp;sdata=HB%2BueAAyo0qcb0MhhDUAM4iwIuNUzE93AflS4jiV2Eg%3D&amp;reserved=0).

Test case description:

* VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd

* PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2

* DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C91a2f95c8337446a4f2a08d739007bc2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637040546547039086&amp;sdata=PmXonFCMzcETh6oxpx%2BupQB9QnbLKOtJigbmw6GMxf0%3D&amp;reserved=0
* VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20

* VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
* VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
* VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.

 DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F231%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C91a2f95c8337446a4f2a08d739007bc2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637040546547039086&amp;sdata=a2u68igGIM874ejz%2BXOIHGBSTGjD7Mmq0l60goHwTGI%3D&amp;reserved=0. 

Test results for DPDK 'v18.11.3-rc1' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
* VERIFY-DPDK-OVS: ABORTED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: FAILED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
* PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc1' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
* VERIFY-DPDK-OVS: ABORTED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: FAILED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
* PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
* VERIFY-DPDK-COMPLIANCE: ABORTED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc1' and Azure image: 'RedHat RHEL 7-RAW latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: PASSED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc1' and Azure image: 'RedHat RHEL 7.5 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: PASSED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc1' and Azure image: 'Openlogic CentOS 7.5 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc1' and Azure image: 'SUSE SLES 15 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: ABORTED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: PASSED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED
-----Original Message-----
From: Ju-Hyoung Lee <juhlee@microsoft.com> 
Sent: Thursday, September 19, 2019 2:33 PM
To: Yu, PingX <pingx.yu@intel.com>; Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org; dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>
Subject: RE: 18.11.3 (LTS) patches review and test

+ @Abhishek Marathe

-----Original Message-----
From: Yu, PingX <pingx.yu@intel.com> 
Sent: Thursday, September 19, 2019 3:22 AM
To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org; dev@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: RE: 18.11.3 (LTS) patches review and test

Hi all,
Update Intel test result here.

# Basic Intel(R) NIC testing
* PF(i40e): Pass
* PF(ixgbe): Pass
* VF: Pass 
* Build or compile: 3 bugs are found.
  1. [dpdk-stable 18.11.3] compile error on freebsd12
  2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
  3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
* Intel NIC single core/NIC performance: Pass 

#Basic cryptodev and virtio testing
* vhost/virtio basic loopback, PVP and performance test: Pass.
* cryptodev: Pass

Regards,
Yu Ping

-----Original Message-----
From: Kevin Traynor [mailto:ktraynor@redhat.com] 
Sent: Saturday, September 14, 2019 12:31 AM
To: stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: 18.11.3 (LTS) patches review and test

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 9th October.

Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc1&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C92b9c96d0d044960e02008d73d48f3f8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637045255847268106&amp;sdata=1y%2BaFOyGTV8t5c4QgT0VQr32vgCrSUkPcClEPzJ1rkg%3D&amp;reserved=0

These patches are located at branch 18.11 of dpdk-stable repo:
    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C92b9c96d0d044960e02008d73d48f3f8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637045255847268106&amp;sdata=KZ51%2FO1ETmNL6%2FgWZ1ncnOb5wh1NGiJtUl9rWxKOqVw%3D&amp;reserved=0

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (5):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (26):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

Regards,
Abhishek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-19 22:44     ` Abhishek Marathe
@ 2019-09-23 16:18       ` Kevin Traynor
  0 siblings, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-09-23 16:18 UTC (permalink / raw)
  To: Abhishek Marathe, Ju-Hyoung Lee, Yu, PingX, stable, dev
  Cc: Akhil Goyal, Ali Alnubani, Walker, Benjamin, David Christensen,
	Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
	Luca Boccassi, Pei Zhang, Xu, Qian Q, Raslan Darawsheh,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

On 19/09/2019 23:44, Abhishek Marathe wrote:
> Hi All,
> 

Hi Abhishek, thanks for testing, some comments below.

> While testing 18.11.3-rc1 on Azure we faced following problems:
> 
> 1.  VERIFY-DPDK-OVS - This test case builds OVS (OpenVSwitch) with DPDK support on Ubuntu distro (16.04 and 18.04) and tests if the OVS DPDK ports can be created. This testcase aborted, after diagnosis we found out that installation is failing because of "netdev-dpdk: Prefix network structures with rte_" commit. After reverting this commit on OVS, we are able to install OVS with DPDK 18.11.3.

Right, that commit is on a branch that is not intended to work with DPDK
18.11.X and the commit updates OVS code to align with changes made in
DPDK master since 18.11, so it makes sense that it would fail to build.
IOW, since it is not a valid OVS/DPDK combination, this is not a genuine
failure.

Sorry the names are a bit confusing when you write them all in one place
but the following are the intended working combinations:
- OVS branch dpdk-latest is a development branch that is intended to
work with the dpdk.org branch master (head)
- OVS branch master is intended to work with DPDK 18.11.2 and DPDK
18.11.3 when it is released
- OVS 2.11/2.12 should also work with DPDK 18.11.2 and DPDK 18.11.3 when
it is released

So you would need to switch to using one of OVS branches
master/branch-2.11/branch-2.12 for your testing with DPDK 18.11.3-rc1.

> 2. Performance test cases failed due to lower performance than the defined threshold. We are investigating it further.
> 

Ok, thanks. Seems it is not consistent across distros, so perhaps it's
something distro specific, or else a borderline failure that sometimes
triggers.

thanks,
Kevin.

> 
> Test Result:
> 
> DPDK v18.11.3-rc1 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
> Tested with Mellanox and netvsc poll-mode drivers.
> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C91a2f95c8337446a4f2a08d739007bc2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637040546547039086&amp;sdata=HB%2BueAAyo0qcb0MhhDUAM4iwIuNUzE93AflS4jiV2Eg%3D&amp;reserved=0).
> 
> Test case description:
> 
> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd
> 
> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
> 
> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C91a2f95c8337446a4f2a08d739007bc2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637040546547039086&amp;sdata=PmXonFCMzcETh6oxpx%2BupQB9QnbLKOtJigbmw6GMxf0%3D&amp;reserved=0
> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
> 
> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
> 
>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F231%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C91a2f95c8337446a4f2a08d739007bc2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637040546547039086&amp;sdata=a2u68igGIM874ejz%2BXOIHGBSTGjD7Mmq0l60goHwTGI%3D&amp;reserved=0. 
> 
> Test results for DPDK 'v18.11.3-rc1' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: ABORTED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: FAILED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc1' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: ABORTED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: FAILED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
> * VERIFY-DPDK-COMPLIANCE: ABORTED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc1' and Azure image: 'RedHat RHEL 7-RAW latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: PASSED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc1' and Azure image: 'RedHat RHEL 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: PASSED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc1' and Azure image: 'Openlogic CentOS 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc1' and Azure image: 'SUSE SLES 15 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: ABORTED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: PASSED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED
> -----Original Message-----
> From: Ju-Hyoung Lee <juhlee@microsoft.com> 
> Sent: Thursday, September 19, 2019 2:33 PM
> To: Yu, PingX <pingx.yu@intel.com>; Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org; dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>
> Subject: RE: 18.11.3 (LTS) patches review and test
> 
> + @Abhishek Marathe
> 
> -----Original Message-----
> From: Yu, PingX <pingx.yu@intel.com> 
> Sent: Thursday, September 19, 2019 3:22 AM
> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org; dev@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: RE: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> Update Intel test result here.
> 
> # Basic Intel(R) NIC testing
> * PF(i40e): Pass
> * PF(ixgbe): Pass
> * VF: Pass 
> * Build or compile: 3 bugs are found.
>   1. [dpdk-stable 18.11.3] compile error on freebsd12
>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
> * Intel NIC single core/NIC performance: Pass 
> 
> #Basic cryptodev and virtio testing
> * vhost/virtio basic loopback, PVP and performance test: Pass.
> * cryptodev: Pass
> 
> Regards,
> Yu Ping
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com] 
> Sent: Saturday, September 14, 2019 12:31 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc1&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C92b9c96d0d044960e02008d73d48f3f8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637045255847268106&amp;sdata=1y%2BaFOyGTV8t5c4QgT0VQr32vgCrSUkPcClEPzJ1rkg%3D&amp;reserved=0
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C92b9c96d0d044960e02008d73d48f3f8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637045255847268106&amp;sdata=KZ51%2FO1ETmNL6%2FgWZ1ncnOb5wh1NGiJtUl9rWxKOqVw%3D&amp;reserved=0
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
> 
> Regards,
> Abhishek
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-19 10:22 ` Yu, PingX
  2019-09-19 21:33   ` Ju-Hyoung Lee
@ 2019-09-25 16:06   ` Kevin Traynor
  2019-09-26  7:41     ` Yu, PingX
  1 sibling, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-09-25 16:06 UTC (permalink / raw)
  To: Yu, PingX, stable, dev
  Cc: Akhil Goyal, Ali Alnubani, Walker, Benjamin, David Christensen,
	Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

On 19/09/2019 11:22, Yu, PingX wrote:
> Hi all,
> Update Intel test result here.
> 

Hi Yu Ping,

Thanks for testing. Some comments/questions on the failures,

> # Basic Intel(R) NIC testing
> * PF(i40e): Pass
> * PF(ixgbe): Pass
> * VF: Pass 
> * Build or compile: 3 bugs are found.
>   1. [dpdk-stable 18.11.3] compile error on freebsd12

ok, I've figured this out and will send a patch.

>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86

What are the error logs? Is it a regression for you? i.e. did this test
pass with 18.11.2?

>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10

Windows support was not added until DPDK 19.05.

thanks,
Kevin.

> * Intel NIC single core/NIC performance: Pass 
> 
> #Basic cryptodev and virtio testing
> * vhost/virtio basic loopback, PVP and performance test: Pass.
> * cryptodev: Pass
> 
> Regards,
> Yu Ping
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com] 
> Sent: Saturday, September 14, 2019 12:31 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
> 




^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-25 16:06   ` Kevin Traynor
@ 2019-09-26  7:41     ` Yu, PingX
  2019-10-03 13:30       ` Kevin Traynor
  0 siblings, 1 reply; 30+ messages in thread
From: Yu, PingX @ 2019-09-26  7:41 UTC (permalink / raw)
  To: Kevin Traynor, stable, dev
  Cc: Akhil Goyal, Ali Alnubani, Walker, Benjamin, David Christensen,
	Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

Kevin,
FYi.
>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
Q1: What are the error logs? 
Please see below Error info.

Q2: Is it a regression for you? i.e. did this test pass with 18.11.2?
No, it isn't a regression. We don't test it on 18.11.1 and 18.11.2 before, another the test result is still failed after testing. 
dpdk-stable V18.11.2 commitID(06c4b12a5968caea61e96f7d6bd29d2726fbe255),test failed. 
dpdk-stable V18.11.1 commitID(16ece46735c9b70b7033ca7ae095930e9038d9fd),test failed, the same mistake.

Error info:
ninja: Entering directory `build-gcc-static'
[296/1419] Compiling C object 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o'.
FAILED: drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o
gcc -Idrivers/a715181@@tmp_rte_common_dpaax@sta -Idrivers -I../drivers -Idrivers/common/dpaax -I../drivers/common/dpaax -I. -I../ -Iconfig -I../config -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/linuxapp/eal/include -Ilib/librte_eal/linuxapp/eal/../../../librte_compat -I../lib/librte_eal/linuxapp/eal/../../../librte_compat -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs/../librte_eal/common/include -I../lib/librte_kvargs/../librte_eal/common/include -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_compat -I../lib/librte_compat -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -fPIC -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o' -MF 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o.d' -o 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o' -c ../drivers/common/dpaax/dpaax_iova_table.c
In file included from ../drivers/common/dpaax/dpaax_iova_table.c:8:0:
../drivers/common/dpaax/dpaax_iova_table.c: In function ‘read_memory_node’:
../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
  rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
                                       ^
../drivers/common/dpaax/dpaax_iova_table.c:102:2: note: in expansion of macro ‘DPAAX_DEBUG’
  DPAAX_DEBUG("Size of device-tree mem node: %lu", statbuf.st_size);
  ^
../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
  rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
                                       ^
../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of macro ‘DPAAX_DEBUG’
   DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
   ^
cc1: all warnings being treated as errors [301/1419] Compiling C object 'lib/76b5a35@@rte_pipeline@sta/librte_pipeline_rte_table_action.c.o'.
ninja: build stopped: subcommand failed.

>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10

Windows support was not added until DPDK 19.05.

[Ping]Got it. Confirm with the test result of 18.11, we don't test meson.build on WIN10. Tks for your information.

Regards,
Yu Ping


-----Original Message-----
From: Kevin Traynor [mailto:ktraynor@redhat.com] 
Sent: Thursday, September 26, 2019 12:07 AM
To: Yu, PingX <pingx.yu@intel.com>; stable@dpdk.org; dev@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: 18.11.3 (LTS) patches review and test

On 19/09/2019 11:22, Yu, PingX wrote:
> Hi all,
> Update Intel test result here.
> 

Hi Yu Ping,

Thanks for testing. Some comments/questions on the failures,

> # Basic Intel(R) NIC testing
> * PF(i40e): Pass
> * PF(ixgbe): Pass
> * VF: Pass
> * Build or compile: 3 bugs are found.
>   1. [dpdk-stable 18.11.3] compile error on freebsd12

ok, I've figured this out and will send a patch.

>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86

What are the error logs? Is it a regression for you? i.e. did this test pass with 18.11.2?

>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10

Windows support was not added until DPDK 19.05.

thanks,
Kevin.

> * Intel NIC single core/NIC performance: Pass
> 
> #Basic cryptodev and virtio testing
> * vhost/virtio basic loopback, PVP and performance test: Pass.
> * cryptodev: Pass
> 
> Regards,
> Yu Ping
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Saturday, September 14, 2019 12:31 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; 
> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal 
> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin 
> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; 
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor 
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q 
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas 
> Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; 
> Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
> 




^ permalink raw reply	[flat|nested] 30+ messages in thread

* [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-13 16:31 [dpdk-dev] 18.11.3 (LTS) patches review and test Kevin Traynor
  2019-09-19 10:22 ` Yu, PingX
@ 2019-10-03 13:20 ` Kevin Traynor
       [not found]   ` <MWHPR21MB083248DEF72934F9291C128B9E970@MWHPR21MB0832.namprd21.prod.outlook.com>
  2019-10-04  2:28 ` [dpdk-dev] " Pei Zhang
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-10-03 13:20 UTC (permalink / raw)
  To: stable
  Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
	benjamin.walker, David Christensen, Hemant Agrawal, Ian Stokes,
	Jerin Jacob, John McNamara, Ju-Hyoung Lee, Kevin Traynor,
	Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
	Thomas Monjalon, yuan.peng, zhaoyan.chen

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 14th October.

Please note the commits since RC1 below. They are primarily to
address some build issues for 32-bit with meson and FreeBSD.
As such, I would expect that most RC1 testing is still valid
and does not need to be repeated.

Please help with testing and validation of your use cases and report
any issues/results in reply to this mail. For the final release the
fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc2

These patches are located at branch 18.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Commits since RC1:
9e7c637c6 build: add libatomic dependency for 32-bit clang
6c576d41c mem: mark unused function in 32-bit builds
7ffe32a15 build: remove unnecessary large file support defines
5c3c20a8a build: enable large file support on 32-bit
5633216d4 net/nfp: disable for 32-bit meson builds
c97d4cd35 build: set RTE_ARCH_64 based on pointer size
86e56d5f9 ethdev: fix endian annotation for SPI item
d908ee9de build: enable BSD features visibility for FreeBSD

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (11):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson
      build: set RTE_ARCH_64 based on pointer size
      net/nfp: disable for 32-bit meson builds
      build: enable large file support on 32-bit
      build: remove unnecessary large file support defines
      mem: mark unused function in 32-bit builds
      build: add libatomic dependency for 32-bit clang

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (27):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx
      ethdev: fix endian annotation for SPI item

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Kevin Traynor (1):
      version: 18.11.3-rc1

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Smoczynski (1):
      build: enable BSD features visibility for FreeBSD

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-26  7:41     ` Yu, PingX
@ 2019-10-03 13:30       ` Kevin Traynor
  2019-10-08 10:22         ` Yu, PingX
  0 siblings, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-10-03 13:30 UTC (permalink / raw)
  To: Yu, PingX, stable, dev
  Cc: Akhil Goyal, Ali Alnubani, Walker, Benjamin, David Christensen,
	Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

On 26/09/2019 08:41, Yu, PingX wrote:
> Kevin,
> FYi.
>>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
> Q1: What are the error logs? 
> Please see below Error info.
> 
> Q2: Is it a regression for you? i.e. did this test pass with 18.11.2?
> No, it isn't a regression. We don't test it on 18.11.1 and 18.11.2 before, another the test result is still failed after testing. 
> dpdk-stable V18.11.2 commitID(06c4b12a5968caea61e96f7d6bd29d2726fbe255),test failed. 
> dpdk-stable V18.11.1 commitID(16ece46735c9b70b7033ca7ae095930e9038d9fd),test failed, the same mistake.
> 
> Error info:
> ninja: Entering directory `build-gcc-static'
> [296/1419] Compiling C object 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o'.
> FAILED: drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o
> gcc -Idrivers/a715181@@tmp_rte_common_dpaax@sta -Idrivers -I../drivers -Idrivers/common/dpaax -I../drivers/common/dpaax -I. -I../ -Iconfig -I../config -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/linuxapp/eal/include -Ilib/librte_eal/linuxapp/eal/../../../librte_compat -I../lib/librte_eal/linuxapp/eal/../../../librte_compat -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs/../librte_eal/common/include -I../lib/librte_kvargs/../librte_eal/common/include -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_compat -I../lib/librte_compat -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -fPIC -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o' -MF 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o.d' -o 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o' -c ../drivers/common/dpaax/dpaax_iova_table.c
> In file included from ../drivers/common/dpaax/dpaax_iova_table.c:8:0:
> ../drivers/common/dpaax/dpaax_iova_table.c: In function ‘read_memory_node’:
> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>                                        ^
> ../drivers/common/dpaax/dpaax_iova_table.c:102:2: note: in expansion of macro ‘DPAAX_DEBUG’
>   DPAAX_DEBUG("Size of device-tree mem node: %lu", statbuf.st_size);
>   ^
> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>                                        ^
> ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of macro ‘DPAAX_DEBUG’
>    DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
>    ^
> cc1: all warnings being treated as errors [301/1419] Compiling C object 'lib/76b5a35@@rte_pipeline@sta/librte_pipeline_rte_table_action.c.o'.
> ninja: build stopped: subcommand failed.
> 

Thanks Yu Ping, I reproduced and applied the commits to fix this. It
should be fixed now in RC2 (see other mail). If you could re-run this
test to confirm same for you, that would be great.

Kevin.

>>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
> 
> Windows support was not added until DPDK 19.05.
> 
> [Ping]Got it. Confirm with the test result of 18.11, we don't test meson.build on WIN10. Tks for your information.
> 
> Regards,
> Yu Ping
> 
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com] 
> Sent: Thursday, September 26, 2019 12:07 AM
> To: Yu, PingX <pingx.yu@intel.com>; stable@dpdk.org; dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.3 (LTS) patches review and test
> 
> On 19/09/2019 11:22, Yu, PingX wrote:
>> Hi all,
>> Update Intel test result here.
>>
> 
> Hi Yu Ping,
> 
> Thanks for testing. Some comments/questions on the failures,
> 
>> # Basic Intel(R) NIC testing
>> * PF(i40e): Pass
>> * PF(ixgbe): Pass
>> * VF: Pass
>> * Build or compile: 3 bugs are found.
>>   1. [dpdk-stable 18.11.3] compile error on freebsd12
> 
> ok, I've figured this out and will send a patch.
> 
>>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
> 
> What are the error logs? Is it a regression for you? i.e. did this test pass with 18.11.2?
> 
>>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
> 
> Windows support was not added until DPDK 19.05.
> 
> thanks,
> Kevin.
> 
>> * Intel NIC single core/NIC performance: Pass
>>
>> #Basic cryptodev and virtio testing
>> * vhost/virtio basic loopback, PVP and performance test: Pass.
>> * cryptodev: Pass
>>
>> Regards,
>> Yu Ping
>>
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>> Sent: Saturday, September 14, 2019 12:31 AM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; 
>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal 
>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin 
>> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; 
>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor 
>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q 
>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas 
>> Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; 
>> Chen, Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: 18.11.3 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.3. 
>>
>> The planned date for the final release is 9th October.
>>
>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin Traynor
>>
>> ---
>> Aaron Conole (2):
>>       test/flow_classify: fix undefined behavior
>>       acl: fix undefined behavior of bit shifts
>>
>> Adam Dybkowski (1):
>>       compress/zlib: fix error handling
>>
>> Aideen McLoughlin (1):
>>       net/pcap: fix possible mbuf double freeing
>>
>> Ajit Khaparde (6):
>>       net/bnxt: fix TSO
>>       net/bnxt: check for error conditions in Tx path
>>       net/bnxt: fix RSS RETA indirection table ops
>>       net/bnxt: save the number of EM flow count
>>       net/bnxt: fix compiler warning
>>       net/bnxt: remove unnecessary interrupt disable
>>
>> Akash Saxena (1):
>>       crypto/openssl: remove useless check before freeing
>>
>> Ali Alnubani (3):
>>       examples/ip_fragmentation: fix Tx queues init
>>       net/mlx5: fix 32-bit build
>>       doc: fix link about bifurcated model in Linux guide
>>
>> Amit Gupta (2):
>>       net/thunderx: fix crash on detach
>>       app/testpmd: fix latency stats deinit on signal
>>
>> Anatoly Burakov (4):
>>       eal/freebsd: fix init completion
>>       eal/freebsd: fix config creation
>>       vfio: use contiguous mapping for IOVA as VA mode
>>       test: enable installing app with meson
>>
>> Andrew Lee (1):
>>       net/sfc/base: fix signed/unsigned mismatch
>>
>> Andrew Rybchenko (16):
>>       ethdev: fix Tx prepare documentation to use positive errno
>>       net/atlantic: fix Tx prepare to set positive rte_errno
>>       net/e1000: fix Tx prepare to set positive rte_errno
>>       net/enic: fix Tx prepare to set positive rte_errno
>>       net/fm10k: fix Tx prepare to set positive rte_errno
>>       net/i40e: fix Tx prepare to set positive rte_errno
>>       net/iavf: fix Tx prepare to set positive rte_errno
>>       net/ixgbe: fix Tx prepare to set positive rte_errno
>>       net/qede: fix Tx prepare to set positive rte_errno
>>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>>       ethdev: avoid error on PCI unplug of closed port
>>       net/sfc: ensure that device is closed on removal
>>       ethdev: avoid getting uninitialized info for bad port
>>       net/sfc: fix power of 2 round up when align has smaller type
>>       net/sfc: fix align to power of 2 when align has smaller type
>>       net/sfc: unify power of 2 alignment check macro
>>
>> Andrius Sirvys (2):
>>       usertools: replace unsafe input function
>>       usertools: fix input handling in telemetry script
>>
>> Andy Pei (1):
>>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
>>
>> Ankur Dwivedi (1):
>>       app/crypto-perf: fix CSV format
>>
>> Arek Kusztal (2):
>>       crypto/openssl: fix usage of non constant time memcmp
>>       crypto/openssl: fix free of asymmetric crypto keys
>>
>> Asaf Penso (2):
>>       net/mlx5: fix condition for link update fallback
>>       net/mlx5: check memory allocation in flow creation
>>
>> Bao-Long Tran (2):
>>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>>       doc: remove useless Rx configuration in l2fwd guide
>>
>> Bernard Iremonger (1):
>>       flow_classify: fix out-of-bounds access
>>
>> Bruce Richardson (5):
>>       examples: fix make clean when using pkg-config
>>       kernel/freebsd: fix module build on latest head
>>       test: add rawdev autotest to meson
>>       examples: fix pkg-config detection with older make
>>       doc: fix build with latest meson
>>
>> Chenbo Xia (1):
>>       crypto/virtio: check PCI config read
>>
>> Congwen Zhang (1):
>>       net/ixgbe/base: fix product version check
>>
>> David Harton (1):
>>       net/ena: fix admin CQ polling for 32-bit
>>
>> David Hunt (2):
>>       examples/power: fix FreeBSD meson lib dependency
>>       examples/power: fix strcpy buffer overrun
>>
>> David Marchand (26):
>>       net/cxgbe: do not dereference global config struct
>>       examples/multi_process: do not dereference global config struct
>>       examples/qos_sched: do not dereference global config struct
>>       test/hash: use existing lcore API
>>       examples/multi_process: fix FreeBSD build
>>       net/virtio: remove useless check on mempool
>>       net/i40e: fix dropped packets statistics name
>>       examples/vdpa: remove trace of legacy linuxapp
>>       test/hash: fix off-by-one check on core count
>>       eal: hide internal hotplug function
>>       vfio: remove incorrect experimental tag
>>       mem: remove incorrect experimental tag on static symbol
>>       telemetry: add missing header include
>>       net/bnx2x: fix invalid free on unplug
>>       drivers/net: fix double free on init failure
>>       mem: fix typo in API description
>>       kni: abort when IOVA is not PA
>>       net/pcap: fix Rx with small buffers
>>       net/pcap: fix Tx return count in error conditions
>>       app/testpmd: fix eth packet dump for small buffers
>>       app/testpmd: rename ambiguous VF config variable
>>       eal: fix control thread affinity with --lcores
>>       test: remove link to ixgbe/i40e with meson
>>       eal: hide internal function
>>       bus/pci: remove unused x86 Linux constant
>>       net/pcap: fix concurrent multiseg Tx
>>
>> Dekel Peled (8):
>>       net/mlx5: fix missing validation of null pointer
>>       net/mlx5: fix description of return value
>>       net/mlx5: fix memory free on queue create error
>>       net/mlx5: fix order of items in NEON scatter
>>       doc: fix ethernet addresses in flow API guide
>>       net/mlx5: fix typos in comments
>>       net/mlx5: remove redundant item from union
>>       net/mlx5: fix validation of VLAN PCP item
>>
>> Dharmik Thakkar (1):
>>       test/hash: rectify slave id to point to valid cores
>>
>> Dilshod Urazov (7):
>>       net/virtio: add Tx preparation
>>       net/virtio: move VLAN tag insertion to Tx prepare
>>       examples/ipsec-secgw: fix error sign
>>       eventdev: fix error sign
>>       event/sw: fix error sign
>>       event/opdl: fix error sign
>>       net: adjust L2 length on soft VLAN insertion
>>
>> Ed Czeck (1):
>>       net/ark: fix queue packet replacement
>>
>> Erik Gabriel Carrillo (1):
>>       examples/performance-thread: init timer subsystem
>>
>> Fan Zhang (3):
>>       examples/vhost_crypto: remove unused function
>>       vhost/crypto: fix logically dead code
>>       vhost/crypto: fix inferred misuse of enum
>>
>> Ferruh Yigit (5):
>>       telemetry: fix build
>>       kni: fix segmented mbuf data overflow
>>       cryptodev: fix typo in comment
>>       security: remove duplicated symbols from map file
>>       igb_uio: fix build on Linux 5.3 for fall through
>>
>> Fiona Trahe (1):
>>       doc: clarify data plane error handling in compressdev
>>
>> Flavia Musatescu (1):
>>       telemetry: fix build warnings seen when using gcc 9
>>
>> Gagandeep Singh (1):
>>       eal: increase maximum different hugepage sizes on Arm
>>
>> Gage Eads (1):
>>       doc: add a note for multi-process in mempool guide
>>
>> Gautam Dawar (1):
>>       net/sfc/base: enable chained multicast on all EF10 cards
>>
>> Gosia Bakota (1):
>>       crypto/qat: set message field to zero in sym SGL case
>>
>> Haiyue Wang (3):
>>       net/ixgbevf: add full link status check option
>>       app/testpmd: fix parsing RSS queue rule
>>       examples/tep_term: remove duplicate definitions
>>
>> Hariprasad Govindharajan (1):
>>       examples/l3fwd: fix unaligned memory access on x86
>>
>> Harman Kalra (3):
>>       test/distributor: fix flush with worker shutdown
>>       distributor: fix check of workers number
>>       examples/ptpclient: fix delay request message
>>
>> Hemant Agrawal (5):
>>       crypto/dpaa2_sec: fix handling of session init failure
>>       net/dpaa: check multi-segment external buffers
>>       net/dpaa: fix build with 0 headroom
>>       bus/fslmc: fix build with 0 headroom
>>       net/virtio: fix build with 0 headroom
>>
>> Herakliusz Lipiec (3):
>>       test: fix autotest crash
>>       mk: fix custom kernel directory name
>>       net/i40e: fix MAC removal check
>>
>> Honnappa Nagarahalli (2):
>>       test/hash: fix data reset on new run
>>       hash: use ordered loads only if signature matches
>>
>> Igor Ryzhov (1):
>>       kernel/linux: fix modules install path
>>
>> Ilya Maximets (1):
>>       eal: fix positive error codes from probe/remove
>>
>> Ivan Malov (2):
>>       net: fix encapsulation markers for inner L3 offset
>>       net: fix how L4 checksum choice is tested
>>
>> Jananee Parthasarathy (1):
>>       table: fix crash in LPM IPv6
>>
>> Jay Ding (1):
>>       net/bnxt: check invalid VNIC id for firmware
>>
>> Jerin Jacob (4):
>>       acl: fix build with some arm64 compiler
>>       eventdev: fix doxygen comment
>>       net/virtio: fix build
>>       devtools: fix building kernel component tags
>>
>> John Daley (2):
>>       net/enic: remove flow count action support
>>       net/enic: remove flow locks
>>
>> Joyce Kong (2):
>>       test/rwlock: benchmark on all available cores
>>       test/rwlock: amortize the cost of getting time
>>
>> Kalesh AP (15):
>>       net/bnxt: fix xstats
>>       net/bnxt: fix crash on probe failure
>>       net/bnxt: fix enabling/disabling interrupts
>>       net/bnxt: check invalid VNIC in cleanup path
>>       net/bnxt: fix error handling in port start
>>       net/bnxt: fix check of address mapping
>>       net/bnxt: fix adding MAC address
>>       net/bnxt: fix unconditional wait in link update
>>       net/bnxt: fix setting primary MAC address
>>       net/bnxt: fix device init error path
>>       net/bnxt: reset filters before registering interrupts
>>       net/bnxt: fix return values to standard error codes
>>       net/bnxt: fix lock release on getting NVM info
>>       net/bnxt: fix checking result of HWRM command
>>       net/bnxt: reduce verbosity of a message
>>
>> Konstantin Ananyev (6):
>>       bpf: fix pseudo calls for program loaded from ELF
>>       ip_frag: fix IPv6 fragment size calculation
>>       bpf: fix check array size
>>       bpf: fix validate for function return value
>>       examples/ip_frag: fix unknown ethernet type
>>       examples/bpf: fix build
>>
>> Krzysztof Kanas (1):
>>       eal: fix typo in comments
>>
>> Lance Richardson (6):
>>       net/bnxt: fix endianness in ring macros
>>       net/bnxt: fix ring type macro name
>>       net/bnxt: fix variable width in endian conversion
>>       net/bnxt: fix Tx hang after port stop/start
>>       net/bnxt: retry IRQ callback deregistration
>>       net/bnxt: fix getting statistics
>>
>> Liang Ma (1):
>>       distributor: fix livelock on flush
>>
>> Liron Himi (1):
>>       net/mvneta: fix ierror statistics
>>
>> Lu Qiuwen (1):
>>       net/fm10k: fix stats crash in multi-process
>>
>> Luo Gaoliang (1):
>>       kni: fix build on RHEL8
>>
>> Maciej Bielski (1):
>>       net/ena: fix L4 checksum Tx offload
>>
>> Marcin Zapolski (4):
>>       examples: fix use of ethdev internal device array
>>       examples/ipsec-secgw: fix use of ethdev internal struct
>>       examples/ip_frag: fix use of ethdev internal device array
>>       examples/ip_frag: fix stale content of ethdev info
>>
>> Mariusz Drost (2):
>>       net/ixgbe: fix IP type for crypto session
>>       examples/ipsec-secgw: fix inline modes
>>
>> Mark Spender (1):
>>       net/sfc/base: fix shift by more bits than field width
>>
>> Matan Azrad (1):
>>       net/mlx5: fix device arguments error detection
>>
>> Maxime Coquelin (1):
>>       net/virtio: fix in-order Rx with segmented packet
>>
>> Michael Santana (1):
>>       fix off-by-one errors in snprintf
>>
>> Michal Krawczyk (2):
>>       net/ena: fix assigning NUMA node to IO queue
>>       net/ena: fix Rx checksum errors statistics
>>
>> Mohsin Mazhar Shaikh (1):
>>       net/netvsc: fix xstats id
>>
>> Morten Brørup (1):
>>       net: fix definition of IPv6 traffic class mask
>>
>> Moti Haimovsky (1):
>>       net/mlx5: fix crash on null operation
>>
>> Naresh Kumar PBS (2):
>>       net/bnxt: fix interrupt vector initialization
>>       net/bnxt: fix icc build
>>
>> Nicolas Dichtel (1):
>>       mem: ease init in a docker container
>>
>> Nipun Gupta (2):
>>       event/dpaa2: fix timeout ticks
>>       net/dpaa2: fix multi-segment Tx
>>
>> Noa Ezra (1):
>>       vhost: fix missing include
>>
>> Pavan Nikhilesh (2):
>>       app/eventdev: fix order test port creation
>>       test/eventdev: fix producer core validity checks
>>
>> Peng Huang (1):
>>       net/i40e: fix RSS hash update for X722 VF
>>
>> Qi Zhang (5):
>>       net/i40e: fix Tx threshold setup
>>       net/ixgbe: fix Tx threshold setup
>>       net/i40e: fix unexpected skip FDIR setup
>>       net/avf: fix Rx bytes stats
>>       net/avf: fix endless loop
>>
>> Qingmin Liu (1):
>>       net/bnxt: fix RxQ count if ntuple filtering is disabled
>>
>> Rahul Gupta (2):
>>       net/bnxt: fix L4 checksum error indication in Rx
>>       net/bnxt: fix interrupt rearm logic
>>
>> Rasesh Mody (5):
>>       net/bnx2x: fix reading VF id
>>       net/bnx2x: fix link events polling for SRIOV
>>       net/bnx2x: fix fastpath SB allocation for SRIOV
>>       doc: add co-existence consideration for bnx2x
>>       doc: add co-existence consideration for qede
>>
>> Reshma Pattan (1):
>>       telemetry: fix memory leak
>>
>> Ruifeng Wang (1):
>>       doc: fix Linux guide for arm64 cross-compilation
>>
>> Saleh Alsouqi (2):
>>       net: define IPv4 IHL and VHL
>>       app/testpmd: fix MPLS IPv4 encapsulation fields
>>
>> Santoshkumar Karanappa Rastapur (1):
>>       net/bnxt: fix extended port counter statistics
>>
>> Shahed Shaikh (5):
>>       net/bnx2x: fix packet drop
>>       net/bnx2x: fix interrupt flood
>>       net/bnx2x: fix memory leak
>>       net/bnx2x: fix link state
>>       net/bnx2x: fix supported max Rx/Tx descriptor count
>>
>> Somnath Kotur (1):
>>       net/bnxt: check for null completion ring doorbell
>>
>> Sriharsha Basavapatna (2):
>>       net/bnxt: fix Tx batching
>>       net/bnxt: optimize Tx batching
>>
>> Stephen Hemminger (36):
>>       net/atlantic: remove unnecessary cast
>>       net/ark: remove unnecessary cast
>>       net/axgbe: remove unnecessary cast
>>       net/bnxt: remove unnecessary cast
>>       net/bonding: remove unnecessary cast
>>       net/cxgbe: remove unnecessary cast
>>       net/e1000: remove unnecessary cast
>>       net/ena: remove unnecessary cast
>>       net/enic: remove unnecessary cast
>>       net/i40e: remove unnecessary cast
>>       net/ixgbe: remove unnecessary cast
>>       net/mlx5: remove unnecessary cast
>>       net/failsafe: fix reported device info
>>       bus/pci: fix TOCTOU for sysfs access
>>       net/netvsc: initialize VF spinlock
>>       net/i40e: remove empty queue stats mapping set devops
>>       net/bnx2x: fix warnings from invalid assert
>>       net/qede: fix warnings from invalid assert
>>       bus/vmbus: skip non-network devices
>>       net/netvsc: fix RSS offload settings
>>       net/netvsc: fix xstats for VF device
>>       net/netvsc: fix definition of offload values
>>       compress/isal: fix use after free
>>       kni: fix copy_from_user failure handling
>>       kni: fix style
>>       net/tap: remove redundant declarations
>>       net/af_packet: remove redundant declaration
>>       net/vhost: remove redundant declaration
>>       net/null: remove redundant declaration
>>       net/pcap: remove redundant declaration
>>       net/ring: remove redundant declaration
>>       net/virtio_user: remove redundant declaration
>>       raw/skeleton: remove redundant declaration
>>       raw/dpaa2_cmdif: remove redundant declaration
>>       net/bnxt: fix Rx interrupt vector
>>       net/mlx4: fix crash on info query in secondary process
>>
>> Sunil Kumar Kori (1):
>>       examples/ip_frag: remove Tx fast free offload flag
>>
>> Thierry Herbelot (5):
>>       doc: cleanup test removal in armv8 and openssl guides
>>       crypto/mvsam: fix typo in comment
>>       doc: fix triplicated typo in prog guides
>>       doc: fix grammar in prog guides
>>       drivers: fix typo in NXP comments
>>
>> Thinh Tran (1):
>>       raw/skeleton: fix test of attribute set/get
>>
>> Thomas Monjalon (6):
>>       doc: robustify PDF build
>>       doc: fix PDF with greek letter
>>       doc: fix typo in EAL guide
>>       eal/linux: fix return after alarm registration failure
>>       doc: fix PDF build
>>       doc: update features supported by mlx
>>
>> Tianfei Zhang (2):
>>       raw/ifpga/base: fix use of untrusted scalar value
>>       raw/ifpga/base: fix physical address info
>>
>> Timothy Redaelli (1):
>>       usertools: fix refresh binding infos
>>
>> Ting Xu (1):
>>       net/avf: fix driver crash when enable TSO
>>
>> Tiwei Bie (4):
>>       net/virtio: fix queue memory leak on error
>>       net/virtio: unmap port IO for legacy device
>>       net/virtio: unmap device on initialization error
>>       net/virtio: fix memory leak in in-order Rx
>>
>> Tom Barbette (1):
>>       net/mlx5: report imissed statistics
>>
>> Tomasz Jozwiak (2):
>>       app/crypto-perf: fix display once detection
>>       app/crypto-perf: check lcore job failure
>>
>> Vamsi Attunuru (1):
>>       test/eal: fix --socket-mem option
>>
>> Viacheslav Ovsiienko (1):
>>       app/testpmd: fix show port info routine
>>
>> Wei Zhao (3):
>>       app/testpmd: fix offloads config
>>       app/testpmd: fix queue offload configuration
>>       net/ixgbe: fix RETA size for VF
>>
>> Xiao Wang (2):
>>       net/fm10k: advertise supported RSS hash function
>>       net/fm10k: fix descriptor filling in vector Tx
>>
>> Xiao Zhang (6):
>>       net/i40e: fix SFP X722 with FW4.16
>>       net/e1000: fix buffer overrun while i219 processing DMA
>>       net/ixgbe: fix address of first segment
>>       net/i40e: fix address of first segment
>>       net/avf: fix address of first segment
>>       net/fm10k: fix address of first segment
>>
>> Xiaolong Ye (5):
>>       eal: correct log for alarm error
>>       doc: fix typos in flow API guide
>>       doc: fix a grammar mistake in rawdev guide
>>       net/i40e: fix ethernet flow rule
>>       net/i40e: fix flow director rule destroy
>>
>> Xiaoyu Min (3):
>>       net/mlx5: fix VLAN inner type matching on DR/DV
>>       net/mlx5: fix link speed info when link is down
>>       net/mlx5: fix crash for empty raw encap data
>>
>> Yangchao Zhou (1):
>>       kni: fix kernel crash with multi-segments
>>
>> Yogev Chaimovich (1):
>>       net/vmxnet3: fix uninitialized variable
>>
>> Yongseok Koh (1):
>>       config: disable armv8 crypto extension
>>
>> Yunjian Wang (1):
>>       net/ixgbe: fix unexpected link handler
>>
> 
> 
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-13 16:31 [dpdk-dev] 18.11.3 (LTS) patches review and test Kevin Traynor
  2019-09-19 10:22 ` Yu, PingX
  2019-10-03 13:20 ` Kevin Traynor
@ 2019-10-04  2:28 ` Pei Zhang
  2019-10-04  9:37   ` Kevin Traynor
  2019-10-07 20:01 ` Thinh Tran
  2019-10-10 18:39 ` Stokes, Ian
  4 siblings, 1 reply; 30+ messages in thread
From: Pei Zhang @ 2019-10-04  2:28 UTC (permalink / raw)
  To: Kevin Traynor
  Cc: stable, dev, Akhil Goyal, Ali Alnubani, benjamin walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Ju-Hyoung Lee, Luca Boccassi, pingx yu, qian q xu,
	Raslan Darawsheh, Thomas Monjalon, yuan peng, zhaoyan chen

Hi Kevin,

The testings from Red Hat get PASS result. Below 13 testing scenarios look good with v18.11.3-rc1.


Testing scenarios:
(1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
(2)Guest with device assignment(PF) throughput testing(2M hugepage size): PASS
(3)Guest with device assignment(VF) throughput testing: PASS
(4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
(5)PVP vhost-user 2Q throughput testing: PASS
(6)PVP vhost-user 2Q - cross numa node  throughput testing: PASS
(7)Guest with vhost-user 2 queues throughput testing: PASS
(8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
(9)PVP 1Q live migration testing: PASS
(10)PVP 2Q cross numa node live migration testing: PASS
(11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
(12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
(13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS


Versions:
kernel 4.18.0
dpdk: git://dpdk.org/dpdk-stable     remotes/origin/18.11     commit d908ee9de303b1c4f22410f0fd5be710ae1eb5fc 


Hardware info:
# lscpu
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              32
On-line CPU(s) list: 0-31
Thread(s) per core:  1
Core(s) per socket:  16
Socket(s):           2
NUMA node(s):        2
Vendor ID:           GenuineIntel
CPU family:          6
Model:               85
Model name:          Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz
Stepping:            4
CPU MHz:             2100.028
BogoMIPS:            4200.00
Virtualization:      VT-x
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
L3 cache:            22528K
NUMA node0 CPU(s):   0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30
NUMA node1 CPU(s):   1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm arat pln pts pku ospke md_clear flush_l1d


# lspci | grep Eth
5e:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
5e:00.1 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
5f:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
5f:00.1 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)


Best regards,

Pei
 

----- Original Message -----
From: "Kevin Traynor" <ktraynor@redhat.com>
To: stable@dpdk.org
Cc: dev@dpdk.org, "Akhil Goyal" <akhil.goyal@nxp.com>, "Ali Alnubani" <alialnu@mellanox.com>, "benjamin walker" <benjamin.walker@intel.com>, "David Christensen" <drc@linux.vnet.ibm.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com>, "Ian Stokes" <ian.stokes@intel.com>, "Jerin Jacob" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, "Ju-Hyoung Lee" <juhlee@microsoft.com>, "Kevin Traynor" <ktraynor@redhat.com>, "Luca Boccassi" <bluca@debian.org>, "Pei Zhang" <pezhang@redhat.com>, "pingx yu" <pingx.yu@intel.com>, "qian q xu" <qian.q.xu@intel.com>, "Raslan Darawsheh" <rasland@mellanox.com>, "Thomas Monjalon" <thomas@monjalon.net>, "yuan peng" <yuan.peng@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>
Sent: Saturday, September 14, 2019 12:31:00 AM
Subject: 18.11.3 (LTS) patches review and test

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 9th October.

Please help with testing and validation of your use cases and report
any issues/results in reply to this mail. For the final release the
fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1

These patches are located at branch 18.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (5):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (26):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-04  2:28 ` [dpdk-dev] " Pei Zhang
@ 2019-10-04  9:37   ` Kevin Traynor
  0 siblings, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-10-04  9:37 UTC (permalink / raw)
  To: Pei Zhang
  Cc: stable, dev, Akhil Goyal, Ali Alnubani, benjamin walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Ju-Hyoung Lee, Luca Boccassi, pingx yu, qian q xu,
	Raslan Darawsheh, Thomas Monjalon, yuan peng, zhaoyan chen

On 04/10/2019 03:28, Pei Zhang wrote:
> Hi Kevin,
> 
> The testings from Red Hat get PASS result. Below 13 testing scenarios look good with v18.11.3-rc1.
> 
> 
> Testing scenarios:
> (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
> (2)Guest with device assignment(PF) throughput testing(2M hugepage size): PASS
> (3)Guest with device assignment(VF) throughput testing: PASS
> (4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
> (5)PVP vhost-user 2Q throughput testing: PASS
> (6)PVP vhost-user 2Q - cross numa node  throughput testing: PASS
> (7)Guest with vhost-user 2 queues throughput testing: PASS
> (8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
> (9)PVP 1Q live migration testing: PASS
> (10)PVP 2Q cross numa node live migration testing: PASS
> (11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
> (12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
> (13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
> 

Thank you Pei. fyi - these do *not* need to be retested with RC2, as the
RC1->RC2 differences would not impact these tests at all.

Kevin.

> 
> Versions:
> kernel 4.18.0
> dpdk: git://dpdk.org/dpdk-stable     remotes/origin/18.11     commit d908ee9de303b1c4f22410f0fd5be710ae1eb5fc 
> 
> 
> Hardware info:
> # lscpu
> Architecture:        x86_64
> CPU op-mode(s):      32-bit, 64-bit
> Byte Order:          Little Endian
> CPU(s):              32
> On-line CPU(s) list: 0-31
> Thread(s) per core:  1
> Core(s) per socket:  16
> Socket(s):           2
> NUMA node(s):        2
> Vendor ID:           GenuineIntel
> CPU family:          6
> Model:               85
> Model name:          Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz
> Stepping:            4
> CPU MHz:             2100.028
> BogoMIPS:            4200.00
> Virtualization:      VT-x
> L1d cache:           32K
> L1i cache:           32K
> L2 cache:            1024K
> L3 cache:            22528K
> NUMA node0 CPU(s):   0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30
> NUMA node1 CPU(s):   1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31
> Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm arat pln pts pku ospke md_clear flush_l1d
> 
> 
> # lspci | grep Eth
> 5e:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
> 5e:00.1 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
> 5f:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
> 5f:00.1 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01)
> 
> 
> Best regards,
> 
> Pei
>  
> 
> ----- Original Message -----
> From: "Kevin Traynor" <ktraynor@redhat.com>
> To: stable@dpdk.org
> Cc: dev@dpdk.org, "Akhil Goyal" <akhil.goyal@nxp.com>, "Ali Alnubani" <alialnu@mellanox.com>, "benjamin walker" <benjamin.walker@intel.com>, "David Christensen" <drc@linux.vnet.ibm.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com>, "Ian Stokes" <ian.stokes@intel.com>, "Jerin Jacob" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, "Ju-Hyoung Lee" <juhlee@microsoft.com>, "Kevin Traynor" <ktraynor@redhat.com>, "Luca Boccassi" <bluca@debian.org>, "Pei Zhang" <pezhang@redhat.com>, "pingx yu" <pingx.yu@intel.com>, "qian q xu" <qian.q.xu@intel.com>, "Raslan Darawsheh" <rasland@mellanox.com>, "Thomas Monjalon" <thomas@monjalon.net>, "yuan peng" <yuan.peng@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>
> Sent: Saturday, September 14, 2019 12:31:00 AM
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report
> any issues/results in reply to this mail. For the final release the
> fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-13 16:31 [dpdk-dev] 18.11.3 (LTS) patches review and test Kevin Traynor
                   ` (2 preceding siblings ...)
  2019-10-04  2:28 ` [dpdk-dev] " Pei Zhang
@ 2019-10-07 20:01 ` Thinh Tran
  2019-10-07 20:11   ` Ju-Hyoung Lee
  2019-10-11  9:34   ` Kevin Traynor
  2019-10-10 18:39 ` Stokes, Ian
  4 siblings, 2 replies; 30+ messages in thread
From: Thinh Tran @ 2019-10-07 20:01 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu,
	qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
	zhaoyan.chen

Hi-

IBM - DPDK on Power result

*Basic PF on Mallanox: No new errors or regressions were seen.
*Performance: no degradation compared to 18.11.2

System tested:
  - IBM Power9 Model 8335-101 CPU: 2.3 (pvr 004e 1203)
Tested NICs:
  - Mellanox Technologies MT28800 Family [ConnectX-5 Ex]
  - firmware version: 16.26.292
  - MLNX_OFED_LINUX-4.7-1.0.0.1


Regards,
Thinh Tran

On 9/13/2019 11:31 AM, Kevin Traynor wrote:
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3.
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report
> any issues/results in reply to this mail. For the final release the
> fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>      https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>      https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>        test/flow_classify: fix undefined behavior
>        acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>        compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>        net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>        net/bnxt: fix TSO
>        net/bnxt: check for error conditions in Tx path
>        net/bnxt: fix RSS RETA indirection table ops
>        net/bnxt: save the number of EM flow count
>        net/bnxt: fix compiler warning
>        net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>        crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>        examples/ip_fragmentation: fix Tx queues init
>        net/mlx5: fix 32-bit build
>        doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>        net/thunderx: fix crash on detach
>        app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>        eal/freebsd: fix init completion
>        eal/freebsd: fix config creation
>        vfio: use contiguous mapping for IOVA as VA mode
>        test: enable installing app with meson
> 
> Andrew Lee (1):
>        net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>        ethdev: fix Tx prepare documentation to use positive errno
>        net/atlantic: fix Tx prepare to set positive rte_errno
>        net/e1000: fix Tx prepare to set positive rte_errno
>        net/enic: fix Tx prepare to set positive rte_errno
>        net/fm10k: fix Tx prepare to set positive rte_errno
>        net/i40e: fix Tx prepare to set positive rte_errno
>        net/iavf: fix Tx prepare to set positive rte_errno
>        net/ixgbe: fix Tx prepare to set positive rte_errno
>        net/qede: fix Tx prepare to set positive rte_errno
>        net/vmxnet3: fix Tx prepare to set positive rte_errno
>        ethdev: avoid error on PCI unplug of closed port
>        net/sfc: ensure that device is closed on removal
>        ethdev: avoid getting uninitialized info for bad port
>        net/sfc: fix power of 2 round up when align has smaller type
>        net/sfc: fix align to power of 2 when align has smaller type
>        net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>        usertools: replace unsafe input function
>        usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>        net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>        app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>        crypto/openssl: fix usage of non constant time memcmp
>        crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>        net/mlx5: fix condition for link update fallback
>        net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>        examples/l3fwd-vf: remove unused Rx/Tx configuration
>        doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>        flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>        examples: fix make clean when using pkg-config
>        kernel/freebsd: fix module build on latest head
>        test: add rawdev autotest to meson
>        examples: fix pkg-config detection with older make
>        doc: fix build with latest meson
> 
> Chenbo Xia (1):
>        crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>        net/ixgbe/base: fix product version check
> 
> David Harton (1):
>        net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>        examples/power: fix FreeBSD meson lib dependency
>        examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>        net/cxgbe: do not dereference global config struct
>        examples/multi_process: do not dereference global config struct
>        examples/qos_sched: do not dereference global config struct
>        test/hash: use existing lcore API
>        examples/multi_process: fix FreeBSD build
>        net/virtio: remove useless check on mempool
>        net/i40e: fix dropped packets statistics name
>        examples/vdpa: remove trace of legacy linuxapp
>        test/hash: fix off-by-one check on core count
>        eal: hide internal hotplug function
>        vfio: remove incorrect experimental tag
>        mem: remove incorrect experimental tag on static symbol
>        telemetry: add missing header include
>        net/bnx2x: fix invalid free on unplug
>        drivers/net: fix double free on init failure
>        mem: fix typo in API description
>        kni: abort when IOVA is not PA
>        net/pcap: fix Rx with small buffers
>        net/pcap: fix Tx return count in error conditions
>        app/testpmd: fix eth packet dump for small buffers
>        app/testpmd: rename ambiguous VF config variable
>        eal: fix control thread affinity with --lcores
>        test: remove link to ixgbe/i40e with meson
>        eal: hide internal function
>        bus/pci: remove unused x86 Linux constant
>        net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>        net/mlx5: fix missing validation of null pointer
>        net/mlx5: fix description of return value
>        net/mlx5: fix memory free on queue create error
>        net/mlx5: fix order of items in NEON scatter
>        doc: fix ethernet addresses in flow API guide
>        net/mlx5: fix typos in comments
>        net/mlx5: remove redundant item from union
>        net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>        test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>        net/virtio: add Tx preparation
>        net/virtio: move VLAN tag insertion to Tx prepare
>        examples/ipsec-secgw: fix error sign
>        eventdev: fix error sign
>        event/sw: fix error sign
>        event/opdl: fix error sign
>        net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>        net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>        examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>        examples/vhost_crypto: remove unused function
>        vhost/crypto: fix logically dead code
>        vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>        telemetry: fix build
>        kni: fix segmented mbuf data overflow
>        cryptodev: fix typo in comment
>        security: remove duplicated symbols from map file
>        igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>        doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>        telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>        eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>        doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>        net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>        crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>        net/ixgbevf: add full link status check option
>        app/testpmd: fix parsing RSS queue rule
>        examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>        examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>        test/distributor: fix flush with worker shutdown
>        distributor: fix check of workers number
>        examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>        crypto/dpaa2_sec: fix handling of session init failure
>        net/dpaa: check multi-segment external buffers
>        net/dpaa: fix build with 0 headroom
>        bus/fslmc: fix build with 0 headroom
>        net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>        test: fix autotest crash
>        mk: fix custom kernel directory name
>        net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>        test/hash: fix data reset on new run
>        hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>        kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>        eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>        net: fix encapsulation markers for inner L3 offset
>        net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>        table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>        net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>        acl: fix build with some arm64 compiler
>        eventdev: fix doxygen comment
>        net/virtio: fix build
>        devtools: fix building kernel component tags
> 
> John Daley (2):
>        net/enic: remove flow count action support
>        net/enic: remove flow locks
> 
> Joyce Kong (2):
>        test/rwlock: benchmark on all available cores
>        test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>        net/bnxt: fix xstats
>        net/bnxt: fix crash on probe failure
>        net/bnxt: fix enabling/disabling interrupts
>        net/bnxt: check invalid VNIC in cleanup path
>        net/bnxt: fix error handling in port start
>        net/bnxt: fix check of address mapping
>        net/bnxt: fix adding MAC address
>        net/bnxt: fix unconditional wait in link update
>        net/bnxt: fix setting primary MAC address
>        net/bnxt: fix device init error path
>        net/bnxt: reset filters before registering interrupts
>        net/bnxt: fix return values to standard error codes
>        net/bnxt: fix lock release on getting NVM info
>        net/bnxt: fix checking result of HWRM command
>        net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>        bpf: fix pseudo calls for program loaded from ELF
>        ip_frag: fix IPv6 fragment size calculation
>        bpf: fix check array size
>        bpf: fix validate for function return value
>        examples/ip_frag: fix unknown ethernet type
>        examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>        eal: fix typo in comments
> 
> Lance Richardson (6):
>        net/bnxt: fix endianness in ring macros
>        net/bnxt: fix ring type macro name
>        net/bnxt: fix variable width in endian conversion
>        net/bnxt: fix Tx hang after port stop/start
>        net/bnxt: retry IRQ callback deregistration
>        net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>        distributor: fix livelock on flush
> 
> Liron Himi (1):
>        net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>        net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>        kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>        net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>        examples: fix use of ethdev internal device array
>        examples/ipsec-secgw: fix use of ethdev internal struct
>        examples/ip_frag: fix use of ethdev internal device array
>        examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>        net/ixgbe: fix IP type for crypto session
>        examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>        net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>        net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>        net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>        fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>        net/ena: fix assigning NUMA node to IO queue
>        net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>        net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>        net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>        net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>        net/bnxt: fix interrupt vector initialization
>        net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>        mem: ease init in a docker container
> 
> Nipun Gupta (2):
>        event/dpaa2: fix timeout ticks
>        net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>        vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>        app/eventdev: fix order test port creation
>        test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>        net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>        net/i40e: fix Tx threshold setup
>        net/ixgbe: fix Tx threshold setup
>        net/i40e: fix unexpected skip FDIR setup
>        net/avf: fix Rx bytes stats
>        net/avf: fix endless loop
> 
> Qingmin Liu (1):
>        net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>        net/bnxt: fix L4 checksum error indication in Rx
>        net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>        net/bnx2x: fix reading VF id
>        net/bnx2x: fix link events polling for SRIOV
>        net/bnx2x: fix fastpath SB allocation for SRIOV
>        doc: add co-existence consideration for bnx2x
>        doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>        telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>        doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>        net: define IPv4 IHL and VHL
>        app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>        net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>        net/bnx2x: fix packet drop
>        net/bnx2x: fix interrupt flood
>        net/bnx2x: fix memory leak
>        net/bnx2x: fix link state
>        net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>        net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>        net/bnxt: fix Tx batching
>        net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>        net/atlantic: remove unnecessary cast
>        net/ark: remove unnecessary cast
>        net/axgbe: remove unnecessary cast
>        net/bnxt: remove unnecessary cast
>        net/bonding: remove unnecessary cast
>        net/cxgbe: remove unnecessary cast
>        net/e1000: remove unnecessary cast
>        net/ena: remove unnecessary cast
>        net/enic: remove unnecessary cast
>        net/i40e: remove unnecessary cast
>        net/ixgbe: remove unnecessary cast
>        net/mlx5: remove unnecessary cast
>        net/failsafe: fix reported device info
>        bus/pci: fix TOCTOU for sysfs access
>        net/netvsc: initialize VF spinlock
>        net/i40e: remove empty queue stats mapping set devops
>        net/bnx2x: fix warnings from invalid assert
>        net/qede: fix warnings from invalid assert
>        bus/vmbus: skip non-network devices
>        net/netvsc: fix RSS offload settings
>        net/netvsc: fix xstats for VF device
>        net/netvsc: fix definition of offload values
>        compress/isal: fix use after free
>        kni: fix copy_from_user failure handling
>        kni: fix style
>        net/tap: remove redundant declarations
>        net/af_packet: remove redundant declaration
>        net/vhost: remove redundant declaration
>        net/null: remove redundant declaration
>        net/pcap: remove redundant declaration
>        net/ring: remove redundant declaration
>        net/virtio_user: remove redundant declaration
>        raw/skeleton: remove redundant declaration
>        raw/dpaa2_cmdif: remove redundant declaration
>        net/bnxt: fix Rx interrupt vector
>        net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>        examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>        doc: cleanup test removal in armv8 and openssl guides
>        crypto/mvsam: fix typo in comment
>        doc: fix triplicated typo in prog guides
>        doc: fix grammar in prog guides
>        drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>        raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>        doc: robustify PDF build
>        doc: fix PDF with greek letter
>        doc: fix typo in EAL guide
>        eal/linux: fix return after alarm registration failure
>        doc: fix PDF build
>        doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>        raw/ifpga/base: fix use of untrusted scalar value
>        raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>        usertools: fix refresh binding infos
> 
> Ting Xu (1):
>        net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>        net/virtio: fix queue memory leak on error
>        net/virtio: unmap port IO for legacy device
>        net/virtio: unmap device on initialization error
>        net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>        net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>        app/crypto-perf: fix display once detection
>        app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>        test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>        app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>        app/testpmd: fix offloads config
>        app/testpmd: fix queue offload configuration
>        net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>        net/fm10k: advertise supported RSS hash function
>        net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>        net/i40e: fix SFP X722 with FW4.16
>        net/e1000: fix buffer overrun while i219 processing DMA
>        net/ixgbe: fix address of first segment
>        net/i40e: fix address of first segment
>        net/avf: fix address of first segment
>        net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>        eal: correct log for alarm error
>        doc: fix typos in flow API guide
>        doc: fix a grammar mistake in rawdev guide
>        net/i40e: fix ethernet flow rule
>        net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>        net/mlx5: fix VLAN inner type matching on DR/DV
>        net/mlx5: fix link speed info when link is down
>        net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>        kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>        net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>        config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>        net/ixgbe: fix unexpected link handler
> 

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-07 20:01 ` Thinh Tran
@ 2019-10-07 20:11   ` Ju-Hyoung Lee
  2019-10-11  9:34   ` Kevin Traynor
  1 sibling, 0 replies; 30+ messages in thread
From: Ju-Hyoung Lee @ 2019-10-07 20:11 UTC (permalink / raw)
  To: Thinh Tran, Kevin Traynor, stable, Abhishek Marathe
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen,
	Ju-Hyoung Lee

+@Abhishek Marathe

-----Original Message-----
From: Thinh Tran <thinhtr@linux.vnet.ibm.com> 
Sent: Monday, October 7, 2019 1:01 PM
To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
Subject: Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

Hi-

IBM - DPDK on Power result

*Basic PF on Mallanox: No new errors or regressions were seen.
*Performance: no degradation compared to 18.11.2

System tested:
  - IBM Power9 Model 8335-101 CPU: 2.3 (pvr 004e 1203) Tested NICs:
  - Mellanox Technologies MT28800 Family [ConnectX-5 Ex]
  - firmware version: 16.26.292
  - MLNX_OFED_LINUX-4.7-1.0.0.1


Regards,
Thinh Tran

On 9/13/2019 11:31 AM, Kevin Traynor wrote:
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3.
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report 
> any issues/results in reply to this mail. For the final release the 
> fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>      
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk
> .org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc1&amp;data=02%7
> C01%7Cjuhlee%40microsoft.com%7C2e77df899ea0470b8b0a08d74b61245b%7C72f9
> 88bf86f141af91ab2d7cd011db47%7C1%7C1%7C637060752910119633&amp;sdata=Gn
> 73m7BX7M9c1Qq%2Bu0nuQ2YXUDYV8Po%2BuxkYncvQWXk%3D&amp;reserved=0
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>      
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk
> .org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.c
> om%7C2e77df899ea0470b8b0a08d74b61245b%7C72f988bf86f141af91ab2d7cd011db
> 47%7C1%7C1%7C637060752910119633&amp;sdata=6ogAMFuJqpFDnLlAut24wSY%2Fp6
> YH%2FMDMGqruSjQr3rM%3D&amp;reserved=0
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>        test/flow_classify: fix undefined behavior
>        acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>        compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>        net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>        net/bnxt: fix TSO
>        net/bnxt: check for error conditions in Tx path
>        net/bnxt: fix RSS RETA indirection table ops
>        net/bnxt: save the number of EM flow count
>        net/bnxt: fix compiler warning
>        net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>        crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>        examples/ip_fragmentation: fix Tx queues init
>        net/mlx5: fix 32-bit build
>        doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>        net/thunderx: fix crash on detach
>        app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>        eal/freebsd: fix init completion
>        eal/freebsd: fix config creation
>        vfio: use contiguous mapping for IOVA as VA mode
>        test: enable installing app with meson
> 
> Andrew Lee (1):
>        net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>        ethdev: fix Tx prepare documentation to use positive errno
>        net/atlantic: fix Tx prepare to set positive rte_errno
>        net/e1000: fix Tx prepare to set positive rte_errno
>        net/enic: fix Tx prepare to set positive rte_errno
>        net/fm10k: fix Tx prepare to set positive rte_errno
>        net/i40e: fix Tx prepare to set positive rte_errno
>        net/iavf: fix Tx prepare to set positive rte_errno
>        net/ixgbe: fix Tx prepare to set positive rte_errno
>        net/qede: fix Tx prepare to set positive rte_errno
>        net/vmxnet3: fix Tx prepare to set positive rte_errno
>        ethdev: avoid error on PCI unplug of closed port
>        net/sfc: ensure that device is closed on removal
>        ethdev: avoid getting uninitialized info for bad port
>        net/sfc: fix power of 2 round up when align has smaller type
>        net/sfc: fix align to power of 2 when align has smaller type
>        net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>        usertools: replace unsafe input function
>        usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>        net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>        app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>        crypto/openssl: fix usage of non constant time memcmp
>        crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>        net/mlx5: fix condition for link update fallback
>        net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>        examples/l3fwd-vf: remove unused Rx/Tx configuration
>        doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>        flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>        examples: fix make clean when using pkg-config
>        kernel/freebsd: fix module build on latest head
>        test: add rawdev autotest to meson
>        examples: fix pkg-config detection with older make
>        doc: fix build with latest meson
> 
> Chenbo Xia (1):
>        crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>        net/ixgbe/base: fix product version check
> 
> David Harton (1):
>        net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>        examples/power: fix FreeBSD meson lib dependency
>        examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>        net/cxgbe: do not dereference global config struct
>        examples/multi_process: do not dereference global config struct
>        examples/qos_sched: do not dereference global config struct
>        test/hash: use existing lcore API
>        examples/multi_process: fix FreeBSD build
>        net/virtio: remove useless check on mempool
>        net/i40e: fix dropped packets statistics name
>        examples/vdpa: remove trace of legacy linuxapp
>        test/hash: fix off-by-one check on core count
>        eal: hide internal hotplug function
>        vfio: remove incorrect experimental tag
>        mem: remove incorrect experimental tag on static symbol
>        telemetry: add missing header include
>        net/bnx2x: fix invalid free on unplug
>        drivers/net: fix double free on init failure
>        mem: fix typo in API description
>        kni: abort when IOVA is not PA
>        net/pcap: fix Rx with small buffers
>        net/pcap: fix Tx return count in error conditions
>        app/testpmd: fix eth packet dump for small buffers
>        app/testpmd: rename ambiguous VF config variable
>        eal: fix control thread affinity with --lcores
>        test: remove link to ixgbe/i40e with meson
>        eal: hide internal function
>        bus/pci: remove unused x86 Linux constant
>        net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>        net/mlx5: fix missing validation of null pointer
>        net/mlx5: fix description of return value
>        net/mlx5: fix memory free on queue create error
>        net/mlx5: fix order of items in NEON scatter
>        doc: fix ethernet addresses in flow API guide
>        net/mlx5: fix typos in comments
>        net/mlx5: remove redundant item from union
>        net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>        test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>        net/virtio: add Tx preparation
>        net/virtio: move VLAN tag insertion to Tx prepare
>        examples/ipsec-secgw: fix error sign
>        eventdev: fix error sign
>        event/sw: fix error sign
>        event/opdl: fix error sign
>        net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>        net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>        examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>        examples/vhost_crypto: remove unused function
>        vhost/crypto: fix logically dead code
>        vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>        telemetry: fix build
>        kni: fix segmented mbuf data overflow
>        cryptodev: fix typo in comment
>        security: remove duplicated symbols from map file
>        igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>        doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>        telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>        eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>        doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>        net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>        crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>        net/ixgbevf: add full link status check option
>        app/testpmd: fix parsing RSS queue rule
>        examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>        examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>        test/distributor: fix flush with worker shutdown
>        distributor: fix check of workers number
>        examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>        crypto/dpaa2_sec: fix handling of session init failure
>        net/dpaa: check multi-segment external buffers
>        net/dpaa: fix build with 0 headroom
>        bus/fslmc: fix build with 0 headroom
>        net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>        test: fix autotest crash
>        mk: fix custom kernel directory name
>        net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>        test/hash: fix data reset on new run
>        hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>        kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>        eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>        net: fix encapsulation markers for inner L3 offset
>        net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>        table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>        net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>        acl: fix build with some arm64 compiler
>        eventdev: fix doxygen comment
>        net/virtio: fix build
>        devtools: fix building kernel component tags
> 
> John Daley (2):
>        net/enic: remove flow count action support
>        net/enic: remove flow locks
> 
> Joyce Kong (2):
>        test/rwlock: benchmark on all available cores
>        test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>        net/bnxt: fix xstats
>        net/bnxt: fix crash on probe failure
>        net/bnxt: fix enabling/disabling interrupts
>        net/bnxt: check invalid VNIC in cleanup path
>        net/bnxt: fix error handling in port start
>        net/bnxt: fix check of address mapping
>        net/bnxt: fix adding MAC address
>        net/bnxt: fix unconditional wait in link update
>        net/bnxt: fix setting primary MAC address
>        net/bnxt: fix device init error path
>        net/bnxt: reset filters before registering interrupts
>        net/bnxt: fix return values to standard error codes
>        net/bnxt: fix lock release on getting NVM info
>        net/bnxt: fix checking result of HWRM command
>        net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>        bpf: fix pseudo calls for program loaded from ELF
>        ip_frag: fix IPv6 fragment size calculation
>        bpf: fix check array size
>        bpf: fix validate for function return value
>        examples/ip_frag: fix unknown ethernet type
>        examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>        eal: fix typo in comments
> 
> Lance Richardson (6):
>        net/bnxt: fix endianness in ring macros
>        net/bnxt: fix ring type macro name
>        net/bnxt: fix variable width in endian conversion
>        net/bnxt: fix Tx hang after port stop/start
>        net/bnxt: retry IRQ callback deregistration
>        net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>        distributor: fix livelock on flush
> 
> Liron Himi (1):
>        net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>        net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>        kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>        net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>        examples: fix use of ethdev internal device array
>        examples/ipsec-secgw: fix use of ethdev internal struct
>        examples/ip_frag: fix use of ethdev internal device array
>        examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>        net/ixgbe: fix IP type for crypto session
>        examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>        net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>        net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>        net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>        fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>        net/ena: fix assigning NUMA node to IO queue
>        net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>        net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>        net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>        net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>        net/bnxt: fix interrupt vector initialization
>        net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>        mem: ease init in a docker container
> 
> Nipun Gupta (2):
>        event/dpaa2: fix timeout ticks
>        net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>        vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>        app/eventdev: fix order test port creation
>        test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>        net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>        net/i40e: fix Tx threshold setup
>        net/ixgbe: fix Tx threshold setup
>        net/i40e: fix unexpected skip FDIR setup
>        net/avf: fix Rx bytes stats
>        net/avf: fix endless loop
> 
> Qingmin Liu (1):
>        net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>        net/bnxt: fix L4 checksum error indication in Rx
>        net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>        net/bnx2x: fix reading VF id
>        net/bnx2x: fix link events polling for SRIOV
>        net/bnx2x: fix fastpath SB allocation for SRIOV
>        doc: add co-existence consideration for bnx2x
>        doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>        telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>        doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>        net: define IPv4 IHL and VHL
>        app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>        net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>        net/bnx2x: fix packet drop
>        net/bnx2x: fix interrupt flood
>        net/bnx2x: fix memory leak
>        net/bnx2x: fix link state
>        net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>        net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>        net/bnxt: fix Tx batching
>        net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>        net/atlantic: remove unnecessary cast
>        net/ark: remove unnecessary cast
>        net/axgbe: remove unnecessary cast
>        net/bnxt: remove unnecessary cast
>        net/bonding: remove unnecessary cast
>        net/cxgbe: remove unnecessary cast
>        net/e1000: remove unnecessary cast
>        net/ena: remove unnecessary cast
>        net/enic: remove unnecessary cast
>        net/i40e: remove unnecessary cast
>        net/ixgbe: remove unnecessary cast
>        net/mlx5: remove unnecessary cast
>        net/failsafe: fix reported device info
>        bus/pci: fix TOCTOU for sysfs access
>        net/netvsc: initialize VF spinlock
>        net/i40e: remove empty queue stats mapping set devops
>        net/bnx2x: fix warnings from invalid assert
>        net/qede: fix warnings from invalid assert
>        bus/vmbus: skip non-network devices
>        net/netvsc: fix RSS offload settings
>        net/netvsc: fix xstats for VF device
>        net/netvsc: fix definition of offload values
>        compress/isal: fix use after free
>        kni: fix copy_from_user failure handling
>        kni: fix style
>        net/tap: remove redundant declarations
>        net/af_packet: remove redundant declaration
>        net/vhost: remove redundant declaration
>        net/null: remove redundant declaration
>        net/pcap: remove redundant declaration
>        net/ring: remove redundant declaration
>        net/virtio_user: remove redundant declaration
>        raw/skeleton: remove redundant declaration
>        raw/dpaa2_cmdif: remove redundant declaration
>        net/bnxt: fix Rx interrupt vector
>        net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>        examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>        doc: cleanup test removal in armv8 and openssl guides
>        crypto/mvsam: fix typo in comment
>        doc: fix triplicated typo in prog guides
>        doc: fix grammar in prog guides
>        drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>        raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>        doc: robustify PDF build
>        doc: fix PDF with greek letter
>        doc: fix typo in EAL guide
>        eal/linux: fix return after alarm registration failure
>        doc: fix PDF build
>        doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>        raw/ifpga/base: fix use of untrusted scalar value
>        raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>        usertools: fix refresh binding infos
> 
> Ting Xu (1):
>        net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>        net/virtio: fix queue memory leak on error
>        net/virtio: unmap port IO for legacy device
>        net/virtio: unmap device on initialization error
>        net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>        net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>        app/crypto-perf: fix display once detection
>        app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>        test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>        app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>        app/testpmd: fix offloads config
>        app/testpmd: fix queue offload configuration
>        net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>        net/fm10k: advertise supported RSS hash function
>        net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>        net/i40e: fix SFP X722 with FW4.16
>        net/e1000: fix buffer overrun while i219 processing DMA
>        net/ixgbe: fix address of first segment
>        net/i40e: fix address of first segment
>        net/avf: fix address of first segment
>        net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>        eal: correct log for alarm error
>        doc: fix typos in flow API guide
>        doc: fix a grammar mistake in rawdev guide
>        net/i40e: fix ethernet flow rule
>        net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>        net/mlx5: fix VLAN inner type matching on DR/DV
>        net/mlx5: fix link speed info when link is down
>        net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>        kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>        net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>        config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>        net/ixgbe: fix unexpected link handler
> 

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-03 13:30       ` Kevin Traynor
@ 2019-10-08 10:22         ` Yu, PingX
  2019-10-11  9:39           ` Kevin Traynor
  0 siblings, 1 reply; 30+ messages in thread
From: Yu, PingX @ 2019-10-08 10:22 UTC (permalink / raw)
  To: Kevin Traynor, stable, dev
  Cc: Akhil Goyal, Ali Alnubani, Walker, Benjamin, David Christensen,
	Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

Kevin,
FYI. All build are passed in 18.11.3-RC2 except Win10 no support. No issues are found now.

Regards,
Yu Ping

-----Original Message-----
From: Kevin Traynor [mailto:ktraynor@redhat.com] 
Sent: Thursday, October 3, 2019 9:30 PM
To: Yu, PingX <pingx.yu@intel.com>; stable@dpdk.org; dev@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Subject: Re: 18.11.3 (LTS) patches review and test

On 26/09/2019 08:41, Yu, PingX wrote:
> Kevin,
> FYi.
>>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
> Q1: What are the error logs? 
> Please see below Error info.
> 
> Q2: Is it a regression for you? i.e. did this test pass with 18.11.2?
> No, it isn't a regression. We don't test it on 18.11.1 and 18.11.2 before, another the test result is still failed after testing. 
> dpdk-stable V18.11.2 commitID(06c4b12a5968caea61e96f7d6bd29d2726fbe255),test failed. 
> dpdk-stable V18.11.1 commitID(16ece46735c9b70b7033ca7ae095930e9038d9fd),test failed, the same mistake.
> 
> Error info:
> ninja: Entering directory `build-gcc-static'
> [296/1419] Compiling C object 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o'.
> FAILED: 
> drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tabl
> e.c.o gcc -Idrivers/a715181@@tmp_rte_common_dpaax@sta -Idrivers 
> -I../drivers -Idrivers/common/dpaax -I../drivers/common/dpaax -I. 
> -I../ -Iconfig -I../config -Ilib/librte_eal/common 
> -I../lib/librte_eal/common -Ilib/librte_eal/common/include 
> -I../lib/librte_eal/common/include 
> -Ilib/librte_eal/common/include/arch/x86 
> -I../lib/librte_eal/common/include/arch/x86 
> -I../lib/librte_eal/linuxapp/eal/include 
> -Ilib/librte_eal/linuxapp/eal/../../../librte_compat 
> -I../lib/librte_eal/linuxapp/eal/../../../librte_compat 
> -Ilib/librte_eal -I../lib/librte_eal 
> -Ilib/librte_kvargs/../librte_eal/common/include 
> -I../lib/librte_kvargs/../librte_eal/common/include 
> -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_compat 
> -I../lib/librte_compat -fdiagnostics-color=always -pipe 
> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include 
> rte_config.h -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -fPIC 
> -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 
> 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tab
> le.c.o' -MF 
> 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tab
> le.c.o.d' -o 
> 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tab
> le.c.o' -c ../drivers/common/dpaax/dpaax_iova_table.c
> In file included from ../drivers/common/dpaax/dpaax_iova_table.c:8:0:
> ../drivers/common/dpaax/dpaax_iova_table.c: In function ‘read_memory_node’:
> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>                                        ^
> ../drivers/common/dpaax/dpaax_iova_table.c:102:2: note: in expansion of macro ‘DPAAX_DEBUG’
>   DPAAX_DEBUG("Size of device-tree mem node: %lu", statbuf.st_size);
>   ^
> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>                                        ^
> ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of macro ‘DPAAX_DEBUG’
>    DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
>    ^
> cc1: all warnings being treated as errors [301/1419] Compiling C object 'lib/76b5a35@@rte_pipeline@sta/librte_pipeline_rte_table_action.c.o'.
> ninja: build stopped: subcommand failed.
> 

Thanks Yu Ping, I reproduced and applied the commits to fix this. It should be fixed now in RC2 (see other mail). If you could re-run this test to confirm same for you, that would be great.

Kevin.

>>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
> 
> Windows support was not added until DPDK 19.05.
> 
> [Ping]Got it. Confirm with the test result of 18.11, we don't test meson.build on WIN10. Tks for your information.
> 
> Regards,
> Yu Ping
> 
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Thursday, September 26, 2019 12:07 AM
> To: Yu, PingX <pingx.yu@intel.com>; stable@dpdk.org; dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; 
> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal 
> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin 
> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; 
> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi 
> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q 
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas 
> Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; 
> Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.3 (LTS) patches review and test
> 
> On 19/09/2019 11:22, Yu, PingX wrote:
>> Hi all,
>> Update Intel test result here.
>>
> 
> Hi Yu Ping,
> 
> Thanks for testing. Some comments/questions on the failures,
> 
>> # Basic Intel(R) NIC testing
>> * PF(i40e): Pass
>> * PF(ixgbe): Pass
>> * VF: Pass
>> * Build or compile: 3 bugs are found.
>>   1. [dpdk-stable 18.11.3] compile error on freebsd12
> 
> ok, I've figured this out and will send a patch.
> 
>>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
> 
> What are the error logs? Is it a regression for you? i.e. did this test pass with 18.11.2?
> 
>>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10
> 
> Windows support was not added until DPDK 19.05.
> 
> thanks,
> Kevin.
> 
>> * Intel NIC single core/NIC performance: Pass
>>
>> #Basic cryptodev and virtio testing
>> * vhost/virtio basic loopback, PVP and performance test: Pass.
>> * cryptodev: Pass
>>
>> Regards,
>> Yu Ping
>>
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>> Sent: Saturday, September 14, 2019 12:31 AM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; 
>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal 
>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin 
>> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; 
>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor 
>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q 
>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; 
>> Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan 
>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: 18.11.3 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.3. 
>>
>> The planned date for the final release is 9th October.
>>
>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin Traynor
>>
>> ---
>> Aaron Conole (2):
>>       test/flow_classify: fix undefined behavior
>>       acl: fix undefined behavior of bit shifts
>>
>> Adam Dybkowski (1):
>>       compress/zlib: fix error handling
>>
>> Aideen McLoughlin (1):
>>       net/pcap: fix possible mbuf double freeing
>>
>> Ajit Khaparde (6):
>>       net/bnxt: fix TSO
>>       net/bnxt: check for error conditions in Tx path
>>       net/bnxt: fix RSS RETA indirection table ops
>>       net/bnxt: save the number of EM flow count
>>       net/bnxt: fix compiler warning
>>       net/bnxt: remove unnecessary interrupt disable
>>
>> Akash Saxena (1):
>>       crypto/openssl: remove useless check before freeing
>>
>> Ali Alnubani (3):
>>       examples/ip_fragmentation: fix Tx queues init
>>       net/mlx5: fix 32-bit build
>>       doc: fix link about bifurcated model in Linux guide
>>
>> Amit Gupta (2):
>>       net/thunderx: fix crash on detach
>>       app/testpmd: fix latency stats deinit on signal
>>
>> Anatoly Burakov (4):
>>       eal/freebsd: fix init completion
>>       eal/freebsd: fix config creation
>>       vfio: use contiguous mapping for IOVA as VA mode
>>       test: enable installing app with meson
>>
>> Andrew Lee (1):
>>       net/sfc/base: fix signed/unsigned mismatch
>>
>> Andrew Rybchenko (16):
>>       ethdev: fix Tx prepare documentation to use positive errno
>>       net/atlantic: fix Tx prepare to set positive rte_errno
>>       net/e1000: fix Tx prepare to set positive rte_errno
>>       net/enic: fix Tx prepare to set positive rte_errno
>>       net/fm10k: fix Tx prepare to set positive rte_errno
>>       net/i40e: fix Tx prepare to set positive rte_errno
>>       net/iavf: fix Tx prepare to set positive rte_errno
>>       net/ixgbe: fix Tx prepare to set positive rte_errno
>>       net/qede: fix Tx prepare to set positive rte_errno
>>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>>       ethdev: avoid error on PCI unplug of closed port
>>       net/sfc: ensure that device is closed on removal
>>       ethdev: avoid getting uninitialized info for bad port
>>       net/sfc: fix power of 2 round up when align has smaller type
>>       net/sfc: fix align to power of 2 when align has smaller type
>>       net/sfc: unify power of 2 alignment check macro
>>
>> Andrius Sirvys (2):
>>       usertools: replace unsafe input function
>>       usertools: fix input handling in telemetry script
>>
>> Andy Pei (1):
>>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
>>
>> Ankur Dwivedi (1):
>>       app/crypto-perf: fix CSV format
>>
>> Arek Kusztal (2):
>>       crypto/openssl: fix usage of non constant time memcmp
>>       crypto/openssl: fix free of asymmetric crypto keys
>>
>> Asaf Penso (2):
>>       net/mlx5: fix condition for link update fallback
>>       net/mlx5: check memory allocation in flow creation
>>
>> Bao-Long Tran (2):
>>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>>       doc: remove useless Rx configuration in l2fwd guide
>>
>> Bernard Iremonger (1):
>>       flow_classify: fix out-of-bounds access
>>
>> Bruce Richardson (5):
>>       examples: fix make clean when using pkg-config
>>       kernel/freebsd: fix module build on latest head
>>       test: add rawdev autotest to meson
>>       examples: fix pkg-config detection with older make
>>       doc: fix build with latest meson
>>
>> Chenbo Xia (1):
>>       crypto/virtio: check PCI config read
>>
>> Congwen Zhang (1):
>>       net/ixgbe/base: fix product version check
>>
>> David Harton (1):
>>       net/ena: fix admin CQ polling for 32-bit
>>
>> David Hunt (2):
>>       examples/power: fix FreeBSD meson lib dependency
>>       examples/power: fix strcpy buffer overrun
>>
>> David Marchand (26):
>>       net/cxgbe: do not dereference global config struct
>>       examples/multi_process: do not dereference global config struct
>>       examples/qos_sched: do not dereference global config struct
>>       test/hash: use existing lcore API
>>       examples/multi_process: fix FreeBSD build
>>       net/virtio: remove useless check on mempool
>>       net/i40e: fix dropped packets statistics name
>>       examples/vdpa: remove trace of legacy linuxapp
>>       test/hash: fix off-by-one check on core count
>>       eal: hide internal hotplug function
>>       vfio: remove incorrect experimental tag
>>       mem: remove incorrect experimental tag on static symbol
>>       telemetry: add missing header include
>>       net/bnx2x: fix invalid free on unplug
>>       drivers/net: fix double free on init failure
>>       mem: fix typo in API description
>>       kni: abort when IOVA is not PA
>>       net/pcap: fix Rx with small buffers
>>       net/pcap: fix Tx return count in error conditions
>>       app/testpmd: fix eth packet dump for small buffers
>>       app/testpmd: rename ambiguous VF config variable
>>       eal: fix control thread affinity with --lcores
>>       test: remove link to ixgbe/i40e with meson
>>       eal: hide internal function
>>       bus/pci: remove unused x86 Linux constant
>>       net/pcap: fix concurrent multiseg Tx
>>
>> Dekel Peled (8):
>>       net/mlx5: fix missing validation of null pointer
>>       net/mlx5: fix description of return value
>>       net/mlx5: fix memory free on queue create error
>>       net/mlx5: fix order of items in NEON scatter
>>       doc: fix ethernet addresses in flow API guide
>>       net/mlx5: fix typos in comments
>>       net/mlx5: remove redundant item from union
>>       net/mlx5: fix validation of VLAN PCP item
>>
>> Dharmik Thakkar (1):
>>       test/hash: rectify slave id to point to valid cores
>>
>> Dilshod Urazov (7):
>>       net/virtio: add Tx preparation
>>       net/virtio: move VLAN tag insertion to Tx prepare
>>       examples/ipsec-secgw: fix error sign
>>       eventdev: fix error sign
>>       event/sw: fix error sign
>>       event/opdl: fix error sign
>>       net: adjust L2 length on soft VLAN insertion
>>
>> Ed Czeck (1):
>>       net/ark: fix queue packet replacement
>>
>> Erik Gabriel Carrillo (1):
>>       examples/performance-thread: init timer subsystem
>>
>> Fan Zhang (3):
>>       examples/vhost_crypto: remove unused function
>>       vhost/crypto: fix logically dead code
>>       vhost/crypto: fix inferred misuse of enum
>>
>> Ferruh Yigit (5):
>>       telemetry: fix build
>>       kni: fix segmented mbuf data overflow
>>       cryptodev: fix typo in comment
>>       security: remove duplicated symbols from map file
>>       igb_uio: fix build on Linux 5.3 for fall through
>>
>> Fiona Trahe (1):
>>       doc: clarify data plane error handling in compressdev
>>
>> Flavia Musatescu (1):
>>       telemetry: fix build warnings seen when using gcc 9
>>
>> Gagandeep Singh (1):
>>       eal: increase maximum different hugepage sizes on Arm
>>
>> Gage Eads (1):
>>       doc: add a note for multi-process in mempool guide
>>
>> Gautam Dawar (1):
>>       net/sfc/base: enable chained multicast on all EF10 cards
>>
>> Gosia Bakota (1):
>>       crypto/qat: set message field to zero in sym SGL case
>>
>> Haiyue Wang (3):
>>       net/ixgbevf: add full link status check option
>>       app/testpmd: fix parsing RSS queue rule
>>       examples/tep_term: remove duplicate definitions
>>
>> Hariprasad Govindharajan (1):
>>       examples/l3fwd: fix unaligned memory access on x86
>>
>> Harman Kalra (3):
>>       test/distributor: fix flush with worker shutdown
>>       distributor: fix check of workers number
>>       examples/ptpclient: fix delay request message
>>
>> Hemant Agrawal (5):
>>       crypto/dpaa2_sec: fix handling of session init failure
>>       net/dpaa: check multi-segment external buffers
>>       net/dpaa: fix build with 0 headroom
>>       bus/fslmc: fix build with 0 headroom
>>       net/virtio: fix build with 0 headroom
>>
>> Herakliusz Lipiec (3):
>>       test: fix autotest crash
>>       mk: fix custom kernel directory name
>>       net/i40e: fix MAC removal check
>>
>> Honnappa Nagarahalli (2):
>>       test/hash: fix data reset on new run
>>       hash: use ordered loads only if signature matches
>>
>> Igor Ryzhov (1):
>>       kernel/linux: fix modules install path
>>
>> Ilya Maximets (1):
>>       eal: fix positive error codes from probe/remove
>>
>> Ivan Malov (2):
>>       net: fix encapsulation markers for inner L3 offset
>>       net: fix how L4 checksum choice is tested
>>
>> Jananee Parthasarathy (1):
>>       table: fix crash in LPM IPv6
>>
>> Jay Ding (1):
>>       net/bnxt: check invalid VNIC id for firmware
>>
>> Jerin Jacob (4):
>>       acl: fix build with some arm64 compiler
>>       eventdev: fix doxygen comment
>>       net/virtio: fix build
>>       devtools: fix building kernel component tags
>>
>> John Daley (2):
>>       net/enic: remove flow count action support
>>       net/enic: remove flow locks
>>
>> Joyce Kong (2):
>>       test/rwlock: benchmark on all available cores
>>       test/rwlock: amortize the cost of getting time
>>
>> Kalesh AP (15):
>>       net/bnxt: fix xstats
>>       net/bnxt: fix crash on probe failure
>>       net/bnxt: fix enabling/disabling interrupts
>>       net/bnxt: check invalid VNIC in cleanup path
>>       net/bnxt: fix error handling in port start
>>       net/bnxt: fix check of address mapping
>>       net/bnxt: fix adding MAC address
>>       net/bnxt: fix unconditional wait in link update
>>       net/bnxt: fix setting primary MAC address
>>       net/bnxt: fix device init error path
>>       net/bnxt: reset filters before registering interrupts
>>       net/bnxt: fix return values to standard error codes
>>       net/bnxt: fix lock release on getting NVM info
>>       net/bnxt: fix checking result of HWRM command
>>       net/bnxt: reduce verbosity of a message
>>
>> Konstantin Ananyev (6):
>>       bpf: fix pseudo calls for program loaded from ELF
>>       ip_frag: fix IPv6 fragment size calculation
>>       bpf: fix check array size
>>       bpf: fix validate for function return value
>>       examples/ip_frag: fix unknown ethernet type
>>       examples/bpf: fix build
>>
>> Krzysztof Kanas (1):
>>       eal: fix typo in comments
>>
>> Lance Richardson (6):
>>       net/bnxt: fix endianness in ring macros
>>       net/bnxt: fix ring type macro name
>>       net/bnxt: fix variable width in endian conversion
>>       net/bnxt: fix Tx hang after port stop/start
>>       net/bnxt: retry IRQ callback deregistration
>>       net/bnxt: fix getting statistics
>>
>> Liang Ma (1):
>>       distributor: fix livelock on flush
>>
>> Liron Himi (1):
>>       net/mvneta: fix ierror statistics
>>
>> Lu Qiuwen (1):
>>       net/fm10k: fix stats crash in multi-process
>>
>> Luo Gaoliang (1):
>>       kni: fix build on RHEL8
>>
>> Maciej Bielski (1):
>>       net/ena: fix L4 checksum Tx offload
>>
>> Marcin Zapolski (4):
>>       examples: fix use of ethdev internal device array
>>       examples/ipsec-secgw: fix use of ethdev internal struct
>>       examples/ip_frag: fix use of ethdev internal device array
>>       examples/ip_frag: fix stale content of ethdev info
>>
>> Mariusz Drost (2):
>>       net/ixgbe: fix IP type for crypto session
>>       examples/ipsec-secgw: fix inline modes
>>
>> Mark Spender (1):
>>       net/sfc/base: fix shift by more bits than field width
>>
>> Matan Azrad (1):
>>       net/mlx5: fix device arguments error detection
>>
>> Maxime Coquelin (1):
>>       net/virtio: fix in-order Rx with segmented packet
>>
>> Michael Santana (1):
>>       fix off-by-one errors in snprintf
>>
>> Michal Krawczyk (2):
>>       net/ena: fix assigning NUMA node to IO queue
>>       net/ena: fix Rx checksum errors statistics
>>
>> Mohsin Mazhar Shaikh (1):
>>       net/netvsc: fix xstats id
>>
>> Morten Brørup (1):
>>       net: fix definition of IPv6 traffic class mask
>>
>> Moti Haimovsky (1):
>>       net/mlx5: fix crash on null operation
>>
>> Naresh Kumar PBS (2):
>>       net/bnxt: fix interrupt vector initialization
>>       net/bnxt: fix icc build
>>
>> Nicolas Dichtel (1):
>>       mem: ease init in a docker container
>>
>> Nipun Gupta (2):
>>       event/dpaa2: fix timeout ticks
>>       net/dpaa2: fix multi-segment Tx
>>
>> Noa Ezra (1):
>>       vhost: fix missing include
>>
>> Pavan Nikhilesh (2):
>>       app/eventdev: fix order test port creation
>>       test/eventdev: fix producer core validity checks
>>
>> Peng Huang (1):
>>       net/i40e: fix RSS hash update for X722 VF
>>
>> Qi Zhang (5):
>>       net/i40e: fix Tx threshold setup
>>       net/ixgbe: fix Tx threshold setup
>>       net/i40e: fix unexpected skip FDIR setup
>>       net/avf: fix Rx bytes stats
>>       net/avf: fix endless loop
>>
>> Qingmin Liu (1):
>>       net/bnxt: fix RxQ count if ntuple filtering is disabled
>>
>> Rahul Gupta (2):
>>       net/bnxt: fix L4 checksum error indication in Rx
>>       net/bnxt: fix interrupt rearm logic
>>
>> Rasesh Mody (5):
>>       net/bnx2x: fix reading VF id
>>       net/bnx2x: fix link events polling for SRIOV
>>       net/bnx2x: fix fastpath SB allocation for SRIOV
>>       doc: add co-existence consideration for bnx2x
>>       doc: add co-existence consideration for qede
>>
>> Reshma Pattan (1):
>>       telemetry: fix memory leak
>>
>> Ruifeng Wang (1):
>>       doc: fix Linux guide for arm64 cross-compilation
>>
>> Saleh Alsouqi (2):
>>       net: define IPv4 IHL and VHL
>>       app/testpmd: fix MPLS IPv4 encapsulation fields
>>
>> Santoshkumar Karanappa Rastapur (1):
>>       net/bnxt: fix extended port counter statistics
>>
>> Shahed Shaikh (5):
>>       net/bnx2x: fix packet drop
>>       net/bnx2x: fix interrupt flood
>>       net/bnx2x: fix memory leak
>>       net/bnx2x: fix link state
>>       net/bnx2x: fix supported max Rx/Tx descriptor count
>>
>> Somnath Kotur (1):
>>       net/bnxt: check for null completion ring doorbell
>>
>> Sriharsha Basavapatna (2):
>>       net/bnxt: fix Tx batching
>>       net/bnxt: optimize Tx batching
>>
>> Stephen Hemminger (36):
>>       net/atlantic: remove unnecessary cast
>>       net/ark: remove unnecessary cast
>>       net/axgbe: remove unnecessary cast
>>       net/bnxt: remove unnecessary cast
>>       net/bonding: remove unnecessary cast
>>       net/cxgbe: remove unnecessary cast
>>       net/e1000: remove unnecessary cast
>>       net/ena: remove unnecessary cast
>>       net/enic: remove unnecessary cast
>>       net/i40e: remove unnecessary cast
>>       net/ixgbe: remove unnecessary cast
>>       net/mlx5: remove unnecessary cast
>>       net/failsafe: fix reported device info
>>       bus/pci: fix TOCTOU for sysfs access
>>       net/netvsc: initialize VF spinlock
>>       net/i40e: remove empty queue stats mapping set devops
>>       net/bnx2x: fix warnings from invalid assert
>>       net/qede: fix warnings from invalid assert
>>       bus/vmbus: skip non-network devices
>>       net/netvsc: fix RSS offload settings
>>       net/netvsc: fix xstats for VF device
>>       net/netvsc: fix definition of offload values
>>       compress/isal: fix use after free
>>       kni: fix copy_from_user failure handling
>>       kni: fix style
>>       net/tap: remove redundant declarations
>>       net/af_packet: remove redundant declaration
>>       net/vhost: remove redundant declaration
>>       net/null: remove redundant declaration
>>       net/pcap: remove redundant declaration
>>       net/ring: remove redundant declaration
>>       net/virtio_user: remove redundant declaration
>>       raw/skeleton: remove redundant declaration
>>       raw/dpaa2_cmdif: remove redundant declaration
>>       net/bnxt: fix Rx interrupt vector
>>       net/mlx4: fix crash on info query in secondary process
>>
>> Sunil Kumar Kori (1):
>>       examples/ip_frag: remove Tx fast free offload flag
>>
>> Thierry Herbelot (5):
>>       doc: cleanup test removal in armv8 and openssl guides
>>       crypto/mvsam: fix typo in comment
>>       doc: fix triplicated typo in prog guides
>>       doc: fix grammar in prog guides
>>       drivers: fix typo in NXP comments
>>
>> Thinh Tran (1):
>>       raw/skeleton: fix test of attribute set/get
>>
>> Thomas Monjalon (6):
>>       doc: robustify PDF build
>>       doc: fix PDF with greek letter
>>       doc: fix typo in EAL guide
>>       eal/linux: fix return after alarm registration failure
>>       doc: fix PDF build
>>       doc: update features supported by mlx
>>
>> Tianfei Zhang (2):
>>       raw/ifpga/base: fix use of untrusted scalar value
>>       raw/ifpga/base: fix physical address info
>>
>> Timothy Redaelli (1):
>>       usertools: fix refresh binding infos
>>
>> Ting Xu (1):
>>       net/avf: fix driver crash when enable TSO
>>
>> Tiwei Bie (4):
>>       net/virtio: fix queue memory leak on error
>>       net/virtio: unmap port IO for legacy device
>>       net/virtio: unmap device on initialization error
>>       net/virtio: fix memory leak in in-order Rx
>>
>> Tom Barbette (1):
>>       net/mlx5: report imissed statistics
>>
>> Tomasz Jozwiak (2):
>>       app/crypto-perf: fix display once detection
>>       app/crypto-perf: check lcore job failure
>>
>> Vamsi Attunuru (1):
>>       test/eal: fix --socket-mem option
>>
>> Viacheslav Ovsiienko (1):
>>       app/testpmd: fix show port info routine
>>
>> Wei Zhao (3):
>>       app/testpmd: fix offloads config
>>       app/testpmd: fix queue offload configuration
>>       net/ixgbe: fix RETA size for VF
>>
>> Xiao Wang (2):
>>       net/fm10k: advertise supported RSS hash function
>>       net/fm10k: fix descriptor filling in vector Tx
>>
>> Xiao Zhang (6):
>>       net/i40e: fix SFP X722 with FW4.16
>>       net/e1000: fix buffer overrun while i219 processing DMA
>>       net/ixgbe: fix address of first segment
>>       net/i40e: fix address of first segment
>>       net/avf: fix address of first segment
>>       net/fm10k: fix address of first segment
>>
>> Xiaolong Ye (5):
>>       eal: correct log for alarm error
>>       doc: fix typos in flow API guide
>>       doc: fix a grammar mistake in rawdev guide
>>       net/i40e: fix ethernet flow rule
>>       net/i40e: fix flow director rule destroy
>>
>> Xiaoyu Min (3):
>>       net/mlx5: fix VLAN inner type matching on DR/DV
>>       net/mlx5: fix link speed info when link is down
>>       net/mlx5: fix crash for empty raw encap data
>>
>> Yangchao Zhou (1):
>>       kni: fix kernel crash with multi-segments
>>
>> Yogev Chaimovich (1):
>>       net/vmxnet3: fix uninitialized variable
>>
>> Yongseok Koh (1):
>>       config: disable armv8 crypto extension
>>
>> Yunjian Wang (1):
>>       net/ixgbe: fix unexpected link handler
>>
> 
> 
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-09-13 16:31 [dpdk-dev] 18.11.3 (LTS) patches review and test Kevin Traynor
                   ` (3 preceding siblings ...)
  2019-10-07 20:01 ` Thinh Tran
@ 2019-10-10 18:39 ` Stokes, Ian
  2019-10-11  9:41   ` Kevin Traynor
  4 siblings, 1 reply; 30+ messages in thread
From: Stokes, Ian @ 2019-10-10 18:39 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Jerin Jacob, John McNamara,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen



On 9/13/2019 5:31 PM, Kevin Traynor wrote:
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3.
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report
> any issues/results in reply to this mail. For the final release the
> fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>      https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>      https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin Traynor

Hi Kevin,

I've validated with current head OVS Master, 2.12.2 and OVS 2.11.3 with 
VSPERF.
Tested with i40e (X710), i40eVF, ixgbe (82599ES), ixgbeVF, igb(I350) and 
igbVF devices.

Following tests were conducted and passed:

* vswitch_p2p_tput: vSwitch - configure switch and execute RFC2544 
throughput test.
* vswitch_p2p_cont: vSwitch - configure switch and execute RFC2544 
continuous stream test.
* vswitch_pvp_tput: vSwitch - configure switch, vnf and execute RFC2544 
throughput test.
* vswitch_pvp_cont: vSwitch - configure switch, vnf and execute RFC2544 
continuous stream test.
* ovsdpdk_hotplug_attach: Ensure successful port-add after binding a 
device to igb_uio after ovs-vswitchd is launched.
* ovsdpdk_mq_p2p_rxqs: Setup rxqs on NIC port.
* ovsdpdk_mq_pvp_rxqs: Setup rxqs on vhost user port.
* ovsdpdk_mq_pvp_rxqs_linux_bridge: Confirm traffic received over vhost 
RXQs with Linux virtio device in guest.
* ovsdpdk_mq_pvp_rxqs_testpmd: Confirm traffic received over vhost RXQs 
with DPDK device in guest.
* ovsdpdk_vhostuser_client: Test vhost-user client mode.
* ovsdpdk_vhostuser_client_reconnect: Test vhost-user client mode 
reconnect feature.
* ovsdpdk_vhostuser_server: Test vhost-user server mode.
* ovsdpdk_vhostuser_sock_dir: Verify functionality of vhost-sock-dir flag.
* ovsdpdk_vdev_add_af_packet_pmd: Test addition of port using the 
af_packet DPDK PMD driver.
* ovsdpdk_vdev_del_af_packet_pmd: Test deletion of port using the 
af_packet DPDK PMD driver.
* ovsdpdk_numa: Test vhost-user NUMA support. Vhostuser PMD threads 
should migrate to the same numa slot, where QEMU is executed.
* ovsdpdk_jumbo_p2p: Ensure that jumbo frames are received, processed 
and forwarded correctly by DPDK physical ports.
* ovsdpdk_jumbo_pvp: Ensure that jumbo frames are received, processed 
and forwarded correctly by DPDK vhost-user ports.
* ovsdpdk_jumbo_p2p_upper_bound: Ensure that jumbo frames above the 
configured Rx port's MTU are not accepted.
* ovsdpdk_jumbo_mtu_upper_bound_vport: Verify that the upper bound limit 
is enforced for OvS DPDK vhost-user ports.
* ovsdpdk_rate_p2p: Ensure when a user creates a rate limiting physical 
interface that the traffic is limited to the specified policer rate in a 
p2p setup.
* ovsdpdk_rate_pvp: Ensure when a user creates a rate limiting vHost 
User interface that the traffic is limited to the specified policer rate 
in a pvp setup.
* ovsdpdk_qos_p2p: In a p2p setup, ensure when a QoS egress policer is 
created that the traffic is limited to the specified rate.
* ovsdpdk_qos_pvp: In a pvp setup, ensure when a QoS egress policer is 
created that the traffic is limited to the specified rate.
* phy2phy_scalability: LTD.Scalability.Flows.RFC2544.0PacketLoss
* phy2phy_scalability_cont: Phy2Phy Scalability Continuous Stream
* pvp_cont: PVP Continuous Stream
* pvvp_cont: PVVP Continuous Stream
* pvpv_cont: Two VMs in parallel with Continuous Stream

Regards
Ian



^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-07 20:01 ` Thinh Tran
  2019-10-07 20:11   ` Ju-Hyoung Lee
@ 2019-10-11  9:34   ` Kevin Traynor
  1 sibling, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-10-11  9:34 UTC (permalink / raw)
  To: Thinh Tran, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu,
	qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
	zhaoyan.chen

On 07/10/2019 21:01, Thinh Tran wrote:
> Hi-
> 
> IBM - DPDK on Power result
> 
> *Basic PF on Mallanox: No new errors or regressions were seen.
> *Performance: no degradation compared to 18.11.2
> 
> System tested:
>   - IBM Power9 Model 8335-101 CPU: 2.3 (pvr 004e 1203)
> Tested NICs:
>   - Mellanox Technologies MT28800 Family [ConnectX-5 Ex]
>   - firmware version: 16.26.292
>   - MLNX_OFED_LINUX-4.7-1.0.0.1
> 
> 
> Regards,
> Thinh Tran
> 

Thanks for the report Thinh. I will add these to the validation notes.

Kevin.

> On 9/13/2019 11:31 AM, Kevin Traynor wrote:
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.3.
>>
>> The planned date for the final release is 9th October.
>>
>> Please help with testing and validation of your use cases and report
>> any issues/results in reply to this mail. For the final release the
>> fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>      https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin Traynor
>>
>> ---


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-08 10:22         ` Yu, PingX
@ 2019-10-11  9:39           ` Kevin Traynor
  0 siblings, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-10-11  9:39 UTC (permalink / raw)
  To: Yu, PingX, stable, dev
  Cc: Akhil Goyal, Ali Alnubani, Walker, Benjamin, David Christensen,
	Hemant Agrawal, Stokes, Ian, Jerin Jacob, Mcnamara, John,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu, Qian Q,
	Raslan Darawsheh, Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan

On 08/10/2019 11:22, Yu, PingX wrote:
> Kevin,
> FYI. All build are passed in 18.11.3-RC2 except Win10 no support. No issues are found now.
> 

Great, thanks for confirming Ping.

Kevin.

> Regards,
> Yu Ping
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com] 
> Sent: Thursday, October 3, 2019 9:30 PM
> To: Yu, PingX <pingx.yu@intel.com>; stable@dpdk.org; dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: Re: 18.11.3 (LTS) patches review and test
> 
> On 26/09/2019 08:41, Yu, PingX wrote:
>> Kevin,
>> FYi.
>>>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86
>> Q1: What are the error logs? 
>> Please see below Error info.
>>
>> Q2: Is it a regression for you? i.e. did this test pass with 18.11.2?
>> No, it isn't a regression. We don't test it on 18.11.1 and 18.11.2 before, another the test result is still failed after testing. 
>> dpdk-stable V18.11.2 commitID(06c4b12a5968caea61e96f7d6bd29d2726fbe255),test failed. 
>> dpdk-stable V18.11.1 commitID(16ece46735c9b70b7033ca7ae095930e9038d9fd),test failed, the same mistake.
>>
>> Error info:
>> ninja: Entering directory `build-gcc-static'
>> [296/1419] Compiling C object 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_table.c.o'.
>> FAILED: 
>> drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tabl
>> e.c.o gcc -Idrivers/a715181@@tmp_rte_common_dpaax@sta -Idrivers 
>> -I../drivers -Idrivers/common/dpaax -I../drivers/common/dpaax -I. 
>> -I../ -Iconfig -I../config -Ilib/librte_eal/common 
>> -I../lib/librte_eal/common -Ilib/librte_eal/common/include 
>> -I../lib/librte_eal/common/include 
>> -Ilib/librte_eal/common/include/arch/x86 
>> -I../lib/librte_eal/common/include/arch/x86 
>> -I../lib/librte_eal/linuxapp/eal/include 
>> -Ilib/librte_eal/linuxapp/eal/../../../librte_compat 
>> -I../lib/librte_eal/linuxapp/eal/../../../librte_compat 
>> -Ilib/librte_eal -I../lib/librte_eal 
>> -Ilib/librte_kvargs/../librte_eal/common/include 
>> -I../lib/librte_kvargs/../librte_eal/common/include 
>> -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_compat 
>> -I../lib/librte_compat -fdiagnostics-color=always -pipe 
>> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include 
>> rte_config.h -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -fPIC 
>> -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 
>> 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tab
>> le.c.o' -MF 
>> 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tab
>> le.c.o.d' -o 
>> 'drivers/a715181@@tmp_rte_common_dpaax@sta/common_dpaax_dpaax_iova_tab
>> le.c.o' -c ../drivers/common/dpaax/dpaax_iova_table.c
>> In file included from ../drivers/common/dpaax/dpaax_iova_table.c:8:0:
>> ../drivers/common/dpaax/dpaax_iova_table.c: In function ‘read_memory_node’:
>> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>>                                        ^
>> ../drivers/common/dpaax/dpaax_iova_table.c:102:2: note: in expansion of macro ‘DPAAX_DEBUG’
>>   DPAAX_DEBUG("Size of device-tree mem node: %lu", statbuf.st_size);
>>   ^
>> ../drivers/common/dpaax/dpaax_logs.h:18:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__off64_t {aka long long int}’ [-Werror=format=]
>>   rte_log(RTE_LOG_DEBUG, dpaax_logger, "dpaax: %s():  " fmt "\n", \
>>                                        ^
>> ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of macro ‘DPAAX_DEBUG’
>>    DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
>>    ^
>> cc1: all warnings being treated as errors [301/1419] Compiling C object 'lib/76b5a35@@rte_pipeline@sta/librte_pipeline_rte_table_action.c.o'.
>> ninja: build stopped: subcommand failed.
>>
> Thanks Yu Ping, I reproduced and applied the commits to fix this. It should be fixed now in RC2 (see other mail). If you could re-run this test to confirm same for you, that would be great.
> 
> Kevin.
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-10 18:39 ` Stokes, Ian
@ 2019-10-11  9:41   ` Kevin Traynor
  0 siblings, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-10-11  9:41 UTC (permalink / raw)
  To: Stokes, Ian, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Jerin Jacob, John McNamara,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 10/10/2019 19:39, Stokes, Ian wrote:
> 
> 
> On 9/13/2019 5:31 PM, Kevin Traynor wrote:
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.3.
>>
>> The planned date for the final release is 9th October.
>>
>> Please help with testing and validation of your use cases and report
>> any issues/results in reply to this mail. For the final release the
>> fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>      https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin Traynor
> 
> Hi Kevin,
> 
> I've validated with current head OVS Master, 2.12.2 and OVS 2.11.3 with 
> VSPERF.
> Tested with i40e (X710), i40eVF, ixgbe (82599ES), ixgbeVF, igb(I350) and 
> igbVF devices.
> 
> Following tests were conducted and passed:
> 
> * vswitch_p2p_tput: vSwitch - configure switch and execute RFC2544 
> throughput test.
> * vswitch_p2p_cont: vSwitch - configure switch and execute RFC2544 
> continuous stream test.
> * vswitch_pvp_tput: vSwitch - configure switch, vnf and execute RFC2544 
> throughput test.
> * vswitch_pvp_cont: vSwitch - configure switch, vnf and execute RFC2544 
> continuous stream test.
> * ovsdpdk_hotplug_attach: Ensure successful port-add after binding a 
> device to igb_uio after ovs-vswitchd is launched.
> * ovsdpdk_mq_p2p_rxqs: Setup rxqs on NIC port.
> * ovsdpdk_mq_pvp_rxqs: Setup rxqs on vhost user port.
> * ovsdpdk_mq_pvp_rxqs_linux_bridge: Confirm traffic received over vhost 
> RXQs with Linux virtio device in guest.
> * ovsdpdk_mq_pvp_rxqs_testpmd: Confirm traffic received over vhost RXQs 
> with DPDK device in guest.
> * ovsdpdk_vhostuser_client: Test vhost-user client mode.
> * ovsdpdk_vhostuser_client_reconnect: Test vhost-user client mode 
> reconnect feature.
> * ovsdpdk_vhostuser_server: Test vhost-user server mode.
> * ovsdpdk_vhostuser_sock_dir: Verify functionality of vhost-sock-dir flag.
> * ovsdpdk_vdev_add_af_packet_pmd: Test addition of port using the 
> af_packet DPDK PMD driver.
> * ovsdpdk_vdev_del_af_packet_pmd: Test deletion of port using the 
> af_packet DPDK PMD driver.
> * ovsdpdk_numa: Test vhost-user NUMA support. Vhostuser PMD threads 
> should migrate to the same numa slot, where QEMU is executed.
> * ovsdpdk_jumbo_p2p: Ensure that jumbo frames are received, processed 
> and forwarded correctly by DPDK physical ports.
> * ovsdpdk_jumbo_pvp: Ensure that jumbo frames are received, processed 
> and forwarded correctly by DPDK vhost-user ports.
> * ovsdpdk_jumbo_p2p_upper_bound: Ensure that jumbo frames above the 
> configured Rx port's MTU are not accepted.
> * ovsdpdk_jumbo_mtu_upper_bound_vport: Verify that the upper bound limit 
> is enforced for OvS DPDK vhost-user ports.
> * ovsdpdk_rate_p2p: Ensure when a user creates a rate limiting physical 
> interface that the traffic is limited to the specified policer rate in a 
> p2p setup.
> * ovsdpdk_rate_pvp: Ensure when a user creates a rate limiting vHost 
> User interface that the traffic is limited to the specified policer rate 
> in a pvp setup.
> * ovsdpdk_qos_p2p: In a p2p setup, ensure when a QoS egress policer is 
> created that the traffic is limited to the specified rate.
> * ovsdpdk_qos_pvp: In a pvp setup, ensure when a QoS egress policer is 
> created that the traffic is limited to the specified rate.
> * phy2phy_scalability: LTD.Scalability.Flows.RFC2544.0PacketLoss
> * phy2phy_scalability_cont: Phy2Phy Scalability Continuous Stream
> * pvp_cont: PVP Continuous Stream
> * pvvp_cont: PVVP Continuous Stream
> * pvpv_cont: Two VMs in parallel with Continuous Stream
> 

Thanks Ian. I might summarize it a bit to shorten and add to the release
notes.

Kevin.

> Regards
> Ian
> 
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
       [not found]   ` <MWHPR21MB083248DEF72934F9291C128B9E970@MWHPR21MB0832.namprd21.prod.outlook.com>
@ 2019-10-11 16:33     ` Ju-Hyoung Lee
  2019-10-11 16:49       ` Luca Boccassi
  2019-10-11 21:19       ` Kevin Traynor
  0 siblings, 2 replies; 30+ messages in thread
From: Ju-Hyoung Lee @ 2019-10-11 16:33 UTC (permalink / raw)
  To: Abhishek Marathe, Kevin Traynor, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen,
	Ju-Hyoung Lee

Is there any other partners have done DPDK performance test with different OS distro?
I wonder if this is distro-specific or Azure-specific.

Ju

-----Original Message-----
From: Abhishek Marathe <Abhishek.Marathe@microsoft.com> 
Sent: Friday, October 11, 2019 9:30 AM
To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
Subject: RE: 18.11.3 (LTS) patches review and test

Hi All,

Our Findings while testing DPDK 18.11.3-rc2 release:
1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
2. We are getting low performance for Ubuntu distribution failed testcases.

Test Result:

DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
Tested with Mellanox and netvsc poll-mode drivers.
The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=vcX1Tnc4v8w2RbdL4xNOQbkrvba4R5lyymiznEYj4Dk%3D&amp;reserved=0).

Test case description:

* VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd

* PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2

* DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=w1ShwRLxHcqibCZKwDmyxWjH5AIlz096gLsek4J1zGY%3D&amp;reserved=0
* VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20

* VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
* VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
* VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.

 DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=jy8T4kTBur4KpeCWFix4s5Pr8KiYFnSW9RPS9Cbjz4I%3D&amp;reserved=0. 

Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
* VERIFY-DPDK-OVS: PASSED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED 
* PERF-DPDK-FWD-PPS-DS15: FAILED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
* PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
* VERIFY-DPDK-OVS: PASSED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: FAILED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
* PERF-DPDK-MULTICORE-PPS-DS15: ABORTED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: PASSED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
* VERIFY-DPDK-OVS: SKIPPED 
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
* PERF-DPDK-FWD-PPS-DS15: PASSED 
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
* VERIFY-DPDK-COMPLIANCE: PASSED 
* VERIFY-DPDK-RING-LATENCY: PASSED 

Regards,
Abhishek

-----Original Message-----
From: Kevin Traynor <ktraynor@redhat.com> 
Sent: Thursday, October 3, 2019 6:21 AM
To: stable@dpdk.org
Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
Subject: 18.11.3 (LTS) patches review and test

Hi all,

Here is a list of patches targeted for LTS release 18.11.3. 

The planned date for the final release is 14th October.

Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
As such, I would expect that most RC1 testing is still valid and does not need to be repeated.

Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=ZFrDBkGh1jgKt7h8jEqv7BtZ%2FhGvPH7xGw%2B6vvGHk4o%3D&amp;reserved=0

These patches are located at branch 18.11 of dpdk-stable repo:
    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=BqMqA%2FKc%2BOg%2FNrXO%2Bf1k0Vqw5xjONqqYVPPh4js2H9M%3D&amp;reserved=0

Commits since RC1:
9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c mem: mark unused function in 32-bit builds
7ffe32a15 build: remove unnecessary large file support defines 5c3c20a8a build: enable large file support on 32-bit
5633216d4 net/nfp: disable for 32-bit meson builds
c97d4cd35 build: set RTE_ARCH_64 based on pointer size
86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: enable BSD features visibility for FreeBSD

Thanks.

Kevin Traynor

---
Aaron Conole (2):
      test/flow_classify: fix undefined behavior
      acl: fix undefined behavior of bit shifts

Adam Dybkowski (1):
      compress/zlib: fix error handling

Aideen McLoughlin (1):
      net/pcap: fix possible mbuf double freeing

Ajit Khaparde (6):
      net/bnxt: fix TSO
      net/bnxt: check for error conditions in Tx path
      net/bnxt: fix RSS RETA indirection table ops
      net/bnxt: save the number of EM flow count
      net/bnxt: fix compiler warning
      net/bnxt: remove unnecessary interrupt disable

Akash Saxena (1):
      crypto/openssl: remove useless check before freeing

Ali Alnubani (3):
      examples/ip_fragmentation: fix Tx queues init
      net/mlx5: fix 32-bit build
      doc: fix link about bifurcated model in Linux guide

Amit Gupta (2):
      net/thunderx: fix crash on detach
      app/testpmd: fix latency stats deinit on signal

Anatoly Burakov (4):
      eal/freebsd: fix init completion
      eal/freebsd: fix config creation
      vfio: use contiguous mapping for IOVA as VA mode
      test: enable installing app with meson

Andrew Lee (1):
      net/sfc/base: fix signed/unsigned mismatch

Andrew Rybchenko (16):
      ethdev: fix Tx prepare documentation to use positive errno
      net/atlantic: fix Tx prepare to set positive rte_errno
      net/e1000: fix Tx prepare to set positive rte_errno
      net/enic: fix Tx prepare to set positive rte_errno
      net/fm10k: fix Tx prepare to set positive rte_errno
      net/i40e: fix Tx prepare to set positive rte_errno
      net/iavf: fix Tx prepare to set positive rte_errno
      net/ixgbe: fix Tx prepare to set positive rte_errno
      net/qede: fix Tx prepare to set positive rte_errno
      net/vmxnet3: fix Tx prepare to set positive rte_errno
      ethdev: avoid error on PCI unplug of closed port
      net/sfc: ensure that device is closed on removal
      ethdev: avoid getting uninitialized info for bad port
      net/sfc: fix power of 2 round up when align has smaller type
      net/sfc: fix align to power of 2 when align has smaller type
      net/sfc: unify power of 2 alignment check macro

Andrius Sirvys (2):
      usertools: replace unsafe input function
      usertools: fix input handling in telemetry script

Andy Pei (1):
      net/i40e: fix crash when TxQ/RxQ set to 0 in VF

Ankur Dwivedi (1):
      app/crypto-perf: fix CSV format

Arek Kusztal (2):
      crypto/openssl: fix usage of non constant time memcmp
      crypto/openssl: fix free of asymmetric crypto keys

Asaf Penso (2):
      net/mlx5: fix condition for link update fallback
      net/mlx5: check memory allocation in flow creation

Bao-Long Tran (2):
      examples/l3fwd-vf: remove unused Rx/Tx configuration
      doc: remove useless Rx configuration in l2fwd guide

Bernard Iremonger (1):
      flow_classify: fix out-of-bounds access

Bruce Richardson (11):
      examples: fix make clean when using pkg-config
      kernel/freebsd: fix module build on latest head
      test: add rawdev autotest to meson
      examples: fix pkg-config detection with older make
      doc: fix build with latest meson
      build: set RTE_ARCH_64 based on pointer size
      net/nfp: disable for 32-bit meson builds
      build: enable large file support on 32-bit
      build: remove unnecessary large file support defines
      mem: mark unused function in 32-bit builds
      build: add libatomic dependency for 32-bit clang

Chenbo Xia (1):
      crypto/virtio: check PCI config read

Congwen Zhang (1):
      net/ixgbe/base: fix product version check

David Harton (1):
      net/ena: fix admin CQ polling for 32-bit

David Hunt (2):
      examples/power: fix FreeBSD meson lib dependency
      examples/power: fix strcpy buffer overrun

David Marchand (27):
      net/cxgbe: do not dereference global config struct
      examples/multi_process: do not dereference global config struct
      examples/qos_sched: do not dereference global config struct
      test/hash: use existing lcore API
      examples/multi_process: fix FreeBSD build
      net/virtio: remove useless check on mempool
      net/i40e: fix dropped packets statistics name
      examples/vdpa: remove trace of legacy linuxapp
      test/hash: fix off-by-one check on core count
      eal: hide internal hotplug function
      vfio: remove incorrect experimental tag
      mem: remove incorrect experimental tag on static symbol
      telemetry: add missing header include
      net/bnx2x: fix invalid free on unplug
      drivers/net: fix double free on init failure
      mem: fix typo in API description
      kni: abort when IOVA is not PA
      net/pcap: fix Rx with small buffers
      net/pcap: fix Tx return count in error conditions
      app/testpmd: fix eth packet dump for small buffers
      app/testpmd: rename ambiguous VF config variable
      eal: fix control thread affinity with --lcores
      test: remove link to ixgbe/i40e with meson
      eal: hide internal function
      bus/pci: remove unused x86 Linux constant
      net/pcap: fix concurrent multiseg Tx
      ethdev: fix endian annotation for SPI item

Dekel Peled (8):
      net/mlx5: fix missing validation of null pointer
      net/mlx5: fix description of return value
      net/mlx5: fix memory free on queue create error
      net/mlx5: fix order of items in NEON scatter
      doc: fix ethernet addresses in flow API guide
      net/mlx5: fix typos in comments
      net/mlx5: remove redundant item from union
      net/mlx5: fix validation of VLAN PCP item

Dharmik Thakkar (1):
      test/hash: rectify slave id to point to valid cores

Dilshod Urazov (7):
      net/virtio: add Tx preparation
      net/virtio: move VLAN tag insertion to Tx prepare
      examples/ipsec-secgw: fix error sign
      eventdev: fix error sign
      event/sw: fix error sign
      event/opdl: fix error sign
      net: adjust L2 length on soft VLAN insertion

Ed Czeck (1):
      net/ark: fix queue packet replacement

Erik Gabriel Carrillo (1):
      examples/performance-thread: init timer subsystem

Fan Zhang (3):
      examples/vhost_crypto: remove unused function
      vhost/crypto: fix logically dead code
      vhost/crypto: fix inferred misuse of enum

Ferruh Yigit (5):
      telemetry: fix build
      kni: fix segmented mbuf data overflow
      cryptodev: fix typo in comment
      security: remove duplicated symbols from map file
      igb_uio: fix build on Linux 5.3 for fall through

Fiona Trahe (1):
      doc: clarify data plane error handling in compressdev

Flavia Musatescu (1):
      telemetry: fix build warnings seen when using gcc 9

Gagandeep Singh (1):
      eal: increase maximum different hugepage sizes on Arm

Gage Eads (1):
      doc: add a note for multi-process in mempool guide

Gautam Dawar (1):
      net/sfc/base: enable chained multicast on all EF10 cards

Gosia Bakota (1):
      crypto/qat: set message field to zero in sym SGL case

Haiyue Wang (3):
      net/ixgbevf: add full link status check option
      app/testpmd: fix parsing RSS queue rule
      examples/tep_term: remove duplicate definitions

Hariprasad Govindharajan (1):
      examples/l3fwd: fix unaligned memory access on x86

Harman Kalra (3):
      test/distributor: fix flush with worker shutdown
      distributor: fix check of workers number
      examples/ptpclient: fix delay request message

Hemant Agrawal (5):
      crypto/dpaa2_sec: fix handling of session init failure
      net/dpaa: check multi-segment external buffers
      net/dpaa: fix build with 0 headroom
      bus/fslmc: fix build with 0 headroom
      net/virtio: fix build with 0 headroom

Herakliusz Lipiec (3):
      test: fix autotest crash
      mk: fix custom kernel directory name
      net/i40e: fix MAC removal check

Honnappa Nagarahalli (2):
      test/hash: fix data reset on new run
      hash: use ordered loads only if signature matches

Igor Ryzhov (1):
      kernel/linux: fix modules install path

Ilya Maximets (1):
      eal: fix positive error codes from probe/remove

Ivan Malov (2):
      net: fix encapsulation markers for inner L3 offset
      net: fix how L4 checksum choice is tested

Jananee Parthasarathy (1):
      table: fix crash in LPM IPv6

Jay Ding (1):
      net/bnxt: check invalid VNIC id for firmware

Jerin Jacob (4):
      acl: fix build with some arm64 compiler
      eventdev: fix doxygen comment
      net/virtio: fix build
      devtools: fix building kernel component tags

John Daley (2):
      net/enic: remove flow count action support
      net/enic: remove flow locks

Joyce Kong (2):
      test/rwlock: benchmark on all available cores
      test/rwlock: amortize the cost of getting time

Kalesh AP (15):
      net/bnxt: fix xstats
      net/bnxt: fix crash on probe failure
      net/bnxt: fix enabling/disabling interrupts
      net/bnxt: check invalid VNIC in cleanup path
      net/bnxt: fix error handling in port start
      net/bnxt: fix check of address mapping
      net/bnxt: fix adding MAC address
      net/bnxt: fix unconditional wait in link update
      net/bnxt: fix setting primary MAC address
      net/bnxt: fix device init error path
      net/bnxt: reset filters before registering interrupts
      net/bnxt: fix return values to standard error codes
      net/bnxt: fix lock release on getting NVM info
      net/bnxt: fix checking result of HWRM command
      net/bnxt: reduce verbosity of a message

Kevin Traynor (1):
      version: 18.11.3-rc1

Konstantin Ananyev (6):
      bpf: fix pseudo calls for program loaded from ELF
      ip_frag: fix IPv6 fragment size calculation
      bpf: fix check array size
      bpf: fix validate for function return value
      examples/ip_frag: fix unknown ethernet type
      examples/bpf: fix build

Krzysztof Kanas (1):
      eal: fix typo in comments

Lance Richardson (6):
      net/bnxt: fix endianness in ring macros
      net/bnxt: fix ring type macro name
      net/bnxt: fix variable width in endian conversion
      net/bnxt: fix Tx hang after port stop/start
      net/bnxt: retry IRQ callback deregistration
      net/bnxt: fix getting statistics

Liang Ma (1):
      distributor: fix livelock on flush

Liron Himi (1):
      net/mvneta: fix ierror statistics

Lu Qiuwen (1):
      net/fm10k: fix stats crash in multi-process

Luo Gaoliang (1):
      kni: fix build on RHEL8

Maciej Bielski (1):
      net/ena: fix L4 checksum Tx offload

Marcin Smoczynski (1):
      build: enable BSD features visibility for FreeBSD

Marcin Zapolski (4):
      examples: fix use of ethdev internal device array
      examples/ipsec-secgw: fix use of ethdev internal struct
      examples/ip_frag: fix use of ethdev internal device array
      examples/ip_frag: fix stale content of ethdev info

Mariusz Drost (2):
      net/ixgbe: fix IP type for crypto session
      examples/ipsec-secgw: fix inline modes

Mark Spender (1):
      net/sfc/base: fix shift by more bits than field width

Matan Azrad (1):
      net/mlx5: fix device arguments error detection

Maxime Coquelin (1):
      net/virtio: fix in-order Rx with segmented packet

Michael Santana (1):
      fix off-by-one errors in snprintf

Michal Krawczyk (2):
      net/ena: fix assigning NUMA node to IO queue
      net/ena: fix Rx checksum errors statistics

Mohsin Mazhar Shaikh (1):
      net/netvsc: fix xstats id

Morten Brørup (1):
      net: fix definition of IPv6 traffic class mask

Moti Haimovsky (1):
      net/mlx5: fix crash on null operation

Naresh Kumar PBS (2):
      net/bnxt: fix interrupt vector initialization
      net/bnxt: fix icc build

Nicolas Dichtel (1):
      mem: ease init in a docker container

Nipun Gupta (2):
      event/dpaa2: fix timeout ticks
      net/dpaa2: fix multi-segment Tx

Noa Ezra (1):
      vhost: fix missing include

Pavan Nikhilesh (2):
      app/eventdev: fix order test port creation
      test/eventdev: fix producer core validity checks

Peng Huang (1):
      net/i40e: fix RSS hash update for X722 VF

Qi Zhang (5):
      net/i40e: fix Tx threshold setup
      net/ixgbe: fix Tx threshold setup
      net/i40e: fix unexpected skip FDIR setup
      net/avf: fix Rx bytes stats
      net/avf: fix endless loop

Qingmin Liu (1):
      net/bnxt: fix RxQ count if ntuple filtering is disabled

Rahul Gupta (2):
      net/bnxt: fix L4 checksum error indication in Rx
      net/bnxt: fix interrupt rearm logic

Rasesh Mody (5):
      net/bnx2x: fix reading VF id
      net/bnx2x: fix link events polling for SRIOV
      net/bnx2x: fix fastpath SB allocation for SRIOV
      doc: add co-existence consideration for bnx2x
      doc: add co-existence consideration for qede

Reshma Pattan (1):
      telemetry: fix memory leak

Ruifeng Wang (1):
      doc: fix Linux guide for arm64 cross-compilation

Saleh Alsouqi (2):
      net: define IPv4 IHL and VHL
      app/testpmd: fix MPLS IPv4 encapsulation fields

Santoshkumar Karanappa Rastapur (1):
      net/bnxt: fix extended port counter statistics

Shahed Shaikh (5):
      net/bnx2x: fix packet drop
      net/bnx2x: fix interrupt flood
      net/bnx2x: fix memory leak
      net/bnx2x: fix link state
      net/bnx2x: fix supported max Rx/Tx descriptor count

Somnath Kotur (1):
      net/bnxt: check for null completion ring doorbell

Sriharsha Basavapatna (2):
      net/bnxt: fix Tx batching
      net/bnxt: optimize Tx batching

Stephen Hemminger (36):
      net/atlantic: remove unnecessary cast
      net/ark: remove unnecessary cast
      net/axgbe: remove unnecessary cast
      net/bnxt: remove unnecessary cast
      net/bonding: remove unnecessary cast
      net/cxgbe: remove unnecessary cast
      net/e1000: remove unnecessary cast
      net/ena: remove unnecessary cast
      net/enic: remove unnecessary cast
      net/i40e: remove unnecessary cast
      net/ixgbe: remove unnecessary cast
      net/mlx5: remove unnecessary cast
      net/failsafe: fix reported device info
      bus/pci: fix TOCTOU for sysfs access
      net/netvsc: initialize VF spinlock
      net/i40e: remove empty queue stats mapping set devops
      net/bnx2x: fix warnings from invalid assert
      net/qede: fix warnings from invalid assert
      bus/vmbus: skip non-network devices
      net/netvsc: fix RSS offload settings
      net/netvsc: fix xstats for VF device
      net/netvsc: fix definition of offload values
      compress/isal: fix use after free
      kni: fix copy_from_user failure handling
      kni: fix style
      net/tap: remove redundant declarations
      net/af_packet: remove redundant declaration
      net/vhost: remove redundant declaration
      net/null: remove redundant declaration
      net/pcap: remove redundant declaration
      net/ring: remove redundant declaration
      net/virtio_user: remove redundant declaration
      raw/skeleton: remove redundant declaration
      raw/dpaa2_cmdif: remove redundant declaration
      net/bnxt: fix Rx interrupt vector
      net/mlx4: fix crash on info query in secondary process

Sunil Kumar Kori (1):
      examples/ip_frag: remove Tx fast free offload flag

Thierry Herbelot (5):
      doc: cleanup test removal in armv8 and openssl guides
      crypto/mvsam: fix typo in comment
      doc: fix triplicated typo in prog guides
      doc: fix grammar in prog guides
      drivers: fix typo in NXP comments

Thinh Tran (1):
      raw/skeleton: fix test of attribute set/get

Thomas Monjalon (6):
      doc: robustify PDF build
      doc: fix PDF with greek letter
      doc: fix typo in EAL guide
      eal/linux: fix return after alarm registration failure
      doc: fix PDF build
      doc: update features supported by mlx

Tianfei Zhang (2):
      raw/ifpga/base: fix use of untrusted scalar value
      raw/ifpga/base: fix physical address info

Timothy Redaelli (1):
      usertools: fix refresh binding infos

Ting Xu (1):
      net/avf: fix driver crash when enable TSO

Tiwei Bie (4):
      net/virtio: fix queue memory leak on error
      net/virtio: unmap port IO for legacy device
      net/virtio: unmap device on initialization error
      net/virtio: fix memory leak in in-order Rx

Tom Barbette (1):
      net/mlx5: report imissed statistics

Tomasz Jozwiak (2):
      app/crypto-perf: fix display once detection
      app/crypto-perf: check lcore job failure

Vamsi Attunuru (1):
      test/eal: fix --socket-mem option

Viacheslav Ovsiienko (1):
      app/testpmd: fix show port info routine

Wei Zhao (3):
      app/testpmd: fix offloads config
      app/testpmd: fix queue offload configuration
      net/ixgbe: fix RETA size for VF

Xiao Wang (2):
      net/fm10k: advertise supported RSS hash function
      net/fm10k: fix descriptor filling in vector Tx

Xiao Zhang (6):
      net/i40e: fix SFP X722 with FW4.16
      net/e1000: fix buffer overrun while i219 processing DMA
      net/ixgbe: fix address of first segment
      net/i40e: fix address of first segment
      net/avf: fix address of first segment
      net/fm10k: fix address of first segment

Xiaolong Ye (5):
      eal: correct log for alarm error
      doc: fix typos in flow API guide
      doc: fix a grammar mistake in rawdev guide
      net/i40e: fix ethernet flow rule
      net/i40e: fix flow director rule destroy

Xiaoyu Min (3):
      net/mlx5: fix VLAN inner type matching on DR/DV
      net/mlx5: fix link speed info when link is down
      net/mlx5: fix crash for empty raw encap data

Yangchao Zhou (1):
      kni: fix kernel crash with multi-segments

Yogev Chaimovich (1):
      net/vmxnet3: fix uninitialized variable

Yongseok Koh (1):
      config: disable armv8 crypto extension

Yunjian Wang (1):
      net/ixgbe: fix unexpected link handler

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-11 16:33     ` Ju-Hyoung Lee
@ 2019-10-11 16:49       ` Luca Boccassi
  2019-10-11 21:19       ` Kevin Traynor
  1 sibling, 0 replies; 30+ messages in thread
From: Luca Boccassi @ 2019-10-11 16:49 UTC (permalink / raw)
  To: Ju-Hyoung Lee, Abhishek Marathe, Kevin Traynor, stable,
	Christian Ehrhardt
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
	Thomas Monjalon, yuan.peng, zhaoyan.chen

+Christian from Canonical for the Ubuntu on Azure performance issue

On Fri, 2019-10-11 at 16:33 +0000, Ju-Hyoung Lee wrote:
> Is there any other partners have done DPDK performance test with
> different OS distro?
> I wonder if this is distro-specific or Azure-specific.
> 
> Ju
> 
> -----Original Message-----
> From: Abhishek Marathe <
> Abhishek.Marathe@microsoft.com
> > 
> Sent: Friday, October 11, 2019 9:30 AM
> To: Kevin Traynor <
> ktraynor@redhat.com
> >; 
> stable@dpdk.org
> 
> Cc: 
> dev@dpdk.org
> ; Akhil Goyal <
> akhil.goyal@nxp.com
> >; Ali Alnubani <
> alialnu@mellanox.com
> >; 
> benjamin.walker@intel.com
> ; David Christensen <
> drc@linux.vnet.ibm.com
> >; Hemant Agrawal <
> hemant.agrawal@nxp.com
> >; Ian Stokes <
> ian.stokes@intel.com
> >; Jerin Jacob <
> jerinj@marvell.com
> >; John McNamara <
> john.mcnamara@intel.com
> >; Ju-Hyoung Lee <
> juhlee@microsoft.com
> >; Luca Boccassi <
> bluca@debian.org
> >; Pei Zhang <
> pezhang@redhat.com
> >; 
> pingx.yu@intel.com
> ; 
> qian.q.xu@intel.com
> ; Raslan Darawsheh <
> rasland@mellanox.com
> >; Thomas Monjalon <
> thomas@monjalon.net
> >; 
> yuan.peng@intel.com
> ; 
> zhaoyan.chen@intel.com
> 
> Subject: RE: 18.11.3 (LTS) patches review and test
> 
> Hi All,
> 
> Our Findings while testing DPDK 18.11.3-rc2 release:
> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost
> all the distros. I can reproduce the problem but there are no errors
> in the Kernel logs / Test Execution logs. It seems that failure is
> due to lower performance than threshold. As this testcase was not
> failing for the previous releases, we are going to investigate it
> further.
> 2. We are getting low performance for Ubuntu distribution failed
> testcases.
> 
> Test Result:
> 
> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer
> 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest,
> RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS
> 7.5 latest, SUSE SLES 15 latest.
> Tested with Mellanox and netvsc poll-mode drivers.
> The tests were executed using LISAv2 framework (
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=vcX1Tnc4v8w2RbdL4xNOQbkrvba4R5lyymiznEYj4Dk%3D&amp;reserved=0
> ).
> 
> Test case description:
> 
> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the
> build is successful
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that
> packets can be sent from a VM to another VM
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated
> Networking for the NICs under test and makes sure DPDK works in both
> scenarios
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated
> Networking for the NICs while generating traffic using testpmd
> 
> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using
> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using
> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using
> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using
> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using
> testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
> 
> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=w1ShwRLxHcqibCZKwDmyxWjH5AIlz096gLsek4J1zGY%3D&amp;reserved=0
> 
> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary /
> secondary processes support for DPDK. Runs only on RHEL and Ubuntu
> distros with Linux kernel >= 4.20
> 
> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS
> DPDK ports can be created. Runs only on Ubuntu distro.
> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP
> ports are present. Runs only on RHEL and Ubuntu distros.
> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the
> functional tests from the NFF-GO repository. Runs only on Ubuntu
> distro.
> 
>  DPDK job exited with status: UNSTABLE - 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=jy8T4kTBur4KpeCWFix4s5Pr8KiYFnSW9RPS9Cbjz4I%3D&amp;reserved=0
> . 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical
> UbuntuServer 16.04-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: PASSED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED 
> * PERF-DPDK-FWD-PPS-DS15: FAILED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical
> UbuntuServer 18.04-DAILY-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: PASSED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: FAILED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-
> RAW latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL
> 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic
> CentOS 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: PASSED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15
> latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Regards,
> Abhishek
> 
> -----Original Message-----
> From: Kevin Traynor <
> ktraynor@redhat.com
> > 
> Sent: Thursday, October 3, 2019 6:21 AM
> To: 
> stable@dpdk.org
> 
> Cc: 
> dev@dpdk.org
> ; Abhishek Marathe <
> Abhishek.Marathe@microsoft.com
> >; Akhil Goyal <
> akhil.goyal@nxp.com
> >; Ali Alnubani <
> alialnu@mellanox.com
> >; 
> benjamin.walker@intel.com
> ; David Christensen <
> drc@linux.vnet.ibm.com
> >; Hemant Agrawal <
> hemant.agrawal@nxp.com
> >; Ian Stokes <
> ian.stokes@intel.com
> >; Jerin Jacob <
> jerinj@marvell.com
> >; John McNamara <
> john.mcnamara@intel.com
> >; Ju-Hyoung Lee <
> juhlee@microsoft.com
> >; Kevin Traynor <
> ktraynor@redhat.com
> >; Luca Boccassi <
> bluca@debian.org
> >; Pei Zhang <
> pezhang@redhat.com
> >; 
> pingx.yu@intel.com
> ; 
> qian.q.xu@intel.com
> ; Raslan Darawsheh <
> rasland@mellanox.com
> >; Thomas Monjalon <
> thomas@monjalon.net
> >; 
> yuan.peng@intel.com
> ; 
> zhaoyan.chen@intel.com
> 
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 14th October.
> 
> Please note the commits since RC1 below. They are primarily to
> address some build issues for 32-bit with meson and FreeBSD.
> As such, I would expect that most RC1 testing is still valid and does
> not need to be repeated.
> 
> Please help with testing and validation of your use cases and report
> any issues/results in reply to this mail. For the final release the
> fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=ZFrDBkGh1jgKt7h8jEqv7BtZ%2FhGvPH7xGw%2B6vvGHk4o%3D&amp;reserved=0
> 
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=BqMqA%2FKc%2BOg%2FNrXO%2Bf1k0Vqw5xjONqqYVPPh4js2H9M%3D&amp;reserved=0
> 
> 
> Commits since RC1:
> 9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c
> mem: mark unused function in 32-bit builds
> 7ffe32a15 build: remove unnecessary large file support defines
> 5c3c20a8a build: enable large file support on 32-bit
> 5633216d4 net/nfp: disable for 32-bit meson builds
> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build:
> enable BSD features visibility for FreeBSD
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (11):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
>       build: set RTE_ARCH_64 based on pointer size
>       net/nfp: disable for 32-bit meson builds
>       build: enable large file support on 32-bit
>       build: remove unnecessary large file support defines
>       mem: mark unused function in 32-bit builds
>       build: add libatomic dependency for 32-bit clang
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (27):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
>       ethdev: fix endian annotation for SPI item
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Kevin Traynor (1):
>       version: 18.11.3-rc1
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Smoczynski (1):
>       build: enable BSD features visibility for FreeBSD
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
> 
-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] 18.11.3 (LTS) patches review and test
  2019-10-11 16:33     ` Ju-Hyoung Lee
  2019-10-11 16:49       ` Luca Boccassi
@ 2019-10-11 21:19       ` Kevin Traynor
  2019-10-15 16:21         ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
  1 sibling, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-10-11 21:19 UTC (permalink / raw)
  To: Ju-Hyoung Lee, Abhishek Marathe, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
> Is there any other partners have done DPDK performance test with different OS distro?

There was a few other perf testings reported elsewhere in reply to this
thread and there wasn't other perf drop reported. I only know the distro
of the Red Hat testing (RHEL). To summarize,

Intel and IBM reported perf testing, Red Hat did perf testing with
SR-IOV. There was also some OVS perf testing from Ian, but that may be a
little less relevant as there is a lot of OVS involved in the datapath.

Mellanox haven't reported their testing results yet, so seen as you are
using a Mellanox NIC their results may be interesting.

I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf
within 0.06% of 18.11.2.

> I wonder if this is distro-specific or Azure-specific.
> 

These are the netvsc/failsafe changes, in case you wanted to clone the
repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them for
investigating:
$ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e failsafe
822c98c8a net/netvsc: fix definition of offload values
a8a965216 net/netvsc: fix xstats for VF device
9fd8123bd net/netvsc: fix xstats id
ddc352a3f net/netvsc: fix RSS offload settings
ad4093aac net/netvsc: initialize VF spinlock
2f05eb233 net/failsafe: fix reported device info

> Ju
> 
> -----Original Message-----
> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com> 
> Sent: Friday, October 11, 2019 9:30 AM
> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: RE: 18.11.3 (LTS) patches review and test
> 
> Hi All,
> 
> Our Findings while testing DPDK 18.11.3-rc2 release:
> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.

What is Standard_F32s_v2? What is the result and the threshold?

thanks,
Kevin.

> 2. We are getting low performance for Ubuntu distribution failed testcases.
> 
> Test Result:
> 
> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
> Tested with Mellanox and netvsc poll-mode drivers.
> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=vcX1Tnc4v8w2RbdL4xNOQbkrvba4R5lyymiznEYj4Dk%3D&amp;reserved=0).
> 
> Test case description:
> 
> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd
> 
> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
> 
> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=w1ShwRLxHcqibCZKwDmyxWjH5AIlz096gLsek4J1zGY%3D&amp;reserved=0
> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
> 
> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
> 
>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=jy8T4kTBur4KpeCWFix4s5Pr8KiYFnSW9RPS9Cbjz4I%3D&amp;reserved=0. 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: PASSED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED 
> * PERF-DPDK-FWD-PPS-DS15: FAILED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: PASSED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: FAILED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: PASSED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
> * VERIFY-DPDK-OVS: SKIPPED 
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
> * PERF-DPDK-FWD-PPS-DS15: PASSED 
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
> * VERIFY-DPDK-COMPLIANCE: PASSED 
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Regards,
> Abhishek
> 
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com> 
> Sent: Thursday, October 3, 2019 6:21 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 14th October.
> 
> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
> 
> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=ZFrDBkGh1jgKt7h8jEqv7BtZ%2FhGvPH7xGw%2B6vvGHk4o%3D&amp;reserved=0
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=BqMqA%2FKc%2BOg%2FNrXO%2Bf1k0Vqw5xjONqqYVPPh4js2H9M%3D&amp;reserved=0
> 
> Commits since RC1:
> 9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c mem: mark unused function in 32-bit builds
> 7ffe32a15 build: remove unnecessary large file support defines 5c3c20a8a build: enable large file support on 32-bit
> 5633216d4 net/nfp: disable for 32-bit meson builds
> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: enable BSD features visibility for FreeBSD
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (11):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
>       build: set RTE_ARCH_64 based on pointer size
>       net/nfp: disable for 32-bit meson builds
>       build: enable large file support on 32-bit
>       build: remove unnecessary large file support defines
>       mem: mark unused function in 32-bit builds
>       build: add libatomic dependency for 32-bit clang
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (27):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
>       ethdev: fix endian annotation for SPI item
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Kevin Traynor (1):
>       version: 18.11.3-rc1
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Smoczynski (1):
>       build: enable BSD features visibility for FreeBSD
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-11 21:19       ` Kevin Traynor
@ 2019-10-15 16:21         ` Kevin Traynor
  2019-10-15 17:12           ` Abhishek Marathe
  0 siblings, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-10-15 16:21 UTC (permalink / raw)
  To: Ju-Hyoung Lee, Abhishek Marathe, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 11/10/2019 22:19, Kevin Traynor wrote:
> On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
>> Is there any other partners have done DPDK performance test with different OS distro?
> 
> There was a few other perf testings reported elsewhere in reply to this
> thread and there wasn't other perf drop reported. I only know the distro
> of the Red Hat testing (RHEL). To summarize,
> 
> Intel and IBM reported perf testing, Red Hat did perf testing with
> SR-IOV. There was also some OVS perf testing from Ian, but that may be a
> little less relevant as there is a lot of OVS involved in the datapath.
> 
> Mellanox haven't reported their testing results yet, so seen as you are
> using a Mellanox NIC their results may be interesting.
> 
> I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf
> within 0.06% of 18.11.2.
> 
>> I wonder if this is distro-specific or Azure-specific.
>>
> 
> These are the netvsc/failsafe changes, in case you wanted to clone the
> repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them for
> investigating:
> $ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e failsafe
> 822c98c8a net/netvsc: fix definition of offload values
> a8a965216 net/netvsc: fix xstats for VF device
> 9fd8123bd net/netvsc: fix xstats id
> ddc352a3f net/netvsc: fix RSS offload settings
> ad4093aac net/netvsc: initialize VF spinlock
> 2f05eb233 net/failsafe: fix reported device info
> 

Hi Abishek/Ju,

Any update on this issue? Were you able to bisect to which commit is
causing an issue in your tests?

thanks,
Kevin.

>> Ju
>>
>> -----Original Message-----
>> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com> 
>> Sent: Friday, October 11, 2019 9:30 AM
>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: RE: 18.11.3 (LTS) patches review and test
>>
>> Hi All,
>>
>> Our Findings while testing DPDK 18.11.3-rc2 release:
>> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
> 
> What is Standard_F32s_v2? What is the result and the threshold?
> 
> thanks,
> Kevin.
> 
>> 2. We are getting low performance for Ubuntu distribution failed testcases.
>>
>> Test Result:
>>
>> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>> Tested with Mellanox and netvsc poll-mode drivers.
>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=vcX1Tnc4v8w2RbdL4xNOQbkrvba4R5lyymiznEYj4Dk%3D&amp;reserved=0).
>>
>> Test case description:
>>
>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd
>>
>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>
>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=w1ShwRLxHcqibCZKwDmyxWjH5AIlz096gLsek4J1zGY%3D&amp;reserved=0
>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
>>
>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>
>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=jy8T4kTBur4KpeCWFix4s5Pr8KiYFnSW9RPS9Cbjz4I%3D&amp;reserved=0. 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
>> * VERIFY-DPDK-OVS: PASSED 
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED 
>> * PERF-DPDK-FWD-PPS-DS15: FAILED 
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED 
>> * VERIFY-DPDK-COMPLIANCE: PASSED 
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
>> * VERIFY-DPDK-OVS: PASSED 
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
>> * PERF-DPDK-FWD-PPS-DS15: FAILED 
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED 
>> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED 
>> * VERIFY-DPDK-COMPLIANCE: PASSED 
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED 
>> * VERIFY-DPDK-OVS: SKIPPED 
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
>> * PERF-DPDK-FWD-PPS-DS15: PASSED 
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
>> * VERIFY-DPDK-COMPLIANCE: PASSED 
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
>> * VERIFY-DPDK-OVS: SKIPPED 
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED 
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
>> * PERF-DPDK-FWD-PPS-DS15: PASSED 
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
>> * VERIFY-DPDK-COMPLIANCE: PASSED 
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
>> * VERIFY-DPDK-OVS: SKIPPED 
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED 
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
>> * PERF-DPDK-FWD-PPS-DS15: PASSED 
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
>> * VERIFY-DPDK-COMPLIANCE: PASSED 
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED 
>> * VERIFY-DPDK-OVS: SKIPPED 
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED 
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED 
>> * PERF-DPDK-FWD-PPS-DS15: PASSED 
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED 
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED 
>> * VERIFY-DPDK-COMPLIANCE: PASSED 
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Regards,
>> Abhishek
>>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com> 
>> Sent: Thursday, October 3, 2019 6:21 AM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: 18.11.3 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.3. 
>>
>> The planned date for the final release is 14th October.
>>
>> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
>> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
>>
>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=ZFrDBkGh1jgKt7h8jEqv7BtZ%2FhGvPH7xGw%2B6vvGHk4o%3D&amp;reserved=0
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7Cjuhlee%40microsoft.com%7C8ad50d4d779c486a550e08d74e68350b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637064081778210151&amp;sdata=BqMqA%2FKc%2BOg%2FNrXO%2Bf1k0Vqw5xjONqqYVPPh4js2H9M%3D&amp;reserved=0
>>
>> Commits since RC1:
>> 9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c mem: mark unused function in 32-bit builds
>> 7ffe32a15 build: remove unnecessary large file support defines 5c3c20a8a build: enable large file support on 32-bit
>> 5633216d4 net/nfp: disable for 32-bit meson builds
>> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
>> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: enable BSD features visibility for FreeBSD
>>
>> Thanks.
>>
>> Kevin Traynor
>>
>> ---

[snipped list of patches]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-15 16:21         ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
@ 2019-10-15 17:12           ` Abhishek Marathe
  2019-10-15 17:19             ` Kevin Traynor
  2019-10-17 13:54             ` Christian Ehrhardt
  0 siblings, 2 replies; 30+ messages in thread
From: Abhishek Marathe @ 2019-10-15 17:12 UTC (permalink / raw)
  To: Kevin Traynor, Ju-Hyoung Lee, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

Hi Kevin,

We tried reverting all netvsc and failsafe patches, still we got the same results. We are still looking into it.
"PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower than threshold.
Following performance is observed in distros other than Ubuntu and RHEL 7 (because it passed):-
16 core rxonly mode with same 28% negative variation : expected 18000000 pps actual around 12800000 pps. We have threshold of 20% negative variation.

Test results:

DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
Tested with Mellanox and netvsc poll-mode drivers.
The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=1nxpxqOUbZzUknXi99LdF%2BLLZ901lCqjzoZAUGMUUPU%3D&amp;reserved=0).

Test case description:

* VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd

* PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2

* DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=VU1ms4jZJBEwXry21gBrYb7vS%2FeNfcmUs6c601c1%2F3U%3D&amp;reserved=0
* VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20

* VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
* VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
* VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.

 DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F265%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=r2bbhp1Fol8w0wUZl0aYczdBI0BF21TmQ%2BpYpx%2BGRlc%3D&amp;reserved=0. 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
* VERIFY-DPDK-OVS: PASSED
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
* PERF-DPDK-MULTICORE-PPS-F32: FAILED
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
* PERF-DPDK-FWD-PPS-DS15: FAILED
* PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
* PERF-DPDK-MULTICORE-PPS-DS15: FAILED
* VERIFY-DPDK-COMPLIANCE: PASSED
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
* VERIFY-DPDK-OVS: PASSED
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
* PERF-DPDK-MULTICORE-PPS-F32: FAILED
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
* PERF-DPDK-FWD-PPS-DS15: FAILED
* PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
* PERF-DPDK-MULTICORE-PPS-DS15: FAILED
* VERIFY-DPDK-COMPLIANCE: PASSED
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
* VERIFY-DPDK-OVS: SKIPPED
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
* PERF-DPDK-MULTICORE-PPS-F32: PASSED
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
* PERF-DPDK-FWD-PPS-DS15: PASSED
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED
* VERIFY-DPDK-COMPLIANCE: PASSED
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
* VERIFY-DPDK-OVS: SKIPPED
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: ABORTED
* PERF-DPDK-MULTICORE-PPS-F32: FAILED
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
* PERF-DPDK-FWD-PPS-DS15: PASSED
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED
* VERIFY-DPDK-COMPLIANCE: PASSED
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
* VERIFY-DPDK-OVS: SKIPPED
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
* PERF-DPDK-MULTICORE-PPS-F32: FAILED
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
* PERF-DPDK-FWD-PPS-DS15: PASSED
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED
* VERIFY-DPDK-COMPLIANCE: PASSED
* VERIFY-DPDK-RING-LATENCY: PASSED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
 
* PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
* VERIFY-DPDK-OVS: SKIPPED
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
* PERF-DPDK-MULTICORE-PPS-F32: FAILED
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
* PERF-DPDK-FWD-PPS-DS15: PASSED
* PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
* PERF-DPDK-MULTICORE-PPS-DS15: PASSED
* VERIFY-DPDK-COMPLIANCE: PASSED
* VERIFY-DPDK-RING-LATENCY: PASSED 


Thank you,
Jenkins DPDK
Regards,
Abhishek

-----Original Message-----
From: Kevin Traynor <ktraynor@redhat.com> 
Sent: Tuesday, October 15, 2019 9:21 AM
To: Ju-Hyoung Lee <juhlee@microsoft.com>; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
Subject: Re: [dpdk-stable] 18.11.3 (LTS) patches review and test

On 11/10/2019 22:19, Kevin Traynor wrote:
> On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
>> Is there any other partners have done DPDK performance test with different OS distro?
> 
> There was a few other perf testings reported elsewhere in reply to 
> this thread and there wasn't other perf drop reported. I only know the 
> distro of the Red Hat testing (RHEL). To summarize,
> 
> Intel and IBM reported perf testing, Red Hat did perf testing with 
> SR-IOV. There was also some OVS perf testing from Ian, but that may be 
> a little less relevant as there is a lot of OVS involved in the datapath.
> 
> Mellanox haven't reported their testing results yet, so seen as you 
> are using a Mellanox NIC their results may be interesting.
> 
> I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf 
> within 0.06% of 18.11.2.
> 
>> I wonder if this is distro-specific or Azure-specific.
>>
> 
> These are the netvsc/failsafe changes, in case you wanted to clone the 
> repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them for
> investigating:
> $ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e 
> failsafe 822c98c8a net/netvsc: fix definition of offload values
> a8a965216 net/netvsc: fix xstats for VF device 9fd8123bd net/netvsc: 
> fix xstats id ddc352a3f net/netvsc: fix RSS offload settings ad4093aac 
> net/netvsc: initialize VF spinlock
> 2f05eb233 net/failsafe: fix reported device info
> 

Hi Abishek/Ju,

Any update on this issue? Were you able to bisect to which commit is causing an issue in your tests?

thanks,
Kevin.

>> Ju
>>
>> -----Original Message-----
>> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
>> Sent: Friday, October 11, 2019 9:30 AM
>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee 
>> <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan 
>> Darawsheh <rasland@mellanox.com>; Thomas Monjalon 
>> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: RE: 18.11.3 (LTS) patches review and test
>>
>> Hi All,
>>
>> Our Findings while testing DPDK 18.11.3-rc2 release:
>> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
> 
> What is Standard_F32s_v2? What is the result and the threshold?
> 
> thanks,
> Kevin.
> 
>> 2. We are getting low performance for Ubuntu distribution failed testcases.
>>
>> Test Result:
>>
>> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>> Tested with Mellanox and netvsc poll-mode drivers.
>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=zmkLCvFLaWCmKujGviwjn%2BZVOY6HjvG3Xqp%2BL%2Br0Vl4%3D&amp;reserved=0).
>>
>> Test case description:
>>
>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the 
>> build is successful
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>> packets can be sent from a VM to another VM
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>> Networking for the NICs under test and makes sure DPDK works in both 
>> scenarios
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated 
>> Networking for the NICs while generating traffic using testpmd
>>
>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using 
>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>
>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek
>> .Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988b
>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=D4EY
>> eIZp%2BZQAD99LzXRBOeq3wV%2BqBJ0C4PsUTdYz7oU%3D&amp;reserved=0
>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>> distros with Linux kernel >= 4.20
>>
>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>
>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0g%2BzRv50M%2BvPlg2fOZ4PQ3nOTDFrB67AArmMoSjSb7M%3D&amp;reserved=0. 
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: PASSED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: PASSED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Regards,
>> Abhishek
>>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Thursday, October 3, 2019 6:21 AM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; 
>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee 
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca 
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: 18.11.3 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.3. 
>>
>> The planned date for the final release is 14th October.
>>
>> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
>> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
>>
>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpd
>> k.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02
>> %7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d751
>> 8bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63706753276396218
>> 2&amp;sdata=XrHRXebU80U1nj6wudFJFNfhtQG1n%2BiIFdMNVT8HTXA%3D&amp;rese
>> rved=0
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>     
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpd
>> k.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%4
>> 0microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af9
>> 1ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0BhLiCZ04ikQsW
>> y5%2BANbJXyasNCJAA62zdtAKQFrZcM%3D&amp;reserved=0
>>
>> Commits since RC1:
>> 9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c 
>> mem: mark unused function in 32-bit builds
>> 7ffe32a15 build: remove unnecessary large file support defines 
>> 5c3c20a8a build: enable large file support on 32-bit
>> 5633216d4 net/nfp: disable for 32-bit meson builds
>> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
>> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: 
>> enable BSD features visibility for FreeBSD
>>
>> Thanks.
>>
>> Kevin Traynor
>>
>> ---

[snipped list of patches]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-15 17:12           ` Abhishek Marathe
@ 2019-10-15 17:19             ` Kevin Traynor
  2019-10-22 10:52               ` Kevin Traynor
  2019-10-17 13:54             ` Christian Ehrhardt
  1 sibling, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-10-15 17:19 UTC (permalink / raw)
  To: Abhishek Marathe, Ju-Hyoung Lee, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 15/10/2019 18:12, Abhishek Marathe wrote:
> Hi Kevin,
> 
> We tried reverting all netvsc and failsafe patches, still we got the same results. We are still looking into it.
> "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower than threshold.
> Following performance is observed in distros other than Ubuntu and RHEL 7 (because it passed):-
> 16 core rxonly mode with same 28% negative variation : expected 18000000 pps actual around 12800000 pps. We have threshold of 20% negative variation.
> 

Ok, thanks. Have you confirmed that it is caused by a commit(s) between
18.11.2 and 18.11.3-rc2, and not some other environmental change? i.e.
did you retest 18.11.2 with the current setup.

> Test results:
> 
> DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
> Tested with Mellanox and netvsc poll-mode drivers.
> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=1nxpxqOUbZzUknXi99LdF%2BLLZ901lCqjzoZAUGMUUPU%3D&amp;reserved=0).
> 
> Test case description:
> 
> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd
> 
> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
> 
> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=VU1ms4jZJBEwXry21gBrYb7vS%2FeNfcmUs6c601c1%2F3U%3D&amp;reserved=0
> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
> 
> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
> 
>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F265%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=r2bbhp1Fol8w0wUZl0aYczdBI0BF21TmQ%2BpYpx%2BGRlc%3D&amp;reserved=0. 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
> * VERIFY-DPDK-OVS: PASSED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
> * PERF-DPDK-FWD-PPS-DS15: FAILED
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
> * VERIFY-DPDK-COMPLIANCE: PASSED
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
> * VERIFY-DPDK-OVS: PASSED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
> * PERF-DPDK-FWD-PPS-DS15: FAILED
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
> * VERIFY-DPDK-COMPLIANCE: PASSED
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
> * VERIFY-DPDK-OVS: SKIPPED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
> * PERF-DPDK-FWD-PPS-DS15: PASSED
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
> * VERIFY-DPDK-COMPLIANCE: PASSED
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
> * VERIFY-DPDK-OVS: SKIPPED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: ABORTED
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
> * PERF-DPDK-FWD-PPS-DS15: PASSED
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
> * VERIFY-DPDK-COMPLIANCE: PASSED
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
> * VERIFY-DPDK-OVS: SKIPPED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
> * PERF-DPDK-FWD-PPS-DS15: PASSED
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
> * VERIFY-DPDK-COMPLIANCE: PASSED
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
>  
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
> * VERIFY-DPDK-OVS: SKIPPED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
> * PERF-DPDK-FWD-PPS-DS15: PASSED
> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
> * VERIFY-DPDK-COMPLIANCE: PASSED
> * VERIFY-DPDK-RING-LATENCY: PASSED 
> 
> 
> Thank you,
> Jenkins DPDK
> Regards,
> Abhishek
> 
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com> 
> Sent: Tuesday, October 15, 2019 9:21 AM
> To: Ju-Hyoung Lee <juhlee@microsoft.com>; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: Re: [dpdk-stable] 18.11.3 (LTS) patches review and test
> 
> On 11/10/2019 22:19, Kevin Traynor wrote:
>> On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
>>> Is there any other partners have done DPDK performance test with different OS distro?
>>
>> There was a few other perf testings reported elsewhere in reply to 
>> this thread and there wasn't other perf drop reported. I only know the 
>> distro of the Red Hat testing (RHEL). To summarize,
>>
>> Intel and IBM reported perf testing, Red Hat did perf testing with 
>> SR-IOV. There was also some OVS perf testing from Ian, but that may be 
>> a little less relevant as there is a lot of OVS involved in the datapath.
>>
>> Mellanox haven't reported their testing results yet, so seen as you 
>> are using a Mellanox NIC their results may be interesting.
>>
>> I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf 
>> within 0.06% of 18.11.2.
>>
>>> I wonder if this is distro-specific or Azure-specific.
>>>
>>
>> These are the netvsc/failsafe changes, in case you wanted to clone the 
>> repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them for
>> investigating:
>> $ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e 
>> failsafe 822c98c8a net/netvsc: fix definition of offload values
>> a8a965216 net/netvsc: fix xstats for VF device 9fd8123bd net/netvsc: 
>> fix xstats id ddc352a3f net/netvsc: fix RSS offload settings ad4093aac 
>> net/netvsc: initialize VF spinlock
>> 2f05eb233 net/failsafe: fix reported device info
>>
> 
> Hi Abishek/Ju,
> 
> Any update on this issue? Were you able to bisect to which commit is causing an issue in your tests?
> 
> thanks,
> Kevin.
> 
>>> Ju
>>>
>>> -----Original Message-----
>>> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
>>> Sent: Friday, October 11, 2019 9:30 AM
>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee 
>>> <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>>> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan 
>>> Darawsheh <rasland@mellanox.com>; Thomas Monjalon 
>>> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>>> Subject: RE: 18.11.3 (LTS) patches review and test
>>>
>>> Hi All,
>>>
>>> Our Findings while testing DPDK 18.11.3-rc2 release:
>>> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
>>
>> What is Standard_F32s_v2? What is the result and the threshold?
>>
>> thanks,
>> Kevin.
>>
>>> 2. We are getting low performance for Ubuntu distribution failed testcases.
>>>
>>> Test Result:
>>>
>>> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>>> Tested with Mellanox and netvsc poll-mode drivers.
>>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=zmkLCvFLaWCmKujGviwjn%2BZVOY6HjvG3Xqp%2BL%2Br0Vl4%3D&amp;reserved=0).
>>>
>>> Test case description:
>>>
>>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the 
>>> build is successful
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>>> packets can be sent from a VM to another VM
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>>> Networking for the NICs under test and makes sure DPDK works in both 
>>> scenarios
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated 
>>> Networking for the NICs while generating traffic using testpmd
>>>
>>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using 
>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>>
>>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek
>>> .Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988b
>>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=D4EY
>>> eIZp%2BZQAD99LzXRBOeq3wV%2BqBJ0C4PsUTdYz7oU%3D&amp;reserved=0
>>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>>> distros with Linux kernel >= 4.20
>>>
>>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>>
>>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0g%2BzRv50M%2BvPlg2fOZ4PQ3nOTDFrB67AArmMoSjSb7M%3D&amp;reserved=0. 
>>>
>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: PASSED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: PASSED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Regards,
>>> Abhishek
>>>
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Thursday, October 3, 2019 6:21 AM
>>> To: stable@dpdk.org
>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; 
>>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee 
>>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca 
>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>> Subject: 18.11.3 (LTS) patches review and test
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for LTS release 18.11.3. 
>>>
>>> The planned date for the final release is 14th October.
>>>
>>> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
>>> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
>>>
>>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>>     
>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpd
>>> k.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02
>>> %7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d751
>>> 8bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63706753276396218
>>> 2&amp;sdata=XrHRXebU80U1nj6wudFJFNfhtQG1n%2BiIFdMNVT8HTXA%3D&amp;rese
>>> rved=0
>>>
>>> These patches are located at branch 18.11 of dpdk-stable repo:
>>>     
>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpd
>>> k.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%4
>>> 0microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af9
>>> 1ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0BhLiCZ04ikQsW
>>> y5%2BANbJXyasNCJAA62zdtAKQFrZcM%3D&amp;reserved=0
>>>
>>> Commits since RC1:
>>> 9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c 
>>> mem: mark unused function in 32-bit builds
>>> 7ffe32a15 build: remove unnecessary large file support defines 
>>> 5c3c20a8a build: enable large file support on 32-bit
>>> 5633216d4 net/nfp: disable for 32-bit meson builds
>>> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
>>> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: 
>>> enable BSD features visibility for FreeBSD
>>>
>>> Thanks.
>>>
>>> Kevin Traynor
>>>
>>> ---
> 
> [snipped list of patches]
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-15 17:12           ` Abhishek Marathe
  2019-10-15 17:19             ` Kevin Traynor
@ 2019-10-17 13:54             ` Christian Ehrhardt
  2019-10-20 13:16               ` Ali Alnubani
  1 sibling, 1 reply; 30+ messages in thread
From: Christian Ehrhardt @ 2019-10-17 13:54 UTC (permalink / raw)
  To: Abhishek Marathe
  Cc: Kevin Traynor, Ju-Hyoung Lee, stable, dev, Akhil Goyal,
	Ali Alnubani, benjamin.walker, David Christensen, Hemant Agrawal,
	Ian Stokes, Jerin Jacob, John McNamara, Luca Boccassi, Pei Zhang,
	pingx.yu, qian.q.xu, Raslan Darawsheh, Thomas Monjalon,
	yuan.peng, zhaoyan.chen

Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest':
>
> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
> * VERIFY-DPDK-OVS: PASSED
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED

Hi Abhishek,
since you use the daily LTS image and see such a significant change
compared to before, could it by any chance be that this made you
switch from kernel 4.15 to 5.0.
Because by the normal HWE policy [1] this got into Bionic rebuilds and
it seems [2] the same is true for linux-azure kernel flavours.

Could you check your logs if the kernel version changed between the
old and the new runs?
An alternative might be to rerun 18.11.2 to see if it drops as well,
which might indicate that it wasn't 18.11.2 -> 18.11.3 but something
else like the kernel.

Not sure if that old kernel is ok, but you always can go back to what
a version was released with. So in this case
package linux-azure=4.15.0.1009.9 is still there and you could try
18.11.3 with that maybe?

Let me know if you need help changing kernels there.

[1]: https://wiki.ubuntu.com/Kernel/LTSEnablementStack
[2]: https://launchpad.net/ubuntu/+source/linux-azure/+publishinghistory

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-17 13:54             ` Christian Ehrhardt
@ 2019-10-20 13:16               ` Ali Alnubani
  2019-10-21  8:54                 ` Kevin Traynor
  0 siblings, 1 reply; 30+ messages in thread
From: Ali Alnubani @ 2019-10-20 13:16 UTC (permalink / raw)
  To: Christian Ehrhardt, Abhishek Marathe, Kevin Traynor,
	Ju-Hyoung Lee, stable, dev, Akhil Goyal, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

Hi,

Replaying here because I can't find the first email in the thread.

Regarding testing results with Mellanox devices, we did basic functional testing with testpmd, and don't see any issues.

Testing matrix:
- NIC: ConnectX-5 / OS: RHEL 7.4 / Kernel: 5.3.0 / Driver: rdma-core v25.1 / fw: 16.26.1040
- NIC: ConnectX-4 Lx / OS: RHEL 7.4 / Kernel: 5.3.0 / Driver: rdma-core v25.1 / fw: 14.26.1040
- NIC: ConnectX-5 / OS: RHEL 7.4 / Kernel: 3.10.0-693.el7.x86_64 / Driver: MLNX_OFED_LINUX-4.7-1.0.0.1 / fw: 16.26.1040
- NIC: ConnectX-4 Lx / OS: RHEL 7.4 / Kernel: 3.10.0-693.el7.x86_64 / Driver: MLNX_OFED_LINUX-4.7-1.0.0.1 / fw: 14.26.1040

I apologize for the delay in reporting our results.

Thanks,
Ali

> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Thursday, October 17, 2019 4:55 PM
> To: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; stable@dpdk.org; dev@dpdk.org; Akhil Goyal
> <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan
> Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
> 
> Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest':
> >
> > * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
> > * VERIFY-DPDK-OVS: PASSED
> > * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
> > * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
> > * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> 
> Hi Abhishek,
> since you use the daily LTS image and see such a significant change compared
> to before, could it by any chance be that this made you switch from kernel
> 4.15 to 5.0.
> Because by the normal HWE policy [1] this got into Bionic rebuilds and it
> seems [2] the same is true for linux-azure kernel flavours.
> 
> Could you check your logs if the kernel version changed between the old and
> the new runs?
> An alternative might be to rerun 18.11.2 to see if it drops as well, which might
> indicate that it wasn't 18.11.2 -> 18.11.3 but something else like the kernel.
> 
> Not sure if that old kernel is ok, but you always can go back to what a version
> was released with. So in this case package linux-azure=4.15.0.1009.9 is still
> there and you could try
> 18.11.3 with that maybe?
> 
> Let me know if you need help changing kernels there.
> 
> [1]:
<removed>
> [2]:
<removed>

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-20 13:16               ` Ali Alnubani
@ 2019-10-21  8:54                 ` Kevin Traynor
  0 siblings, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-10-21  8:54 UTC (permalink / raw)
  To: Ali Alnubani, Christian Ehrhardt, Abhishek Marathe,
	Ju-Hyoung Lee, stable, dev, Akhil Goyal, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 20/10/2019 14:16, Ali Alnubani wrote:
> Hi,
> 
> Replaying here because I can't find the first email in the thread.
> 
> Regarding testing results with Mellanox devices, we did basic functional testing with testpmd, and don't see any issues.
> 
> Testing matrix:
> - NIC: ConnectX-5 / OS: RHEL 7.4 / Kernel: 5.3.0 / Driver: rdma-core v25.1 / fw: 16.26.1040
> - NIC: ConnectX-4 Lx / OS: RHEL 7.4 / Kernel: 5.3.0 / Driver: rdma-core v25.1 / fw: 14.26.1040
> - NIC: ConnectX-5 / OS: RHEL 7.4 / Kernel: 3.10.0-693.el7.x86_64 / Driver: MLNX_OFED_LINUX-4.7-1.0.0.1 / fw: 16.26.1040
> - NIC: ConnectX-4 Lx / OS: RHEL 7.4 / Kernel: 3.10.0-693.el7.x86_64 / Driver: MLNX_OFED_LINUX-4.7-1.0.0.1 / fw: 14.26.1040
> 
> I apologize for the delay in reporting our results.
> 

No problems, thanks for the testing Ali,

Kevin.

> Thanks,
> Ali
> 
>> -----Original Message-----
>> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>> Sent: Thursday, October 17, 2019 4:55 PM
>> To: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
>> Cc: Kevin Traynor <ktraynor@redhat.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; stable@dpdk.org; dev@dpdk.org; Akhil Goyal
>> <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan
>> Darawsheh <rasland@mellanox.com>; Thomas Monjalon
>> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
>>
>> Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest':
>>>
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: PASSED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>
>> Hi Abhishek,
>> since you use the daily LTS image and see such a significant change compared
>> to before, could it by any chance be that this made you switch from kernel
>> 4.15 to 5.0.
>> Because by the normal HWE policy [1] this got into Bionic rebuilds and it
>> seems [2] the same is true for linux-azure kernel flavours.
>>
>> Could you check your logs if the kernel version changed between the old and
>> the new runs?
>> An alternative might be to rerun 18.11.2 to see if it drops as well, which might
>> indicate that it wasn't 18.11.2 -> 18.11.3 but something else like the kernel.
>>
>> Not sure if that old kernel is ok, but you always can go back to what a version
>> was released with. So in this case package linux-azure=4.15.0.1009.9 is still
>> there and you could try
>> 18.11.3 with that maybe?
>>
>> Let me know if you need help changing kernels there.
>>
>> [1]:
> <removed>
>> [2]:
> <removed>
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-15 17:19             ` Kevin Traynor
@ 2019-10-22 10:52               ` Kevin Traynor
  2019-10-22 17:44                 ` Abhishek Marathe
  0 siblings, 1 reply; 30+ messages in thread
From: Kevin Traynor @ 2019-10-22 10:52 UTC (permalink / raw)
  To: Abhishek Marathe, Ju-Hyoung Lee, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 15/10/2019 18:19, Kevin Traynor wrote:
> On 15/10/2019 18:12, Abhishek Marathe wrote:
>> Hi Kevin,
>>
>> We tried reverting all netvsc and failsafe patches, still we got the same results. We are still looking into it.
>> "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower than threshold.
>> Following performance is observed in distros other than Ubuntu and RHEL 7 (because it passed):-
>> 16 core rxonly mode with same 28% negative variation : expected 18000000 pps actual around 12800000 pps. We have threshold of 20% negative variation.
>>
> 
> Ok, thanks. Have you confirmed that it is caused by a commit(s) between
> 18.11.2 and 18.11.3-rc2, and not some other environmental change? i.e.
> did you retest 18.11.2 with the current setup.
> 

Hi Abhishek/Ju,

Can you give an update on status of your testing? I would like to make
the release this week and this is the only outstanding issue.

thanks,
Kevin.

>> Test results:
>>
>> DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>> Tested with Mellanox and netvsc poll-mode drivers.
>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=1nxpxqOUbZzUknXi99LdF%2BLLZ901lCqjzoZAUGMUUPU%3D&amp;reserved=0).
>>
>> Test case description:
>>
>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd
>>
>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>
>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=VU1ms4jZJBEwXry21gBrYb7vS%2FeNfcmUs6c601c1%2F3U%3D&amp;reserved=0
>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
>>
>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>
>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F265%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=r2bbhp1Fol8w0wUZl0aYczdBI0BF21TmQ%2BpYpx%2BGRlc%3D&amp;reserved=0. 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: PASSED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451974543&amp;sdata=bhHZIahnW%2Fg5Zg8YAZg7lWiuaEHZrigvw3YxaWxrGqo%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: PASSED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: ABORTED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C62f11281c4244341cabd08d750c75a6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066689451984541&amp;sdata=UGLL41Ifhr0s5pukWcAdwJHryLa%2Bd%2FMRu3Aj1kWZFs8%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED 
>>
>>
>> Thank you,
>> Jenkins DPDK
>> Regards,
>> Abhishek
>>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com> 
>> Sent: Tuesday, October 15, 2019 9:21 AM
>> To: Ju-Hyoung Lee <juhlee@microsoft.com>; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: Re: [dpdk-stable] 18.11.3 (LTS) patches review and test
>>
>> On 11/10/2019 22:19, Kevin Traynor wrote:
>>> On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
>>>> Is there any other partners have done DPDK performance test with different OS distro?
>>>
>>> There was a few other perf testings reported elsewhere in reply to 
>>> this thread and there wasn't other perf drop reported. I only know the 
>>> distro of the Red Hat testing (RHEL). To summarize,
>>>
>>> Intel and IBM reported perf testing, Red Hat did perf testing with 
>>> SR-IOV. There was also some OVS perf testing from Ian, but that may be 
>>> a little less relevant as there is a lot of OVS involved in the datapath.
>>>
>>> Mellanox haven't reported their testing results yet, so seen as you 
>>> are using a Mellanox NIC their results may be interesting.
>>>
>>> I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf 
>>> within 0.06% of 18.11.2.
>>>
>>>> I wonder if this is distro-specific or Azure-specific.
>>>>
>>>
>>> These are the netvsc/failsafe changes, in case you wanted to clone the 
>>> repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them for
>>> investigating:
>>> $ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e 
>>> failsafe 822c98c8a net/netvsc: fix definition of offload values
>>> a8a965216 net/netvsc: fix xstats for VF device 9fd8123bd net/netvsc: 
>>> fix xstats id ddc352a3f net/netvsc: fix RSS offload settings ad4093aac 
>>> net/netvsc: initialize VF spinlock
>>> 2f05eb233 net/failsafe: fix reported device info
>>>
>>
>> Hi Abishek/Ju,
>>
>> Any update on this issue? Were you able to bisect to which commit is causing an issue in your tests?
>>
>> thanks,
>> Kevin.
>>
>>>> Ju
>>>>
>>>> -----Original Message-----
>>>> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
>>>> Sent: Friday, October 11, 2019 9:30 AM
>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>>>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee 
>>>> <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>>>> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan 
>>>> Darawsheh <rasland@mellanox.com>; Thomas Monjalon 
>>>> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>> Subject: RE: 18.11.3 (LTS) patches review and test
>>>>
>>>> Hi All,
>>>>
>>>> Our Findings while testing DPDK 18.11.3-rc2 release:
>>>> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
>>>
>>> What is Standard_F32s_v2? What is the result and the threshold?
>>>
>>> thanks,
>>> Kevin.
>>>
>>>> 2. We are getting low performance for Ubuntu distribution failed testcases.
>>>>
>>>> Test Result:
>>>>
>>>> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>>>> Tested with Mellanox and netvsc poll-mode drivers.
>>>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=zmkLCvFLaWCmKujGviwjn%2BZVOY6HjvG3Xqp%2BL%2Br0Vl4%3D&amp;reserved=0).
>>>>
>>>> Test case description:
>>>>
>>>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the 
>>>> build is successful
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>>>> packets can be sent from a VM to another VM
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>>>> Networking for the NICs under test and makes sure DPDK works in both 
>>>> scenarios
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated 
>>>> Networking for the NICs while generating traffic using testpmd
>>>>
>>>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using 
>>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>>>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>>>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>>>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>>>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>>>
>>>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek
>>>> .Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988b
>>>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=D4EY
>>>> eIZp%2BZQAD99LzXRBOeq3wV%2BqBJ0C4PsUTdYz7oU%3D&amp;reserved=0
>>>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>>>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>>>> distros with Linux kernel >= 4.20
>>>>
>>>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>>>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>>>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>>>
>>>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0g%2BzRv50M%2BvPlg2fOZ4PQ3nOTDFrB67AArmMoSjSb7M%3D&amp;reserved=0. 
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>> * VERIFY-DPDK-OVS: PASSED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>> * VERIFY-DPDK-OVS: PASSED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Regards,
>>>> Abhishek
>>>>
>>>> -----Original Message-----
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Thursday, October 3, 2019 6:21 AM
>>>> To: stable@dpdk.org
>>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; 
>>>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>>>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee 
>>>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca 
>>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>>>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>> Subject: 18.11.3 (LTS) patches review and test
>>>>
>>>> Hi all,
>>>>
>>>> Here is a list of patches targeted for LTS release 18.11.3. 
>>>>
>>>> The planned date for the final release is 14th October.
>>>>
>>>> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
>>>> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
>>>>
>>>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>>>
>>>> A release candidate tarball can be found at:
>>>>
>>>>     
>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpd
>>>> k.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=02
>>>> %7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d751
>>>> 8bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63706753276396218
>>>> 2&amp;sdata=XrHRXebU80U1nj6wudFJFNfhtQG1n%2BiIFdMNVT8HTXA%3D&amp;rese
>>>> rved=0
>>>>
>>>> These patches are located at branch 18.11 of dpdk-stable repo:
>>>>     
>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpd
>>>> k.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%4
>>>> 0microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141af9
>>>> 1ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0BhLiCZ04ikQsW
>>>> y5%2BANbJXyasNCJAA62zdtAKQFrZcM%3D&amp;reserved=0
>>>>
>>>> Commits since RC1:
>>>> 9e7c637c6 build: add libatomic dependency for 32-bit clang 6c576d41c 
>>>> mem: mark unused function in 32-bit builds
>>>> 7ffe32a15 build: remove unnecessary large file support defines 
>>>> 5c3c20a8a build: enable large file support on 32-bit
>>>> 5633216d4 net/nfp: disable for 32-bit meson builds
>>>> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
>>>> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: 
>>>> enable BSD features visibility for FreeBSD
>>>>
>>>> Thanks.
>>>>
>>>> Kevin Traynor
>>>>
>>>> ---
>>
>> [snipped list of patches]
>>
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-22 10:52               ` Kevin Traynor
@ 2019-10-22 17:44                 ` Abhishek Marathe
  2019-10-22 18:02                   ` Kevin Traynor
  0 siblings, 1 reply; 30+ messages in thread
From: Abhishek Marathe @ 2019-10-22 17:44 UTC (permalink / raw)
  To: Kevin Traynor, Ju-Hyoung Lee, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

Hi Kevin,

We ran DPDK 18.11.2 and 18.11.3-rc1 and got the same results for both that is “PERF-DPDK-MULTICORE-PPS-F32” failed. With the current situation it seems like Multicore and DPDK 18.11.3 does not work well on Azure. 
There are no errors in DPDK execution logs or Kernel logs. We are still investigating it, but it seems that it will require some more time.

DPDK 18.11.2:

DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=VSWkBVcgTeyqzs1SPtL624etiv58NJY9UAoWhVKG5iQ%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
Tested with Mellanox and netvsc poll-mode drivers.
The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=c3nJGjFDIkHDJHHVf9YVQchiMBfUMsS4poU9nc3imaM%3D&amp;reserved=0).

Test case description:

* VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
* VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd

* PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2

* DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=KY05YV4%2Fbdubb5%2BPojdzrWDahLOhEk4m8arpCgZjkcw%3D&amp;reserved=0
* VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20

* VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
* VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
* VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.

DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F272%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=7p5RNaK5LU49TsOeFsKbMUGh0hjfA4nFSFT8SQS%2Bf%2BM%3D&amp;reserved=0. 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED 

Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
 
* PERF-DPDK-MULTICORE-PPS-F32: FAILED


Regards,
Abhishek

-----Original Message-----
From: Kevin Traynor <ktraynor@redhat.com> 
Sent: Tuesday, October 22, 2019 3:52 AM
To: Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; stable@dpdk.org
Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test

On 15/10/2019 18:19, Kevin Traynor wrote:
> On 15/10/2019 18:12, Abhishek Marathe wrote:
>> Hi Kevin,
>>
>> We tried reverting all netvsc and failsafe patches, still we got the same results. We are still looking into it.
>> "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower than threshold.
>> Following performance is observed in distros other than Ubuntu and 
>> RHEL 7 (because it passed):-
>> 16 core rxonly mode with same 28% negative variation : expected 18000000 pps actual around 12800000 pps. We have threshold of 20% negative variation.
>>
> 
> Ok, thanks. Have you confirmed that it is caused by a commit(s) 
> between
> 18.11.2 and 18.11.3-rc2, and not some other environmental change? i.e.
> did you retest 18.11.2 with the current setup.
> 

Hi Abhishek/Ju,

Can you give an update on status of your testing? I would like to make the release this week and this is the only outstanding issue.

thanks,
Kevin.

>> Test results:
>>
>> DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461919756&amp;sdata=puzoZYcYWi4TNRQvT5Es03NIb7HJkHfHAg9A5fIoEMM%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>> Tested with Mellanox and netvsc poll-mode drivers.
>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461919756&amp;sdata=UqmEbpt0HgYtSw24A%2BY1oYr8MXcpWtZh%2BCCUo9NaPPw%3D&amp;reserved=0).
>>
>> Test case description:
>>
>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the 
>> build is successful
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>> packets can be sent from a VM to another VM
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>> Networking for the NICs under test and makes sure DPDK works in both 
>> scenarios
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated 
>> Networking for the NICs while generating traffic using testpmd
>>
>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using 
>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>
>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7Cabhishek
>> .marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988b
>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461919756&amp;sdata=3ogG
>> hJ7hNtrJ4dyS7pwHM34z%2FUbndjyloAPHDCu7mHw%3D&amp;reserved=0
>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>> distros with Linux kernel >= 4.20
>>
>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>
>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F265%2F&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=I0fGO3hEd5ucxXp9LTsXPPxMGZpxaGDP%2F0%2Fg1kPSRRA%3D&amp;reserved=0. 
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: PASSED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: PASSED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: ABORTED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
>>  
>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>> * VERIFY-DPDK-OVS: SKIPPED
>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>> * VERIFY-DPDK-COMPLIANCE: PASSED
>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>
>>
>> Thank you,
>> Jenkins DPDK
>> Regards,
>> Abhishek
>>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, October 15, 2019 9:21 AM
>> To: Ju-Hyoung Lee <juhlee@microsoft.com>; Abhishek Marathe 
>> <Abhishek.Marathe@microsoft.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>> John McNamara <john.mcnamara@intel.com>; Luca Boccassi 
>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: Re: [dpdk-stable] 18.11.3 (LTS) patches review and test
>>
>> On 11/10/2019 22:19, Kevin Traynor wrote:
>>> On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
>>>> Is there any other partners have done DPDK performance test with different OS distro?
>>>
>>> There was a few other perf testings reported elsewhere in reply to 
>>> this thread and there wasn't other perf drop reported. I only know 
>>> the distro of the Red Hat testing (RHEL). To summarize,
>>>
>>> Intel and IBM reported perf testing, Red Hat did perf testing with 
>>> SR-IOV. There was also some OVS perf testing from Ian, but that may 
>>> be a little less relevant as there is a lot of OVS involved in the datapath.
>>>
>>> Mellanox haven't reported their testing results yet, so seen as you 
>>> are using a Mellanox NIC their results may be interesting.
>>>
>>> I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf 
>>> within 0.06% of 18.11.2.
>>>
>>>> I wonder if this is distro-specific or Azure-specific.
>>>>
>>>
>>> These are the netvsc/failsafe changes, in case you wanted to clone 
>>> the repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them 
>>> for
>>> investigating:
>>> $ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e 
>>> failsafe 822c98c8a net/netvsc: fix definition of offload values
>>> a8a965216 net/netvsc: fix xstats for VF device 9fd8123bd net/netvsc: 
>>> fix xstats id ddc352a3f net/netvsc: fix RSS offload settings 
>>> ad4093aac
>>> net/netvsc: initialize VF spinlock
>>> 2f05eb233 net/failsafe: fix reported device info
>>>
>>
>> Hi Abishek/Ju,
>>
>> Any update on this issue? Were you able to bisect to which commit is causing an issue in your tests?
>>
>> thanks,
>> Kevin.
>>
>>>> Ju
>>>>
>>>> -----Original Message-----
>>>> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
>>>> Sent: Friday, October 11, 2019 9:30 AM
>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David 
>>>> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal 
>>>> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin 
>>>> Jacob <jerinj@marvell.com>; John McNamara 
>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; 
>>>> Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>>>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>> Subject: RE: 18.11.3 (LTS) patches review and test
>>>>
>>>> Hi All,
>>>>
>>>> Our Findings while testing DPDK 18.11.3-rc2 release:
>>>> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
>>>
>>> What is Standard_F32s_v2? What is the result and the threshold?
>>>
>>> thanks,
>>> Kevin.
>>>
>>>> 2. We are getting low performance for Ubuntu distribution failed testcases.
>>>>
>>>> Test Result:
>>>>
>>>> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>>>> Tested with Mellanox and netvsc poll-mode drivers.
>>>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=ZqU%2BisNUy3igA3jsh7ec%2BTGvltt4ybJ%2BLSEphYSTj2s%3D&amp;reserved=0).
>>>>
>>>> Test case description:
>>>>
>>>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that 
>>>> the build is successful
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>>>> packets can be sent from a VM to another VM
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>>>> Networking for the NICs under test and makes sure DPDK works in 
>>>> both scenarios
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables 
>>>> Accelerated Networking for the NICs while generating traffic using 
>>>> testpmd
>>>>
>>>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance 
>>>> using testpmd on 2, 4, 8 cores, rx and io mode on size 
>>>> Standard_DS15_v2
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>>>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>>>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>>>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>>>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size 
>>>> Standard_F32s_v2
>>>>
>>>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>> it 
>>>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhish
>>>> ek 
>>>> .Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f98
>>>> 8b 
>>>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=D4
>>>> EY
>>>> eIZp%2BZQAD99LzXRBOeq3wV%2BqBJ0C4PsUTdYz7oU%3D&amp;reserved=0
>>>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>>>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>>>> distros with Linux kernel >= 4.20
>>>>
>>>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>>>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>>>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>>>
>>>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=PjLppgF7wDdSinQ3gc8ZorcgHgE3viHMAOU1KIllrXQ%3D&amp;reserved=0. 
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>> * VERIFY-DPDK-OVS: PASSED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>> * VERIFY-DPDK-OVS: PASSED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>>>>  
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>
>>>> Regards,
>>>> Abhishek
>>>>
>>>> -----Original Message-----
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Thursday, October 3, 2019 6:21 AM
>>>> To: stable@dpdk.org
>>>> Cc: dev@dpdk.org; Abhishek Marathe 
>>>> <Abhishek.Marathe@microsoft.com>; Akhil Goyal 
>>>> <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; 
>>>> benjamin.walker@intel.com; David Christensen 
>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob 
>>>> <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; 
>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor 
>>>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>>>> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; 
>>>> Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon 
>>>> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>> Subject: 18.11.3 (LTS) patches review and test
>>>>
>>>> Hi all,
>>>>
>>>> Here is a list of patches targeted for LTS release 18.11.3. 
>>>>
>>>> The planned date for the final release is 14th October.
>>>>
>>>> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
>>>> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
>>>>
>>>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>>>
>>>> A release candidate tarball can be found at:
>>>>
>>>>     
>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd
>>>> pd
>>>> k.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=
>>>> 02
>>>> %7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7
>>>> 51
>>>> 8bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962
>>>> 18 
>>>> 2&amp;sdata=XrHRXebU80U1nj6wudFJFNfhtQG1n%2BiIFdMNVT8HTXA%3D&amp;re
>>>> se
>>>> rved=0
>>>>
>>>> These patches are located at branch 18.11 of dpdk-stable repo:
>>>>     
>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd
>>>> pd
>>>> k.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe
>>>> %4
>>>> 0microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141a
>>>> f9 
>>>> 1ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0BhLiCZ04ikQ
>>>> sW
>>>> y5%2BANbJXyasNCJAA62zdtAKQFrZcM%3D&amp;reserved=0
>>>>
>>>> Commits since RC1:
>>>> 9e7c637c6 build: add libatomic dependency for 32-bit clang 
>>>> 6c576d41c
>>>> mem: mark unused function in 32-bit builds
>>>> 7ffe32a15 build: remove unnecessary large file support defines 
>>>> 5c3c20a8a build: enable large file support on 32-bit
>>>> 5633216d4 net/nfp: disable for 32-bit meson builds
>>>> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
>>>> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: 
>>>> enable BSD features visibility for FreeBSD
>>>>
>>>> Thanks.
>>>>
>>>> Kevin Traynor
>>>>
>>>> ---
>>
>> [snipped list of patches]
>>
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
  2019-10-22 17:44                 ` Abhishek Marathe
@ 2019-10-22 18:02                   ` Kevin Traynor
  0 siblings, 0 replies; 30+ messages in thread
From: Kevin Traynor @ 2019-10-22 18:02 UTC (permalink / raw)
  To: Abhishek Marathe, Ju-Hyoung Lee, stable
  Cc: dev, Akhil Goyal, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Luca Boccassi, Pei Zhang, pingx.yu, qian.q.xu,
	Raslan Darawsheh, Thomas Monjalon, yuan.peng, zhaoyan.chen

On 22/10/2019 18:44, Abhishek Marathe wrote:
> Hi Kevin,
> 

Hi Abhishek,

> We ran DPDK 18.11.2 and 18.11.3-rc1 and got the same results for both that is “PERF-DPDK-MULTICORE-PPS-F32” failed. With the current situation it seems like Multicore and DPDK 18.11.3 does not work well on Azure. 

Ok thanks, that confirms that it is not a regression in 18.11.3 but some
change in the environment that is causing (or exposing) the issue.

If you have a fix for DPDK that will restore the performance in the next
few days and it doesn't invalidate the testing from others we can
consider it for 18.11.3. Otherwise, it be can be further investigated
for 18.11.4.

I don't want to hold up the release any more beyond the end of the week
as it is already 2 weeks overdue. Please keep me up to date with any
progress,

thanks,
Kevin.

> There are no errors in DPDK execution logs or Kernel logs. We are still investigating it, but it seems that it will require some more time.
> 
> DPDK 18.11.2:
> 
> DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=VSWkBVcgTeyqzs1SPtL624etiv58NJY9UAoWhVKG5iQ%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
> Tested with Mellanox and netvsc poll-mode drivers.
> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=c3nJGjFDIkHDJHHVf9YVQchiMBfUMsS4poU9nc3imaM%3D&amp;reserved=0).
> 
> Test case description:
> 
> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated Networking for the NICs while generating traffic using testpmd
> 
> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
> 
> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=KY05YV4%2Fbdubb5%2BPojdzrWDahLOhEk4m8arpCgZjkcw%3D&amp;reserved=0
> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
> 
> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
> 
> DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F272%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538510502&amp;sdata=7p5RNaK5LU49TsOeFsKbMUGh0hjfA4nFSFT8SQS%2Bf%2BM%3D&amp;reserved=0. 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>  
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>  
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
>  
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
>  
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
>  
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED 
> 
> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-18.11.2.tar.gz&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7Ccdfa1b1227b949067ee208d7519b042f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067598538520498&amp;sdata=X9m0UCbuquZtc7h22q0G8o82W9wYNMU1wT4n%2F1i1cnI%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
>  
> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
> 
> 
> Regards,
> Abhishek
> 
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com> 
> Sent: Tuesday, October 22, 2019 3:52 AM
> To: Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test
> 
> On 15/10/2019 18:19, Kevin Traynor wrote:
>> On 15/10/2019 18:12, Abhishek Marathe wrote:
>>> Hi Kevin,
>>>
>>> We tried reverting all netvsc and failsafe patches, still we got the same results. We are still looking into it.
>>> "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower than threshold.
>>> Following performance is observed in distros other than Ubuntu and 
>>> RHEL 7 (because it passed):-
>>> 16 core rxonly mode with same 28% negative variation : expected 18000000 pps actual around 12800000 pps. We have threshold of 20% negative variation.
>>>
>>
>> Ok, thanks. Have you confirmed that it is caused by a commit(s) 
>> between
>> 18.11.2 and 18.11.3-rc2, and not some other environmental change? i.e.
>> did you retest 18.11.2 with the current setup.
>>
> 
> Hi Abhishek/Ju,
> 
> Can you give an update on status of your testing? I would like to make the release this week and this is the only outstanding issue.
> 
> thanks,
> Kevin.
> 
>>> Test results:
>>>
>>> DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461919756&amp;sdata=puzoZYcYWi4TNRQvT5Es03NIb7HJkHfHAg9A5fIoEMM%3D&amp;reserved=0 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>>> Tested with Mellanox and netvsc poll-mode drivers.
>>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461919756&amp;sdata=UqmEbpt0HgYtSw24A%2BY1oYr8MXcpWtZh%2BCCUo9NaPPw%3D&amp;reserved=0).
>>>
>>> Test case description:
>>>
>>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the 
>>> build is successful
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>>> packets can be sent from a VM to another VM
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>>> Networking for the NICs under test and makes sure DPDK works in both 
>>> scenarios
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables Accelerated 
>>> Networking for the NICs while generating traffic using testpmd
>>>
>>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using 
>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size Standard_F32s_v2
>>>
>>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7Cabhishek
>>> .marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988b
>>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461919756&amp;sdata=3ogG
>>> hJ7hNtrJ4dyS7pwHM34z%2FUbndjyloAPHDCu7mHw%3D&amp;reserved=0
>>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>>> distros with Linux kernel >= 4.20
>>>
>>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>>
>>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F265%2F&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=I0fGO3hEd5ucxXp9LTsXPPxMGZpxaGDP%2F0%2Fg1kPSRRA%3D&amp;reserved=0. 
>>>
>>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: PASSED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: PASSED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'RedHat RHEL 7.5 latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: ABORTED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>> Test results for DPDK 'https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flisawestus2.blob.core.windows.net%2Ftestcontainer%2Fdpdk-test-18.11.3-rc2.tar.gz&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=JPH8bOqZFupBkPw5WG3O82Q8B65fsJ0I0e6N%2FgMtE4k%3D&amp;reserved=0' and Azure image: 'SUSE SLES 15 latest': 
>>>  
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>> * VERIFY-DPDK-OVS: SKIPPED
>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>
>>>
>>> Thank you,
>>> Jenkins DPDK
>>> Regards,
>>> Abhishek
>>>
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Tuesday, October 15, 2019 9:21 AM
>>> To: Ju-Hyoung Lee <juhlee@microsoft.com>; Abhishek Marathe 
>>> <Abhishek.Marathe@microsoft.com>; stable@dpdk.org
>>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen 
>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; 
>>> John McNamara <john.mcnamara@intel.com>; Luca Boccassi 
>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>> Subject: Re: [dpdk-stable] 18.11.3 (LTS) patches review and test
>>>
>>> On 11/10/2019 22:19, Kevin Traynor wrote:
>>>> On 11/10/2019 17:33, Ju-Hyoung Lee wrote:
>>>>> Is there any other partners have done DPDK performance test with different OS distro?
>>>>
>>>> There was a few other perf testings reported elsewhere in reply to 
>>>> this thread and there wasn't other perf drop reported. I only know 
>>>> the distro of the Red Hat testing (RHEL). To summarize,
>>>>
>>>> Intel and IBM reported perf testing, Red Hat did perf testing with 
>>>> SR-IOV. There was also some OVS perf testing from Ian, but that may 
>>>> be a little less relevant as there is a lot of OVS involved in the datapath.
>>>>
>>>> Mellanox haven't reported their testing results yet, so seen as you 
>>>> are using a Mellanox NIC their results may be interesting.
>>>>
>>>> I've ran some OVS and testpmd tests on RHEL. For testpmd I see perf 
>>>> within 0.06% of 18.11.2.
>>>>
>>>>> I wonder if this is distro-specific or Azure-specific.
>>>>>
>>>>
>>>> These are the netvsc/failsafe changes, in case you wanted to clone 
>>>> the repo (git://dpdk.org/dpdk-stable branch 18.11) and revert them 
>>>> for
>>>> investigating:
>>>> $ git log --oneline  v18.11.2..v18.11.3-rc2 | grep -e netvsc -e 
>>>> failsafe 822c98c8a net/netvsc: fix definition of offload values
>>>> a8a965216 net/netvsc: fix xstats for VF device 9fd8123bd net/netvsc: 
>>>> fix xstats id ddc352a3f net/netvsc: fix RSS offload settings 
>>>> ad4093aac
>>>> net/netvsc: initialize VF spinlock
>>>> 2f05eb233 net/failsafe: fix reported device info
>>>>
>>>
>>> Hi Abishek/Ju,
>>>
>>> Any update on this issue? Were you able to bisect to which commit is causing an issue in your tests?
>>>
>>> thanks,
>>> Kevin.
>>>
>>>>> Ju
>>>>>
>>>>> -----Original Message-----
>>>>> From: Abhishek Marathe <Abhishek.Marathe@microsoft.com>
>>>>> Sent: Friday, October 11, 2019 9:30 AM
>>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>>>> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani 
>>>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David 
>>>>> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal 
>>>>> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin 
>>>>> Jacob <jerinj@marvell.com>; John McNamara 
>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; 
>>>>> Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; 
>>>>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh 
>>>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; 
>>>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>>> Subject: RE: 18.11.3 (LTS) patches review and test
>>>>>
>>>>> Hi All,
>>>>>
>>>>> Our Findings while testing DPDK 18.11.3-rc2 release:
>>>>> 1. PERF-DPDK-MULTICORE-PPS-F32: This testcase is failing for almost all the distros. I can reproduce the problem but there are no errors in the Kernel logs / Test Execution logs. It seems that failure is due to lower performance than threshold. As this testcase was not failing for the previous releases, we are going to investigate it further.
>>>>
>>>> What is Standard_F32s_v2? What is the result and the threshold?
>>>>
>>>> thanks,
>>>> Kevin.
>>>>
>>>>> 2. We are getting low performance for Ubuntu distribution failed testcases.
>>>>>
>>>>> Test Result:
>>>>>
>>>>> DPDK v18.11.3-rc2 was validated on Azure for Canonical UbuntuServer 16.04-LTS latest, Canonical UbuntuServer 18.04-DAILY-LTS latest, RedHat RHEL 7-RAW latest, RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, SUSE SLES 15 latest.
>>>>> Tested with Mellanox and netvsc poll-mode drivers.
>>>>> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=ZqU%2BisNUy3igA3jsh7ec%2BTGvltt4ybJ%2BLSEphYSTj2s%3D&amp;reserved=0).
>>>>>
>>>>> Test case description:
>>>>>
>>>>> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that 
>>>>> the build is successful
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that 
>>>>> packets can be sent from a VM to another VM
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated 
>>>>> Networking for the NICs under test and makes sure DPDK works in 
>>>>> both scenarios
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC - disables/enables 
>>>>> Accelerated Networking for the NICs while generating traffic using 
>>>>> testpmd
>>>>>
>>>>> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance 
>>>>> using testpmd on 2, 4, 8 cores, rx and io mode on size 
>>>>> Standard_DS15_v2
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using 
>>>>> testpmd on 1 core, rx and io mode on size Standard_DS4_v2
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15 - verifies DPDK performance using 
>>>>> testpmd on 1 core, rx and io mode on size Standard_DS15_v2
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using 
>>>>> testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
>>>>> * PERF-DPDK-MULTICORE-PPS-F32 - verifies DPDK performance using 
>>>>> testpmd on 2, 4, 8, 16 cores, rx and io mode on size 
>>>>> Standard_F32s_v2
>>>>>
>>>>> * DPDK-RING-LATENCY - verifies DPDK CPU latency using 
>>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>> it 
>>>>> hub.com%2Fshemminger%2Fdpdk-ring-ping.git&amp;data=02%7C01%7CAbhish
>>>>> ek 
>>>>> .Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f98
>>>>> 8b 
>>>>> f86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=D4
>>>>> EY
>>>>> eIZp%2BZQAD99LzXRBOeq3wV%2BqBJ0C4PsUTdYz7oU%3D&amp;reserved=0
>>>>> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / 
>>>>> secondary processes support for DPDK. Runs only on RHEL and Ubuntu 
>>>>> distros with Linux kernel >= 4.20
>>>>>
>>>>> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
>>>>> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
>>>>> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
>>>>>
>>>>>  DPDK job exited with status: UNSTABLE - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flinuxpipeline.westus2.cloudapp.azure.com%2Fjob%2FDPDK%2Fjob%2Fpipeline-dpdk-validation%2Fjob%2Fmaster%2F252%2F&amp;data=02%7C01%7Cabhishek.marathe%40microsoft.com%7C17f6445f217b444256de08d756ddec3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637073383461929750&amp;sdata=PjLppgF7wDdSinQ3gc8ZorcgHgE3viHMAOU1KIllrXQ%3D&amp;reserved=0. 
>>>>>
>>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 16.04-LTS latest': 
>>>>>  
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>>> * VERIFY-DPDK-OVS: PASSED
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: ABORTED
>>>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15: FAILED
>>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>>
>>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Canonical UbuntuServer 18.04-DAILY-LTS latest': 
>>>>>  
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>>> * VERIFY-DPDK-OVS: PASSED
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>>> * PERF-DPDK-FWD-PPS-DS15: FAILED
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: FAILED
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15: ABORTED
>>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>>
>>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7-RAW latest': 
>>>>>  
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: FAILED
>>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>>
>>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'RedHat RHEL 7.5 latest': 
>>>>>  
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-F32: ABORTED
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>>
>>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'Openlogic CentOS 7.5 latest': 
>>>>>  
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-F32: PASSED
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>>
>>>>> Test results for DPDK 'v18.11.3-rc2' and Azure image: 'SUSE SLES 15 latest': 
>>>>>  
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS4: PASSED
>>>>> * VERIFY-DPDK-OVS: SKIPPED
>>>>> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST: PASSED
>>>>> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-F32: FAILED
>>>>> * VERIFY-DPDK-FAILSAFE-DURING-TRAFFIC: PASSED
>>>>> * PERF-DPDK-FWD-PPS-DS15: PASSED
>>>>> * PERF-DPDK-SINGLE-CORE-PPS-DS15: PASSED
>>>>> * PERF-DPDK-MULTICORE-PPS-DS15: PASSED
>>>>> * VERIFY-DPDK-COMPLIANCE: PASSED
>>>>> * VERIFY-DPDK-RING-LATENCY: PASSED
>>>>>
>>>>> Regards,
>>>>> Abhishek
>>>>>
>>>>> -----Original Message-----
>>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>>> Sent: Thursday, October 3, 2019 6:21 AM
>>>>> To: stable@dpdk.org
>>>>> Cc: dev@dpdk.org; Abhishek Marathe 
>>>>> <Abhishek.Marathe@microsoft.com>; Akhil Goyal 
>>>>> <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; 
>>>>> benjamin.walker@intel.com; David Christensen 
>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; 
>>>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob 
>>>>> <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; 
>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor 
>>>>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang 
>>>>> <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; 
>>>>> Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon 
>>>>> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>>> Subject: 18.11.3 (LTS) patches review and test
>>>>>
>>>>> Hi all,
>>>>>
>>>>> Here is a list of patches targeted for LTS release 18.11.3. 
>>>>>
>>>>> The planned date for the final release is 14th October.
>>>>>
>>>>> Please note the commits since RC1 below. They are primarily to address some build issues for 32-bit with meson and FreeBSD.
>>>>> As such, I would expect that most RC1 testing is still valid and does not need to be repeated.
>>>>>
>>>>> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
>>>>>
>>>>> A release candidate tarball can be found at:
>>>>>
>>>>>     
>>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd
>>>>> pd
>>>>> k.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv18.11.3-rc2&amp;data=
>>>>> 02
>>>>> %7C01%7CAbhishek.Marathe%40microsoft.com%7Ca6f35d7fcb5547dc159e08d7
>>>>> 51
>>>>> 8bb372%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637067532763962
>>>>> 18 
>>>>> 2&amp;sdata=XrHRXebU80U1nj6wudFJFNfhtQG1n%2BiIFdMNVT8HTXA%3D&amp;re
>>>>> se
>>>>> rved=0
>>>>>
>>>>> These patches are located at branch 18.11 of dpdk-stable repo:
>>>>>     
>>>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd
>>>>> pd
>>>>> k.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe
>>>>> %4
>>>>> 0microsoft.com%7Ca6f35d7fcb5547dc159e08d7518bb372%7C72f988bf86f141a
>>>>> f9 
>>>>> 1ab2d7cd011db47%7C1%7C0%7C637067532763962182&amp;sdata=0BhLiCZ04ikQ
>>>>> sW
>>>>> y5%2BANbJXyasNCJAA62zdtAKQFrZcM%3D&amp;reserved=0
>>>>>
>>>>> Commits since RC1:
>>>>> 9e7c637c6 build: add libatomic dependency for 32-bit clang 
>>>>> 6c576d41c
>>>>> mem: mark unused function in 32-bit builds
>>>>> 7ffe32a15 build: remove unnecessary large file support defines 
>>>>> 5c3c20a8a build: enable large file support on 32-bit
>>>>> 5633216d4 net/nfp: disable for 32-bit meson builds
>>>>> c97d4cd35 build: set RTE_ARCH_64 based on pointer size
>>>>> 86e56d5f9 ethdev: fix endian annotation for SPI item d908ee9de build: 
>>>>> enable BSD features visibility for FreeBSD
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Kevin Traynor
>>>>>
>>>>> ---
>>>
>>> [snipped list of patches]
>>>
>>
> 


^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2019-10-23 21:33 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-13 16:31 [dpdk-dev] 18.11.3 (LTS) patches review and test Kevin Traynor
2019-09-19 10:22 ` Yu, PingX
2019-09-19 21:33   ` Ju-Hyoung Lee
2019-09-19 22:44     ` Abhishek Marathe
2019-09-23 16:18       ` Kevin Traynor
2019-09-25 16:06   ` Kevin Traynor
2019-09-26  7:41     ` Yu, PingX
2019-10-03 13:30       ` Kevin Traynor
2019-10-08 10:22         ` Yu, PingX
2019-10-11  9:39           ` Kevin Traynor
2019-10-03 13:20 ` Kevin Traynor
     [not found]   ` <MWHPR21MB083248DEF72934F9291C128B9E970@MWHPR21MB0832.namprd21.prod.outlook.com>
2019-10-11 16:33     ` Ju-Hyoung Lee
2019-10-11 16:49       ` Luca Boccassi
2019-10-11 21:19       ` Kevin Traynor
2019-10-15 16:21         ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
2019-10-15 17:12           ` Abhishek Marathe
2019-10-15 17:19             ` Kevin Traynor
2019-10-22 10:52               ` Kevin Traynor
2019-10-22 17:44                 ` Abhishek Marathe
2019-10-22 18:02                   ` Kevin Traynor
2019-10-17 13:54             ` Christian Ehrhardt
2019-10-20 13:16               ` Ali Alnubani
2019-10-21  8:54                 ` Kevin Traynor
2019-10-04  2:28 ` [dpdk-dev] " Pei Zhang
2019-10-04  9:37   ` Kevin Traynor
2019-10-07 20:01 ` Thinh Tran
2019-10-07 20:11   ` Ju-Hyoung Lee
2019-10-11  9:34   ` Kevin Traynor
2019-10-10 18:39 ` Stokes, Ian
2019-10-11  9:41   ` Kevin Traynor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).