From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 30BC1200 for ; Mon, 18 Dec 2017 19:43:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 10:43:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,423,1508828400"; d="scan'208";a="13672790" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 18 Dec 2017 10:43:36 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Dec 2017 10:43:36 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.21]) by FMSMSX154.amr.corp.intel.com ([169.254.6.52]) with mapi id 14.03.0319.002; Mon, 18 Dec 2017 10:43:36 -0800 From: "Wiles, Keith" To: Adrien Mazarguil CC: "Yigit, Ferruh" , "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality Thread-Index: AQHTeB/faMALlTGZEkWU+e8tKrmfGaNJ2luAgAAPRACAAAx0AA== Date: Mon, 18 Dec 2017 18:43:35 +0000 Message-ID: References: <20171124172132.GW4062@6wind.com> <20171218162443.12971-1-adrien.mazarguil@6wind.com> <20171218162443.12971-3-adrien.mazarguil@6wind.com> <20171218175900.GC4062@6wind.com> In-Reply-To: <20171218175900.GC4062@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.72.149] Content-Type: text/plain; charset="us-ascii" Content-ID: <3D244431BA491B4B8AA4B2746505A0FC@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 18:43:40 -0000 > On Dec 18, 2017, at 11:59 AM, Adrien Mazarguil wrote: >> Not to criticize style, but a few blank lines could help in readability = for these files IMHO. Unless blank lines are illegal :-) >=20 > It's a matter of taste, I think people tend to add random blank lines whe= re > they think doing so clarifies things for themselves, resulting in > inconsistent coding style not much clearer for everyone after several > iterations. >=20 > As a maintainer I've grown tired of discussions related to blank lines wh= ile > reviewing patches. That's why except for a few special cases, I now enfor= ce > exactly the bare minimum of one blank line between variable declarations = and > the rest of the code inside each block. >=20 > If doing so makes a function unreadable then perhaps it needs to be split= :) > I'm sure you'll understand! I do not really understand the problem as I have not seen any complaints ab= out blank lines unless two or more in a row. I have never seen someone comp= lain about a given blank line in a function, unless a missing one to split = up the declared variables and code in a function or block of code. It is a shame you have decided to take the minimum approach to blank lines,= IMO it does not make a lot of sense. I only bring it up to help others wit= h reading your code like our customers. We do not have rule for this so I can not force anyone to add blank lines f= or readability, so I have to live with it. :-( >=20 > Regards, >=20 > --=20 > Adrien Mazarguil > 6WIND Regards, Keith