From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2C95E25D9 for ; Tue, 22 May 2018 22:46:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 13:46:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208";a="43935537" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 22 May 2018 13:46:00 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 May 2018 13:46:00 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 May 2018 13:45:59 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.40]) with mapi id 14.03.0319.002; Wed, 23 May 2018 04:45:58 +0800 From: "Liu, Changpeng" To: Thomas Monjalon CC: "dev@dpdk.org" , Maxime Coquelin Thread-Topic: [dpdk-dev] [PATCH 1/2] examples/vhost_scsi: add virtio-1.0 feature bit support Thread-Index: AQHT7jX9h8zp0FdLREWt+DRRxdi3MaQ05scAgAahswCAAC1DAIAAh9zQ Date: Tue, 22 May 2018 20:45:58 +0000 Message-ID: References: <1526599932-13083-1-git-send-email-changpeng.liu@intel.com> <30363841-11bc-3d43-08c2-7ccd07296a6c@redhat.com> <12946126.f8e536ouzB@xps> <1560362.DyZTV1XtT0@xps> In-Reply-To: <1560362.DyZTV1XtT0@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ2OTQ1NjctNmFiMS00MTA1LWIwOTItMzM2ZjY0ODk5ODNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnRBRzFZVkRxODd1Nmp0ZERiMnlPK2JKVitSWFwvZkZhenVzd3M0VlVVRHdaNVpsajBPdnpXNVp1THJlVUJXcFIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] examples/vhost_scsi: add virtio-1.0 feature bit support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 20:46:02 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, May 22, 2018 1:33 PM > To: Liu, Changpeng > Cc: dev@dpdk.org; Maxime Coquelin > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/vhost_scsi: add virtio-1.0 f= eature > bit support >=20 > 22/05/2018 19:51, Thomas Monjalon: > > 18/05/2018 14:35, Maxime Coquelin: > > > > > > On 05/18/2018 01:32 AM, Changpeng Liu wrote: > > > > Signed-off-by: Changpeng Liu > > > > --- > > > > examples/vhost_scsi/vhost_scsi.c | 7 ++++--- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > Reviewed-by: Maxime Coquelin > > > > Patch 1 applied alone, thanks >=20 > After compilation tests, the patch is not accepted in 18.05, > because VIRTIO_F_VERSION_1 seems not defined on some distributions, > despite the fallback implemented. What a mess for vhost library. :). lib/librte_vhost/vhost.h has the definition VIRTIO_F_VERSION_1 for some old= er kernel,=20 but didn't include in the public API header , looks like we sh= ould move this definition to rte_vhost.h for some old kernels. >=20