From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0074.outbound.protection.outlook.com [104.47.1.74]) by dpdk.org (Postfix) with ESMTP id 416762B9E for ; Sun, 8 Oct 2017 00:19:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OJMK73OCISTVdv7BcFDS90grl++pTVJeF7CvzaRoRYw=; b=XKL7rt6HEN0uaSBYpUeQpHtKID/tn1HNwkIu0Q8DKo1AsThwBMtkR7l0EZEVIgVFKA7qVVK3+CfezAzkk5g+oFq4vOfC7eEMdbzsEhNOPNP2g3MnGY+olyI4k3FwcRs/kbgULJDz79DcEMJ74edx/B5+5Rx3jsQCGI3ewcQln8U= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2048.eurprd05.prod.outlook.com (10.167.195.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 7 Oct 2017 22:19:14 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::84ed:9505:3e7f:9722]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::84ed:9505:3e7f:9722%13]) with mapi id 15.20.0077.018; Sat, 7 Oct 2017 22:19:14 +0000 From: Yongseok Koh To: Martin Weiser CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Ferruh Yigit Thread-Topic: [dpdk-dev] Mellanox ConnectX-5 crashes and mbuf leak Thread-Index: AQHTNqktVwg/YRPpzEiZDb3J3tSb96LV2VeAgAES/ACAAIvqAIABjw0A Date: Sat, 7 Oct 2017 22:19:14 +0000 Message-ID: References: <5d1f07c4-5933-806d-4d11-8fdfabc701d7@allegro-packets.com> <374F8C13-CFB0-42FD-8993-BF7F0401F891@mellanox.com> In-Reply-To: <374F8C13-CFB0-42FD-8993-BF7F0401F891@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2048; 6:4Fwo5RIaHs0CP6e6gxUcr/uEI7GSIbRk7AOHX0XS72Lo2BT3btGkDDmykgzTEf3kZLlQ3oiDjVyM4V0N6IhEBL1nvt1IaYU/I8cHR+Y5X9/7Z8RkNSDpcKo11wqvcKOUKN0cdAG88Oy9Cg7zt4UznFAAZK+oHRdNdIzNujmWqc+u7bpeHvLiSUIrWj66iyj0KAwYbN0r1sJfKLAyCVIKwOaUB2knZK2SRNfobyt4eGhHECEqvV64iYbqLM2mjx/L7+wXdi39FkQV7Sub4l2pBhC5qG6UaiSfWDiH0ucSKGBL1eF+NUHEqxxRQzTJ14yFC1Uptf0C8YZ1r0z3f9FaJw==; 5:dIZXDuh2Mlh3M3fLWGw/g2vpsv4E038QuZ/8L/OdQt50mxYUbszPW+l4l9BZo1BztzWx2C5Hqyc2j00Zal2Uf8S/lJa/kl8wAeuxWcYf4X4yiIRm9zDWRHIx1bZz4S+lbs6ezcVP353RQUAlR3heWw==; 24:/iq86yrXyZQQuYmHg5VHjSOswSJnqXLhS5yiwtqjOdMxciHvpEr1KC9jGoGCPkFkVgo5BaZe5UNLhjSZI8jU+1ey02iCVSAi1E5JxNJ0JPo=; 7:KNl2A2rApRZwg2Qo1Z+ROmjC6oLWUiN2je3m6GBu86brcVp1o1NwEU0rjUZuNm1I52HPj42MwyxRv1iI5MKsPSlDu13Xbg+pEs/ib1yscTBaacc9CnAi1nFB5dxq/DDWePpUSn9cbCGlcYqPp1fwkBFEw8rfoRImrbzi8RYcYLUcdulONz/Orjfno5Xrfo9f/w2MUmrAmhnS1l0t+Unnp06eODj14M84AZEFXetLdMo= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8d477d76-1932-461a-ef72-08d50dd17174 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:VI1PR0501MB2048; x-ms-traffictypediagnostic: VI1PR0501MB2048: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0501MB2048; x-forefront-prvs: 045315E1EE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(377454003)(24454002)(305945005)(7736002)(6506006)(8676002)(6436002)(2900100001)(68736007)(6486002)(93886005)(189998001)(53546010)(229853002)(2950100002)(6916009)(33656002)(102836003)(6306002)(3846002)(66066001)(36756003)(4326008)(6116002)(316002)(5660300001)(14454004)(3660700001)(8936002)(6512007)(3280700002)(82746002)(99286003)(81156014)(81166006)(53936002)(106356001)(105586002)(97736004)(6246003)(1720100001)(25786009)(5890100001)(54906003)(478600001)(5250100002)(101416001)(53376002)(86362001)(83716003)(966005)(2906002)(50986999)(76176999)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <991FBEDDB0E21C4DB3653AE28C90E6A3@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2017 22:19:14.4826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: Re: [dpdk-dev] Mellanox ConnectX-5 crashes and mbuf leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 22:19:17 -0000 > On Oct 6, 2017, at 3:30 PM, Yongseok Koh wrote: >=20 > Hi, Martin >=20 > Even though I had done quite serious tests before sending out the patch, > I figured out deadlock could happen if the Rx queue size is smaller. It i= s 128 > by default in testpmd while I usually use 256. >=20 > I've fixed the bug and submitted a new patch [1], which actually reverts = the > previous patch. So, you can apply the attached with disregarding the old = one. >=20 > And I have also done extensive tests for this new patch but please let me= know > your test results. >=20 > [1] > "net/mlx5: fix deadlock due to buffered slots in Rx SW ring" > at http://dpdk.org/dev/patchwork/patch/29847 Hi Martin I've submitted v2 of the patch [1]. I just replaced vector insns with regul= ar statements. This is just for ease of maintenance because I'm about to add vectorized PMD for ARM NEON. In terms of functionality and performance it = is identical. Please proceed your testing with this and let me know the result. [1] [dpdk-dev,v2] net/mlx5: fix deadlock due to buffered slots in Rx SW ring , which is at http://dpdk.org/dev/patchwork/patch/29879/ Thanks, Yongseok