From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C31C642B1A; Tue, 16 May 2023 03:54:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A97340C35; Tue, 16 May 2023 03:54:35 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2069.outbound.protection.outlook.com [40.107.6.69]) by mails.dpdk.org (Postfix) with ESMTP id 48C5340A7A for ; Tue, 16 May 2023 03:54:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iOAc0XmTzTJOgwkrpZ4h6EKcQxFdUEr4U6BuIuyVuFA=; b=bW43oXKnWnCChikTJiwi7HePyxLxp/M1poYUocMMBAzNOqj7V27R7rVx/U8g/K6q39arVsoGqhIVHPEZmpmIgSm04LT8nr/+unkaGRx+4EjS2Nldkmk0jpCpYk07ze+Qq8PlGuY1Ax0ko4Hcr0RFj4dvg591qp7J6a2VtAM4pWI= Received: from AS9PR06CA0342.eurprd06.prod.outlook.com (2603:10a6:20b:466::18) by AS8PR08MB6486.eurprd08.prod.outlook.com (2603:10a6:20b:33c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May 2023 01:54:32 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::60) by AS9PR06CA0342.outlook.office365.com (2603:10a6:20b:466::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30 via Frontend Transport; Tue, 16 May 2023 01:54:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 01:54:31 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 16 May 2023 01:54:31 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9169df66f089.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 55DEE8D1-40E8-43AB-BBF4-458E323A658A.1; Tue, 16 May 2023 01:54:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9169df66f089.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 May 2023 01:54:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mfdWN2O/qbVu+bWUajImIHdi+FH2mX2bIFy9jK162mtxa5Ip6d3zatPtWM5lt1ZEbrv2QaOhu64ift4usoYNu66QeufvN+8yrlFOtoyQ8+0w8HhGcC7zdBDFc5GD/azUqWx9nKrA9TEYMSfLW5OtfkdGmPrw0+k/chH5DnICqCglSL+NkZbT0bKkyuI8uQL9PmLaqT+NiPmJOzsUDmdrhxjKBQYlvp8hqcWIq08p2MrJkpMp7FwPXCnd7ggDwYuD3vhP3sOdIHlZ2RqdLWVrOwf74w2MG1Zc8aUKQD9p3VrNMgMAtQtnnyxCMkJyy1qTC+YcQGIicootT/heG/yh1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iOAc0XmTzTJOgwkrpZ4h6EKcQxFdUEr4U6BuIuyVuFA=; b=Z87yS1xYDGc3HMZWhINs416T5H01V8u5DQbvgQfuSpizEeHIcZL34s7hsiXRgNe09C8aefbZuObBnEb1T15+LQM1eBwOvDCoC7FztJUU66jTD/0iCygqvcE39n7h86wUK85WZ0VbVkd6UU8D8rsAhq6hz5S0R3UBPrIUhOLsrHvWymQ6/yCQN7i2wUolfGxHxOvh7A5YtPC5dm24X9EgvzQwvoMITvuuLZadIi8opiGnofWOpbYDcI4xUR9d8vkCKJDd0mQ9fBWr1KW4JZeRQN2YBok9rt8T5GpIRvUmP1bNDSXS1cfWpCPwnHSHlSe6vbkDYFSdHzVDRwrEEWiHWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iOAc0XmTzTJOgwkrpZ4h6EKcQxFdUEr4U6BuIuyVuFA=; b=bW43oXKnWnCChikTJiwi7HePyxLxp/M1poYUocMMBAzNOqj7V27R7rVx/U8g/K6q39arVsoGqhIVHPEZmpmIgSm04LT8nr/+unkaGRx+4EjS2Nldkmk0jpCpYk07ze+Qq8PlGuY1Ax0ko4Hcr0RFj4dvg591qp7J6a2VtAM4pWI= Received: from GV1PR08MB7707.eurprd08.prod.outlook.com (2603:10a6:150:52::8) by GV2PR08MB9302.eurprd08.prod.outlook.com (2603:10a6:150:d4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 01:54:18 +0000 Received: from GV1PR08MB7707.eurprd08.prod.outlook.com ([fe80::643d:84fd:3bf6:6355]) by GV1PR08MB7707.eurprd08.prod.outlook.com ([fe80::643d:84fd:3bf6:6355%7]) with mapi id 15.20.6387.030; Tue, 16 May 2023 01:54:18 +0000 From: Feifei Wang To: "Zhang, Qi Z" , "Richardson, Bruce" , Konstantin Ananyev , "Zhang, Yuying" , "Xing, Beilei" , David Christensen , Ruifeng Wang CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli , nd Subject: RE: [PATCH v2] net/i40e: remove redundant judgment Thread-Topic: [PATCH v2] net/i40e: remove redundant judgment Thread-Index: AQHZYUb3hAuKwTaxeUuYR9dYBILuVK8+88uAgBvrSACAAZAyMA== Date: Tue, 16 May 2023 01:54:18 +0000 Message-ID: References: <20211220054246.4031616-1-feifei.wang2@arm.com> <20230328072828.386576-1-feifei.wang2@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 12F07BBB5F95EA49B8EAE6FA63626523.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: GV1PR08MB7707:EE_|GV2PR08MB9302:EE_|AM7EUR03FT045:EE_|AS8PR08MB6486:EE_ X-MS-Office365-Filtering-Correlation-Id: 584ee106-198b-4c24-8e9b-08db55b07e00 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wuLt2JmCNmStmrzQ3IvmdBAO20bxn94ND46DIFHltqnrVyNWxK1sepQWjZtLJEg9MA3oXAxlWdU5qYJWuBSA+m8AM+wA0/eeJ+Hs/wp57qSF5pn6S4ZPmbL7MSqoBeLxBphTnjaEn8Oa8PA3ipwEBIWx07w1HIlV6XVFiW3ulp7sk9vdgA6/GGTdeRcMb4Hfp0HHQG0dEz2ptujuDDlU5uogXmdRTDJyUs5YiWWlxzASFC09KN77jhSkG3vC6i2UYe+QPLDoMTyPb/FPKqQdF6k4Cx1k97eT7S0BEEUBVPIr2HGBntuT83RONum8N2Tui3UDGMYX+bGRMzVGrswc+/5pJMu8Sh+Au8bNvDXcx90sfF10B/vQB3/s6cseKq1RwFUcVsFf+8ljrKzYzcaofvJypj6wkCZppriFo6aIEivi5ZACb6/xXj2OWw8QmlqnNVz//yzBD0b/ZE8JnSIfHf9ArPFbAzql52j8bULN+YPhsXNZfhZOYAwp44TwpdU1z9NqtL83vYcfjNIBBfJ08WSu3UHvJpT0m/+47mJ5iQhYlfECKq2iBxFOCLqD/0kRCDOxrW8YUv/yYrVqROkMnRGbOAB/vtgvEg1Rc4++rFepu2jwj5CL/Gg9GfMoGoikqhAjPAS9UWzVD7rf6xGHlQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR08MB7707.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(366004)(136003)(396003)(346002)(451199021)(478600001)(186003)(53546011)(9686003)(6506007)(26005)(55016003)(71200400001)(66446008)(83380400001)(64756008)(66946007)(4326008)(6636002)(66476007)(76116006)(66556008)(110136005)(54906003)(7696005)(86362001)(41300700001)(122000001)(52536014)(5660300002)(921005)(316002)(8936002)(8676002)(2906002)(38100700002)(38070700005)(33656002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9302 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d42386c-70b0-444d-0ed1-08db55b07617 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sbQRPEiYfEWlSkCKw2YjmSad6pKuxel0OJTpRhhCGcj7YdQPZ3lHTcMkwJY2yMmqfUUWdZm9kzCMBkjPbWNKmxih7dUrJXm2j7Av/c/SSr1puNbeUPEoTV5haZpwfyYl/OUEfMEN46SLTLaJd7IOo0EPAayKoFlRG0vAEWfzAqdh4VuJPLxZdVFdvw81LDz3QFncmMFmslrh6mn6+cw4xBKqEncVDKa4oeGo9RBHT32GX6Mo7tNZ8soDBMLlqfL1CTV8jO3SThCuAPbK6toObVArkI4SKuipeya8FlMxB1UPwee3VwtDFrCcL1EC6lvSTQXcjOh4u1uN8VpbBeeG4HD2eYIrjEEjSvoOXMbw7I9T9vnJsq/yQm9/dxeHRTRedzgZGbFOU/H0H7NhLm2sKCS04joc2huHt4o/5FoGUKcOePhaWATgDBYR6QiXXoPqesKnIPsWY3raXfD9RkrVjN2O73G87egn4KGmyGhl4CqKB0EEa1PFonr5eFnB4mGBOnOdZxNt2MGlPnEA/yo3FSFAeB3vJg4ljzGmVz5M0Fk1vJ12wIEKV5EIJV0K0gIbK8tZtXvZTmzj4WRn8AQltuCUI+eHCO8hzsN6geY0kO9E/yOm6uQ55GmDjRBMatprYStIbgEJi1bQma+tZ1Suc7YqzbLDxul2sAZxGg2/FV31ooUdxuNhb5hxbof0+gW/dYppOR/KEN73ikghQjRLRYIB+TeS3m3znqGFJAzEoEubUOcJzNBsUzAK4PYgeAsoMDqAf4TQhWI/xnePq3/QKuCB4/zCpFXrohDzLLNsbg0= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199021)(36840700001)(40470700004)(46966006)(7696005)(36860700001)(33656002)(83380400001)(26005)(53546011)(9686003)(186003)(336012)(47076005)(40480700001)(82310400005)(86362001)(82740400003)(6506007)(921005)(356005)(81166007)(40460700003)(55016003)(52536014)(8676002)(8936002)(5660300002)(70586007)(70206006)(41300700001)(4326008)(6636002)(316002)(2906002)(54906003)(478600001)(110136005)(23180200003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 01:54:31.8846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 584ee106-198b-4c24-8e9b-08db55b07e00 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6486 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 15, 2023 9:59 AM > To: Zhang, Qi Z ; Feifei Wang > ; Richardson, Bruce ; > Konstantin Ananyev ; Zhang, Yuying > ; Xing, Beilei ; David > Christensen ; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, April 27, 2023 3:38 PM > > To: Feifei Wang ; Richardson, Bruce > > ; Konstantin Ananyev > > ; Zhang, Yuying > > ; Xing, Beilei ; David > > Christensen ; Ruifeng Wang > > > > Cc: dev@dpdk.org; nd@arm.com; Honnappa Nagarahalli > > > > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment > > > > > > > > > -----Original Message----- > > > From: Feifei Wang > > > Sent: Tuesday, March 28, 2023 3:28 PM > > > To: Richardson, Bruce ; Konstantin > > > Ananyev ; Zhang, Yuying > > > ; Xing, Beilei ; > > > David Christensen ; Ruifeng Wang > > > > > > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; > > > Honnappa Nagarahalli > > > Subject: [PATCH v2] net/i40e: remove redundant judgment > > > > > > Merged variable updates under the same condition. It reduces branch. > > > > > > In ampere-altra, there is no performance improvement with this patch. > > > In x86 sse and avx2 path, there is also no performance improvement. > > > > Thanks for sharing the results. While the code implements some best > > practices, such as reducing branching and adding compiler hints, which > > should generally improve performance, it's not necessary to highlight > > that it didn't provide benefits on certain specific platforms. > > > > Would it be ok to remove the last two lines when merging the patch? >=20 > Ping >=20 Sorry for I did not reply this. I agree with this when merging the patch. Thanks for the comments~. > > > > Otherwise > > Acked-by: Qi Zhang > > > > > > > > > > > > > v2: > > > 1. add change for avx and altivec path. > > > > > > Suggested-by: Honnappa Nagarahalli > > > Signed-off-by: Feifei Wang > > > Reviewed-by: Ruifeng Wang > > > --- > > > drivers/net/i40e/i40e_rxtx_common_avx.h | 9 +++++---- > > > drivers/net/i40e/i40e_rxtx_vec_altivec.c | 9 +++++---- > > > drivers/net/i40e/i40e_rxtx_vec_neon.c | 9 +++++---- > > > drivers/net/i40e/i40e_rxtx_vec_sse.c | 9 +++++---- > > > 4 files changed, 20 insertions(+), 16 deletions(-) > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx_common_avx.h > > > b/drivers/net/i40e/i40e_rxtx_common_avx.h > > > index cfc1e63173..85958d6c81 100644 > > > --- a/drivers/net/i40e/i40e_rxtx_common_avx.h > > > +++ b/drivers/net/i40e/i40e_rxtx_common_avx.h > > > @@ -198,14 +198,15 @@ i40e_rxq_rearm_common(struct > i40e_rx_queue > > *rxq, > > > __rte_unused bool avx512) #endif > > > > > > rxq->rxrearm_start +=3D RTE_I40E_RXQ_REARM_THRESH; > > > - if (rxq->rxrearm_start >=3D rxq->nb_rx_desc) > > > + rx_id =3D rxq->rxrearm_start - 1; > > > + > > > + if (unlikely(rxq->rxrearm_start >=3D rxq->nb_rx_desc)) { > > > rxq->rxrearm_start =3D 0; > > > + rx_id =3D rxq->nb_rx_desc - 1; > > > + } > > > > > > rxq->rxrearm_nb -=3D RTE_I40E_RXQ_REARM_THRESH; > > > > > > - rx_id =3D (uint16_t)((rxq->rxrearm_start =3D=3D 0) ? > > > - (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1)); > > > - > > > /* Update the tail pointer on the NIC */ > > > I40E_PCI_REG_WC_WRITE(rxq->qrx_tail, rx_id); } diff --git > > > a/drivers/net/i40e/i40e_rxtx_vec_altivec.c > > > b/drivers/net/i40e/i40e_rxtx_vec_altivec.c > > > index 2dfa04599c..8672ad1c41 100644 > > > --- a/drivers/net/i40e/i40e_rxtx_vec_altivec.c > > > +++ b/drivers/net/i40e/i40e_rxtx_vec_altivec.c > > > @@ -89,14 +89,15 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq) > > > } > > > > > > rxq->rxrearm_start +=3D RTE_I40E_RXQ_REARM_THRESH; > > > - if (rxq->rxrearm_start >=3D rxq->nb_rx_desc) > > > + rx_id =3D rxq->rxrearm_start - 1; > > > + > > > + if (unlikely(rxq->rxrearm_start >=3D rxq->nb_rx_desc)) { > > > rxq->rxrearm_start =3D 0; > > > + rx_id =3D rxq->nb_rx_desc - 1; > > > + } > > > > > > rxq->rxrearm_nb -=3D RTE_I40E_RXQ_REARM_THRESH; > > > > > > - rx_id =3D (uint16_t)((rxq->rxrearm_start =3D=3D 0) ? > > > - (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1)); > > > - > > > /* Update the tail pointer on the NIC */ > > > I40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id); } diff --git > > > a/drivers/net/i40e/i40e_rxtx_vec_neon.c > > > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > > > index 12e6f1cbcb..49391fe4c7 100644 > > > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > > > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > > > @@ -64,14 +64,15 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq) > > > } > > > > > > rxq->rxrearm_start +=3D RTE_I40E_RXQ_REARM_THRESH; > > > - if (rxq->rxrearm_start >=3D rxq->nb_rx_desc) > > > + rx_id =3D rxq->rxrearm_start - 1; > > > + > > > + if (unlikely(rxq->rxrearm_start >=3D rxq->nb_rx_desc)) { > > > rxq->rxrearm_start =3D 0; > > > + rx_id =3D rxq->nb_rx_desc - 1; > > > + } > > > > > > rxq->rxrearm_nb -=3D RTE_I40E_RXQ_REARM_THRESH; > > > > > > - rx_id =3D (uint16_t)((rxq->rxrearm_start =3D=3D 0) ? > > > - (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1)); > > > - > > > rte_io_wmb(); > > > /* Update the tail pointer on the NIC */ > > > I40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rx_id); diff --git > > > a/drivers/net/i40e/i40e_rxtx_vec_sse.c > > > b/drivers/net/i40e/i40e_rxtx_vec_sse.c > > > index bdc979a839..baf83cb3df 100644 > > > --- a/drivers/net/i40e/i40e_rxtx_vec_sse.c > > > +++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c > > > @@ -77,14 +77,15 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq) > > > } > > > > > > rxq->rxrearm_start +=3D RTE_I40E_RXQ_REARM_THRESH; > > > - if (rxq->rxrearm_start >=3D rxq->nb_rx_desc) > > > + rx_id =3D rxq->rxrearm_start - 1; > > > + > > > + if (unlikely(rxq->rxrearm_start >=3D rxq->nb_rx_desc)) { > > > rxq->rxrearm_start =3D 0; > > > + rx_id =3D rxq->nb_rx_desc - 1; > > > + } > > > > > > rxq->rxrearm_nb -=3D RTE_I40E_RXQ_REARM_THRESH; > > > > > > - rx_id =3D (uint16_t)((rxq->rxrearm_start =3D=3D 0) ? > > > - (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1)); > > > - > > > /* Update the tail pointer on the NIC */ > > > I40E_PCI_REG_WC_WRITE(rxq->qrx_tail, rx_id); } > > > -- > > > 2.25.1