From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0088.outbound.protection.outlook.com [104.47.0.88]) by dpdk.org (Postfix) with ESMTP id 4CAD11B7DE for ; Tue, 17 Oct 2017 12:28:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jq2f0z8M7tgkaJfU8IZphLLfsck8KlFF62gTRi3zFWs=; b=TWDhCw9+QTFQpN6RfD6mFKwUEHUaOu2qJ1PwSim1E4uPRkTG50X1LgZmilbUr+bi+1XWqEXC0fXonysdjnLBYSK81wpJoRPipmToxD8jjTO+6QLeFIQ5jI7V9Rk8YyxToWQ6NTfbOzqmLxAtPxutGBZBIoBkHE4mEK1k2tfTsPs= Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com (10.168.33.22) by DB4PR04MB0766.eurprd04.prod.outlook.com (10.141.45.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 17 Oct 2017 10:28:29 +0000 Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::a1f9:523b:383c:d454]) by HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::a1f9:523b:383c:d454%18]) with mapi id 15.20.0077.022; Tue, 17 Oct 2017 10:28:28 +0000 From: Nipun Gupta To: Jerin Jacob CC: "dev@dpdk.org" , Hemant Agrawal , "nikhil.rao@intel.com" Thread-Topic: [PATCH v3 3/4] event/dpaa2: support event eth adapter Thread-Index: AQHTRpORvenipgssZEGFlBXxz0L5gqLnfJcAgABaQQA= Date: Tue, 17 Oct 2017 10:28:28 +0000 Message-ID: References: <1507657887-11366-1-git-send-email-nipun.gupta@nxp.com> <1508190275-32305-1-git-send-email-nipun.gupta@nxp.com> <1508190275-32305-3-git-send-email-nipun.gupta@nxp.com> <20171017050037.GA4009@jerin> In-Reply-To: <20171017050037.GA4009@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB4PR04MB0766; 6:i5gfPhik4vUm+fpXkg4dmDQ4pz7C1E+9gwWmtdlcgqkIiL/yeKqX+AWgjLirkumG9eMtd1cXaDOCtYgVSfZsEEVaCLYGU86x2gEYyc7tVP6gYuytjO4sUV6TAakJjktxTyLgJaM1tX5uKl7KQYGh5eZc6aZQ30lXdbcwM5+/fupBbRvJRsCPHiakCfZt25iEKrteEhXfLvJSc/B+vHT9rGu6WkPUHu4lGxr5upmaHrR8NQB1MEXyg3+nwZHZ14cfKRsvA5GVv9etsLBScS7ZcnrnHqcWgxPNROJ34lxkT10pf2OaCCYFBRt6TovM1kvH5EtnxYuSYsUerIrnTmGdKw==; 5:Memymv1B864t8cLO76Giv4SkYDVJkgvzlF8LII5LO/OwUx8wbuHJL7ZFot3khRh7qAQDtuk4uecjqSUnNEdPXtILfn34I8R1kzswyIkFgCc1PP8kFWn8G9YYk7Gbmf+kliCW9KkwU/qk2Rg0rWTucGFdRNbLnqugj/f/emfLzJo=; 24:PrWKuZ189MLJu9q5zLQ63xhgDtR++3N5qwOZDOD1noDkLF+2FtraogNunQL4lD/GZCTWES5aBUEXu9IhzU7nweag6kNsYphAz0+iuhK4e/U=; 7:d2WWmgzlXhoZ4mer+/p1khGIV/yOb5KLXgSUcvYaigm8vdl+lAjnDMpN8gdF2pydPZjMOumObng1XytLsZ9WVez8sRBQPYkKJ6V5Y9Ia/uvkDPzqqsBj2bdjvOpCOw48GWRI5rhjv7qaAomfUQp1OyVR0C4oCt/pUhuF9bBzrJ6uumoMJfTRJaQNxn0WkouGMYwUrukh704PTstas6C3n2Cu4OoQbZKEoEdvToRHr0A= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(13464003)(189002)(6436002)(6506006)(54356999)(76176999)(8936002)(50986999)(2906002)(189998001)(93886005)(101416001)(7696004)(3280700002)(305945005)(105586002)(66066001)(68736007)(53546010)(229853002)(2950100002)(74316002)(53936002)(3660700001)(106356001)(6916009)(5250100002)(55016002)(8676002)(7736002)(5660300001)(2900100001)(14454004)(97736004)(81166006)(478600001)(3846002)(6116002)(53376002)(966005)(6246003)(81156014)(33656002)(316002)(86362001)(102836003)(99286003)(9686003)(575784001)(25786009)(4326008)(54906003)(6306002)(533714002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB0766; H:HE1PR0401MB2425.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:3; LANG:en; x-ms-office365-filtering-correlation-id: e780a69f-5c1e-43be-6dfd-08d51549ce68 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:DB4PR04MB0766; x-ms-traffictypediagnostic: DB4PR04MB0766: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB4PR04MB0766; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB4PR04MB0766; x-forefront-prvs: 04631F8F77 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2017 10:28:28.0664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0766 Subject: Re: [dpdk-dev] [PATCH v3 3/4] event/dpaa2: support event eth adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 10:28:32 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 17, 2017 10:31 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > nikhil.rao@intel.com > Subject: Re: [PATCH v3 3/4] event/dpaa2: support event eth adapter >=20 > -----Original Message----- > > Date: Tue, 17 Oct 2017 03:14:34 +0530 > > From: Nipun Gupta > > To: dev@dpdk.org > > CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, > > nikhil.rao@intel.com, Nipun Gupta > > Subject: [PATCH v3 3/4] event/dpaa2: support event eth adapter > > X-Mailer: git-send-email 1.9.1 > > > > Signed-off-by: Nipun Gupta > > Reviewed-by: Nikhil Rao > > Acked-by: Hemant Agrawal > > --- > > Changes in v3: > > Fix shared library build > > Changes in v2: > > Support rx_queue_id =3D -1 in eth adapter queue and and del (Nikhil) > > Remove duplicate returns (Nikhil) > > > > drivers/Makefile | 2 +- > > drivers/event/Makefile | 4 +- > > drivers/event/dpaa2/Makefile | 2 + > > drivers/event/dpaa2/dpaa2_eventdev.c | 151 > ++++++++++++++++++++++++++++++++++- > > drivers/event/dpaa2/dpaa2_eventdev.h | 8 ++ > > 5 files changed, 163 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 0467250..db0cd76 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -39,6 +39,6 @@ DEPDIRS-net :=3D bus mempool > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) +=3D crypto > > DEPDIRS-crypto :=3D bus mempool > > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) +=3D event > > -DEPDIRS-event :=3D bus mempool > > +DEPDIRS-event :=3D bus mempool net > > > > include $(RTE_SDK)/mk/rte.subdir.mk > > diff --git a/drivers/event/Makefile b/drivers/event/Makefile > > index d09be74..e119d60 100644 > > --- a/drivers/event/Makefile > > +++ b/drivers/event/Makefile > > @@ -31,7 +31,7 @@ > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > -core-libs :=3D librte_eal librte_eventdev > > +core-libs :=3D librte_eal librte_ether librte_eventdev >=20 > The above two changes makes sense to me as eventdev-ethdev Rx adapter is > depended on ethdev and there could be an Rx adapter implementation in > event area that may use ethdev driver exported API. >=20 > Can you split driver/event and driver/Makefile change to different > patch? I have sent the v4 for this series. >=20 > Other than that, This patch set looks good to me and it is ready to merge= . >=20 > But, There is a compilation error[1] in event-next tree be case of > Hemant reported problem[2].I can apply this patch set once the solution f= or > the reported problem[3] is applied to master branch(so that I pull those > changes to next-eventdev to avoid build issue) I understand this :) Thanks, Nipun >=20 > [1] > Applying: event/dpaa2: support event eth adapter > /export/dpdk-next-eventdev/mk/rte.subdir.mk:62: target 'event' given > more than once in the same rule > make[2]: Circular mempool <- event dependency dropped. >=20 > [2] > http://dpdk.org/ml/archives/dev/2017-October/079249.html >=20 > [3] > http://dpdk.org/ml/archives/dev/2017-October/079324.html