From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0072.outbound.protection.outlook.com [104.47.2.72]) by dpdk.org (Postfix) with ESMTP id 0D5BE377A for ; Fri, 30 Jun 2017 09:30:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uqawbxSrTENEu1CJx/SG7aevplxEwHbPPG8M5yRv/Ns=; b=c3hIOzz74KkTCyg7ahoxXbhqEZgtjGBwsIYxzptuKabxvu+8q9Od2za7jQiOUzwdfeK/2mqO9iNHEX1FrGanL3gGuW1FzTWuMNdDjgmmWRZNxOLGw7NNgM0z4rWOlRUrnjX0bJJcQOmgW0pjArR+mJSKF8XIauqpheCYeN4jl00= Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com (10.168.33.22) by HE1PR0401MB2458.eurprd04.prod.outlook.com (10.168.147.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.15; Fri, 30 Jun 2017 07:30:49 +0000 Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::9050:a47:2fa4:56cb]) by HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::9050:a47:2fa4:56cb%17]) with mapi id 15.01.1220.015; Fri, 30 Jun 2017 07:30:48 +0000 From: Nipun Gupta To: Jerin Jacob CC: "dev@dpdk.org" , Hemant Agrawal , "harry.van.haaren@intel.com" , "bruce.richardson@intel.com" , "gage.eads@intel.com" , Shreyansh Jain Thread-Topic: [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD Thread-Index: AQHS8MJ4y1VydoOookCGqBX1rZ3H6qI7rQgAgAFW3FA= Date: Fri, 30 Jun 2017 07:30:48 +0000 Message-ID: References: <1495735361-4840-1-git-send-email-nipun.gupta@nxp.com> <1498732085-18449-1-git-send-email-nipun.gupta@nxp.com> <20170629110300.GA5779@jerin> In-Reply-To: <20170629110300.GA5779@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0401MB2458; 7:eVce55WhIwWIWYW1GsNVSMQxr8C/7Rre+OC/xrGIv6g5uzfidz64fkHv0Yb2eqWgu7o3pB8eRwMDm7OyIPemVevE5L8szyVFe8NBofyLtDK9Mla0PivOSJrCPbQHVFMyGX8jGZuIWiAxmYDr1QFo5JHAfMdi9EUr8xMjaChZLKa7DC5tp0EJd+YW38kXD2dF804BUXC88gJSw+sdq2RCYAszAjENP9sVuheNtKnxcdiZ4vWQzJ/5K+rhqDBJHgOlN2qEUzgegPh3tXRM34EcHbTElXpojHzouiC6iigp37HSozkVaO42DRjePGcwmTLjiKheeKgzZT0PfaPJNlYKXGKVuN0ENz+jgq4t6EACMimtuEnnvdzPAshhx6gZZHbyyuu46ztfuZSJr0dORZrIDydaQpzfs0kvWaHcsaANeUuHXZOWWFrRHdwm9Lm402Ntg+LVobSSkLCyZAVc6g336i1zLAKC2YWgozf4BXOYL8DTiwoeUQNuwyCNb8ghReY0H11Fw2YkoINATYq5Hy+RIlvQdhCj/QUxSiUAt92v1IOPiDSNXCZNKQPergXIuzpFw1AevJs6AJQ2zDSMWGFpF4/53tzv6FD9k+6Y9E+/zhU+qgmnvOMZELxJ6WHMwOcu6bFl0loeLJSaB/YfKt/ykaXvxGfgQdB/dZoNxoqUtCvaIw+v4IxX8/gs8IQmHqwMzIfc2IJ1Ei9iFi4nJ0Joja9XFUmaQ+YHhmHJLf8PYXhyI0LnvGtoQ99teyw8MEJSF2kNC8H9/Unaz6lFWhLFCH/Nqk9OMUprGVJUHACNiuc= x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39860400002)(13464003)(2906002)(8676002)(6436002)(53936002)(66066001)(110136004)(81166006)(38730400002)(2900100001)(6916009)(25786009)(4326008)(33656002)(8936002)(86362001)(5660300001)(7696004)(7736002)(2950100002)(5250100002)(53546010)(305945005)(14454004)(74316002)(3660700001)(3280700002)(6116002)(102836003)(50986999)(55016002)(9686003)(3846002)(6246003)(478600001)(76176999)(189998001)(54356999)(6506006)(99286003)(54906002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2458; H:HE1PR0401MB2425.eurprd04.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-office365-filtering-correlation-id: 458bfdeb-7555-4645-1083-08d4bf89edb7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:HE1PR0401MB2458; x-ms-traffictypediagnostic: HE1PR0401MB2458: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(133145235818549)(236129657087228)(185117386973197)(275809806118684)(167848164394848)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0401MB2458; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0401MB2458; x-forefront-prvs: 0354B4BED2 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2017 07:30:48.3517 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2458 Subject: Re: [dpdk-dev] [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 07:30:51 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Thursday, June 29, 2017 16:33 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > harry.van.haaren@intel.com; bruce.richardson@intel.com; > gage.eads@intel.com; Shreyansh Jain > Subject: Re: [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD >=20 > -----Original Message----- > > Date: Thu, 29 Jun 2017 15:57:44 +0530 > > From: Nipun Gupta > > To: dev@dpdk.org > > CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, > > harry.van.haaren@intel.com, bruce.richardson@intel.com, > > gage.eads@intel.com, shreyansh.jain@nxp.com, Nipun Gupta > > > > Subject: [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD > > X-Mailer: git-send-email 1.9.1 > > > > The following patch set adds NXP DPAA2 HW based eventdev > > implementation to the next-eventdev tree. > > > > The patchset consists of the following: > > - DPCON support required by DPAA2 eventdev > > - DPCI support in fslmc bus > > - Interrupt support in QBMAN > > - Implemetation of eventdev API's for DPAA2 > > - Documentation of DPAA2 eventdev PMD >=20 > Overall it looks good. >=20 > There are a few check-git log and check-patch errors. Please send the > next version with fixes that makes sense. >=20 > If there are no more review comments. I will pull the next version in a w= eek for > eventdev-next. >=20 > Wrong headline prefix: > drivers: add bus dependency for event > fslmc/bus: add interrupt enabling routine >=20 > ### bus/fslmc: enable portal interrupt handling Ill spin a v5 fixing this. >=20 > WARNING:NAKED_SSCANF: unchecked sscanf return value > #93: FILE: drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:175: > + sscanf(getenv("DPAA2_PORTAL_INTR_TIMEOUT"), "%x", > &timeout); >=20 > WARNING:SSCANF_TO_KSTRTO: Prefer kstrto to single variable sscanf > #93: FILE: drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:175: > + sscanf(getenv("DPAA2_PORTAL_INTR_TIMEOUT"), "%x", > &timeout); >=20 > total: 0 errors, 2 warnings, 247 lines checked >=20 >=20 >=20 >=20 >=20 >=20 > > > > Changes in v4: > > Fixed doxygen warning > > > > Changes in v3: > > Rebased to dpdk master branch > > Fix shared library parallel build (patch 01/21) > > Fixed a checkpatch error > > > > Changes in v2: > > Rebase to latest dpdk-next-eventdev > > Update to support only atomic and ordered queues > > Fix checkpatch errors > > > > Hemant Agrawal (3): > > drivers: add bus dependency for event > > bus/fslmc: generic framework for mc object creation > > bus/fslmc: export qbman dqrr funcs for eventdev usages > > > > Nipun Gupta (18): > > event/dpaa2: add basic build infrastructure > > bus/fslmc: integrating dpio and dpbp to object framework > > bus/fslmc: adding basic dpcon support > > event/dpaa2: register dpcon as dpaa2 device for bus scan > > bus/fslmc: adding basic dpci support > > bus/fslmc: register dpci as dpaa2 device for bus scan > > bus/fslmc: adding cpu support in stashing config > > event/dpaa2: add initialization of event device > > bus/fslmc: add support for static dequeue from portal > > event/dpaa2: add configuration functions > > bus/fslmc: support enqueue with multiple enqueue descriptors > > bus/fslmc: add callback per queue to enable > > bus/fslmc: change func argument to const to avoid warning > > event/dpaa2: add enqueue and dequeue functionality > > fslmc/bus: add interrupt enabling routine > > bus/fslmc: enable portal interrupt handling > > event/dpaa2: handle timeout using interrupts in dequeue > > doc: add NXP DPAA2 EVENTDEV details > > > > MAINTAINERS | 5 + > > config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 + > > doc/guides/eventdevs/dpaa2.rst | 175 ++++++ > > doc/guides/eventdevs/index.rst | 1 + > > drivers/Makefile | 1 + > > drivers/bus/fslmc/Makefile | 5 +- > > drivers/bus/fslmc/fslmc_vfio.c | 69 +- > > drivers/bus/fslmc/fslmc_vfio.h | 47 +- > > drivers/bus/fslmc/mc/dpci.c | 307 +++++++++ > > drivers/bus/fslmc/mc/dpcon.c | 230 +++++++ > > drivers/bus/fslmc/mc/dpio.c | 44 ++ > > drivers/bus/fslmc/mc/fsl_dpci.h | 404 ++++++++++++ > > drivers/bus/fslmc/mc/fsl_dpci_cmd.h | 147 +++++ > > drivers/bus/fslmc/mc/fsl_dpcon.h | 238 +++++++ > > drivers/bus/fslmc/mc/fsl_dpcon_cmd.h | 175 ++++++ > > drivers/bus/fslmc/mc/fsl_dpio.h | 30 + > > drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 14 +- > > drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 179 ++++++ > > drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 133 +++- > > drivers/bus/fslmc/portal/dpaa2_hw_dpio.h | 5 + > > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 28 +- > > drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 46 +- > > drivers/bus/fslmc/qbman/qbman_portal.c | 94 ++- > > drivers/bus/fslmc/rte_bus_fslmc_version.map | 18 + > > drivers/event/Makefile | 2 + > > drivers/event/dpaa2/Makefile | 60 ++ > > drivers/event/dpaa2/dpaa2_eventdev.c | 691 > +++++++++++++++++++++ > > drivers/event/dpaa2/dpaa2_eventdev.h | 114 ++++ > > drivers/event/dpaa2/dpaa2_hw_dpcon.c | 139 +++++ > > .../event/dpaa2/rte_pmd_dpaa2_event_version.map | 3 + > > mk/rte.app.mk | 1 + > > 31 files changed, 3370 insertions(+), 41 deletions(-) > > create mode 100644 doc/guides/eventdevs/dpaa2.rst > > create mode 100644 drivers/bus/fslmc/mc/dpci.c > > create mode 100644 drivers/bus/fslmc/mc/dpcon.c > > create mode 100644 drivers/bus/fslmc/mc/fsl_dpci.h > > create mode 100644 drivers/bus/fslmc/mc/fsl_dpci_cmd.h > > create mode 100644 drivers/bus/fslmc/mc/fsl_dpcon.h > > create mode 100644 drivers/bus/fslmc/mc/fsl_dpcon_cmd.h > > create mode 100644 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c > > create mode 100644 drivers/event/dpaa2/Makefile > > create mode 100644 drivers/event/dpaa2/dpaa2_eventdev.c > > create mode 100644 drivers/event/dpaa2/dpaa2_eventdev.h > > create mode 100644 drivers/event/dpaa2/dpaa2_hw_dpcon.c > > create mode 100644 > drivers/event/dpaa2/rte_pmd_dpaa2_event_version.map > > > > -- > > 1.9.1 > >