From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10066.outbound.protection.outlook.com [40.107.1.66]) by dpdk.org (Postfix) with ESMTP id A2E647CB4 for ; Thu, 1 Jun 2017 13:39:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lw/N+1aB3wOxdLZ4C2ddd5hZD9lwfRSJDVF3Vw8lryQ=; b=g6gFByOngwg/Q2TaZe9Ebf0B2DgLA7Ctw7z4RfBHY9Bh+UXxM05qepPN5BsbBADzl66/yEkBG5QpOgv0KIE05EMiQ6bx0te5l/gpx/dZWZoZEWQXnbWZqdqob44ssCZkgkgucn1R0MZiuSCpacL4VdZkhKMI9ug1JW1YTgy2i9A= Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com (10.168.33.22) by DB6PR0401MB2453.eurprd04.prod.outlook.com (10.169.224.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1143.10; Thu, 1 Jun 2017 11:39:42 +0000 Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::c0d0:93f:4f63:54db]) by HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::c0d0:93f:4f63:54db%18]) with mapi id 15.01.1143.012; Thu, 1 Jun 2017 11:39:35 +0000 From: Nipun Gupta To: Jerin Jacob CC: "dev@dpdk.org" , Hemant Agrawal , "harry.van.haaren@intel.com" , "bruce.richardson@intel.com" , "gage.eads@intel.com" , Shreyansh Jain Thread-Topic: [PATCH 12/20] event/dpaa2: add configuration functions Thread-Index: AQHS1YIZ8XxKtGo7BUWC6THBRmlHFKIOmk0AgAE9u6A= Date: Thu, 1 Jun 2017 11:39:35 +0000 Message-ID: References: <1495735671-4917-1-git-send-email-nipun.gupta@nxp.com> <1495735671-4917-13-git-send-email-nipun.gupta@nxp.com> <20170531152913.GD16598@jerin> In-Reply-To: <20170531152913.GD16598@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0401MB2453; 7:YWlRH/G5DdWFxfsp1ZPTIrMTi+cCgGQMItzilFCWudbe2BwYUu+47HsT9glA4fM7nH4RcJ0az2uTasWzwJhE1E0lVxkiWK/1yHv22T8w9C+TfBf14Zz5bycjhOvZa8PhQQbZuHGazwb2qxpyaJVLkoxEWmO8HDjKaevERVPevSEDYVusQ/yehMTLhopjVgb4Ikd+wlXQyuCQrhvScOB6b+pv2mqHYhL5yXn6tTZmvy8RwyFBSpbQYutSpt2lhRk5v5ojB7jBUxeSVETHzdwE4SagiJAZ2xC19LKT6FrZWiI0zBReMoLeiN68dW6JKZkpS8NUA/jGwrkFkUqqhdaeXQ== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39450400003)(39860400002)(39410400002)(39400400002)(39850400002)(13464003)(54906002)(55016002)(229853002)(99286003)(6436002)(6506006)(14454004)(81166006)(3846002)(102836003)(8676002)(8936002)(6116002)(3280700002)(33656002)(9686003)(86362001)(3660700001)(2906002)(7736002)(5250100002)(305945005)(74316002)(25786009)(53546009)(110136004)(38730400002)(4326008)(76176999)(54356999)(6246003)(50986999)(7696004)(66066001)(2950100002)(189998001)(478600001)(5660300001)(53936002)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0401MB2453; H:HE1PR0401MB2425.eurprd04.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-traffictypediagnostic: DB6PR0401MB2453: x-ms-office365-filtering-correlation-id: cb4d29d8-560e-411f-c96f-08d4a8e2e11f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:DB6PR0401MB2453; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700094)(100105000095)(100000701094)(100105300095)(100000702094)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703094)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(6072148)(100000704094)(100105200095)(100000705094)(100105500095); SRVR:DB6PR0401MB2453; BCL:0; PCL:0; RULEID:(100000800094)(100110000095)(100000801094)(100110300095)(100000802094)(100110100095)(100000803094)(100110400095)(100000804094)(100110200095)(100000805094)(100110500095); SRVR:DB6PR0401MB2453; x-forefront-prvs: 0325F6C77B spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2017 11:39:35.7239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2453 Subject: Re: [dpdk-dev] [PATCH 12/20] event/dpaa2: add configuration functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 11:39:44 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Wednesday, May 31, 2017 20:59 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > harry.van.haaren@intel.com; bruce.richardson@intel.com; > gage.eads@intel.com; Shreyansh Jain > Subject: Re: [PATCH 12/20] event/dpaa2: add configuration functions >=20 > -----Original Message----- > > Date: Thu, 25 May 2017 23:37:43 +0530 > > From: Nipun Gupta > > To: dev@dpdk.org > > CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, > > harry.van.haaren@intel.com, bruce.richardson@intel.com, > > gage.eads@intel.com, shreyansh.jain@nxp.com, Nipun Gupta > > > > Subject: [PATCH 12/20] event/dpaa2: add configuration functions > > X-Mailer: git-send-email 1.9.1 > > > > This patch adds all the configuration API's for DPAA2 eventdev > > including device config, start, stop & port and queue > > related API's > > > > Signed-off-by: Nipun Gupta > > --- > > drivers/event/dpaa2/dpaa2_eventdev.c | 283 > ++++++++++++++++++++++++++++++++++- > > drivers/event/dpaa2/dpaa2_eventdev.h | 22 +++ > > 2 files changed, 304 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c > b/drivers/event/dpaa2/dpaa2_eventdev.c > > index 7fa17f2..cfb52bb 100644 > > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > > @@ -106,7 +106,288 @@ > > return dpaa2_eventdev_dequeue_burst(port, ev, 1, timeout_ticks); > > } > > > > +static int > > +dpaa2_eventdev_queue_setup(struct rte_eventdev *dev, uint8_t queue_id, > > + const struct rte_event_queue_conf *queue_conf) > > +{ > > + struct dpaa2_eventdev *priv =3D dev->data->dev_private; > > + struct evq_info_t *evq_info =3D > > + &priv->evq_info[queue_id]; > > + > > + PMD_DRV_FUNC_TRACE(); > > + > > + evq_info->event_queue_cfg =3D queue_conf->event_queue_cfg; >=20 > Based on the documentation, it looks like ORDERED sched type is not > supported. If so, return an error when queue config request is > RTE_EVENT_QUEUE_CFG_ORDERED_ONLY. >=20 > On the same lines, default_queue_setup() returns > RTE_EVENT_QUEUE_CFG_ALL_TYPES as default value. If ORDERED sched type > is not supported then I think, RTE_EVENT_QUEUE_CFG_ALL_TYPES > can not be used as default or configured. Yes, Right now we are supporting only parallel and atomic queues and waitin= g for our MC firmware to have support for ordered queues in case of enqueue from software. I need to update my code with this. Ill update this in v2. Thanks >=20 > > + > > + return 0; > > +} > > + > > +static void > > +dpaa2_eventdev_port_release(void *port) > > +{ > > + PMD_DRV_FUNC_TRACE(); > > + > > + RTE_SET_USED(port); > > +} > > + > > +static int > > +dpaa2_eventdev_port_setup(struct rte_eventdev *dev, uint8_t port_id, > > + const struct rte_event_port_conf *port_conf) > > +{ > > + PMD_DRV_FUNC_TRACE(); > > + > > + RTE_SET_USED(port_conf); > > + > > + if (!dpaa2_io_portal[port_id].dpio_dev) { > > + dpaa2_io_portal[port_id].dpio_dev =3D > > + dpaa2_get_qbman_swp(port_id); > > + rte_atomic16_inc(&dpaa2_io_portal[port_id].dpio_dev- > >ref_count); > > + if (!dpaa2_io_portal[port_id].dpio_dev) > > + return -1; > > + } > > + > > + dpaa2_io_portal[port_id].eventdev =3D dev; > > + dev->data->ports[port_id] =3D &dpaa2_io_portal[port_id]; > > + return 0; > > +} > > +