* [dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values
@ 2018-03-09 17:59 Ferruh Yigit
2018-03-12 5:28 ` Shreyansh Jain
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-03-09 17:59 UTC (permalink / raw)
To: Hemant Agrawal, Shreyansh Jain; +Cc: dev, Ferruh Yigit
Use existing defines instead of hardcoded vales.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/dpaa/dpaa_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 9b69ef456..db493648a 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -275,9 +275,9 @@ static int dpaa_eth_link_update(struct rte_eth_dev *dev,
PMD_INIT_FUNC_TRACE();
if (dpaa_intf->fif->mac_type == fman_mac_1g)
- link->link_speed = 1000;
+ link->link_speed = ETH_SPEED_NUM_1G;
else if (dpaa_intf->fif->mac_type == fman_mac_10g)
- link->link_speed = 10000;
+ link->link_speed = ETH_SPEED_NUM_10G;
else
DPAA_PMD_ERR("invalid link_speed: %s, %d",
dpaa_intf->name, dpaa_intf->fif->mac_type);
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values
2018-03-09 17:59 [dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values Ferruh Yigit
@ 2018-03-12 5:28 ` Shreyansh Jain
2018-03-27 17:31 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Shreyansh Jain @ 2018-03-12 5:28 UTC (permalink / raw)
To: Ferruh Yigit, Hemant Agrawal; +Cc: dev
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, March 9, 2018 11:29 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; Shreyansh Jain
> <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH] net/dpaa: prefer defines for link speed values
>
> Use existing defines instead of hardcoded vales.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values
2018-03-12 5:28 ` Shreyansh Jain
@ 2018-03-27 17:31 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-03-27 17:31 UTC (permalink / raw)
To: Shreyansh Jain, Hemant Agrawal; +Cc: dev
On 3/12/2018 5:28 AM, Shreyansh Jain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Friday, March 9, 2018 11:29 PM
>> To: Hemant Agrawal <hemant.agrawal@nxp.com>; Shreyansh Jain
>> <shreyansh.jain@nxp.com>
>> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
>> Subject: [PATCH] net/dpaa: prefer defines for link speed values
>>
>> Use existing defines instead of hardcoded vales.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>
> Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-27 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-09 17:59 [dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values Ferruh Yigit
2018-03-12 5:28 ` Shreyansh Jain
2018-03-27 17:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).