Re: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic logging

[Shreyansh Jain <shreyansh.jain@nxp.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, March 29, 2018 8:57 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic
> logging
> 
> 23/03/2018 13:04, Shreyansh Jain:
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -189,11 +189,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
> >  # Compile burst-oriented NXP DPAA2 PMD driver
> >  #
> >  CONFIG_RTE_LIBRTE_DPAA2_PMD=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n
> [...]
> > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> > @@ -26,15 +26,7 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> >  # Compile Support Libraries for DPAA2
> >  #
> >  CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n
> > -
> > -#
> > -# Compile burst-oriented NXP DPAA2 PMD driver
> > -#
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
> >  CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n
> 
> 
> CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER should be in config/common_base.
> 
> All options should be in config/common_base.
> Other files should be used only to overwrite config/common_base.
> 

OK. I explicitly didn't put it in common_base because this is not a general option. It should be limited to only those who wish to debug/develop on this. It is not something an end-user should worry about.

Anyways, I will send another version.

-
Shreyansh