From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0052.outbound.protection.outlook.com [104.47.0.52]) by dpdk.org (Postfix) with ESMTP id 3233E5F30 for ; Wed, 14 Mar 2018 13:28:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D94AK/BeJxovyygJr5Kqt6pl/tIR09U4DD6JA7c1me8=; b=iDmWUaBnIHRckkiDj6RqBX0f44mm8bgRk0LuZ9v4Q75N87TmHRId/ZbYbVF5k01XTlWvUK11e4/Gf6qZMj2nul06C1Kti0jcjlMUJVbwTZ3DW0N9B+0+l926pNFWZS+4gxryJz0GKpe0VCCt5+ZlwfD53q8vQnhMdTAgSytgJe0= Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com (10.175.29.14) by HE1PR0402MB2730.eurprd04.prod.outlook.com (10.175.35.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 14 Mar 2018 12:28:41 +0000 Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::80e4:217f:be76:bd52]) by HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::80e4:217f:be76:bd52%14]) with mapi id 15.20.0588.013; Wed, 14 Mar 2018 12:28:41 +0000 From: Shreyansh Jain To: Remy Horton , "dev@dpdk.org" CC: Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Thomas Monjalon Thread-Topic: [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters Thread-Index: AQHTtg0VeG0/2j+zlE697NEFBF22U6PPryfQ Date: Wed, 14 Mar 2018 12:28:15 +0000 Deferred-Delivery: Wed, 14 Mar 2018 12:27:19 +0000 Message-ID: References: <20180307120851.5822-1-remy.horton@intel.com> <20180307120851.5822-2-remy.horton@intel.com> In-Reply-To: <20180307120851.5822-2-remy.horton@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [92.121.36.197] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0402MB2730; 7:BIU15PnGbRJb2WgQBbxDDRzvbGrdmyT2vW5CPwxi400xh7EnBoBTYAmMizv5sAY8hOZ3p4iJl2UVbecnLF8svIeK2Zs6o+C4GLZO9GTUHGDeQq4v3U32bN8wiIKNzPpFQjtwt1vxDMTalJ3qcFReKqFdr5NL2CI0YR7Coshj5ft4sHKY2QzhXFtckgoZvxkjPbkOD9or7s+GdeF6uSm53t1Xo81+eo7DH0rQoBrH9z/TvodroZzvvffOAfSelhkP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8f647959-0fbe-4625-e402-08d589a71ed6 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2730; x-ms-traffictypediagnostic: HE1PR0402MB2730: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0402MB2730; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2730; x-forefront-prvs: 0611A21987 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(376002)(39380400002)(366004)(13464003)(199004)(189003)(3660700001)(66066001)(55016002)(6436002)(2906002)(6116002)(3846002)(3280700002)(4326008)(5660300001)(7696005)(76176011)(575784001)(14454004)(86362001)(99286004)(6246003)(110136005)(316002)(54906003)(106356001)(97736004)(33656002)(53936002)(53546011)(229853002)(105586002)(2900100001)(6506007)(9686003)(74316002)(102836004)(26005)(7736002)(186003)(8676002)(2950100002)(5250100002)(6666003)(68736007)(25786009)(478600001)(8936002)(81156014)(2501003)(81166006)(305945005)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2730; H:HE1PR0402MB2780.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: b3ybGK00/SCuZZwASUTEOq/Lk13Kkrq1qVzK3/ZEsugmyPePF4lnGbCDI9encpjv9R6t1B5sn4nS4iHRnawutQOyJiCXuXZRdsG29U1yP7TUsA1842+qoF41mupDUpsdz9FLrx4MWkHAGry3R3giueK4yA4cU0NZkbIAbgSaFRNsWyAQ9Tf5w48Sy5smTVhD7nLelqe1dMDO8U9cqvgIyLlO+5V8PdjTRlrzQE3T5K7t9E99CBdfQnGOt0N5HkcFoxIKWjxaAkcPi+XkxYyOsyEi3+VLr+kxFue5DwhvRjBlt7G9ZVm8iO7C/PM7C+GWFNkb+vBX84g1EICNpKKFvg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f647959-0fbe-4625-e402-08d589a71ed6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2018 12:28:41.1642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2730 Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 12:28:43 -0000 > -----Original Message----- > From: Remy Horton [mailto:remy.horton@intel.com] > Sent: Wednesday, March 7, 2018 5:39 PM > To: dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx > parameters >=20 > The optimal values of several transmission & reception related > parameters, such as burst sizes, descriptor ring sizes, and number > of queues, varies between different network interface devices. This > patch allows individual PMDs to specify preferred parameter values. >=20 > Signed-off-by: Remy Horton > --- > lib/librte_ether/rte_ethdev.c | 18 ++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 15 +++++++++++++++ > 2 files changed, 33 insertions(+) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c > b/lib/librte_ether/rte_ethdev.c > index 0590f0c..1630407 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -1461,6 +1461,10 @@ rte_eth_rx_queue_setup(uint16_t port_id, > uint16_t rx_queue_id, > return -EINVAL; > } >=20 > + /* Use default specified by driver, if nb_rc_desc is zero */ ^^^^^^^^^^^ Should be '_rx_' > + if (nb_rx_desc =3D=3D 0) > + nb_rx_desc =3D dev_info.preferred_queue_values.rx_ring_size; > + > if (nb_rx_desc > dev_info.rx_desc_lim.nb_max || > nb_rx_desc < dev_info.rx_desc_lim.nb_min || > nb_rx_desc % dev_info.rx_desc_lim.nb_align !=3D 0) { > @@ -1584,6 +1588,10 @@ rte_eth_tx_queue_setup(uint16_t port_id, > uint16_t tx_queue_id, >=20 [...] Other than the above; Acked-by: Shreyansh Jain