From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30054.outbound.protection.outlook.com [40.107.3.54]) by dpdk.org (Postfix) with ESMTP id D685B374 for ; Wed, 25 Apr 2018 06:18:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OhPRvqox/3LSkc0DDbbd/rEwnxthAIeF8EdjKOVu7lA=; b=bo3wf8RrnwUS7h2kdE1MN/WcbkhjncPCpVdJgJacLsv26xMkfZjqFDnLal7jR6PRTJMM4HJ6Mi862vfWzHswAIM0vtm0vqQFwvmjKO7JUinstmLByRV14XsnGoAjsOaD+TC+ZmKlznXFFCMupuRM4oWDNdjORPjshOtzZHOZ/DA= Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com (10.175.29.14) by HE1PR0402MB3420.eurprd04.prod.outlook.com (10.167.125.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Wed, 25 Apr 2018 04:18:20 +0000 Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::8d97:47e4:52b9:2040]) by HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::8d97:47e4:52b9:2040%14]) with mapi id 15.20.0696.019; Wed, 25 Apr 2018 04:18:20 +0000 From: Shreyansh Jain To: Nipun Gupta CC: "dev@dpdk.org" , "thomas@monjalon.net" , Hemant Agrawal Thread-Topic: [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Thread-Index: AQHTzn2aMVbfNcrof0OUrzjSEfHKrKQQ+pAA Date: Wed, 25 Apr 2018 04:18:00 +0000 Deferred-Delivery: Wed, 25 Apr 2018 04:17:14 +0000 Message-ID: References: <1519292089-13851-1-git-send-email-nipun.gupta@nxp.com> <1523111645-8076-1-git-send-email-nipun.gupta@nxp.com> <1523111645-8076-6-git-send-email-nipun.gupta@nxp.com> In-Reply-To: <1523111645-8076-6-git-send-email-nipun.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [182.69.217.20] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0402MB3420; 7:JYi5y7YWz83wRmdPnnhUDctNhHsQX4VE6qrpYsNJLCfnRXkjXu+MKLIReNkAEx9Wr3+v6Xsrdowx3G9/ncjTy1xEdGtSi/WmuykDA4pYnkiIp6y9CJqPfsDpHZX9jcszHKOjC62SKNk914byUfeAqXlQR6N2MpYD10DT4UkwnLBp6qjNBts0vjjtdHQB7Kh7xsthT+c7AWua5GAIr+ZtwA7NoXOsXkxDooJq1Dp2cwNyVHuBUcrgIjA9Dx0RLtps x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB3420; x-ms-traffictypediagnostic: HE1PR0402MB3420: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(66839620246622); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231232)(2232076)(944501410)(52105095)(10201501046)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0402MB3420; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB3420; x-forefront-prvs: 06530126A4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39860400002)(39380400002)(376002)(346002)(189003)(199004)(13464003)(5660300001)(6506007)(6666003)(105586002)(106356001)(3846002)(6116002)(8936002)(68736007)(59450400001)(305945005)(74316002)(8676002)(229853002)(76176011)(81156014)(81166006)(14454004)(26005)(5250100002)(99286004)(6436002)(53546011)(478600001)(54906003)(25786009)(316002)(7736002)(2900100001)(6636002)(6246003)(6862004)(4326008)(33656002)(55016002)(486006)(97736004)(86362001)(53936002)(9686003)(102836004)(2906002)(476003)(3280700002)(3660700001)(446003)(66066001)(11346002)(44832011)(7696005)(59010400001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB3420; H:HE1PR0402MB2780.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dt7uo4rzpDkKUutv0s/vUYT3fFDMAD0BH+R/6z1P0A814TCQ1R11i+jyPYJ8JK9dKoTRKizaImccqvvuMCuJ7QCkPCf2U6alPxmT5M+Cql5mHJ0pr36mtVrvlEIj7flrVG/AHQ39Ev0Wl6ZJ3j0mKxQ2Z2SHFV8ExObj27kddRHZAOuz3wUDGsMZoSJTsVBAfb4o2BYZuJDEcryYV4M9BKXTGflNv4SAnbo499gYmaYxIcW9c6Z9wndqd1PrYEqso2+Dn+n3CuUk2ItMuWC4v0b+P3KhXUczay3VK+ZTUMTVBXFWghJG2ByDVZ7EMAJGDtT0fkgqWdjrLdxxO82YEw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 96502601-48a0-40c3-5d7c-08d5aa63941f X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96502601-48a0-40c3-5d7c-08d5aa63941f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2018 04:18:20.4954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3420 Subject: Re: [dpdk-dev] [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 04:18:23 -0000 > -----Original Message----- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: thomas@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command > interface driver >=20 > Signed-off-by: Nipun Gupta > --- > MAINTAINERS | 8 ++ > config/common_base | 1 + > config/common_linuxapp | 1 + > drivers/raw/Makefile | 3 + > drivers/raw/dpaa2_cmdif/Makefile | 33 +++++ > drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 139 > +++++++++++++++++++++ > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 35 ++++++ > .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map | 4 + > mk/rte.app.mk | 1 + > 9 files changed, 225 insertions(+) > create mode 100644 drivers/raw/dpaa2_cmdif/Makefile > create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > create mode 100644 > drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map >=20 [...] > diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > new file mode 100644 > index 0000000..5eb0885 > --- /dev/null > +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > @@ -0,0 +1,35 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2018 NXP > + */ > + > +#ifndef __DPAA2_CMDIF_LOGS_H__ > +#define __DPAA2_CMDIF_LOGS_H__ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +#include > + > +extern int dpaa2_cmdif_logtype; > + > +#define DPAA2_CMDIF_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, dpaa2_cmdif_logtype, "%s(): " fmt "\n", > \ > + __func__, ##args) Trivial comment: Would it be better to have two variants - one which prints= the function names and which doesn't. ERR/WARNING with function name shoul= d be avoided. > + > +#define DPAA2_CMDIF_FUNC_TRACE() DPAA2_CMDIF_LOG(DEBUG, ">>") > + > +#define DPAA2_CMDIF_DEBUG(fmt, args...) \ > + DPAA2_CMDIF_LOG(DEBUG, fmt, ## args) > +#define DPAA2_CMDIF_INFO(fmt, args...) \ > + DPAA2_CMDIF_LOG(INFO, fmt, ## args) > +#define DPAA2_CMDIF_ERR(fmt, args...) \ > + DPAA2_CMDIF_LOG(ERR, fmt, ## args) > +#define DPAA2_CMDIF_WARN(fmt, args...) \ > + DPAA2_CMDIF_LOG(WARNING, fmt, ## args) > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif /* __DPAA2_CMDIF_LOGS_H__ */ [...]