From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0061.outbound.protection.outlook.com [104.47.2.61]) by dpdk.org (Postfix) with ESMTP id A35A7B33E for ; Wed, 21 Dec 2016 13:45:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MsVSDXvuP4I6JvHfC8f32xPkmJV2msFR3pEDUDKNAAc=; b=YQO7YOY7YUGf06l9suiCcGtXAF+0635qlW4Vbnn3+f9TCrv0rCNEkzAOXNl1EMEh/qdwVMJZ3CQvGg6coiREjvf9Zk/t81Wb42fVQB5vjp5HpnF2zjzvhn/M2RmX18CdZsVxo1ibm5JjQ0w405/arbC6hYadBUBf5z+zSvZoM2s= Received: from HE1PR0402MB2826.eurprd04.prod.outlook.com (10.175.30.7) by AM4PR04MB1604.eurprd04.prod.outlook.com (10.164.78.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Wed, 21 Dec 2016 12:45:11 +0000 Received: from HE1PR0402MB2826.eurprd04.prod.outlook.com ([10.175.30.7]) by HE1PR0402MB2826.eurprd04.prod.outlook.com ([10.175.30.7]) with mapi id 15.01.0803.010; Wed, 21 Dec 2016 12:45:10 +0000 From: Akhil Goyal To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , Hemant Agrawal , "declan.doherty@intel.com" Thread-Topic: [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality Thread-Index: AQHSTslDhurYFjgvwEyz3EG960y/i6EScQ2AgAAAgVA= Date: Wed, 21 Dec 2016 12:45:10 +0000 Message-ID: References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161205125540.6419-7-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1; AM4PR04MB1604; 7:6mazsuqRsy8eemaJ3ML+U7D/RGgT5YGXAg9mwqQY1ExzhDLXtuobgWMEES08F+NeO5sNZEuFyBjUGh4XH6aBraSXydSIg/MyCVyF1ROcbvJMAjIj9G9nFWgcq+TfLqf1ARYNM8mbZPStPLzJyWwEUFdBRc2z83xVBZGOMeKu/HgqyqbteobBFGQlKmRM2tYbEjos54N7e7lZs6Jifa+AFa7KN3osuVrKdIFJuz5jun6o7tB2YpmaTTPAbUJQ5jS4HEwxt7QcpGyQXOdAvaevQ3GVu7S6gAKWaEI6y9x2mNK+vJ/MIwWWl0iB4UK/uh6Spnmv4MgIL73K0SjGQtIPAc6s9nXmcAKAn1IVYEF836aq44x1Mdg3JCYbKXxJpF3PIT7zIzD4rPgclaxD81sPxLVDrP7naxCJ8m80ncxvYecxk2waGQTSbNdks4rnglU4fYzAZVV1vvWLW+1pJz8XdA== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39840400002)(39860400002)(13464003)(377454003)(199003)(189002)(8936002)(229853002)(38730400001)(5001770100001)(102836003)(2950100002)(2501003)(8676002)(7736002)(76576001)(6116002)(81166006)(3846002)(81156014)(92566002)(86362001)(97736004)(4326007)(5660300001)(7696004)(2900100001)(2906002)(189998001)(54356999)(68736007)(76176999)(50986999)(74316002)(101416001)(105586002)(106116001)(106356001)(9686002)(305945005)(122556002)(6506006)(66066001)(25786008)(3280700002)(77096006)(6436002)(33656002)(15395725005)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR04MB1604; H:HE1PR0402MB2826.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: d7bfa6d1-b612-49dc-d16a-08d4299f335d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM4PR04MB1604; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148)(6047074); SRVR:AM4PR04MB1604; BCL:0; PCL:0; RULEID:; SRVR:AM4PR04MB1604; x-forefront-prvs: 01630974C0 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2016 12:45:10.2966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1604 Subject: Re: [dpdk-dev] [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 12:45:12 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Monday, December 05, 2016 12:56 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; eclan.doherty@intel.com; De Lara > Guarch, Pablo; hemant.agrawal@nxp.com; Akhil Goyal > Subject: [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality >=20 > Signed-off-by: Akhil Goyal > Reviewed-by: Hemant Agrawal > --- > config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 + > drivers/crypto/dpaa2_sec/Makefile | 1 - > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1337 > +++++++++++++++++++++++++++ > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 516 +++++++++++ > drivers/net/dpaa2/base/dpaa2_hw_pvt.h | 25 + For the whole patch, there are some checkpatch errors that you should fix f= or the v2: http://dpdk.org/ml/archives/test-report/2016-December/005244.html [Akhil] ok. Will try to resolve as much as I could. Make sure that you fix also the other patches. [Akhil] ok Also, a comment below about the capabilities structure. Thanks, Pablo > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > new file mode 100644 > index 0000000..01fae77 > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > @@ -0,0 +1,516 @@ ... As far as I could see, this PMD supports AES-CBC, 3DES-CBC and SHA1 and SHA= 2 with HMAC algorithms, but you are including here more algorithms that this PMD looks like does no= t support (such as AES XCBC, GCM, etc...) [Akhil] ok I will remove it for now. It will be added in future. > + { /* AES XCBC MAC */ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > + {.sym =3D { > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, > + {.auth =3D { > + .algo =3D > RTE_CRYPTO_AUTH_AES_XCBC_MAC, > + .block_size =3D 16, > + .key_size =3D { > + .min =3D 16, > + .max =3D 16, > + .increment =3D 0 > + }, > + .digest_size =3D { > + .min =3D 16, > + .max =3D 16, > + .increment =3D 0 > + }, > + .aad_size =3D { 0 } > + }, } > + }, } > + },