Re: [dpdk-dev] [PATCH v5] net/pcap: physical interface MAC address support

["Kuusisaari, Juhamatti (Coriant - FI/Espoo)" <juhamatti.kuusisaari@coriant.com>]

Hello Ferruh,

> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Monday, September 10, 2018 3:04 PM
>
> Hi Juhamatti,
> 
> Thanks for the patch.
> 
> Can you please add a little more details into commit log that why this new
> feature is enabled, what is the use case?
> 
> Also can you please send new version of the patches as a reply to previous
> one,
> - via "--in-reply-to" git send-email argument. And a history after commit log
> what changed in new version. These helps tracing the multiple versions.

Thanks for the excellent comments and guidance. I did the changes and v6 has been sent to Patchwork queue. The use case is really just to use PCAP interface as one of the interfaces of the application and thus allowing to use also the physical MAC address of the interface. I tried to elaborate this a bit more, I hope it is at least better now.

Seems that I cannot easily get rid of __FreeBSD__ define checkpatches-nag. I assumed that it isn't really mandatory as I can see the same define used elsewhere.

BR,
--
 Juhamatti