DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments
@ 2018-04-22 14:20 Ophir Munk
  2018-04-22 14:47 ` Ophir Munk
  2018-04-23  4:13 ` Hu, Jiayu
  0 siblings, 2 replies; 12+ messages in thread
From: Ophir Munk @ 2018-04-22 14:20 UTC (permalink / raw)
  To: dev, Jiayu Hu
  Cc: Thomas Monjalon, Olga Shern, Pascal Mazon, Ophir Munk, stable

Large TCP packets which are marked with PKT_TX_TCP_SEG flag are
segmented and the flag is cleared in the resulting segments, however,
the segments checksum is not updated. It is therefore required to set
the PKT_TX_TCP_CKSUM flag in each TCP segment in order to mark for the
sending driver the need to update the TCP checksum before transmitting
the segment.

Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO")
Cc: stable@dpdk.org

Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
 lib/librte_gso/rte_gso.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c
index a44e3d4..e9ce9ce 100644
--- a/lib/librte_gso/rte_gso.c
+++ b/lib/librte_gso/rte_gso.c
@@ -50,12 +50,14 @@ rte_gso_segment(struct rte_mbuf *pkt,
 			((IS_IPV4_GRE_TCP4(pkt->ol_flags) &&
 			 (gso_ctx->gso_types & DEV_TX_OFFLOAD_GRE_TNL_TSO)))) {
 		pkt->ol_flags &= (~PKT_TX_TCP_SEG);
+		pkt->ol_flags |= PKT_TX_TCP_CKSUM;
 		ret = gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta,
 				direct_pool, indirect_pool,
 				pkts_out, nb_pkts_out);
 	} else if (IS_IPV4_TCP(pkt->ol_flags) &&
 			(gso_ctx->gso_types & DEV_TX_OFFLOAD_TCP_TSO)) {
 		pkt->ol_flags &= (~PKT_TX_TCP_SEG);
+		pkt->ol_flags |= PKT_TX_TCP_CKSUM;
 		ret = gso_tcp4_segment(pkt, gso_size, ipid_delta,
 				direct_pool, indirect_pool,
 				pkts_out, nb_pkts_out);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-04-25  1:51 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-22 14:20 [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments Ophir Munk
2018-04-22 14:47 ` Ophir Munk
2018-04-23  4:13 ` Hu, Jiayu
2018-04-24  9:44   ` Ophir Munk
2018-04-24 10:56     ` Ananyev, Konstantin
2018-04-24 11:45       ` Ophir Munk
2018-04-24 12:31         ` Ananyev, Konstantin
2018-04-24 12:55           ` Hu, Jiayu
2018-04-24 13:53             ` Ophir Munk
2018-04-25  1:51               ` Hu, Jiayu
2018-04-24 13:41           ` Ophir Munk
2018-04-24 14:26             ` Ananyev, Konstantin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).