From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10087.outbound.protection.outlook.com [40.107.1.87]) by dpdk.org (Postfix) with ESMTP id EC4F6A84E; Wed, 9 May 2018 10:47:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gUK2sRclneY37bLPDfNjRe/AUHE1YjrnNyzxxxzZ2D0=; b=CYBr1njeBbpEa0o+g8Tu6vC24LVfUxb1KbcIYdTCRK6K1QNomWXjGamRu+y0d414Kez8oCez6DtXLk0WqPG+ifXb3WfnyHaEyHQ4NYZcCvkYWeqk0SRZhC9dzQily+p+qCv52XTctY902q2Zmx5nLarKo/CpYglkkeiULq/Ss5A= Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com (10.168.34.19) by HE1PR0501MB2361.eurprd05.prod.outlook.com (10.168.34.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 08:47:01 +0000 Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97]) by HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97%18]) with mapi id 15.20.0735.021; Wed, 9 May 2018 08:47:01 +0000 From: Ophir Munk To: Adrien Mazarguil , Shahaf Shuler CC: Ferruh Yigit , "dev@dpdk.org" , "stable@dpdk.org" , Thomas Monjalon , Raslan Darawsheh , Saleh Alsouqi , Olga Shern Thread-Topic: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS converter Thread-Index: AdPncXBiPvWHcNBXQQ6JnspCaCHQlw== Date: Wed, 9 May 2018 08:47:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2361; 7:XxuONXXtydseuR1P6V+WcDBA7EALWRqR2o0RLoE1mMUVVQXDrbtLDuck4TXs9neF+GAiU5IQEY211Q6ENeLI2drSWfroDom09ix5AL+fzs/jClzLPMvpgdWoxXtdFXvd7NEmBS3SCIhOeaGaTyowPQuapBEGbqBzJ7s2fZOSjzPG3Rfd8sWCF/xJovcXGG+6K7gaV1xF5skukxR0ZlIGFjWlBOZ15maHd1lvVP1gHsPUecXWDEkvZgQi9Ps3H7DW x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2361; x-ms-traffictypediagnostic: HE1PR0501MB2361: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0501MB2361; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2361; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(39850400004)(396003)(39380400002)(376002)(346002)(189003)(199004)(13464003)(86362001)(33656002)(68736007)(81166006)(53546011)(8936002)(97736004)(186003)(81156014)(105586002)(6636002)(66066001)(54906003)(106356001)(6506007)(316002)(74316002)(102836004)(2900100001)(25786009)(5660300001)(7736002)(486006)(476003)(305945005)(8676002)(110136005)(6116002)(478600001)(53936002)(99286004)(9686003)(26005)(55016002)(2906002)(3280700002)(107886003)(6436002)(3660700001)(14454004)(4326008)(5250100002)(7696005)(3846002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2361; H:HE1PR0501MB2314.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: jwBP5hI/iWG6I1PDtGAb17oW2mi03iobyGRd7MDiGKIFgMJk7uGx6XTS/dRb3ipB+F7QFHHJSxqvZvZYNRaLO1oOL9LhFestYEttnNxopDXl4HFKMgP5tYrx2Jtv1qhxdKeplJo4zymzxMadIYCNv3Q+NOA8iNbrOz9vq4pVlRJQ+mqWaQTAOgnq8hRPXZH5 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 40edcd48-f953-41b0-4288-08d5b5896ed1 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40edcd48-f953-41b0-4288-08d5b5896ed1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 08:47:01.6835 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2361 Subject: [dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 08:47:05 -0000 Hi Shahaf, Adrien, This commit (in next-net/master since 8-May-18) is breaking all testpmd cal= ls with mlx4 NIC, see [1]. Can you please revert it? [1] PMD: net_mlx4: cannot set up internal flow rules (code 95, "Operation not s= upported"), flow error type 16, cause 0x7fffdb5bb3a0, message: unsupported = RSS hash type requested Fail to configure port 0 EAL: Error - exiting with code: 1 Cause: Start ports failed > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Friday, May 04, 2018 6:18 PM > To: Shahaf Shuler > Cc: Ferruh Yigit ; dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS > converter >=20 > Since the commit below, mlx4_conv_rss_types() does not need to support > special value -1 anymore. Other functions rely on priv->hw_rss_sup direct= ly. >=20 > Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adrien Mazarguil > --- > drivers/net/mlx4/mlx4_flow.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c > index 3f754b480..cb3b9a952 100644 > --- a/drivers/net/mlx4/mlx4_flow.c > +++ b/drivers/net/mlx4/mlx4_flow.c > @@ -78,9 +78,6 @@ struct mlx4_drop { > /** > * Convert DPDK RSS hash types to their Verbs equivalent. > * > - * This function returns the supported (default) set when @p types has > - * special value (uint64_t)-1. > - * > * @param priv > * Pointer to private structure. > * @param types > @@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t > types) > uint64_t conv =3D 0; > unsigned int i; >=20 > - if (types =3D=3D (uint64_t)-1) > - return priv->hw_rss_sup; > for (i =3D 0; i !=3D RTE_DIM(in); ++i) > if (types & in[i]) { > seen |=3D types & in[i]; > -- > 2.11.0