From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40076.outbound.protection.outlook.com [40.107.4.76]) by dpdk.org (Postfix) with ESMTP id 8AC261CC5D for ; Sun, 13 May 2018 18:23:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nFK+Ug9ODaSxS+RjpHjXll3lqeLqqFmYnkBPV2GKl70=; b=oqa8W6OHdKmAh6C2SSoHVj3Pe5Hkjjufj+vgY1UVR3yl0MFN9f9P/vq5GlMu1j8hUJ0rECYFQWMtM5WFJkQsPdiq3f8kacfOirTqMrRYGQ8U79bZ16jujsJebzysshwNWNVVAllJst+mblyYB/kPmBN9cX3C+mRvwsmG6auDIgs= Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com (10.168.34.19) by HE1PR0501MB2281.eurprd05.prod.outlook.com (10.168.34.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Sun, 13 May 2018 16:23:53 +0000 Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97]) by HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97%18]) with mapi id 15.20.0755.018; Sun, 13 May 2018 16:23:53 +0000 From: Ophir Munk To: Thomas Monjalon CC: "'dev@dpdk.org'" , Adrien Mazarguil , Olga Shern , Shahaf Shuler Thread-Topic: [PATCH v4 2/2] net/mlx4: advertise supported RSS hash functions Thread-Index: AQHT6tCttZ+JaKV/30uQARb83mbpZKQt1MeAgAAAK7CAAALCoA== Date: Sun, 13 May 2018 16:23:53 +0000 Message-ID: References: <1525962108-15215-1-git-send-email-ophirmu@mellanox.com> <1526225995-31378-1-git-send-email-ophirmu@mellanox.com> <1526225995-31378-2-git-send-email-ophirmu@mellanox.com> <3374507.afEf5z8BbC@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2281; 7:MBDojByGsYhhCnKoSBmoNddftyULCn++CG6zY6aWfENJva+6uR1gXjnTKFi0RRyFVmALZDpX9qW2ePrUTO18kZYyVsKFsJnotu/axks9eOvciTaxPrxYhKPQPBkkAsUPK7w37mSGvke2vkE44hcWMRYlVJ0hZfroiQqUlQ6WwqHU6gyWkHlD5qdRzyMXQ52Q312e9zaNsI56yWbBv8h1xQqUdbV+Y9UdehnOHOJaMoHhd0+M8EQJSzjHbOiPo37v x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2281; x-ms-traffictypediagnostic: HE1PR0501MB2281: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0501MB2281; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2281; x-forefront-prvs: 0671F32598 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(376002)(346002)(366004)(396003)(199004)(189003)(13464003)(99286004)(316002)(3280700002)(575784001)(86362001)(66066001)(8936002)(8676002)(33656002)(81156014)(81166006)(54906003)(6436002)(9686003)(6916009)(6306002)(45080400002)(74316002)(7696005)(93886005)(229853002)(3660700001)(55016002)(53936002)(966005)(4326008)(2906002)(478600001)(5250100002)(305945005)(97736004)(476003)(76176011)(68736007)(14454004)(106356001)(25786009)(6506007)(102836004)(186003)(53546011)(486006)(7736002)(59450400001)(26005)(6246003)(2940100002)(11346002)(5660300001)(6116002)(3846002)(2900100001)(446003)(107886003)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2281; H:HE1PR0501MB2314.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: R5aaQyp/4bQ23e/WmxGK1RkkoXMVB+QsWIy0jdbDf84L31YJhlWqSqv6xB1BBrDl/CGn4E/3Ec1IN0FgiXa9Swco1v9SPxXPqUWaXB9ZQJyL/mfawLffG3KY8PCoyvW/AuGG8j43DD7zjYe3ZZaniCO/qXrSJUtqIuSzUcYlpHmB16T6Z1f3hGM5j7BSQ4w8 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 948ab1ea-f35c-452c-7bf0-08d5b8edeb3a X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 948ab1ea-f35c-452c-7bf0-08d5b8edeb3a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2018 16:23:53.4781 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2281 Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/mlx4: advertise supported RSS hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 16:23:55 -0000 Anyway will update in v5 to be sent now > -----Original Message----- > From: Ophir Munk > Sent: Sunday, May 13, 2018 7:14 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Adrien Mazarguil ; Olga > Shern ; Shahaf Shuler > Subject: RE: [PATCH v4 2/2] net/mlx4: advertise supported RSS hash > functions >=20 > Shahaf asked for it in his review >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Sunday, May 13, 2018 7:13 PM > > To: Ophir Munk > > Cc: dev@dpdk.org; Adrien Mazarguil ; Olga > > Shern ; Shahaf Shuler > > Subject: Re: [PATCH v4 2/2] net/mlx4: advertise supported RSS hash > > functions > > > > 13/05/2018 17:39, Ophir Munk: > > > info->speed_capa =3D > > > - ETH_LINK_SPEED_1G | > > > - ETH_LINK_SPEED_10G | > > > - ETH_LINK_SPEED_20G | > > > - ETH_LINK_SPEED_40G | > > > - ETH_LINK_SPEED_56G; > > > + ETH_LINK_SPEED_1G | > > > + ETH_LINK_SPEED_10G | > > > + ETH_LINK_SPEED_20G | > > > + ETH_LINK_SPEED_40G | > > > + ETH_LINK_SPEED_56G; > > > > Not sure why you re-indent. > > For info, line continuation in control statements must be done with 2 t= abs: > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F > > > %2Fdpdk.org%2Fdoc%2Fguides%2Fcontributing%2Fcoding_style.html%23ge > > > neral&data=3D02%7C01%7Cophirmu%40mellanox.com%7C521136e06b61475a > > > 99c308d5b8ec58fa%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7 > > > C636618247609249241&sdata=3DGkEBudFg9ukUbGM9Wi%2F84vT%2FQRv3qX > > KuT%2BiFN0ziVjc%3D&reserved=3D0 > > In this case, it is not a control statement, so I guess 1 or 2 tabs > > can be accepted. > >