From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0049.outbound.protection.outlook.com [104.47.0.49]) by dpdk.org (Postfix) with ESMTP id 0915C1C98D for ; Sun, 13 May 2018 18:13:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D5va9Qk/1a0ti/5T+ZbMQXUNH4/ilnAUwEzYAywo1GQ=; b=YFJ4dXfoyYqcW/gKF4O2cpDbKBWFS54Oq+vEtMn37h4Qm0MtQ9WRCuekQAjEIMORJtYlI4YEvg9MQ5jgG1UNogqLjC5X6kz+DjWY1fcWeEbJJIB/ok+VyVGmYe9FVnASQJKoYMjUCC/A5UAKS0LxqIKs4fwH5QPYXeXB/13W944= Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com (10.168.34.19) by HE1PR0501MB2234.eurprd05.prod.outlook.com (10.168.33.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Sun, 13 May 2018 16:13:41 +0000 Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97]) by HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97%18]) with mapi id 15.20.0755.018; Sun, 13 May 2018 16:13:41 +0000 From: Ophir Munk To: Thomas Monjalon CC: "dev@dpdk.org" , Adrien Mazarguil , Olga Shern , Shahaf Shuler Thread-Topic: [PATCH v4 2/2] net/mlx4: advertise supported RSS hash functions Thread-Index: AQHT6tCttZ+JaKV/30uQARb83mbpZKQt1MeAgAAAK7A= Date: Sun, 13 May 2018 16:13:41 +0000 Message-ID: References: <1525962108-15215-1-git-send-email-ophirmu@mellanox.com> <1526225995-31378-1-git-send-email-ophirmu@mellanox.com> <1526225995-31378-2-git-send-email-ophirmu@mellanox.com> <3374507.afEf5z8BbC@xps> In-Reply-To: <3374507.afEf5z8BbC@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2234; 7:gGGAH78rUW08f08Lqa7JWerJfiom2Myi56+Pf9HvfACvChUCJnVGq6nuMRvqfOp0KNfnCL7NprnY20oB/XGdHF/c31Pr+HxLtu4O2+aa7NfQD+XQ3VCGdmve+9j3MXRKWx29e/aBuMuTCXLwM0hmQ+H751VBZStFb5vfcu5yXfzbyZzPTx63phv2bHjOgpVL3VoFga7HohtQEJkSWqnoTc9G3L4hxYT0yygC7pfTU0blSGh97NEvyhTB43Q793B5 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2234; x-ms-traffictypediagnostic: HE1PR0501MB2234: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2234; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2234; x-forefront-prvs: 0671F32598 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(376002)(366004)(39860400002)(13464003)(199004)(189003)(8936002)(486006)(575784001)(68736007)(93886005)(97736004)(316002)(7696005)(966005)(478600001)(446003)(11346002)(105586002)(106356001)(55016002)(6306002)(81156014)(8676002)(476003)(2900100001)(81166006)(45080400002)(7736002)(54906003)(305945005)(9686003)(86362001)(102836004)(6916009)(5250100002)(26005)(6506007)(2906002)(186003)(53546011)(6246003)(53936002)(25786009)(107886003)(5660300001)(4326008)(229853002)(3846002)(66066001)(6116002)(3660700001)(3280700002)(6436002)(76176011)(14454004)(99286004)(74316002)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2234; H:HE1PR0501MB2314.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 6k7ldk/NMU90Vz+qX53nhrs2rdlSoR06aCZoKot73LSr2Q0jgqG5lA/ER/lowFEKrnsWr1NZPa7lvhA3xJFYCFvMpir5LzctBqSPn/6St3QCo4P5oT7yzhTGqgkUUAyyWKFmiTzisjVY1gzMVsHl+jZY9tOzLjxkFz33y3YL45pLpk6zdA3VC0+IdZkAt+P3 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 290524f2-8b14-42d5-7a8c-08d5b8ec7e92 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 290524f2-8b14-42d5-7a8c-08d5b8ec7e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2018 16:13:41.6864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2234 Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/mlx4: advertise supported RSS hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 16:13:43 -0000 Shahaf asked for it in his review > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Sunday, May 13, 2018 7:13 PM > To: Ophir Munk > Cc: dev@dpdk.org; Adrien Mazarguil ; Olga > Shern ; Shahaf Shuler > Subject: Re: [PATCH v4 2/2] net/mlx4: advertise supported RSS hash > functions >=20 > 13/05/2018 17:39, Ophir Munk: > > info->speed_capa =3D > > - ETH_LINK_SPEED_1G | > > - ETH_LINK_SPEED_10G | > > - ETH_LINK_SPEED_20G | > > - ETH_LINK_SPEED_40G | > > - ETH_LINK_SPEED_56G; > > + ETH_LINK_SPEED_1G | > > + ETH_LINK_SPEED_10G | > > + ETH_LINK_SPEED_20G | > > + ETH_LINK_SPEED_40G | > > + ETH_LINK_SPEED_56G; >=20 > Not sure why you re-indent. > For info, line continuation in control statements must be done with 2 tab= s: > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F > %2Fdpdk.org%2Fdoc%2Fguides%2Fcontributing%2Fcoding_style.html%23ge > neral&data=3D02%7C01%7Cophirmu%40mellanox.com%7C521136e06b61475a > 99c308d5b8ec58fa%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7 > C636618247609249241&sdata=3DGkEBudFg9ukUbGM9Wi%2F84vT%2FQRv3qX > KuT%2BiFN0ziVjc%3D&reserved=3D0 > In this case, it is not a control statement, so I guess 1 or 2 tabs can b= e > accepted. >=20