From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0065.outbound.protection.outlook.com [104.47.1.65]) by dpdk.org (Postfix) with ESMTP id 6DEB57272 for ; Wed, 9 May 2018 12:31:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eifO7UTuG5xi4mmD0RKaWk86WFqedf3kmOolUYiyynw=; b=C5n09hYGIG4ZkGV63jAiAaoidiAWHuyOKHRzM6FG8bdTI2udR9jRTblhb/ik4OiPSTyc45z8LlW1a8wpmiLIMiB2J+JlgH+xyX6y8Gp6gKnDtZ4oS9tLtnln7EBBrXyYBk+hoKS4t2oUGRJnGePzDrLcYpQNAqUZWqIoVYRpiRo= Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com (10.168.34.19) by HE1PR0501MB2393.eurprd05.prod.outlook.com (10.168.125.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Wed, 9 May 2018 10:31:51 +0000 Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97]) by HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97%18]) with mapi id 15.20.0735.021; Wed, 9 May 2018 10:31:51 +0000 From: Ophir Munk To: Shahaf Shuler , Thomas Monjalon CC: "dev@dpdk.org" , Adrien Mazarguil , Olga Shern Thread-Topic: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation Thread-Index: AQHT5shignKuzfxi8EGhR8ryoDk9FaQlxD+AgAFpQ4CAAAawQA== Date: Wed, 9 May 2018 10:31:51 +0000 Message-ID: References: <1525782629-897-1-git-send-email-ophirmu@mellanox.com> <1663463.84SeaxCa5g@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2393; 7:GUAjwE5ZceQmfzjtay5ooaDdZWb5lOD1N37jql+Q4O8ONC3kFsBl+YWlAIg9r+i83nBzqWjmsEQPy3K5HS4MCe54TipgRtVKFCBFohdWzJKgTkcOJotSz7J4FcBwPvXpkujx0TDAHUxxWJKbciAx/Bpm7J4fFSa/i1NcftzHnF3jNXQIueZXfzn7SJ+boYdZaNQwdE256FnuvMztZVPqw1mHEtNWjHnG6vm2oHILLJtyCWsHlYaaWvV1FBstI4Qq x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2393; x-ms-traffictypediagnostic: HE1PR0501MB2393: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0501MB2393; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2393; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(346002)(376002)(396003)(13464003)(189003)(199004)(102836004)(26005)(5250100002)(11346002)(316002)(6506007)(33656002)(25786009)(110136005)(476003)(68736007)(54906003)(486006)(86362001)(97736004)(105586002)(53546011)(478600001)(76176011)(446003)(7696005)(106356001)(229853002)(4326008)(99286004)(8936002)(6436002)(66066001)(81166006)(81156014)(8676002)(3846002)(9686003)(3660700001)(53936002)(6116002)(55016002)(305945005)(14454004)(5660300001)(6246003)(7736002)(2906002)(2900100001)(3280700002)(107886003)(74316002)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2393; H:HE1PR0501MB2314.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: +ppxclMrg0XH1HptD0NYmEfOsB7Eg0j+PyJ+IUNn5f0FTflLAJ8nZHBrsf9EzdqwxaNUoAMSjVVPoqE/T+wdaPh58KSvlI7IkZy4s1gq4Oqb4GrvPNeOfEr5ZiEAux8XCAnnM1WHRyj3ngBv6kFmWu1LWXCBJpSEJ1uaSJONPBUMujyHzqpkCVGdOndAgQGp spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 42334fb9-ed21-458f-bada-08d5b59813e5 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42334fb9-ed21-458f-bada-08d5b59813e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 10:31:51.4709 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2393 Subject: Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 10:31:53 -0000 Sure. Agreed. Regards, Ophir > -----Original Message----- > From: Shahaf Shuler > Sent: Wednesday, May 09, 2018 1:07 PM > To: Thomas Monjalon ; Ophir Munk > > Cc: dev@dpdk.org; Adrien Mazarguil ; Olga > Shern > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation >=20 > Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon: > > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > > > 08/05/2018 14:30, Ophir Munk: > > > +Limitations > > > +----------- > > > + > > > +- CRC stripping is supported by default and this capability is alway= s > > reported > > > + as "true". The ability to enable/disable CRC stripping requires OF= ED > > version > > > + 4.3-1.5.0.0 or rdma-core version v18. > > > > I think it is better to merge this patch with the one fixing the capabi= lity. > > So we will be able to refer to one atomic commit in the history. > > >=20 > If you agree Ophir I will squash the two patch into one and merge it on m= lx4. > OK?