From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0086.outbound.protection.outlook.com [104.47.1.86]) by dpdk.org (Postfix) with ESMTP id CD1BB1B025 for ; Wed, 24 Jan 2018 13:48:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=B+zrW0+106HFE6zL6k7nuSQrHAPdWO6cunFRibIjVgA=; b=Czh5Wdk90HK/VPOjRy59gmHXMVODblo6qA2tlbYaKiYUwxB4xjKy1KugzUdF/gkUhFF44I0qCBplW5rGEuhCyuPq4sYGr3uXYxwGn43gAD5SmuJ0V48pVUML/WXFSDghrXIeac5PgSQL7BNUNO7TYHYbxpmSi5+ws2thaSahpMs= Received: from HE1PR0502MB3804.eurprd05.prod.outlook.com (10.167.127.158) by HE1PR0502MB3724.eurprd05.prod.outlook.com (10.167.127.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Wed, 24 Jan 2018 12:48:12 +0000 Received: from HE1PR0502MB3804.eurprd05.prod.outlook.com ([fe80::4ddd:13dd:a1da:502a]) by HE1PR0502MB3804.eurprd05.prod.outlook.com ([fe80::4ddd:13dd:a1da:502a%13]) with mapi id 15.20.0428.019; Wed, 24 Jan 2018 12:48:12 +0000 From: Matan Azrad To: Ophir Munk , "dev@dpdk.org" CC: Thomas Monjalon , Olga Shern , Adrien Mazarguil Thread-Topic: [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic Thread-Index: AQHTlQVK+nUXO50QfEKBc+kzI3Biu6OC96JQ Date: Wed, 24 Jan 2018 12:48:12 +0000 Message-ID: References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0502MB3724; 7:h/RSF2UqSOj0qGw3WzRptfYUxwtLs2A2eEzTD20E8YFG4vX0Avq1ARV04CBvYUzB1U8TT9VXeD1cdrsh8wKDFyzNL1sl0Wca/kYQWMRn4Wk8KO/h9YJ30tW52cfAEaI7P6onGZk/MivSmY3Xe3G4STamedGQ2l02F/YRpoNCMGFP24XG0CjctRQy3dZCtbjlypEmAYuyORutqNEj9ZI9VhmRD3Fq+INQ7HNHIYZKIzKN/bD4NJft4rkDfxM6mhU0 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: decd601c-99a9-4233-581f-08d56328bad1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:HE1PR0502MB3724; x-ms-traffictypediagnostic: HE1PR0502MB3724: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231023)(2400081)(944501161)(10201501046)(6055026)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0502MB3724; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0502MB3724; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39380400002)(396003)(366004)(39860400002)(199004)(189003)(33656002)(7736002)(316002)(74316002)(106356001)(5660300001)(6246003)(2900100001)(99286004)(2950100002)(305945005)(3660700001)(3846002)(26005)(2906002)(6506007)(68736007)(3280700002)(66066001)(102836004)(6116002)(229853002)(4326008)(7696005)(59450400001)(8936002)(54906003)(110136005)(76176011)(81156014)(81166006)(8676002)(25786009)(86362001)(55016002)(53936002)(5250100002)(2501003)(9686003)(14454004)(105586002)(97736004)(6436002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3724; H:HE1PR0502MB3804.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: GyV/d0nnMED4cMVzQa4vaWixDarNXvCRcqRZ2wTTuNTQqHp0HpRPqlQBEr8ERmmhYWKrK5IO0SHOWalHj32o3g== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: decd601c-99a9-4233-581f-08d56328bad1 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 12:48:12.4729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3724 Subject: Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 12:48:15 -0000 Hi Ophir From: Ophir Munk, Wednesday, January 24, 2018 1:20 PM > In order to guarantee a successful vdev_netvsc compilation on old Linux > distributions remove CFLAGS -std=3Dc11 and -pedantic Otherwise old GCC > compilers may complain as follows: > cc1: error: unrecognized command line option -std=3Dc11 >=20 > Signed-off-by: Ophir Munk > --- > drivers/net/vdev_netvsc/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/vdev_netvsc/Makefile > b/drivers/net/vdev_netvsc/Makefile > index f2b2ac5..45351b8 100644 > --- a/drivers/net/vdev_netvsc/Makefile > +++ b/drivers/net/vdev_netvsc/Makefile > @@ -12,7 +12,7 @@ EXPORT_MAP :=3D rte_pmd_vdev_netvsc_version.map # > Additional compilation flags. > CFLAGS +=3D -O3 > CFLAGS +=3D -g > -CFLAGS +=3D -std=3Dc11 -pedantic -Wall -Wextra > +CFLAGS +=3D -Wall -Wextra > CFLAGS +=3D -D_XOPEN_SOURCE=3D600 > CFLAGS +=3D -D_BSD_SOURCE > CFLAGS +=3D -D_DEFAULT_SOURCE > -- > 2.7.4 This patch is a fix for compilation issue so it should be with fix title. Suggestion: net/vdev_netvsc: fix build using C11 mode and pedantic Also "Fixes" line should be added. Thanks, Matan.