From: Suanming Mou <suanmingm@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@mellanox.com>,
Asaf Penso <asafp@mellanox.com>,
"Gal Cohen (Product)" <galco@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update release notes for mlx5 PMD
Date: Thu, 6 Aug 2020 00:57:52 +0000 [thread overview]
Message-ID: <HE1PR05MB348449C75C79C612211E9B3ECC480@HE1PR05MB3484.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <4743632.BZODOphkSX@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, August 5, 2020 11:31 PM
> To: Suanming Mou <suanmingm@mellanox.com>
> Cc: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; dev@dpdk.org; Raslan Darawsheh
> <rasland@mellanox.com>; Asaf Penso <asafp@mellanox.com>; Gal Cohen
> (Product) <galco@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: update release notes for mlx5 PMD
>
> 19/07/2020 13:59, Suanming Mou:
> > Update the release notes of mlx5 PMD for two new added devargs:
> > 1. sys_mem_en
> > 2. decap_en
>
> That's a pity it was not sent as part of code implementation.
>
> Please, at least, add the Fixes lines.
OK, will add the Fixes lines.
>
> > Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> > ---
> > --- a/doc/guides/rel_notes/release_20_08.rst
> > +++ b/doc/guides/rel_notes/release_20_08.rst
> > @@ -123,6 +123,8 @@ New Features
> > * Added new PMD devarg ``reclaim_mem_mode``.
> > * Added new devarg ``lacp_by_user``.
> > * Added support for eCPRI protocol offloading.
> > + * Added new devarg ``decap_en``.
> > + * Added new devarg ``sys_mem_en``.
>
> You could group by moving up with other devargs in a logical order.
> I think we could even group all devargs in a single list item.
Good idea. Thanks.
>
>
next prev parent reply other threads:[~2020-08-06 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 11:59 Suanming Mou
2020-08-05 15:31 ` Thomas Monjalon
2020-08-06 0:57 ` Suanming Mou [this message]
2020-08-06 2:42 ` [dpdk-dev] [PATCH v2] " Suanming Mou
2020-08-06 13:48 ` Kinsella, Ray
2020-08-06 23:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR05MB348449C75C79C612211E9B3ECC480@HE1PR05MB3484.eurprd05.prod.outlook.com \
--to=suanmingm@mellanox.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=galco@mellanox.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=rasland@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).