DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, dev <dev@dpdk.org>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>, dpdk stable <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation
Date: Mon, 27 Jul 2020 10:03:50 +0000
Message-ID: <HE1PR0801MB202530E067DCDE90DB5894609E720@HE1PR0801MB2025.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8y864sGDWWn_LsU7DQ=CFi2_1LaRBQ+BBst2hjcBcgFiw@mail.gmail.com>


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, July 27, 2020 5:39 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: Akhil.goyal@nxp.com; dev <dev@dpdk.org>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation
> 
> Hello Ruifeng,
> 
> On Mon, Jul 27, 2020 at 10:58 AM Ruifeng Wang <ruifeng.wang@arm.com>
> wrote:
> >
> > Typo in debug log switch macro caused debug log cannot be enabled.
> > Fixed the typo to match option defined in config file.
> >
> > Typo in crypto dev name macro caused unexpected device name in log.
> > Fixed the typo to log with correct device name.
> >
> > Solved compilation error when debug log is enabled:
> > rte_armv8_pmd.c: In function ‘process_armv8_chained_op’:
> > rte_armv8_pmd.c:633:22: error: expected ‘)’ before ‘crypto_func’
> >   ARMV8_CRYPTO_ASSERT(crypto_func != NULL);
> >                       ^
> >
> > Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8
> > processors")
> > Cc: stable@dpdk.org
> >
> 
> Reported-by: David Marchand <david.marchand@redhat.com>
> 
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
> > https://mails.dpdk.org/archives/dev/2020-July/175241.html
> >
> >  drivers/crypto/armv8/armv8_pmd_private.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/crypto/armv8/armv8_pmd_private.h
> > b/drivers/crypto/armv8/armv8_pmd_private.h
> > index e08d0df78..b183c739b 100644
> > --- a/drivers/crypto/armv8/armv8_pmd_private.h
> > +++ b/drivers/crypto/armv8/armv8_pmd_private.h
> > @@ -12,25 +12,25 @@
> >
> >  #define ARMV8_CRYPTO_LOG_ERR(fmt, args...) \
> >         RTE_LOG(ERR, CRYPTODEV, "[%s] %s() line %u: " fmt "\n",  \
> > -                       RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
> > +                       RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \
> >                         __func__, __LINE__, ## args)
> >
> 
> 
> - Those macros can use a dedicated logtype for this driver rather than pollute
> the CRYPTODEV general logtype.
> 
Agreed. Will add a dedicated logtype for this driver.

> - Looking at their uses:
> drivers/crypto/armv8/armv8_pmd_private.h:#define
> ARMV8_CRYPTO_LOG_ERR(fmt, args...) \
> drivers/crypto/armv8/armv8_pmd_private.h:#define
> ARMV8_CRYPTO_LOG_INFO(fmt, args...) \
> drivers/crypto/armv8/armv8_pmd_private.h:#define
> ARMV8_CRYPTO_LOG_DBG(fmt, args...) \
> drivers/crypto/armv8/armv8_pmd_private.h:#define
> ARMV8_CRYPTO_LOG_INFO(fmt, args...)
> drivers/crypto/armv8/armv8_pmd_private.h:#define
> ARMV8_CRYPTO_LOG_DBG(fmt, args...)
> drivers/crypto/armv8/rte_armv8_pmd.c:           ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd.c:
> ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd.c:
> ARMV8_CRYPTO_LOG_ERR("Invalid/unsupported operation");
> drivers/crypto/armv8/rte_armv8_pmd.c:           ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd.c:           ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd.c:           ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd.c:
> ARMV8_CRYPTO_LOG_ERR("failed to create cryptodev vdev");
> drivers/crypto/armv8/rte_armv8_pmd.c:   ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd_ops.c:
> ARMV8_CRYPTO_LOG_INFO(
> drivers/crypto/armv8/rte_armv8_pmd_ops.c:
> ARMV8_CRYPTO_LOG_ERR(
> drivers/crypto/armv8/rte_armv8_pmd_ops.c:
> ARMV8_CRYPTO_LOG_ERR("invalid session struct");
> drivers/crypto/armv8/rte_armv8_pmd_ops.c:
> ARMV8_CRYPTO_LOG_ERR("failed configure session parameters");
> 
> There is nothing for debug, and the rest of these messages are in setup steps.
> I would rather have them always enabled and remove the debug option
> entirely.
> 
> WDYT?
> 
Agreed. The logs are not in data path. They can be always enabled.
Will change in next version. 

> 
> > -#ifdef RTE_LIBRTE_ARMV8_CRYPTO_DEBUG
> > +#ifdef RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG
> >  #define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \
> >         RTE_LOG(INFO, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
> > -                       RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
> > +                       RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \
> >                         __func__, __LINE__, ## args)
> >
> >  #define ARMV8_CRYPTO_LOG_DBG(fmt, args...) \
> >         RTE_LOG(DEBUG, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
> > -                       RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
> > +                       RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \
> >                         __func__, __LINE__, ## args)
> >
> >  #define ARMV8_CRYPTO_ASSERT(con)                               \
> >  do {                                                           \
> >         if (!(con)) {                                           \
> > -               rte_panic("%s(): "                              \
> > -                   con "condition failed, line %u", __func__); \
> > +               rte_panic("condition failed, line %u",          \
> > +                       __LINE__);                              \
> >         }                                                       \
> >  } while (0)
> 
> 
> RTE_VERIFY does the same.
> 
Yes. Will switch to RTE_VERIFY in next version.

> 
> --
> David Marchand


  reply	other threads:[~2020-07-27 10:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  8:58 Ruifeng Wang
2020-07-27  9:38 ` David Marchand
2020-07-27 10:03   ` Ruifeng Wang [this message]
2020-07-28  9:24 ` [dpdk-dev] [PATCH v2 0/3] armv8 crypto PMD Ruifeng Wang
2020-07-28  9:24   ` [dpdk-dev] [PATCH v2 1/3] crypto/armv8: remove log debug option Ruifeng Wang
2020-07-28 19:48     ` Akhil Goyal
2020-07-28  9:24   ` [dpdk-dev] [PATCH v2 2/3] crypto/armv8: use dedicated log type Ruifeng Wang
2020-07-28 19:48     ` Akhil Goyal
2020-07-28  9:24   ` [dpdk-dev] [PATCH v2 3/3] crypto/armv8: remove redundant assert definition Ruifeng Wang
2020-07-28 19:49     ` Akhil Goyal
2020-07-28 20:04   ` [dpdk-dev] [PATCH v2 0/3] armv8 crypto PMD Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR0801MB202530E067DCDE90DB5894609E720@HE1PR0801MB2025.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=akhil.goyal@nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git