From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB91AA04B0; Fri, 14 Aug 2020 12:42:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFFCE1C0C3; Fri, 14 Aug 2020 12:42:19 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20065.outbound.protection.outlook.com [40.107.2.65]) by dpdk.org (Postfix) with ESMTP id 869111C023 for ; Fri, 14 Aug 2020 12:42:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9wRJqsalUT+hhzcZjWh29uHOuCxlcaRC0ZpSEDGHtnY=; b=S4AiVS7Fqt3szG8AHgM/hsWZnOX6LPkUe4z7oyc026Ss2hSshPVCWeO8CFf39NeQzMnhzaOlDhcK2r8xd2VVnJgotQm7cQAi1lupsOG9/tvsW00W6E8bUI2oI/s2T8KvUR/xpBTjca/sUPWLk2G2H+qcVJnYNbPbIr+AXGncsWY= Received: from AM6PR01CA0058.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::35) by DB6PR0801MB1944.eurprd08.prod.outlook.com (2603:10a6:4:73::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Fri, 14 Aug 2020 10:42:16 +0000 Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::8b) by AM6PR01CA0058.outlook.office365.com (2603:10a6:20b:e0::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15 via Frontend Transport; Fri, 14 Aug 2020 10:42:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16 via Frontend Transport; Fri, 14 Aug 2020 10:42:16 +0000 Received: ("Tessian outbound 34b830c8a0ef:v64"); Fri, 14 Aug 2020 10:42:16 +0000 X-CR-MTA-TID: 64aa7808 Received: from eedfeed2eb22.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2EA38C64-A3AE-41C0-B7EB-20DAB2E7CA50.1; Fri, 14 Aug 2020 10:42:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eedfeed2eb22.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Aug 2020 10:42:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jvmxKzlfe7HC8qQbACxIMBGb35umkZ0FjtcbrKnRjCHGZG9ogCFIzmywCtcOz2MaPp9a5QavpUD35c1MJXzCOkWoo/rPAo9qzdwrggkkSYPjoe56Obhlr7wKmm3FXadaKhPfbf2xyih9zRIotWIzNVVqWKyuL8b/hxZl6QUIe+7JjKDPl3fyvuo2L0T0gfldu+iv3KfQu7OgnFGeTrZ1pMW0e4iEDLVsM7fHxonuOAcjcim9yVfB6tqeXSrioIjBMrUQBxYy8OVohAb6G4TPajfisJM+WCcJUQGc8fMRLym8CDrNKDFigXX7SLnJMbgthcINtiZ9/WTVAn+W2t54tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9wRJqsalUT+hhzcZjWh29uHOuCxlcaRC0ZpSEDGHtnY=; b=W6FqLKVdE1mgNHp2HTWAq9RD7v7OnQy+fc4iAC14i1madRud5mJjVhh+0dNylgvvSgGkH/nKddPvQJ6MAAjUEUE16gYMRSg5VIIc5fZSJykWlyby40h7mXrhcCWYMZRTUT7eIbuoGwEX6x3sFlrnC3u9AY9El01cS0pvktl6ZHYoxTlLQjlaQ5NkjHwtc4u02Vx3FbpJeowBtOpvHvSFH98faCPeXCUHyV2vEY0xh60MeObcE9yJKv8IzBHxCRyP5gWNBNXfLNXz8WaCoS65g91G3HScH1uiVaKl1BZ6J7z0Ixp5Es5vXeoX2PviGP+PcLHCA/GEn6NJQ69hQcS3Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9wRJqsalUT+hhzcZjWh29uHOuCxlcaRC0ZpSEDGHtnY=; b=S4AiVS7Fqt3szG8AHgM/hsWZnOX6LPkUe4z7oyc026Ss2hSshPVCWeO8CFf39NeQzMnhzaOlDhcK2r8xd2VVnJgotQm7cQAi1lupsOG9/tvsW00W6E8bUI2oI/s2T8KvUR/xpBTjca/sUPWLk2G2H+qcVJnYNbPbIr+AXGncsWY= Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com (2603:10a6:3:50::14) by HE1PR08MB2937.eurprd08.prod.outlook.com (2603:10a6:7:2d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15; Fri, 14 Aug 2020 10:42:09 +0000 Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::e863:15c9:b803:6533]) by HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::e863:15c9:b803:6533%7]) with mapi id 15.20.3261.025; Fri, 14 Aug 2020 10:42:09 +0000 From: Ruifeng Wang To: Bruce Richardson CC: "hemant.agrawal@nxp.com" , "jerinj@marvell.com" , "viktorin@rehivetech.com" , "dev@dpdk.org" , Honnappa Nagarahalli , Phil Yang , nd , nd Thread-Topic: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platforms Thread-Index: AQHWcgC1yeU354j8lkejGRbiFrSUCKk3QXgAgAAJoRCAABSIgIAACLDQ Date: Fri, 14 Aug 2020 10:42:08 +0000 Message-ID: References: <20200814060320.86238-1-ruifeng.wang@arm.com> <20200814081306.GA1970@bricha3-MOBL.ger.corp.intel.com> <20200814100103.GB1970@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200814100103.GB1970@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 63056950-6a27-4c00-aa79-cfc363ede4ec.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.111] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f6162710-37b6-42c2-a901-08d8403eb675 x-ms-traffictypediagnostic: HE1PR08MB2937:|DB6PR0801MB1944: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AxyK9VZVLNldSTta5ic+iw8d109Y7DuAqUPb6iDfCITKoOlv9VKQeXBwFO3Tv9RLRfnIiwZ3x/Y5VqzlpNKNdQE1XRWo3VUUkE7QR3EPiZeMVj9ihWMVQKs9LpoWNf7KJpBhChGoAoPizjlgVeYASmCVL3AYXRbhSC9ugDZMYxe/iv1WgOyVcOF2hJ149hK3oGyoLkmnMAgSXxAFanJCF5f667J9/7M1P8nhTthYVWHcgp6ZcaXQ1Xq83Ex9TVtzhuQDRrpayy+VBICg/KBfnJ3wEJupLhDO21HR68SalCcnzafbf15zkkii/iFqJ/N7wR5tTEe/UVxIcoscEBuVzQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0801MB2025.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(478600001)(316002)(54906003)(64756008)(53546011)(6506007)(66446008)(66476007)(66946007)(66556008)(86362001)(8676002)(5660300002)(7696005)(52536014)(76116006)(26005)(186003)(4326008)(2906002)(33656002)(8936002)(71200400001)(55016002)(6916009)(83380400001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: AV3pPZJxv+AmlqDQHd7HjioYNzDutkShFRnY1CVyJFb9fjWdbdwv0+1UkgNbHB/dPmkdzfmuySWJhIMcDvYSXmm1lJWm8telhA1ravwXgXGoz36ukCjLznDttdH01B7t+6h8RGPucp2SQcwbdfl4INk+GMhlqVFbpyH+6HfuspsWTDFRQK+3ppZmFcPxqA5YSok/mRpx9XWFXtLvFZtJoS5LoXlkg4R46bgyVo+S/UUsfjv4KyuNzuA1E5AfS8RHvgafFCr+z91iehERjDC95AZvFpRziE5Zz2mJ2D9ROEHjUGnUExBifByqwiFAV4tEc6uGH1jBvIZ9QEHn7KWvXPu+tnDmYKh+mtDeDaKDW2ZbUfySTKATDqrR4Gt4QeThm33dr3syfzH2xxjPefCi9NyU3WT00RUK9WGOz2TcaDwIry2g/afcz8kIy1ZPtr9aGKdygcIUGmjFCopwHNkabXgug0or7eJUz+VFIyGdEaROJ17wTJ8dM86V/Zfm+xxzdS8VG61TDUp/k78L0XumXEMy6O5bAeANM69H50J7DOvAKZzo/47a6Xl8l/mko/OX7mukXGiWig4X7k8KEN7Z1bWo69m4rlDN/Vq6fms5thnZ7t33KtRoyBjTJ9QGaJaa56wIaGikun169Q3qK44vnw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2937 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e1078fa7-466e-4380-097b-08d8403eb211 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bc3zMM7ic3uXDIZpq5pag2o+ekzNkzTORVU7X0CxtnYSGPBkPraRAg2STVAQrRbcfqpQhZJw97XIl48bpfGSGtUMtOwjvbAYyqGuJUgbclwZ1eqTke7vXW7tqFDEX/tGqVTSyaN/Lk7JEU9Okk5ZS64otKe+c2RchEzHJiqNGJ3sl3zj07FIWI/aRP3GfcKNZ/jsG8yi7S7wC43Z+j7zqZOvo8DG2eV35dSkC6SEpfUpW7pPDZOKl/5YmyV1oiN96RUzU7Vc6XC7F9IOWQbtP22WmSSwncuIunTBHMkKVuEoQGqSu3Sd2D8a7ZpXxliPmrjcd2dtfUYihb5W2KNmYvo3MF3Y9fwjCdJCYnbm2FVNRB1g/a24yUOPVHExfKELNYhhsWE2qTZGXed7fUJgpA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966005)(4326008)(52536014)(356005)(478600001)(7696005)(8676002)(82310400002)(86362001)(36906005)(54906003)(316002)(83380400001)(55016002)(8936002)(5660300002)(9686003)(53546011)(6506007)(2906002)(26005)(336012)(33656002)(81166007)(6862004)(70586007)(47076004)(70206006)(186003)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2020 10:42:16.5579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6162710-37b6-42c2-a901-08d8403eb675 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1944 Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platforms X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Friday, August 14, 2020 6:01 PM > To: Ruifeng Wang > Cc: hemant.agrawal@nxp.com; jerinj@marvell.com; > viktorin@rehivetech.com; dev@dpdk.org; Honnappa Nagarahalli > ; Phil Yang ; nd > > Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm > platforms >=20 > On Fri, Aug 14, 2020 at 09:05:23AM +0000, Ruifeng Wang wrote: > > > > > -----Original Message----- > > > From: Bruce Richardson > > > Sent: Friday, August 14, 2020 4:13 PM > > > To: Ruifeng Wang > > > Cc: hemant.agrawal@nxp.com; jerinj@marvell.com; > > > viktorin@rehivetech.com; dev@dpdk.org; Honnappa Nagarahalli > > > ; Phil Yang ; nd > > > > > > Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm > > > platforms > > > > > > On Fri, Aug 14, 2020 at 02:03:20PM +0800, Ruifeng Wang wrote: > > > > Flags are used to distinguish different platform architectures. > > > > These flags can be used to pick different code paths for different > > > > architectures at compile time. > > > > For Arm platforms, there are 3 flags in use: RTE_ARCH_ARM, > > > > RTE_ARCH_ARMv7 and RTE_ARCH_ARM64. > > > > RTE_ARCH_ARM64 is used to flag 64-bit aarch64 platforms, while > > > > RTE_ARCH_ARM & RTE_ARCH_ARMv7 are used to flag 32-bit platforms. > > > > RTE_ARCH_ARMv7 is for ARMv7 platforms as its name suggested. > > > > > > > > The issue is that flag name RTE_ARCH_ARM is unclear and could > > > > cause confusion. No info about platform word length is included in = the > name. > > > > To make the flag names more clear, a naming scheme is proposed. > > > > > > > > RTE_ARCH_ARM > > > > | > > > > +----RTE_ARCH_ARM32 > > > > | | > > > > | +----RTE_ARCH_ARMv7 > > > > | | > > > > | +----RTE_ARCH_ARMv8_AARCH32 > > > > | > > > > +----RTE_ARCH_ARM64 > > > > > > > > RTE_ARCH_ARM32 will be used for 32-bit Arm platforms. > > > > It includes RTE_ARCH_ARMv7 and RTE_ARCH_ARMv8_AARCH32. > > > > RTE_ARCH_ARMv7 is for ARMv7 platforms. > > > > RTE_ARCH_ARMv8_AARCH32 is for aarch32 state on aarch64 platforms. > > > > RTE_ARCH_ARM64 is for 64-bit Arm platforms. > > > > RTE_ARCH_ARM will be used for all Arm platforms, including > > > > RTE_ARCH_ARM32 and RTE_ARCH_ARM64. > > > > > > > > To fit into the new naming scheme, current usage of RTE_ARCH_ARM > > > > in project code is mapped to RTE_ARCH_ARM32. > > > > > > > > Suggested-by: Honnappa Nagarahalli > > > > Signed-off-by: Ruifeng Wang > > > > Reviewed-by: Phil Yang > > > > --- > > > Just to note that for all architectures there is the RTE_ARCH_64 > > > define which is set if the system is 64-bit. That could be used > > > instead if you didn't want to have to specially define ARM32 and ARM6= 4 > macros. > > > > > Yes. Thanks for the note. > > RTE_ARCH_ARM64 is used in architecture specific cases. For example, > > when a processing path is not implemented by some of 64-bit architectur= es, > RTE_ARCH_64 is not sufficient. > > > Yes, but is RTE_ARCH_ARM64 not identical to RTE_ARCH_ARM && > RTE_ARCH_64? My thought is: 1. RTE_ARCH_ARM64 is a direct macro, so with better readability. 2. RTE_ARCH_ARM64 is already used widely in the project. So I think it is better not to replace the occurrences with combination of = other macros.