From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2174A00C3; Fri, 15 May 2020 10:03:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86A631DA79; Fri, 15 May 2020 10:03:49 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by dpdk.org (Postfix) with ESMTP id 1765B1DA77 for ; Fri, 15 May 2020 10:03:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oasPeX6Q19A3b4wCqBaH0ZZhhMyJNyAhfVuVOHAqdsA=; b=AaKtC2+jUYtNKKniJIsjdYr6aS7h4eSMeaHJVN4C6eYad795dKpGBuvbU5lwX44BUcDRekBHijQcZIvfpOg4BLyTWHNsoOT+PzZ+MLjCxzK88lUhDdn7mnkNTgmHzkXk2DsQkOt1XYWAzjRVQ/FqeZzIlFaaJvMHpXjzZ+zmSZQ= Received: from AM6PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:20b:6e::34) by DB8PR08MB5116.eurprd08.prod.outlook.com (2603:10a6:10:e5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Fri, 15 May 2020 08:03:47 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::67) by AM6PR02CA0021.outlook.office365.com (2603:10a6:20b:6e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Fri, 15 May 2020 08:03:46 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Fri, 15 May 2020 08:03:46 +0000 Received: ("Tessian outbound fb9de21a7e90:v54"); Fri, 15 May 2020 08:03:46 +0000 X-CR-MTA-TID: 64aa7808 Received: from e39ead28f943.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7EA0CF42-5931-4F26-AEBD-809B0FF3A285.1; Fri, 15 May 2020 08:03:41 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e39ead28f943.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 May 2020 08:03:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIBRWt5DyqfgFK0McXuk2VkzGg7LtuXaBoPOa6O/7b0Ll/xao2Na24fuO3BZL3m6fYcAx5zVUs2F5w0ARUVU0YiQ/lSomfYGJh8nlXeZpHGuG2FPcXMbOr3M/iLntxaUTq+soYvdWYgUKi9vsKuZMH+JHzAuA9XpQ/sMKHW/lQt+5eQOKQzmeZ+Y1rAl2HNICBao8CiehlSR26D2dhnroxcU4GEoNneAx/cky/Kl2Coe8zNt3C1nxMrHKggdk5LgH/xxvWOkpk1CVU4ELanJwObJEyah+7DgqMVE/PBvKQiy27CpdrmJfIYCjSTXipTliN/ACxCJ/f45KAEN+LZmyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oasPeX6Q19A3b4wCqBaH0ZZhhMyJNyAhfVuVOHAqdsA=; b=d4fl4OuQ5OkVTMRqCp9cwzeznWhff6wpQClGVh/8kY5AEoDZ2XGnIxDOtOk0CiH3PxcEHPfbS/PVdGRhWJvTA6CliZmEX4dZueylxUbxj6Yl8mVQdD7VJVx3Jeex+4BJZ4nkOZIZZXHCh7K/xzpdbC6PNeSYbrG3jw5vhoHDplFiRWAvm46EF1HKn1h/Zpiu2UZxEFjn6YProeqEf2H3r9yBeTYkFFrW4g8x2+9FTOwpIIu7TxVzZBUkLLl8GBwuEeTV2H4cqc32OYhVXNj99ShejELpEX7HkBcPtXUajOyOv9FDAIQeBOVzm7RS2k4URSRMqEcboGuL8+WkOv/Bcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oasPeX6Q19A3b4wCqBaH0ZZhhMyJNyAhfVuVOHAqdsA=; b=AaKtC2+jUYtNKKniJIsjdYr6aS7h4eSMeaHJVN4C6eYad795dKpGBuvbU5lwX44BUcDRekBHijQcZIvfpOg4BLyTWHNsoOT+PzZ+MLjCxzK88lUhDdn7mnkNTgmHzkXk2DsQkOt1XYWAzjRVQ/FqeZzIlFaaJvMHpXjzZ+zmSZQ= Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com (2603:10a6:3:50::14) by HE1PR0801MB2108.eurprd08.prod.outlook.com (2603:10a6:3:51::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Fri, 15 May 2020 08:03:37 +0000 Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::646e:c258:7269:f4b2]) by HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::646e:c258:7269:f4b2%11]) with mapi id 15.20.3000.016; Fri, 15 May 2020 08:03:37 +0000 From: Ruifeng Wang To: Apeksha Gupta , "dev@dpdk.org" CC: "declan.doherty@intel.com" , "asomalap@amd.com" , "anoobj@marvell.com" , "roy.fan.zhang@intel.com" , "fiona.trahe@intel.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , "Akhil.goyal@nxp.com" , nd Thread-Topic: [PATCH v3] Test/crypto: check valid test_stats before running test Thread-Index: AQHWKo5TFDUf7jwEYU6fJJF2XLCPUKioyWdQ Date: Fri, 15 May 2020 08:03:37 +0000 Message-ID: References: <20200515073242.24720-1-apeksha.gupta@nxp.com> <20200515075606.25709-1-apeksha.gupta@nxp.com> In-Reply-To: <20200515075606.25709-1-apeksha.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 45ea91c2-f1e8-47b8-8308-e4b393df3fb2.0 x-checkrecipientchecked: true Authentication-Results-Original: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e3c2af24-5892-4b9c-d9ca-08d7f8a67e5d x-ms-traffictypediagnostic: HE1PR0801MB2108:|DB8PR08MB5116: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125; x-forefront-prvs: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TPLmWoO5MuYJLuXgQ9l5bdMG6+u4k4ARtU3eiQCGTL/8iMxgwSqe/DekzmmoFATAoXuQR0uI+Aa6kx+Lk8npYdY5w9ddiSikLsmSSI7/N0kJxjmrCw4o10x4h8GSEx14D7YzpyEkdmrng/4geRL8K5Eq7hprL7FRSu5LaaoqUh9+pCUvhI2j8Auy7NnrLTz71U9CNEULl8JH76zycyMTNjBBcIJh9Q5kSUcFJPiLWB4lHJJpl+Rw2TkEiWaviS4k86JiOU6xDFkprf3ExaO9JF3EJMCePq4Hiu0BdFjmA7wDZnP+W9ZNfeQAI7eZoY5Wnhxp5g4KT3hVg+j8mLR2AxGDMh/PksshtYNndHEyiwU/JRYO/MBrsxegLJoHJcMhEoxjTc2Y8wmb1O/O9ngfTJ2QK0McxkS68EnV4ngXXHTNzgsEy2P1tpq2YmnKQQ0o X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0801MB2025.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(366004)(39860400002)(346002)(136003)(26005)(4326008)(71200400001)(478600001)(186003)(7696005)(55016002)(53546011)(7416002)(6506007)(55236004)(5660300002)(33656002)(9686003)(2906002)(76116006)(8936002)(110136005)(54906003)(86362001)(64756008)(8676002)(66446008)(66556008)(66946007)(316002)(52536014)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Ef+KvUlMkSY5xkaAZstBEcAT4gM57gzGXZtfOIUjaVzl4UUoCy8fd3IeYtXePSq0Q2u0VCtv35+Bs5EZV2tjm6lwpYIxAMCSSgN3lOtkCetoWpIyQZvN7z4nVwq6PmagUu16mCvYgRJtQvm+r0WWX/SDBfLmHlbtljsivcs0UiQaB/TvEssEahBftCSDwr2+M9OgDYnUH/LPVjpO+R61vRujpjYEuNYP9J0UuzPWixkGfPn0I3rrq06MgvlJLHEfAITfM5ssEgxf6gbfnXFEKczyhX/TA5sGH6vPgXV1CMGoaNYIPzzP92vJ1YKWe9OtZvSSJ7pUMNHnUVb9QtZuK+M64MaL+Mg/ioic1kBqGVd1qI26x6vmvd4ZsAeb6NWj+nnNkqO1Ib0Tq1jLlLdIdawLD/j0ZAqs06DOanMDNbh5odrBlIS4Aqc6mJffZ05ZitV3xZaM1OOlFuJJSxgf3ah5ph7NFJQCTdAgBQ3CK/4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2108 Original-Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966005)(36906005)(54906003)(26005)(316002)(186003)(55016002)(82740400003)(9686003)(110136005)(81166007)(8936002)(47076004)(478600001)(8676002)(86362001)(33656002)(70586007)(70206006)(82310400002)(356005)(2906002)(4326008)(336012)(53546011)(6506007)(5660300002)(52536014)(7696005); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 28b39204-533e-4d18-b37f-08d7f8a678df X-Forefront-PRVS: 04041A2886 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1J7BcQYsCge2bv5JbrWsMKAShBkr7osv4awh9B7s/jejD/t1vnhQ/5XXA/cqiUvwRCGDam3swnVMxs4e3UKA/b25/fUoaFhi3J682pPTkgGQQo4PhMHqae9C4np8gn8RfH+HmIxZvAMYJz/0T/qAhI0N5TZtA7RW/9yOTzZ75OBD/wvG7GAlGot0el46RD5KZ+ya1ERYWPk26HGh+GZmo+xLDuvMR2Upm/53MFTND3gIt8ihGjjQ70y/7zgm0OhQG7303i11lQPK7RE2gQG2gSGM5y6S6U9UNdgS8/4Tg+fAqBINVpJ6EV/jK0S5tW5kUFBmlDRkUQtvaTGlBWEcj9eWKTsgLDbGHXIdGaAViB8PGzB5yl8R1NF8GdBzOcYR3h0zPQndGuemq9rqfxTXcCMFJipm2MDKtNy+Gv7T5WoJFhVEdZkpBwz6qFaXm994gmTokDb/c8MHekv8RkaqoSyoeAMI3l/GBEdvzGVKh8/MOX8TBoHx/dTZsBdilrWTy7jxkmkgIYWOqiQG3qQvsA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 08:03:46.3174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e3c2af24-5892-4b9c-d9ca-08d7f8a67e5d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5116 Subject: Re: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Apeksha Gupta > Sent: Friday, May 15, 2020 3:56 PM > To: dev@dpdk.org > Cc: Ruifeng Wang ; declan.doherty@intel.com; > asomalap@amd.com; anoobj@marvell.com; roy.fan.zhang@intel.com; > fiona.trahe@intel.com; rnagadheeraj@marvell.com; adwivedi@marvell.com; > jianjay.zhou@huawei.com; pablo.de.lara.guarch@intel.com; > adamx.dybkowski@intel.com; Akhil.goyal@nxp.com; Apeksha Gupta > > Subject: [PATCH v3] Test/crypto: check valid test_stats before running te= st >=20 > Test_stats is an optional cryptodev op and if it is not defined by the PM= D, it > should not run the test cases for it. >=20 > Signed-off-by: Apeksha Gupta > --- > app/test/test_cryptodev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > c624018ee..1ad650675 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -8801,6 +8801,10 @@ test_stats(void) > if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > return -ENOTSUP; >=20 > + dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; > + if (dev->dev_ops->stats_get =3D=3D 0) > + return -ENOTSUP; > + > /* Verify the capabilities */ > struct rte_cryptodev_sym_capability_idx cap_idx; > cap_idx.type =3D RTE_CRYPTO_SYM_XFORM_AUTH; @@ -8820,7 > +8824,6 @@ test_stats(void) > "rte_cryptodev_stats_get invalid dev failed"); > TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], > 0) !=3D 0), > "rte_cryptodev_stats_get invalid Param failed"); > - dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; > temp_pfn =3D dev->dev_ops->stats_get; > dev->dev_ops->stats_get =3D (cryptodev_stats_get_t)0; > TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], > &stats) > -- > 2.17.1 Reviewed-by: Ruifeng Wang