Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, June 23, 2020 4:37 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: thomas@monjalon.net; Wei Zhao <wei.zhao1@intel.com>; Jeff Guo
> <jia.guo@intel.com>; dev <dev@dpdk.org>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Juraj Linkeš
> <juraj.linkes@pantheon.tech>; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32
> 
> Hello Ruifeng,
Hi David,

Thanks for your review.
> 
> On Tue, Jun 23, 2020 at 9:00 AM Ruifeng Wang <ruifeng.wang@arm.com>
> wrote:
> > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc
> > b/config/defconfig_arm-armv7a-linuxapp-gcc
> > index 9ecc2a526..9c6d387cf 100644
> > --- a/config/defconfig_arm-armv7a-linuxapp-gcc
> > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc
> > @@ -30,6 +30,7 @@
> CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n
> >  # KNI is not supported on 32-bit
> >  CONFIG_RTE_LIBRTE_KNI=n
> >
> > +CONFIG_RTE_LIBRTE_IXGBE_PMD=y
> 
> All components are enabled by default in the common_base file.
> We explicitly disable components in the targets config files that can't support
> them.
> 
> $ git grep IXGBE_PMD= origin/master -- config/
> config/common_base:CONFIG_RTE_LIBRTE_IXGBE_PMD=y
> config/defconfig_arm-armv7a-linuxapp-
> gcc:CONFIG_RTE_LIBRTE_IXGBE_PMD=n
> config/defconfig_ppc_64-power8-linuxapp-
> gcc:CONFIG_RTE_LIBRTE_IXGBE_PMD=n
> 
Didn't realize that. 
Will change to remove IXGBE line from armv7a config in next version.

> 
> >  # cannot use those on ARM
> >  CONFIG_RTE_LIBRTE_ARK_PMD=n
> >  CONFIG_RTE_LIBRTE_EM_PMD=n
> > @@ -39,7 +40,6 @@ CONFIG_RTE_LIBRTE_E1000_PMD=n
> > CONFIG_RTE_LIBRTE_ENIC_PMD=n  CONFIG_RTE_LIBRTE_FM10K_PMD=n
> > CONFIG_RTE_LIBRTE_I40E_PMD=n -CONFIG_RTE_LIBRTE_IXGBE_PMD=n
> 
> So removing this line only should be enough.
> Idem with i40e in following patch.
> 
Will remove the line from armv7a config in next version.
/Ruifeng
> 
> >  CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
> >  CONFIG_RTE_LIBRTE_QEDE_PMD=n
> >  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
> 
> 
> --
> David Marchand