From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 830A6A00C3; Thu, 14 May 2020 03:12:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33D5A1D658; Thu, 14 May 2020 03:12:06 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by dpdk.org (Postfix) with ESMTP id B0ED01D652 for ; Thu, 14 May 2020 03:12:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqQl6f5Ep2D1qtsaNy9bdvuW+GA6LBjdPL91W99rtAc=; b=V5GTYdsebdpnsSiwGR/4fu+VhDXKT1v3Saf+dnPM913g5ez72PjRgu+A5xCj41ejjwEWd7qL4Jb6mtqU6QDm7jDyVGzp1lKpmjT/C2fh8xDPOAOJ/cTmDAXT3GFlD1Z6iRXSmFnrBjpUGDC6wDdIE7Fc14VB2bkfEVzk5fGgQ9o= Received: from DB8PR06CA0046.eurprd06.prod.outlook.com (2603:10a6:10:120::20) by VI1PR08MB3280.eurprd08.prod.outlook.com (2603:10a6:803:3d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 14 May 2020 01:12:02 +0000 Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::e9) by DB8PR06CA0046.outlook.office365.com (2603:10a6:10:120::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Thu, 14 May 2020 01:12:02 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 01:12:02 +0000 Received: ("Tessian outbound b3a67fbfbb1f:v54"); Thu, 14 May 2020 01:12:02 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9018857172fd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 771BC6FF-6503-4959-A05A-49508BCC3E55.1; Thu, 14 May 2020 01:11:57 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9018857172fd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 May 2020 01:11:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lCHSWqykU7IJySW0pKtDly+ijvtPYoFoZhMM+z0194gAVnKshgXu4jQUwJQjTSw1D68cGPoeLduBXNVnraW3QNWG0+oPdednfYyPKqNXYaxnepuTKrac4epiDmQiCGhDQgceFNpcmDTx73kIV2jDaOJ6eAuqTI6cCLnBcMr+cEqCeZ3YkX5slT7n8JCmYFKtFasiWCcHrXXbLq/84gbuGCnR05x0IA5k1Egf8lSv99yxW1sOh9krQWLQGqsA0zkOsHgeS0Sp1JVWFa4ByZTUaZMcG00/vlMjMpy+IkPXztZ2DOAgOWpnakZXVlL0LrMwNLifhRPzquZ+yVVuwPE5XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqQl6f5Ep2D1qtsaNy9bdvuW+GA6LBjdPL91W99rtAc=; b=EFmdfss8YXdl+WMdZetyedTwjpuCHBQ03m8UjrvBaAYc3d5n9c4aGXIk6Wcv63L2swlO1c5CQImtjCC5yrMD2gsQUiLoBJ3bX9IzNVHEvTTV6Ig6zLUHp3DZ1BXl1B2iuXDnWbCBXleAkOBecf9nnqYHDFyR5L9ld2hEvocyBAec4L1nFRbsN9+bVhEVlwpRbnMpksg0dvkaU9wCFTMl/gLZt8sxBevlUI1nP1R07zNVIeCzUttsBP+g048sjfWRvshTBGKK5Dis/UvMLNnbcRI+vvdXnAuRJSR7xM8ClIJt8RKRNLTxt1QNywOHCrvSfe8rdIjleyLmlzVQepwC5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqQl6f5Ep2D1qtsaNy9bdvuW+GA6LBjdPL91W99rtAc=; b=V5GTYdsebdpnsSiwGR/4fu+VhDXKT1v3Saf+dnPM913g5ez72PjRgu+A5xCj41ejjwEWd7qL4Jb6mtqU6QDm7jDyVGzp1lKpmjT/C2fh8xDPOAOJ/cTmDAXT3GFlD1Z6iRXSmFnrBjpUGDC6wDdIE7Fc14VB2bkfEVzk5fGgQ9o= Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com (2603:10a6:3:50::14) by HE1PR0801MB1627.eurprd08.prod.outlook.com (2603:10a6:3:80::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Thu, 14 May 2020 01:11:55 +0000 Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::646e:c258:7269:f4b2]) by HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::646e:c258:7269:f4b2%11]) with mapi id 15.20.3000.016; Thu, 14 May 2020 01:11:55 +0000 From: Ruifeng Wang To: Apeksha Gupta , "dev@dpdk.org" CC: "declan.doherty@intel.com" , "asomalap@amd.com" , "anoobj@marvell.com" , "roy.fan.zhang@intel.com" , "fiona.trahe@intel.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , "Akhil.goyal@nxp.com" , nd Thread-Topic: [PATCH] app/test: Fix test_stats for dpaa_sec Thread-Index: AQHWKUrEOhWImC9Qn06miTYIvJ+356imxO2g Date: Thu, 14 May 2020 01:11:55 +0000 Message-ID: References: <20200513171918.14128-1-apeksha.gupta@nxp.com> In-Reply-To: <20200513171918.14128-1-apeksha.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 20de471c-dee3-4a4e-a2ed-5ee3a4b696dd.0 x-checkrecipientchecked: true Authentication-Results-Original: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8222395d-3672-4256-f1a0-08d7f7a3cf27 x-ms-traffictypediagnostic: HE1PR0801MB1627:|VI1PR08MB3280: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:561;OLM:561; x-forefront-prvs: 040359335D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wkO0ciyJqLcxfF9j0RmOD53Ol7xPLZdGb6zTLZuzwK01avZN0svT6xfyMs14broKzEF4gmHqmekvLTd/vghBb/TbmNuXsqfQEo9T4/am0MyXomAvWbrYTsxGLsbnG4dbe0aOzw9wVeAPHvl2jAeRsMMEwyCctp8Mp8swmaSLJu/D4AVimrlHnk24fstKqQXeaqKB01ULGhLTa3nrc9eHzuIsz2Q2luHUenYGkBVYqjymH0Nn1LD6asDXQHSIdYsmKrlzM1Doewp2jGTNickFZzPNKicV1eogha/nQrz7tfizPstQfib2d06Z2luHKaNLg8r5jmpmXyR9+IVtawD5XBoFlIX7L0h+mkdhkjXfvu1j7YrsSLoQsUseKdJ7EHcL3KaL3bIjVV+jKoww5KKyC0lJYI1NrH9fiwyBBLT9aHvqrq/etYwjJeWzyRfMQzCi X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0801MB2025.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(66446008)(55016002)(71200400001)(66476007)(186003)(478600001)(8676002)(53546011)(66556008)(6506007)(33656002)(66946007)(26005)(5660300002)(7416002)(4326008)(64756008)(8936002)(9686003)(110136005)(54906003)(7696005)(55236004)(52536014)(76116006)(2906002)(316002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lW8KQ1DVDXJQEJ53zO3e4pbtgPQkG6PhLgdZa/hNn0JFftIXiF1J8kLvkNz3qoh8It9Qp9J2GomuzJjvj3mvtFawwu8KcYpQHgGC5RnBrVXQbFyFg/4QNLVL+if+IYuZIdUy7hH2+MVTmEYYZXGYieBUz61qBKMQKbZro/qk4zxYMHf2Q4B8+tOy/M7kgh7JPoHDX+uUmRivdZFP/S29CJS50eXbmjz80TMInxYY2g0c7L90khzxJnJUy+YwhWJqYX4GI+Lgi0+AvQf6TZbaF+LyS9PYKZjWHHP79o9MqBKttBTt8Q+rr4faB+tfMqFjns2WK4DIcb56x1fa6EK6ItskVccEz7ty/GfG8Yk5DsTp6wdxYAJPwCIal/1/7goq+a+TXwckybx0DC/9AACffpSo0L+kkYxCOQFAcHNFxxAXhLkxGaMusDsayg7mTzLp8XegHXdSlvhaqyOGYA5cx7c6LEnRVRRcxINOIDt29dk= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1627 Original-Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(136003)(346002)(39860400002)(46966005)(52536014)(54906003)(478600001)(5660300002)(81166007)(8676002)(2906002)(336012)(356005)(26005)(53546011)(33656002)(186003)(6506007)(9686003)(4326008)(8936002)(316002)(86362001)(110136005)(55016002)(82310400002)(82740400003)(47076004)(7696005)(70586007)(70206006); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 94adc061-1ee6-4a61-5d96-08d7f7a3cb07 X-Forefront-PRVS: 040359335D X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G0ZNjhEsGXyIEXtZZdz5dp9s7rFvWxjFsjFGmTYtNxk2+IWNciW5ME4f18ETY2iZNt+p0EqnEN06ac1QyxEg2bUh7uSipsUfZAzzyw0DgfPWkdHaRrujNt0yOrYipKzRwkYm4tBnB3qEJ/BP+n82a09VrTSxLSHOFL3zXo1SYctD1dD6i9z2SH7tuIz/AXScLA/KGeS5xbck+0ZHMMxnO7bzRM8OTsior6IHg8r5v6OHK+FJny2WFZoJTuJ6yI2fLcs6FFQAHPtmrqenI2HbawH/wlPyrdJThsAB7M3Q8tXq88SHVQADbdo6ELZka4dilz6jXuzzKSQ+3QKsa1jwjAAbUCIsDp/guy0lbtRZH5wvGjgY2oqeomDfRL5s46gvAWR4dSxrCS/YyJljeqzMR24vXUMZ06FsEyuUusdOm1kINbm9kGhDfs+yExSR9l3LdfWnVeb/IolUMJEDVhsXOjGhR1/6vFS/R90TQMWUUkSdCu6P/PUCkmwuoiOgrjimJC9tm1611Hx8d9CQxm+uUA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2020 01:12:02.3345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8222395d-3672-4256-f1a0-08d7f7a3cf27 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3280 Subject: Re: [dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Apeksha Gupta > Sent: Thursday, May 14, 2020 1:19 AM > To: dev@dpdk.org > Cc: Ruifeng Wang ; declan.doherty@intel.com; > asomalap@amd.com; anoobj@marvell.com; roy.fan.zhang@intel.com; > fiona.trahe@intel.com; rnagadheeraj@marvell.com; adwivedi@marvell.com; > jianjay.zhou@huawei.com; pablo.de.lara.guarch@intel.com; > adamx.dybkowski@intel.com; Akhil.goyal@nxp.com; Apeksha Gupta > > Subject: [PATCH] app/test: Fix test_stats for dpaa_sec >=20 > Test case test_stats should be unsupported for dpaa_sec and return - > ENOTSUP. >=20 > Signed-off-by: Apeksha Gupta > --- > app/test/test_cryptodev.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > c624018ee..5aafe52f1 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -8821,6 +8821,8 @@ test_stats(void) > TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], > 0) !=3D 0), > "rte_cryptodev_stats_get invalid Param failed"); > dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; > + if (dev->dev_ops->stats_get =3D=3D 0) > + return -ENOTSUP; There are two tests prior to this check. IMO, this check should be hoisted. What do you think? > temp_pfn =3D dev->dev_ops->stats_get; > dev->dev_ops->stats_get =3D (cryptodev_stats_get_t)0; > TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], > &stats) > -- > 2.17.1