* [dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec
@ 2020-05-13 17:19 Apeksha Gupta
2020-05-14 1:11 ` Ruifeng Wang
0 siblings, 1 reply; 2+ messages in thread
From: Apeksha Gupta @ 2020-05-13 17:19 UTC (permalink / raw)
To: dev
Cc: Ruifeng.Wang, declan.doherty, asomalap, anoobj, roy.fan.zhang,
fiona.trahe, rnagadheeraj, adwivedi, jianjay.zhou,
pablo.de.lara.guarch, adamx.dybkowski, akhil.goyal,
Apeksha Gupta
Test case test_stats should be unsupported for dpaa_sec and return
-ENOTSUP.
Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
app/test/test_cryptodev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c624018ee..5aafe52f1 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -8821,6 +8821,8 @@ test_stats(void)
TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], 0) != 0),
"rte_cryptodev_stats_get invalid Param failed");
dev = &rte_cryptodevs[ts_params->valid_devs[0]];
+ if (dev->dev_ops->stats_get == 0)
+ return -ENOTSUP;
temp_pfn = dev->dev_ops->stats_get;
dev->dev_ops->stats_get = (cryptodev_stats_get_t)0;
TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats)
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec
2020-05-13 17:19 [dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec Apeksha Gupta
@ 2020-05-14 1:11 ` Ruifeng Wang
0 siblings, 0 replies; 2+ messages in thread
From: Ruifeng Wang @ 2020-05-14 1:11 UTC (permalink / raw)
To: Apeksha Gupta, dev
Cc: declan.doherty, asomalap, anoobj, roy.fan.zhang, fiona.trahe,
rnagadheeraj, adwivedi, jianjay.zhou, pablo.de.lara.guarch,
adamx.dybkowski, Akhil.goyal@nxp.com, nd
> -----Original Message-----
> From: Apeksha Gupta <apeksha.gupta@nxp.com>
> Sent: Thursday, May 14, 2020 1:19 AM
> To: dev@dpdk.org
> Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; declan.doherty@intel.com;
> asomalap@amd.com; anoobj@marvell.com; roy.fan.zhang@intel.com;
> fiona.trahe@intel.com; rnagadheeraj@marvell.com; adwivedi@marvell.com;
> jianjay.zhou@huawei.com; pablo.de.lara.guarch@intel.com;
> adamx.dybkowski@intel.com; Akhil.goyal@nxp.com; Apeksha Gupta
> <apeksha.gupta@nxp.com>
> Subject: [PATCH] app/test: Fix test_stats for dpaa_sec
>
> Test case test_stats should be unsupported for dpaa_sec and return -
> ENOTSUP.
>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
> app/test/test_cryptodev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> c624018ee..5aafe52f1 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -8821,6 +8821,8 @@ test_stats(void)
> TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0],
> 0) != 0),
> "rte_cryptodev_stats_get invalid Param failed");
> dev = &rte_cryptodevs[ts_params->valid_devs[0]];
> + if (dev->dev_ops->stats_get == 0)
> + return -ENOTSUP;
There are two tests prior to this check. IMO, this check should be hoisted.
What do you think?
> temp_pfn = dev->dev_ops->stats_get;
> dev->dev_ops->stats_get = (cryptodev_stats_get_t)0;
> TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0],
> &stats)
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-14 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 17:19 [dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec Apeksha Gupta
2020-05-14 1:11 ` Ruifeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).