From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF0BA00BE; Wed, 29 Apr 2020 04:31:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAB9F1D6FE; Wed, 29 Apr 2020 04:31:20 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by dpdk.org (Postfix) with ESMTP id 270341D5F8 for ; Wed, 29 Apr 2020 04:31:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUVGV8cSXeXLDJSdxGEVmQPIJnlPOfoNt5v6x8Vsqdc=; b=v/MF+A05uUqj8vnOGufP1dOZU8t/VX0RdlSMAzWFBkAlQOQ2gtweP2tmu5cB5DWIrcm0cwDTPKcjxgPq97TzqnsTT83PGEYNxrQb0hRwNnNwnWmBS89P7MOHhrSXeNkchcRLjxolzboB4jGEqCs8T2flkd/Jv2Jou24wqbytO08= Received: from DB6PR07CA0114.eurprd07.prod.outlook.com (2603:10a6:6:2c::28) by AM0PR08MB3683.eurprd08.prod.outlook.com (2603:10a6:208:102::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Wed, 29 Apr 2020 02:31:08 +0000 Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::ac) by DB6PR07CA0114.outlook.office365.com (2603:10a6:6:2c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.9 via Frontend Transport; Wed, 29 Apr 2020 02:31:08 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.19 via Frontend Transport; Wed, 29 Apr 2020 02:31:08 +0000 Received: ("Tessian outbound e88319d7ccd0:v54"); Wed, 29 Apr 2020 02:31:08 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0cc8ace3ad3a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9FC677FE-ABE2-49F2-9638-EA1E3B47E471.1; Wed, 29 Apr 2020 02:31:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0cc8ace3ad3a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 29 Apr 2020 02:31:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mN8FJxa4gPyB2XG0/6ROeYLFj0PIxO4WfUKpqbe9zOjZn1XSNkgcG7SGsMv2W8v6O7/U728Xvl6CzzcSHwkrSY/XcQiaQXUuHACZrs7UyWUblJYAoVkCpurD5WTOwtlRCsbk6TH3c79FhxxnAi+OfJU12itwudLIHA1vnIFU2HMeqBNs9Etk/41+8LTUUAwW91NU2PssM4xZ0+wEjeT+edo1t9Ud4Ut89MQigOtCiKrIY7RhEtPm2MbXlzRLXHM8n4rUJAXQYTaZ3WOpqWsBIRqRxdcuPKs9fvfgF/kertJkABMliCcFbrsfPklBEHcCQ5orITNUhf2TenmaARcCYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUVGV8cSXeXLDJSdxGEVmQPIJnlPOfoNt5v6x8Vsqdc=; b=OKvvZLz0uhzklL3E4WydLYhhF6X2pLb70IkY8bnGWmYaPgIMqVKIWUVtjQfsP45ow7A8+ETppG7IpxBL/xjhsSZ6iuxKnJYwff30tXzYQFxm0ox9YRaZ+szrpRJMSqCXybJw09rsAyASVBDPxErYuJegImPalh+p0QJOqLQm3vpPT1wsrpXGJ1PqzLiQL0U+2M8gXQlaRwz8AkArQZR4/j5MRIrRRogEboe1x23s+gQzQFm5iCIUIz8D0g9Lj/H/mB6ICY54xcwsT0hMSypM8vHEhaxWsWYs5Z7+czFkZOLTDIbE8d6pORmkTaNmIkjEOi1NmloK6BxpcJxKC+/jXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUVGV8cSXeXLDJSdxGEVmQPIJnlPOfoNt5v6x8Vsqdc=; b=v/MF+A05uUqj8vnOGufP1dOZU8t/VX0RdlSMAzWFBkAlQOQ2gtweP2tmu5cB5DWIrcm0cwDTPKcjxgPq97TzqnsTT83PGEYNxrQb0hRwNnNwnWmBS89P7MOHhrSXeNkchcRLjxolzboB4jGEqCs8T2flkd/Jv2Jou24wqbytO08= Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com (2603:10a6:3:50::14) by HE1PR0801MB1899.eurprd08.prod.outlook.com (2603:10a6:3:4e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Wed, 29 Apr 2020 02:31:01 +0000 Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::c05f:e0a8:dd0:46c7]) by HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::c05f:e0a8:dd0:46c7%6]) with mapi id 15.20.2937.023; Wed, 29 Apr 2020 02:31:01 +0000 From: Ruifeng Wang To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/4] net/vmbus: add missing barrier Thread-Index: AQHWHOuZcmLqS+b6okmV7m5ATMcMBaiPYogA Date: Wed, 29 Apr 2020 02:31:01 +0000 Message-ID: References: <20200427232822.21695-1-stephen@networkplumber.org> <20200427232822.21695-2-stephen@networkplumber.org> In-Reply-To: <20200427232822.21695-2-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 67279c83-f47e-4845-ad50-aa5f9aadb03d.0 x-checkrecipientchecked: true Authentication-Results-Original: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b34ab38e-3428-4267-f508-08d7ebe55fc7 x-ms-traffictypediagnostic: HE1PR0801MB1899:|AM0PR08MB3683: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:935;OLM:7219; x-forefront-prvs: 03883BD916 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0801MB2025.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(376002)(39830400003)(136003)(346002)(8936002)(52536014)(110136005)(5660300002)(66446008)(66556008)(76116006)(8676002)(55236004)(66946007)(66476007)(7696005)(64756008)(26005)(71200400001)(186003)(316002)(33656002)(9686003)(55016002)(2906002)(6506007)(53546011)(478600001)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dta2H6W26tqfWCYxB9CwvG0R3Q2W/NDyZ1Xx1FtFVgava7VjmuHpjv+G37+sI7FosO4pbcxn6jtEKZ5U2Yt6UANfoqM1aHbnUhdx4V39Aqwx97euc7TNsPf7AyWqD706z+XQF3mcYGt71MFR0xfjScb03qyWq2J0v0n4LpS0RCh/dY202sy9eCddFO2jqK4PJuFxIqWrCiHlsLNDCcsmTJNoAcPwRtfHZuc9Wa1k1JVUS0zlsE48NJIAbn6OAbIQ8oPSAaSE7YxrwrDAC7WjvcJMIQkzPqnWEUK0Nzv+OMXJ38jgzPyBVG87GQcd0ki8tY6HigV+y2Nywrmnluerd/HwFrIBlpkxj3+igk7mDtjzr9Ahklgh4JQE0M4KbSiXc9oZDZndQJc51KOX58JIyBCcxuJ40k/36onItHlWcifj6SgZQVs95y/Relj0Ozg3 x-ms-exchange-antispam-messagedata: 0dff2ie1Q40Hl95AFsc1i+4F/6NiBqaPUCZhhVubeizFfQ6rK9XvexAAnWIAd0IivLlvWXvQvsiMq2lGw+4W4fYpjbDyuktq+4I21UZF+QFoSWDLKNls59BcCnVP4wNaAm2XHxq4YQO8rrwdckyBsujtfNiVDv4yaRMS9hHw2Daxpwhtdu0zhPHqJRjZkuoYZzGa+DOUufBnDBWBUen8zZBJ7HD2g+yTjRwxAGFn0GzAP+MCvxTGHgyOZnU4zuGVR2k9T6PFLeQLLyvIDpuzowf7fqTM4c0TQ3dxMLCU7VZyBadtgdSCkhtjtomLa0NJ2lVZrSBHgZFNcgjy2ukS8dAwB+lvQ/3S4shu3Mpu1wwa22itY9EGKRRry1KrL7slwXjnipdw2AL8tXgMSd4hbE/lX6maZSNDsfjwoqHeRyIK8Ka8K/hl2i2gHwcyurj5vPspPLF9PMOghOpODUScpNhguA1w3nV+I67EHkIJolPk/pK+//l6LrwHxeGOpcOtt1w4m9WLbMyDFE5laMztI+IhPNJ3Sz5MgQps9+beMZ/J53oVskrjVxiKzTOJUHTXv4HH3qrmsdO0d0Cqn9Z+F8prhj0NFBmMu1hywewfN+t3gTJtiEgaliCwDq3PnQSV9R2JuXcu1SWKjV/amaJD5L0Nn3uJExuVBxymUxbcmN3g/T+tUF4eEwcj+yIwSaSlzuKoAb1I8l90fCkWvY7oKhZ+cmSm/K6T6YziHydw/BRTj9dy3tzIydw4BK/VBiaM0meRzISUSV9SNr+ozC7vE5e2KiSF3+LLehaZ5prWBIw= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1899 Original-Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(396003)(39840400004)(376002)(46966005)(8676002)(186003)(81166007)(47076004)(2906002)(336012)(26005)(6506007)(52536014)(82310400002)(53546011)(7696005)(33656002)(110136005)(5660300002)(8936002)(86362001)(478600001)(70586007)(9686003)(55016002)(356005)(316002)(70206006); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 81ba7091-6c44-4aa8-aecc-08d7ebe55bd4 X-Forefront-PRVS: 03883BD916 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TCPm1NnOw5dQGtLkPM2aMdUTXFcrOblWWg5yhX4VbHwHwi8KBvXKtgkfOah4Rkt7yDDB5j+sNLeD5cCKc6xFUmdlfMSFVqZBpvBASSTcY7/jdOSa08+o6GXOo+Z8afv1OHezBbiTJxdCO6vgj5qx5LPa8R/22E1UEejK9y5oPoUB4WEVEG0pAbF54e0ygWthbKzlviJzC+8fcMpgmFheqLLKN+B9Xj5oVabFHUK4iggxrXBFUEBNPwTQ7UubuulPEEfgqfXRPfZVOBAN5al01GtIKfgo3WO2wvnPJOVhQFf5eMPThPVhThcSu14sVe2pjA8L1LgCdBVmn11iIHjcm1yucrl2zg7St/jWlszpAZWpbxSMpginH9kewWfQb+hr7rG8Gl596m2lri3ggwS8o58jE1frdzsyiZf9MtFsyZbzAfzdKlezUzvZP7mH4X9Q6j9EVxtC30Mgfitp0Trdcaxp04qtrurR5V0Ec2t+Pe69LlgcicZZjlhCkLS5L5i9C3f66RUN67uxu4YzLecO7w== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2020 02:31:08.3132 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b34ab38e-3428-4267-f508-08d7ebe55fc7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3683 Subject: Re: [dpdk-dev] [PATCH 1/4] net/vmbus: add missing barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Stephen Hemminger > Sent: Tuesday, April 28, 2020 7:28 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 1/4] net/vmbus: add missing barrier > > The check for event ring being empty needs a barrier to avoid any over > agressive optimization. > This is same barrier as Linux kernel. > > Signed-off-by: Stephen Hemminger > --- > drivers/bus/vmbus/vmbus_channel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/vmbus/vmbus_channel.c > b/drivers/bus/vmbus/vmbus_channel.c > index 46b3ba3f9f9e..ff2985c25758 100644 > --- a/drivers/bus/vmbus/vmbus_channel.c > +++ b/drivers/bus/vmbus/vmbus_channel.c > @@ -199,6 +199,7 @@ bool rte_vmbus_chan_rx_empty(const struct > vmbus_channel *channel) { > const struct vmbus_br *br =3D &channel->rxbr; > > +rte_smp_rmb(); > return br->vbr->rindex =3D=3D br->vbr->windex; } > > -- > 2.20.1 Reviewed-by: Ruifeng Wang IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.