From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1157430E2; Fri, 25 Aug 2023 09:49:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D14E40A7A; Fri, 25 Aug 2023 09:49:10 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 05E2040695 for ; Fri, 25 Aug 2023 09:49:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692949749; x=1724485749; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rYGCNqZMBVwZaDbA3c3uz5Qlmklso/U73F0+HQNOC2s=; b=nVUFragqjQiTbmSMiPdyYL/Kop6/5Wl5N1CWDV0modZQqUZDaRFPCwqM lk2yiNvnJCRUTAQyhNXimrPtVxZo80IxzvYdejy4gRdx8eJHJBGi5JMpY bAm8/NY2+p7pS+IpAPiSVAwTPWk6GeGSfWJ/ac35Ovrl5sOv7V1HIANGM oPxgIATbPNpBgj447/RR3FpShN0WoPZivFkIluYTlZVF+b0Q989yyd5Z8 wcYyMzXX63H9GM81uvjd0dFJtlrFmHeVGk9DHf5T8zdLRnVUwnpcJbWt6 uvC59BIyWqsU1cbmJHL0SSuo8zmSzQErQFwZqadhrPPaeYef0S5ZjInwa A==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="374633824" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="374633824" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 00:48:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="851871081" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="851871081" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 25 Aug 2023 00:48:49 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 25 Aug 2023 00:48:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 25 Aug 2023 00:48:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 25 Aug 2023 00:48:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxN2X/yNUe/Tc8vElQhmqeoexojUCycxn+I+7Dt6PksUYqKdWKo8cEI/HmvayXV+6o/j02aHmAijiMxPtPsDMZgVtEgblWQjug7fAPbG5YOQf2jGnCMx4mC45a5hznz8A9mUWrWf0AVkbXAtmSE6Q/LWRNR8tHnsDcVdnUgWSYpdeGkVyeQPervwWU0Qp8uwWY2xNbcj239EQ7R/kXf9SujrNPnFvw6gPpkBhBS+xRH3RhouhE+mjQCe3EbSjiJVec5KK8FN19tobiTi2yLkafDwCAQLOyKufJFZ2aZt4v9IrmqOZp+NKR9XBqXG2mSs9y/SEb+MpyBUBtbWm5Bf0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zb8byw4If90xFhPDF3W8cc7xe5VeDvm5v2apcjRR9ak=; b=K3F1NceGUap/Jidp5NMoiwcUTMFudv9nTTG5gZTb0y3ckFKA2oHuA+/S03dmGYkeeeMmYj2Dj3tge34bmOSxc6v0h9axiCyiV06r9BeLPkcnk5VgavzVKoshlOfOJzVhKsW87/xyIoCqF9YymnFA+NSbUsjmEERKihXgr7hlyFqVPRLFFUahkRIYfn+jvmw7q6GlcCvFW0pexwpjD4lvE1H4w0gg/fG02rqruZDSzWcF/LYLYFj5z4ZpnC6VwzPEXhQHsUIggLbZ2qXQWzpH2fg53MC3hurTkR0HWiGAD325ilRSK4c9kHr6L9dP3rDZ5URocViBMHHNdLY8NTS7ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA0PR11MB7955.namprd11.prod.outlook.com (2603:10b6:208:3dd::6) by MN2PR11MB4741.namprd11.prod.outlook.com (2603:10b6:208:26a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.27; Fri, 25 Aug 2023 07:48:47 +0000 Received: from IA0PR11MB7955.namprd11.prod.outlook.com ([fe80::6f86:7fd1:af53:ee2]) by IA0PR11MB7955.namprd11.prod.outlook.com ([fe80::6f86:7fd1:af53:ee2%7]) with mapi id 15.20.6699.027; Fri, 25 Aug 2023 07:48:46 +0000 From: "Wu, Wenjun1" To: "Su, Simei" , "Wu, Jingjing" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" Subject: RE: [PATCH] common/idpf: rework single queue Tx function Thread-Topic: [PATCH] common/idpf: rework single queue Tx function Thread-Index: AQHZ1ySi6YOTjoli002eMccBP+x/pK/6oQnw Date: Fri, 25 Aug 2023 07:48:46 +0000 Message-ID: References: <20230825072106.1819603-1-simei.su@intel.com> In-Reply-To: <20230825072106.1819603-1-simei.su@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB7955:EE_|MN2PR11MB4741:EE_ x-ms-office365-filtering-correlation-id: 81bff4fb-01b9-43ce-f72c-08dba53fb654 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x8QW8kmV7LEeK9mWaiuND/5EQPhJAeqxp3uJDH08oWZkxLIdEjUXb6e/GYPCKvbf8tZUZ74EevlVEuvLD96Qzc3Wa9JbpyPHUFEdPLqqJIg4lz8QoueCGWPdABfoo2u3jWB3Jyf67wRWbzH+ifSZ32S2st7M/8MuI61sGZeHnVyfpfZJt6YD0wnZ82CJp7of7EtXZdRcDxJBIrYznlKfcjdLGBUn/NfH5AFjg8Fgn07VzUi3qBPuNI9fOPKhhhW3OJkhs02WD5zg5UpTEUOqgjD0QC2dX9IrmP7ICZfq+odCzFOsdqFOyvo2OkuhiVl4jkwSPSeQonS+oH8EHeGfoM0A0UuR2P56P5U+W+YDbEAZVaCje854ukqqIprxs+yMkBY1rULscMns3hVReNA8p4GAXUamF9JFujkplbH1lmjLEl+4N0yjurqzKKYe/O/siRofp94r7OCk+TLMluAZRCUHj/U7lbX7P1yKs5P1Lu5nHL1ZyZXoKYkxKdzq2YF91+N9T99b78RhNNVjuXNjxbGYAWzG/MRhH5l10+6MXrSnhgYW8Z6OrHghpnRR9R1SnIE9N+Ub4ZhGfFTvVbj9vAlZz9tUpg70heFFygHJsZgaDYW0gM+nAXhuGVsvPEUm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA0PR11MB7955.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(346002)(39860400002)(376002)(366004)(451199024)(186009)(1800799009)(64756008)(66446008)(7696005)(66556008)(76116006)(66946007)(6636002)(316002)(66476007)(82960400001)(122000001)(478600001)(110136005)(55016003)(26005)(38070700005)(38100700002)(71200400001)(41300700001)(53546011)(86362001)(6506007)(2906002)(9686003)(4326008)(8676002)(8936002)(52536014)(5660300002)(83380400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XLQTVC/dt5FBIVVraSOBDJ/UDaHUffgEzTOGwkidtscy0psb1pUBfN8uKi9Q?= =?us-ascii?Q?6Yu4OR1EXNzUNZfTeCtnQDmIidyLV8o8zASI6bUa9U3x7Wt4+Ue2/ZrjZ3Mg?= =?us-ascii?Q?xGPeELLkWud4RPmKV1auiTNdEjIBHH3QkR8kf+Ols0B9ZJl9730b0SM0v5kN?= =?us-ascii?Q?iBvnbQizXIR1pL7Fs6V+GqmiVNiLmHSgvX0Bto4ppi/YsJjd/UGpq91F871p?= =?us-ascii?Q?3Ne4PObZ4V6QTS+EsXLsHfPhbFVGCOMam5M9zVoC1viVxs+M7djfD9q6AM3h?= =?us-ascii?Q?9K6kRWPkMSFFtmBSe/ohvJtA5JSOIT2DYOXYBbeMxpZKujve3ga9C8S+SpI9?= =?us-ascii?Q?r/47ieYegBd9+/TksdGjImTqQBGrIUHpfcqcHWwYH04pCS2AfAirfsZfPSKy?= =?us-ascii?Q?GzE6TmcqgexBJm3uWIleb+WnBU3lSMMh7bUwcGrUNffqzc+EghazorYLUoY8?= =?us-ascii?Q?yL+vZDzjiI42X9Vec+Jq7IoIxdgI0AApqtr3v0JhP2molwDp2XkaH+/9S19/?= =?us-ascii?Q?A9NJ7tvC9I+KQYdgtGhMz41nPIffQCgubkYUDuXyvzszRdq6F6+EEmrSAVyR?= =?us-ascii?Q?7Gi7Iq3Jetw6OzdUpfACKEK4YrvvvBJ2lS2QLalBe2PHDiSOO7JKqwkBdrw3?= =?us-ascii?Q?owwJkNe1wyv9lHJZELXocUazXUXQAQYtPZMjOm9kF3S5S17yLYKgCbspqvWU?= =?us-ascii?Q?bAS3+7mhY8udl77X7gF5uMwbnQLThy+5AXbUyQOHOvjYCEZI1IUT83SUCqS5?= =?us-ascii?Q?QQV67iRL5zurIWPTbH/P8Q1sCpckLsxkIeql4Zy/qmpgE7u/W1YRs+KjxjWC?= =?us-ascii?Q?rm0tRvSdrjrV507e77wsabyQ8pGi2FaMkSkHdEjJsn6E6mDDbyzhmyRNrVF1?= =?us-ascii?Q?JdKOjTFY5iTh6rwE1TUkKIiA2a2EdVRCeKzqtLkXBIUm/V365DBwR15s0xaA?= =?us-ascii?Q?P8cixk0+GrHSQHY9qdRftZo1BePTYUlprr2KkooqGMK2lY4GbHG/WeLqXDDy?= =?us-ascii?Q?Qag9LxufZ+YLKL5I5iTq/ZWe0tA+R7gUaJ2affJDfkByqz4zTZY2OK+K/ia/?= =?us-ascii?Q?6jAHH/hpKrEUeyQGl99HozpauPIBJ7pprLqCS0HwjwEkCp7ZOsATUaE0x7Pm?= =?us-ascii?Q?wGbo8jckrf1dbEQeAsBjYvlYYjZkZr/s3P6F2Kr2jOufJRh5+5DR2Dejv+KZ?= =?us-ascii?Q?qT4mOMzWUW4/i6Qd9FYjTdzOQEy5MCChC0OdkOHHsEDzoJrQt87g5KyWO/Se?= =?us-ascii?Q?SxD/FRYI2Eyj/paa45/zH9IECrja+UzEdk/idz8OAwyBQL6unN0b4qlzo3UG?= =?us-ascii?Q?l2Lvh4IKLT48/nWT3HGNsO2k7PlbslYYbDn71vklGZc4vslD/13QrxxGQaxC?= =?us-ascii?Q?58zamx1lVXpzUZfpoTPniI7MfE6olepaX0KZDY6AP7jp6PWgIsogHpwHIEtP?= =?us-ascii?Q?pznikSgCCeRZUCHuF0KM4wh/Td5QoAKsSUiDXOoiAWK6QgLPvXpdZeDNy4HH?= =?us-ascii?Q?IDN9Yn7Fi5oToRbikTb0h+m8lBSVei/t3NpCscRUBnDw9lqQz8RDSNMlEfMY?= =?us-ascii?Q?haMtmobb6Db+rBKlmVHNe6L+oBljoOSmAvbe6awE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7955.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81bff4fb-01b9-43ce-f72c-08dba53fb654 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2023 07:48:46.2991 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I8q6sb9vd3VmUYbTmt58hLy1MtzaH9jEwv2iObazrkw+vjkxOuPhPY3tWTUuPAKmY7CwP9BGIm8g0TCXKONVpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4741 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Su, Simei > Sent: Friday, August 25, 2023 3:21 PM > To: Wu, Jingjing ; Xing, Beilei ; > Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH] common/idpf: rework single queue Tx function >=20 > This patch replaces flex Tx descriptor structure with base Tx descriptor. >=20 > Signed-off-by: Simei Su > --- > drivers/common/idpf/idpf_common_rxtx.c | 72 +++++++++++++------ > drivers/common/idpf/idpf_common_rxtx.h | 2 +- > drivers/common/idpf/idpf_common_rxtx_avx512.c | 36 +++++----- > drivers/net/idpf/idpf_rxtx.c | 2 +- > 4 files changed, 69 insertions(+), 43 deletions(-) >=20 > diff --git a/drivers/common/idpf/idpf_common_rxtx.c > b/drivers/common/idpf/idpf_common_rxtx.c > index fc87e3e243..67c124a614 100644 > --- a/drivers/common/idpf/idpf_common_rxtx.c > +++ b/drivers/common/idpf/idpf_common_rxtx.c > @@ -276,14 +276,14 @@ idpf_qc_single_tx_queue_reset(struct > idpf_tx_queue *txq) > } >=20 > txe =3D txq->sw_ring; > - size =3D sizeof(struct idpf_flex_tx_desc) * txq->nb_tx_desc; > + size =3D sizeof(struct idpf_base_tx_desc) * txq->nb_tx_desc; > for (i =3D 0; i < size; i++) > ((volatile char *)txq->tx_ring)[i] =3D 0; >=20 > prev =3D (uint16_t)(txq->nb_tx_desc - 1); > for (i =3D 0; i < txq->nb_tx_desc; i++) { > - txq->tx_ring[i].qw1.cmd_dtype =3D > - > rte_cpu_to_le_16(IDPF_TX_DESC_DTYPE_DESC_DONE); > + txq->tx_ring[i].qw1 =3D > + > rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE); > txe[i].mbuf =3D NULL; > txe[i].last_id =3D i; > txe[prev].next_id =3D i; > @@ -823,6 +823,33 @@ idpf_calc_context_desc(uint64_t flags) > return 0; > } >=20 > +/* set TSO context descriptor for single queue */ static inline void > +idpf_set_singleq_tso_ctx(struct rte_mbuf *mbuf, > + union idpf_tx_offload tx_offload, > + volatile struct idpf_base_tx_ctx_desc *ctx_desc) { > + uint16_t cmd_dtype; > + uint32_t tso_len; > + uint8_t hdr_len; > + > + if (tx_offload.l4_len =3D=3D 0) { > + TX_LOG(DEBUG, "L4 length set to 0"); > + return; > + } > + > + hdr_len =3D tx_offload.l2_len + > + tx_offload.l3_len + > + tx_offload.l4_len; > + cmd_dtype =3D IDPF_TX_CTX_DESC_TSO; The cmd_dtype for base mode context TSO descriptor should be=20 cmd_dtype =3D IDPF_TX_DESC_DTYPE_CTX | IDPF_TX_CTX_DESC_TSO << IDPF_TXD_QW1= _CMD_S; > + tso_len =3D mbuf->pkt_len - hdr_len; > + > + ctx_desc->qw1 |=3D ((uint64_t)cmd_dtype << > IDPF_TXD_CTX_QW1_CMD_S) | > + ((uint64_t)tso_len << IDPF_TXD_CTX_QW1_TSO_LEN_S) | > + ((uint64_t)mbuf->tso_segsz << > IDPF_TXD_CTX_QW1_MSS_S); } It seems better to add mask & here to avoid crossing. >... Regards, Wenjun