From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Ajmera, Megha" <megha.ajmera@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: RE: [PATCH] sched: fix wrr parameter data type
Date: Fri, 21 Feb 2025 13:02:14 +0000 [thread overview]
Message-ID: <IA1PR11MB6290E14BFE9B90F3A21B848DE0C72@IA1PR11MB6290.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250221124755.427459-1-megha.ajmera@intel.com>
> -----Original Message-----
> From: Ajmera, Megha <megha.ajmera@intel.com>
> Sent: Friday, February 21, 2025 12:48 PM
> To: dev@dpdk.org
> Cc: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH] sched: fix wrr parameter data type
>
> wrr tokens getting truncated to uint8_t in wrr_store function() due to type
> mismatch. This patch chnages the data type to uint16_t.
>
> Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues")
>
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> ---
> lib/sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index
> d8ee4e7e91..dcef44b91b 100644
> --- a/lib/sched/rte_sched.c
> +++ b/lib/sched/rte_sched.c
> @@ -66,7 +66,7 @@ struct __rte_cache_aligned rte_sched_pipe {
> uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
>
> /* Weighted Round Robin (WRR) */
> - uint8_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
> + uint16_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
>
> /* TC oversubscription */
> uint64_t tc_ov_credits;
> --
> 2.34.1
Acked-by: Jasvinder Singh <Jasvinder.singh@intel.com>
next prev parent reply other threads:[~2025-02-21 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 12:47 Megha Ajmera
2025-02-21 13:02 ` Singh, Jasvinder [this message]
2025-02-21 19:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR11MB6290E14BFE9B90F3A21B848DE0C72@IA1PR11MB6290.namprd11.prod.outlook.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=megha.ajmera@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).